Switch auto time setting to use TimeManager APIs instead of low-level direct settings access. This makes the AutoTimePreferenceController approach the same as AutoTimeZonePreferenceController. Most of the logic about what to display and whether toggles are enabled is moved to the service. This change has the side effect of adding support in SettingsUI for devices with no auto time detection mechanism configured at all, i.e. the auto time toggle will stop being shown in SettingsUI. There are no known devices that require this currently, but it is a theoretical possibility if config.xml is configured in particular ways. Bug: 172891783 Test: Manual testing with different settings for "time origin priorities" (i.e. empty, non-empty) Test: m ROBOTEST_FILTER=com.android.settings.datetime RunSettingsRoboTests -j40 Change-Id: I4112fb51adb0d06a1dbc39a44ea109d6df899153
233 lines
10 KiB
Java
233 lines
10 KiB
Java
/*
|
|
* Copyright (C) 2016 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.datetime;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import static org.mockito.Mockito.spy;
|
|
import static org.mockito.Mockito.verify;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
import android.app.time.Capabilities;
|
|
import android.app.time.TimeManager;
|
|
import android.app.time.TimeZoneCapabilities;
|
|
import android.app.time.TimeZoneCapabilitiesAndConfig;
|
|
import android.app.time.TimeZoneConfiguration;
|
|
import android.content.Context;
|
|
import android.os.UserHandle;
|
|
|
|
import androidx.preference.Preference;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Mock;
|
|
import org.mockito.Mockito;
|
|
import org.mockito.MockitoAnnotations;
|
|
import org.robolectric.RobolectricTestRunner;
|
|
import org.robolectric.RuntimeEnvironment;
|
|
|
|
@RunWith(RobolectricTestRunner.class)
|
|
public class AutoTimeZonePreferenceControllerTest {
|
|
|
|
@Mock
|
|
private UpdateTimeAndDateCallback mCallback;
|
|
private Context mContext;
|
|
private Preference mPreference;
|
|
@Mock
|
|
private TimeManager mTimeManager;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
MockitoAnnotations.initMocks(this);
|
|
mContext = spy(RuntimeEnvironment.application);
|
|
|
|
mPreference = new Preference(mContext);
|
|
|
|
when(mContext.getSystemService(TimeManager.class)).thenReturn(mTimeManager);
|
|
}
|
|
|
|
@Test
|
|
public void isFromSUW_notAvailable() {
|
|
TimeZoneCapabilitiesAndConfig capabilitiesAndConfig = createCapabilitiesAndConfig(
|
|
/* autoSupported= */true, /* autoEnabled= */false);
|
|
when(mTimeManager.getTimeZoneCapabilitiesAndConfig()).thenReturn(capabilitiesAndConfig);
|
|
|
|
AutoTimeZonePreferenceController controller = new AutoTimeZonePreferenceController(
|
|
mContext, null /* callback */, true /* isFromSUW */);
|
|
|
|
assertThat(controller.isAvailable()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void notFromSUW_isAvailable() {
|
|
TimeZoneCapabilitiesAndConfig capabilitiesAndConfig = createCapabilitiesAndConfig(
|
|
/* autoSupported= */true, /* autoEnabled= */false);
|
|
when(mTimeManager.getTimeZoneCapabilitiesAndConfig()).thenReturn(capabilitiesAndConfig);
|
|
|
|
AutoTimeZonePreferenceController controller = new AutoTimeZonePreferenceController(
|
|
mContext, null /* callback */, false /* isFromSUW */);
|
|
|
|
assertThat(controller.isAvailable()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void autoTimeZoneNotSupported_notAvailable() {
|
|
TimeZoneCapabilitiesAndConfig capabilitiesAndConfig = createCapabilitiesAndConfig(
|
|
/* autoSupported= */false, /* autoEnabled= */false);
|
|
when(mTimeManager.getTimeZoneCapabilitiesAndConfig()).thenReturn(capabilitiesAndConfig);
|
|
|
|
AutoTimeZonePreferenceController controller = new AutoTimeZonePreferenceController(
|
|
mContext, null /* callback */, false /* fromSUW */);
|
|
|
|
assertThat(controller.isAvailable()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void isFromSUW_notEnable() {
|
|
TimeZoneCapabilitiesAndConfig capabilitiesAndConfig = createCapabilitiesAndConfig(
|
|
/* autoSupported= */false, /* autoEnabled= */false);
|
|
when(mTimeManager.getTimeZoneCapabilitiesAndConfig()).thenReturn(capabilitiesAndConfig);
|
|
|
|
AutoTimeZonePreferenceController controller = new AutoTimeZonePreferenceController(
|
|
mContext, null /* callback */, true /* fromSUW */);
|
|
|
|
assertThat(controller.isEnabled()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void isFromSUW_isEnable() {
|
|
TimeZoneCapabilitiesAndConfig capabilitiesAndConfig = createCapabilitiesAndConfig(
|
|
/* autoSupported= */false, /* autoEnabled= */true);
|
|
when(mTimeManager.getTimeZoneCapabilitiesAndConfig()).thenReturn(capabilitiesAndConfig);
|
|
|
|
AutoTimeZonePreferenceController controller = new AutoTimeZonePreferenceController(
|
|
mContext, null /* callback */, true /* fromSUW */);
|
|
|
|
assertThat(controller.isEnabled()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void autoTimeZoneNotSupported_notEnable() {
|
|
TimeZoneCapabilitiesAndConfig capabilitiesAndConfig = createCapabilitiesAndConfig(
|
|
/* autoSupported= */false, /* autoEnabled= */false);
|
|
when(mTimeManager.getTimeZoneCapabilitiesAndConfig()).thenReturn(capabilitiesAndConfig);
|
|
|
|
AutoTimeZonePreferenceController controller = new AutoTimeZonePreferenceController(
|
|
mContext, null /* callback */, false /* fromSUW */);
|
|
|
|
assertThat(controller.isEnabled()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void testIsEnabled_shouldReadFromTimeManagerConfig() {
|
|
AutoTimeZonePreferenceController controller = new AutoTimeZonePreferenceController(
|
|
mContext, null /* callback */, false /* fromSUW */);
|
|
|
|
{
|
|
// Disabled
|
|
TimeZoneCapabilitiesAndConfig capabilitiesAndConfig = createCapabilitiesAndConfig(
|
|
/* autoSupported= */true, /* autoEnabled= */false);
|
|
when(mTimeManager.getTimeZoneCapabilitiesAndConfig()).thenReturn(capabilitiesAndConfig);
|
|
|
|
assertThat(controller.isEnabled()).isFalse();
|
|
}
|
|
|
|
{
|
|
// Enabled
|
|
TimeZoneCapabilitiesAndConfig capabilitiesAndConfig = createCapabilitiesAndConfig(
|
|
/* autoSupported= */true, /* autoEnabled= */true);
|
|
when(mTimeManager.getTimeZoneCapabilitiesAndConfig()).thenReturn(capabilitiesAndConfig);
|
|
|
|
assertThat(controller.isEnabled()).isTrue();
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void updatePreferenceChange_prefIsChecked_shouldUpdatePreferenceAndNotifyCallback() {
|
|
TimeZoneCapabilitiesAndConfig capabilitiesAndConfig = createCapabilitiesAndConfig(
|
|
/* autoSupported= */true, /* autoEnabled= */false);
|
|
when(mTimeManager.getTimeZoneCapabilitiesAndConfig()).thenReturn(capabilitiesAndConfig);
|
|
when(mTimeManager.updateTimeZoneConfiguration(Mockito.any())).thenReturn(true);
|
|
|
|
AutoTimeZonePreferenceController controller = new AutoTimeZonePreferenceController(
|
|
mContext, mCallback, false /* fromSUW */);
|
|
|
|
assertThat(controller.onPreferenceChange(mPreference, true)).isTrue();
|
|
verify(mCallback).updateTimeAndDateDisplay(mContext);
|
|
|
|
// Check the service was asked to change the configuration correctly.
|
|
TimeZoneConfiguration timeZoneConfiguration = new TimeZoneConfiguration.Builder()
|
|
.setAutoDetectionEnabled(true)
|
|
.build();
|
|
verify(mTimeManager).updateTimeZoneConfiguration(timeZoneConfiguration);
|
|
|
|
// Update the mTimeManager mock so that it now returns the expected updated config.
|
|
TimeZoneCapabilitiesAndConfig capabilitiesAndConfigAfterUpdate =
|
|
createCapabilitiesAndConfig(/* autoSupported= */true, /* autoEnabled= */true);
|
|
when(mTimeManager.getTimeZoneCapabilitiesAndConfig())
|
|
.thenReturn(capabilitiesAndConfigAfterUpdate);
|
|
|
|
assertThat(controller.isEnabled()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void updatePreferenceChange_prefIsUnchecked_shouldUpdatePreferenceAndNotifyCallback() {
|
|
TimeZoneCapabilitiesAndConfig capabilitiesAndConfig = createCapabilitiesAndConfig(
|
|
/* autoSupported= */true, /* autoEnabled= */true);
|
|
when(mTimeManager.getTimeZoneCapabilitiesAndConfig()).thenReturn(capabilitiesAndConfig);
|
|
when(mTimeManager.updateTimeZoneConfiguration(Mockito.any())).thenReturn(true);
|
|
|
|
AutoTimeZonePreferenceController controller = new AutoTimeZonePreferenceController(
|
|
mContext, mCallback, false /* fromSUW */);
|
|
|
|
assertThat(controller.onPreferenceChange(mPreference, false)).isTrue();
|
|
verify(mCallback).updateTimeAndDateDisplay(mContext);
|
|
|
|
// Check the service was asked to change the configuration correctly.
|
|
TimeZoneConfiguration timeZoneConfiguration = new TimeZoneConfiguration.Builder()
|
|
.setAutoDetectionEnabled(false)
|
|
.build();
|
|
verify(mTimeManager).updateTimeZoneConfiguration(timeZoneConfiguration);
|
|
|
|
// Update the mTimeManager mock so that it now returns the expected updated config.
|
|
TimeZoneCapabilitiesAndConfig capabilitiesAndConfigAfterUpdate =
|
|
createCapabilitiesAndConfig(/* autoSupported= */true, /* autoEnabled= */false);
|
|
when(mTimeManager.getTimeZoneCapabilitiesAndConfig())
|
|
.thenReturn(capabilitiesAndConfigAfterUpdate);
|
|
|
|
assertThat(controller.isEnabled()).isFalse();
|
|
}
|
|
|
|
private static TimeZoneCapabilitiesAndConfig createCapabilitiesAndConfig(
|
|
boolean autoSupported, boolean autoEnabled) {
|
|
int configureAutoDetectionEnabledCapability =
|
|
autoSupported ? Capabilities.CAPABILITY_POSSESSED
|
|
: Capabilities.CAPABILITY_NOT_SUPPORTED;
|
|
TimeZoneCapabilities capabilities = new TimeZoneCapabilities.Builder(UserHandle.SYSTEM)
|
|
.setConfigureAutoDetectionEnabledCapability(configureAutoDetectionEnabledCapability)
|
|
.setConfigureGeoDetectionEnabledCapability(Capabilities.CAPABILITY_NOT_SUPPORTED)
|
|
.setSuggestManualTimeZoneCapability(Capabilities.CAPABILITY_POSSESSED)
|
|
.build();
|
|
TimeZoneConfiguration config = new TimeZoneConfiguration.Builder()
|
|
.setAutoDetectionEnabled(autoEnabled)
|
|
.setGeoDetectionEnabled(false)
|
|
.build();
|
|
return new TimeZoneCapabilitiesAndConfig(capabilities, config);
|
|
}
|
|
}
|