bc1b12db3a
There are duplicate a11y focuses in the App Notifications subpage. See the bug for more details. To fix the App, we will make the LayoutPreference unselectable, which makes the internal FrameLayout unfocusable. To fix the Switch, we can disable its focusability. This will make the FrameLayout the only focusable view for the Main Switch Bar. This a11y fix applies to all instances of SettingsMainSwitchPreference in the Settings app. Bug: 306725248 Flag: EXEMPT bugfix Test: atest SettingsMainSwitchPreferenceTest Manually tested the UI. The SettingsMainSwitchPreference is also used in `Display & Touch > Adaptive brightness`, `Accessibility > Caption Preference`, etc. The toggle acts as expected in the pages. Change-Id: I52b4965ac0ffc8d1576e8bc650715eb80ab4e8c7
97 lines
3.0 KiB
Java
97 lines
3.0 KiB
Java
/*
|
|
* Copyright (C) 2021 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.widget;
|
|
|
|
import static com.android.settingslib.RestrictedLockUtils.EnforcedAdmin;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import android.content.Context;
|
|
import android.view.View;
|
|
|
|
import androidx.preference.PreferenceViewHolder;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Mock;
|
|
import org.mockito.MockitoAnnotations;
|
|
import org.robolectric.RobolectricTestRunner;
|
|
import org.robolectric.RuntimeEnvironment;
|
|
import org.robolectric.util.ReflectionHelpers;
|
|
|
|
@RunWith(RobolectricTestRunner.class)
|
|
public class SettingsMainSwitchPreferenceTest {
|
|
|
|
@Mock
|
|
private EnforcedAdmin mEnforcedAdmin;
|
|
private SettingsMainSwitchPreference mPreference;
|
|
private PreferenceViewHolder mHolder;
|
|
private View mRootView;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
MockitoAnnotations.initMocks(this);
|
|
final Context context = RuntimeEnvironment.application;
|
|
final SettingsMainSwitchBar switchBar = new SettingsMainSwitchBar(context);
|
|
mPreference = new SettingsMainSwitchPreference(context);
|
|
ReflectionHelpers.setField(mPreference, "mEnforcedAdmin", mEnforcedAdmin);
|
|
ReflectionHelpers.setField(mPreference, "mMainSwitchBar", switchBar);
|
|
mRootView = View.inflate(context, com.android.settings.R.layout.preference_widget_main_switch,
|
|
null /* parent */);
|
|
mHolder = PreferenceViewHolder.createInstanceForTests(mRootView);
|
|
}
|
|
|
|
@Test
|
|
public void show_preferenceShouldDisplay() {
|
|
mPreference.show();
|
|
|
|
mPreference.onBindViewHolder(mHolder);
|
|
|
|
assertThat(mPreference.isShowing()).isTrue();
|
|
assertThat(mPreference.isVisible()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void hide_preferenceShouldNotDisplay() {
|
|
mPreference.hide();
|
|
|
|
mPreference.onBindViewHolder(mHolder);
|
|
|
|
assertThat(mPreference.isShowing()).isFalse();
|
|
assertThat(mPreference.isVisible()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void focusability_mainSwitchBarIsNotFocusable() {
|
|
mPreference.show();
|
|
|
|
mPreference.onBindViewHolder(mHolder);
|
|
|
|
assertThat(mPreference.getSwitchBar().isFocusable()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void focusability_mainSwitchBarFrameLayoutIsFocusable() {
|
|
mPreference.show();
|
|
|
|
mPreference.onBindViewHolder(mHolder);
|
|
|
|
assertThat(mRootView.isFocusable()).isTrue();
|
|
}
|
|
}
|