DO disclosures referring to actions that the admin did not actually take are hidden in the UI, but still show up in the search index. This CL switches the remaining PreferenceControllers from setting visibility to implementing isAvailable() instead. Bug: 32692748 Test: m RunSettingsRoboTests Change-Id: I54360698f28b549b18cdc230e3b9087cf4e9ff4a
149 lines
5.5 KiB
Java
149 lines
5.5 KiB
Java
/*
|
|
* Copyright (C) 2017 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.enterprise;
|
|
|
|
import android.content.Context;
|
|
import android.content.Intent;
|
|
import android.content.res.Resources;
|
|
import android.support.v7.preference.Preference;
|
|
|
|
import com.android.settings.R;
|
|
import com.android.settings.applications.ApplicationFeatureProvider;
|
|
import com.android.settings.testutils.FakeFeatureFactory;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.mockito.Answers;
|
|
import org.mockito.ArgumentCaptor;
|
|
import org.mockito.Mock;
|
|
import org.mockito.MockitoAnnotations;
|
|
import org.mockito.invocation.InvocationOnMock;
|
|
import org.mockito.stubbing.Answer;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static org.mockito.Mockito.anyObject;
|
|
import static org.mockito.Mockito.doAnswer;
|
|
import static org.mockito.Mockito.eq;
|
|
import static org.mockito.Mockito.verify;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
/**
|
|
* Common base for testing subclasses of {@link AdminGrantedPermissionsPreferenceControllerBase}.
|
|
*/
|
|
public abstract class AdminGrantedPermissionsPreferenceControllerTestBase {
|
|
|
|
protected final String mKey;
|
|
protected final String[] mPermissions;
|
|
protected final String mPermissionGroup;
|
|
|
|
@Mock(answer = Answers.RETURNS_DEEP_STUBS)
|
|
protected Context mContext;
|
|
private FakeFeatureFactory mFeatureFactory;
|
|
|
|
protected AdminGrantedPermissionsPreferenceControllerBase mController;
|
|
|
|
public AdminGrantedPermissionsPreferenceControllerTestBase(String key, String[] permissions,
|
|
String permissionGroup) {
|
|
mKey = key;
|
|
mPermissions = permissions;
|
|
mPermissionGroup = permissionGroup;
|
|
}
|
|
|
|
@Before
|
|
public void setUp() {
|
|
MockitoAnnotations.initMocks(this);
|
|
FakeFeatureFactory.setupForTest(mContext);
|
|
mFeatureFactory = (FakeFeatureFactory) FakeFeatureFactory.getFactory(mContext);
|
|
mController = createController(true /* async */);
|
|
}
|
|
|
|
private void setNumberOfPackagesWithAdminGrantedPermissions(int number, boolean async) {
|
|
doAnswer(new Answer() {
|
|
public Object answer(InvocationOnMock invocation) {
|
|
((ApplicationFeatureProvider.NumberOfAppsCallback)
|
|
invocation.getArguments()[2]).onNumberOfAppsResult(number);
|
|
return null;
|
|
}}).when(mFeatureFactory.applicationFeatureProvider)
|
|
.calculateNumberOfAppsWithAdminGrantedPermissions(eq(mPermissions),
|
|
eq(async), anyObject());
|
|
}
|
|
|
|
@Test
|
|
public void testUpdateState() {
|
|
final Preference preference = new Preference(mContext, null, 0, 0);
|
|
preference.setVisible(true);
|
|
|
|
setNumberOfPackagesWithAdminGrantedPermissions(0, true /* async */);
|
|
mController.updateState(preference);
|
|
assertThat(preference.isVisible()).isFalse();
|
|
|
|
setNumberOfPackagesWithAdminGrantedPermissions(20, true /* async */);
|
|
when(mContext.getResources().getQuantityString(
|
|
R.plurals.enterprise_privacy_number_packages_actionable,20, 20))
|
|
.thenReturn("20 packages");
|
|
mController.updateState(preference);
|
|
assertThat(preference.getSummary()).isEqualTo("20 packages");
|
|
assertThat(preference.isVisible()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void testIsAvailableSync() {
|
|
final AdminGrantedPermissionsPreferenceControllerBase controller
|
|
= createController(false /* async */);
|
|
|
|
setNumberOfPackagesWithAdminGrantedPermissions(0, false /* async */);
|
|
assertThat(controller.isAvailable()).isFalse();
|
|
|
|
setNumberOfPackagesWithAdminGrantedPermissions(20, false /* async */);
|
|
assertThat(controller.isAvailable()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void testIsAvailableAsync() {
|
|
setNumberOfPackagesWithAdminGrantedPermissions(0, true /* async */);
|
|
assertThat(mController.isAvailable()).isTrue();
|
|
|
|
setNumberOfPackagesWithAdminGrantedPermissions(20, true /* async */);
|
|
assertThat(mController.isAvailable()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void testHandlePreferenceTreeClick() {
|
|
final Preference preference = new Preference(mContext, null, 0, 0);
|
|
preference.setKey(mKey);
|
|
|
|
assertThat(mController.handlePreferenceTreeClick(preference)).isTrue();
|
|
|
|
final ArgumentCaptor<Intent> argumentCaptor = ArgumentCaptor.forClass(Intent.class);
|
|
verify(mContext).startActivity(argumentCaptor.capture());
|
|
|
|
final Intent intent = argumentCaptor.getValue();
|
|
|
|
assertThat(intent.getAction()).isEqualTo(Intent.ACTION_MANAGE_PERMISSION_APPS);
|
|
assertThat(intent.getStringExtra(Intent.EXTRA_PERMISSION_NAME)).
|
|
isEqualTo(mPermissionGroup);
|
|
}
|
|
|
|
@Test
|
|
public void testGetPreferenceKey() {
|
|
assertThat(mController.getPreferenceKey()).isEqualTo(mKey);
|
|
}
|
|
|
|
protected abstract AdminGrantedPermissionsPreferenceControllerBase createController(
|
|
boolean async);
|
|
}
|