In two places, Settings uses getProfileIdsWithDisabled intending to restrict itself to *managed* profiles, but actually allows for any type of profile. Since the declared intent is to only deal with managed profiles, we update the code to only consider managed profiles. On devices that only have managed profiles (currently almost all devices), this cl is a no-op. Bug: 230495929 Bug: 230534572 Bug: 170249807 Test: com.android.settings.UtilsTest Test: make RunSettingsRoboTests -j Change-Id: Id04d45839ef61080b00ca2f91525718cb3a85120
200 lines
8.1 KiB
Java
200 lines
8.1 KiB
Java
/*
|
|
* Copyright (C) 2017 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
package com.android.settings.location;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import static org.mockito.ArgumentMatchers.any;
|
|
import static org.mockito.ArgumentMatchers.anyInt;
|
|
import static org.mockito.ArgumentMatchers.eq;
|
|
import static org.mockito.Mockito.doReturn;
|
|
import static org.mockito.Mockito.spy;
|
|
import static org.mockito.Mockito.verify;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
import android.app.admin.DevicePolicyManager;
|
|
import android.content.ComponentName;
|
|
import android.content.Context;
|
|
import android.content.pm.UserInfo;
|
|
import android.os.UserHandle;
|
|
import android.os.UserManager;
|
|
import android.provider.Settings;
|
|
import android.util.ArrayMap;
|
|
|
|
import androidx.lifecycle.LifecycleOwner;
|
|
import androidx.preference.Preference;
|
|
import androidx.preference.PreferenceCategory;
|
|
import androidx.preference.PreferenceScreen;
|
|
|
|
import com.android.settings.testutils.shadow.ShadowUserManager;
|
|
import com.android.settings.widget.RestrictedAppPreference;
|
|
import com.android.settingslib.core.lifecycle.Lifecycle;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Answers;
|
|
import org.mockito.Mock;
|
|
import org.mockito.MockitoAnnotations;
|
|
import org.robolectric.RobolectricTestRunner;
|
|
import org.robolectric.RuntimeEnvironment;
|
|
import org.robolectric.annotation.Config;
|
|
|
|
import java.util.ArrayList;
|
|
import java.util.List;
|
|
import java.util.Map;
|
|
|
|
@RunWith(RobolectricTestRunner.class)
|
|
@Config(shadows = ShadowUserManager.class)
|
|
public class LocationInjectedServicesPreferenceControllerTest {
|
|
|
|
private static final String KEY_LOCATION_SERVICES = "location_service";
|
|
|
|
@Mock(answer = Answers.RETURNS_DEEP_STUBS)
|
|
private LocationSettings mFragment;
|
|
@Mock
|
|
private PreferenceCategory mCategoryPrimary;
|
|
@Mock
|
|
private PreferenceScreen mScreen;
|
|
@Mock
|
|
private AppSettingsInjector mSettingsInjector;
|
|
@Mock
|
|
private DevicePolicyManager mDevicePolicyManager;
|
|
|
|
private Context mContext;
|
|
private LocationInjectedServicesPreferenceController mController;
|
|
private LifecycleOwner mLifecycleOwner;
|
|
private Lifecycle mLifecycle;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
MockitoAnnotations.initMocks(this);
|
|
mContext = spy(RuntimeEnvironment.application);
|
|
mLifecycleOwner = () -> mLifecycle;
|
|
mLifecycle = new Lifecycle(mLifecycleOwner);
|
|
mController = spy(
|
|
new LocationInjectedServicesPreferenceController(mContext, KEY_LOCATION_SERVICES));
|
|
when(mFragment.getSettingsLifecycle()).thenReturn(mLifecycle);
|
|
mController.init(mFragment);
|
|
mController.mInjector = mSettingsInjector;
|
|
final String key = mController.getPreferenceKey();
|
|
when(mScreen.findPreference(key)).thenReturn(mCategoryPrimary);
|
|
when(mCategoryPrimary.getKey()).thenReturn(key);
|
|
when(mContext.getSystemService(Context.DEVICE_POLICY_SERVICE))
|
|
.thenReturn(mDevicePolicyManager);
|
|
}
|
|
|
|
@Test
|
|
public void onResume_shouldRegisterListener() {
|
|
mController.onResume();
|
|
|
|
verify(mContext).registerReceiver(eq(mController.mInjectedSettingsReceiver),
|
|
eq(mController.INTENT_FILTER_INJECTED_SETTING_CHANGED),
|
|
anyInt());
|
|
}
|
|
|
|
@Test
|
|
public void onPause_shouldUnregisterListener() {
|
|
mController.onResume();
|
|
mController.onPause();
|
|
|
|
verify(mContext).unregisterReceiver(mController.mInjectedSettingsReceiver);
|
|
}
|
|
|
|
@Test
|
|
public void workProfileDisallowShareLocationOn_getParentUserLocationServicesOnly() {
|
|
final int fakeWorkProfileId = 123;
|
|
ShadowUserManager.getShadow().setProfileIdsWithDisabled(
|
|
new int[]{UserHandle.myUserId(), fakeWorkProfileId});
|
|
ShadowUserManager.getShadow().addProfile(new UserInfo(UserHandle.myUserId(), "", 0));
|
|
ShadowUserManager.getShadow().addProfile(new UserInfo(fakeWorkProfileId, "",
|
|
UserInfo.FLAG_MANAGED_PROFILE | UserInfo.FLAG_PROFILE));
|
|
|
|
// Mock RestrictedLockUtils.checkIfRestrictionEnforced and let it return non-null.
|
|
final List<UserManager.EnforcingUser> enforcingUsers = new ArrayList<>();
|
|
enforcingUsers.add(new UserManager.EnforcingUser(fakeWorkProfileId,
|
|
UserManager.RESTRICTION_SOURCE_DEVICE_OWNER));
|
|
final ComponentName componentName = new ComponentName("test", "test");
|
|
// Ensure that RestrictedLockUtils.checkIfRestrictionEnforced doesn't return null.
|
|
ShadowUserManager.getShadow().setUserRestrictionSources(
|
|
UserManager.DISALLOW_SHARE_LOCATION,
|
|
UserHandle.of(fakeWorkProfileId),
|
|
enforcingUsers);
|
|
when(mDevicePolicyManager.getDeviceOwnerComponentOnAnyUser()).thenReturn(componentName);
|
|
|
|
mController.displayPreference(mScreen);
|
|
verify(mSettingsInjector).getInjectedSettings(
|
|
any(Context.class), eq(UserHandle.myUserId()));
|
|
}
|
|
|
|
@Test
|
|
public void workProfileDisallowShareLocationOff_getAllUserLocationServices() {
|
|
final int fakeWorkProfileId = 123;
|
|
ShadowUserManager.getShadow().setProfileIdsWithDisabled(
|
|
new int[]{UserHandle.myUserId(), fakeWorkProfileId});
|
|
|
|
// Mock RestrictedLockUtils.checkIfRestrictionEnforced and let it return null.
|
|
// Empty enforcing users.
|
|
final List<UserManager.EnforcingUser> enforcingUsers = new ArrayList<>();
|
|
ShadowUserManager.getShadow().setUserRestrictionSources(
|
|
UserManager.DISALLOW_SHARE_LOCATION,
|
|
UserHandle.of(fakeWorkProfileId),
|
|
enforcingUsers);
|
|
|
|
mController.displayPreference(mScreen);
|
|
verify(mSettingsInjector).getInjectedSettings(
|
|
any(Context.class), eq(UserHandle.USER_CURRENT));
|
|
}
|
|
|
|
@Test
|
|
public void onLocationModeChanged_shouldRequestReloadInjectedSettigns() {
|
|
mController.onLocationModeChanged(Settings.Secure.LOCATION_MODE_BATTERY_SAVING, false);
|
|
|
|
verify(mSettingsInjector).reloadStatusMessages();
|
|
}
|
|
|
|
@Test
|
|
public void withUserRestriction_shouldDisableLocationAccuracy() {
|
|
final List<Preference> preferences = new ArrayList<>();
|
|
final RestrictedAppPreference pref = new RestrictedAppPreference(mContext,
|
|
UserManager.DISALLOW_CONFIG_LOCATION);
|
|
pref.setTitle("Location Accuracy");
|
|
preferences.add(pref);
|
|
final Map<Integer, List<Preference>> map = new ArrayMap<>();
|
|
map.put(UserHandle.myUserId(), preferences);
|
|
doReturn(map).when(mSettingsInjector)
|
|
.getInjectedSettings(any(Context.class), anyInt());
|
|
ShadowUserManager.getShadow().setProfileIdsWithDisabled(new int[]{UserHandle.myUserId()});
|
|
|
|
final int userId = UserHandle.myUserId();
|
|
List<UserManager.EnforcingUser> enforcingUsers = new ArrayList<>();
|
|
enforcingUsers.add(new UserManager.EnforcingUser(userId,
|
|
UserManager.RESTRICTION_SOURCE_DEVICE_OWNER));
|
|
ComponentName componentName = new ComponentName("test", "test");
|
|
// Ensure that RestrictedLockUtils.checkIfRestrictionEnforced doesn't return null.
|
|
ShadowUserManager.getShadow().setUserRestrictionSources(
|
|
UserManager.DISALLOW_CONFIG_LOCATION,
|
|
UserHandle.of(userId),
|
|
enforcingUsers);
|
|
when(mDevicePolicyManager.getDeviceOwnerComponentOnAnyUser()).thenReturn(componentName);
|
|
|
|
mController.displayPreference(mScreen);
|
|
|
|
assertThat(pref.isEnabled()).isFalse();
|
|
assertThat(pref.isDisabledByAdmin()).isTrue();
|
|
}
|
|
}
|