2c3e6c6434
The feature failed after the CL "Force the adapter to rebind cards with a toggle". Because toggle slices have been forced to rebind after starting another activity and when any slice is updating. This unpins Wi-Fi slice and stops WifiScanWorker and then clears the saved clicked network. Solution: 1. Change ConnectToWifiHandler from activity to receiver and send broadcasts to it with FLAG_RECEIVER_FOREGROUND, so Wi-Fi slice won't be forced to rebind. 2. Seperate Wi-Fi scan worker and contextual Wi-Fi scan worker. Keep the original logic for the generic one, and then add the logic below to the contextual one. 3. Do not clear the saved clicked network when slice is unppined because it happens frequently in contextual homepage. 4. Introduce a static long in ContextualWifiScanWorker that updates once in every visible UI session. A session is when the screen is visible to user. 5. Use session token to determine whether auto-starting captive portal is needed. Fixes: 128056349 Test: robotest, visual in homepage and network panel Change-Id: I9e03c379806e124fa7253b2a635574b2433f6afc
65 lines
2.0 KiB
Java
65 lines
2.0 KiB
Java
/*
|
|
* Copyright (C) 2019 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License
|
|
*/
|
|
|
|
package com.android.settings.wifi.slice;
|
|
|
|
import android.content.Context;
|
|
import android.net.Uri;
|
|
import android.os.SystemClock;
|
|
|
|
import com.android.settings.slices.SliceBackgroundWorker;
|
|
|
|
/**
|
|
* {@link SliceBackgroundWorker} for Wi-Fi, used by {@link ContextualWifiSlice}.
|
|
*/
|
|
public class ContextualWifiScanWorker extends WifiScanWorker {
|
|
|
|
private static long sVisibleUiSessionToken;
|
|
private static long sActiveSession;
|
|
|
|
public ContextualWifiScanWorker(Context context, Uri uri) {
|
|
super(context, uri);
|
|
}
|
|
|
|
/**
|
|
* Starts a new visible UI session for the purpose of automatically starting captive portal.
|
|
*
|
|
* A visible UI session is defined as a duration of time when a UI screen is visible to user.
|
|
* Going to a sub-page and coming out breaks the continuation, leaving the page and coming back
|
|
* breaks it too.
|
|
*/
|
|
public static void newVisibleUiSession() {
|
|
sVisibleUiSessionToken = SystemClock.elapsedRealtime();
|
|
}
|
|
|
|
static void saveSession() {
|
|
sActiveSession = sVisibleUiSessionToken;
|
|
}
|
|
|
|
@Override
|
|
protected void clearClickedWifiOnSliceUnpinned() {
|
|
// Do nothing for contextual Wi-Fi slice
|
|
}
|
|
|
|
@Override
|
|
protected boolean isSessionValid() {
|
|
if (sVisibleUiSessionToken != sActiveSession) {
|
|
clearClickedWifi();
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
} |