8fe5d507d5
The app icon size as 24dp is too small. We'd like to increase to 32dp
based on latest UX feedback and to match Material Spec v2 wrt app icon
sizes.
Test: make RunSettingsRoboTest -j40 ROBOTEST_FILTER=AppPreferenceTest
Test: visual (Launch settings -> App & notification -> verify app icon
size increased)
Fixes: 71767701
Change-Id: I474df72075602fc48d3123127b4f9bf350374506
89 lines
2.8 KiB
Java
89 lines
2.8 KiB
Java
/*
|
|
* Copyright (C) 2017 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.widget;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import android.content.Context;
|
|
import android.support.v7.preference.PreferenceViewHolder;
|
|
import android.view.View;
|
|
|
|
import com.android.settings.R;
|
|
import com.android.settings.TestConfig;
|
|
import com.android.settings.testutils.SettingsRobolectricTestRunner;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.robolectric.RuntimeEnvironment;
|
|
import org.robolectric.annotation.Config;
|
|
|
|
@RunWith(SettingsRobolectricTestRunner.class)
|
|
@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION)
|
|
public class AppPreferenceTest {
|
|
|
|
private static final int EXPECTED_APP_ICON_SIZE_DP = 32;
|
|
|
|
private Context mContext;
|
|
private View mRootView;
|
|
private AppPreference mPref;
|
|
private PreferenceViewHolder mHolder;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
mContext = RuntimeEnvironment.application;
|
|
mRootView = View.inflate(mContext, R.layout.preference_app, null /* parent */);
|
|
mHolder = PreferenceViewHolder.createInstanceForTests(mRootView);
|
|
mPref = new AppPreference(mContext);
|
|
}
|
|
|
|
@Test
|
|
public void setProgress_showProgress() {
|
|
mPref.setProgress(1);
|
|
mPref.onBindViewHolder(mHolder);
|
|
|
|
assertThat(mHolder.findViewById(android.R.id.progress).getVisibility())
|
|
.isEqualTo(View.VISIBLE);
|
|
}
|
|
|
|
@Test
|
|
public void setSummary_showSummaryContainer() {
|
|
mPref.setSummary("test");
|
|
mPref.onBindViewHolder(mHolder);
|
|
|
|
assertThat(mHolder.findViewById(R.id.summary_container).getVisibility())
|
|
.isEqualTo(View.VISIBLE);
|
|
}
|
|
|
|
@Test
|
|
public void noSummary_hideSummaryContainer() {
|
|
mPref.setSummary(null);
|
|
mPref.onBindViewHolder(mHolder);
|
|
|
|
assertThat(mHolder.findViewById(R.id.summary_container).getVisibility())
|
|
.isEqualTo(View.GONE);
|
|
}
|
|
|
|
@Test
|
|
public void foobar_testName() {
|
|
// Can't use isEquals() to compare float. Use isWithIn().of() instead.
|
|
assertThat(mContext.getResources().getDimension(R.dimen.secondary_app_icon_size))
|
|
.isWithin(0.01f)
|
|
.of(EXPECTED_APP_ICON_SIZE_DP);
|
|
}
|
|
}
|