b6fdd25c23
Settings Panels as a dialog have a default animation for entering the screen, but Slices complicate the animation. While the dialog enters the screen, Slices begin to bind, thus changing the height of the dialog as it enters, causing perceived bounce / jank in the animation. This CL is cherry-picked/based on ag/6671083 but do the following modification: (See the original commit message for the whole concept) When trying to load all the Slices, there are few possible situations: 1. Slice starts loading slowly, starting at state LOADED_NONE 2. Slice is loading in progress, having state LOADED_PARTIAL 3. Slice is loaded, but there's error return from the Slice data (We don't need to show the Slice in this case) 4. Slice is loaded, progress to state LOADED_ALL 5. Slice starts from state LOADED_NONE, but never progress to the next state because it crashes at setting backend. Notice that there are two cases that the state will stay at LOADED_NONE and we can't distinguish them. Hence, we decide to do the following: If Slice is with error (case 3) we remove the slice from the list and mark it loaded. If Slice is loaded with LOADED_ALL (case 4, which is the ideal case), we mark it as loaded. In the other cases, we fire a handler to mark the slice loaded anyway after 250ms timeout. When all the slices are marked loaded (which should happen after 250ms timeout, we will animate the panel out. Although there might be slices which are still partial loaded, we can still have the slice in the panel once it is ready. The panel might bounce/jank in this case, but at least it will still showing correctly, and should show up smoothly in most cases. The solution to this problem is twofold: 1. Load all Slices first 2. Create a custom animation to draw the panel once the recyclerview has been laid out. Test: Manual/Visual inspection Test: make -j40 RunSettingsRobotests Bug: 123942159 Change-Id: I639a707aa4ba3f906bd6f9752c92727aaba28142
92 lines
2.8 KiB
Java
92 lines
2.8 KiB
Java
/*
|
|
* Copyright (C) 2019 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
|
|
package com.android.settings.panel;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import android.content.Context;
|
|
import android.net.Uri;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
|
|
import org.robolectric.RobolectricTestRunner;
|
|
import org.robolectric.RuntimeEnvironment;
|
|
|
|
@RunWith(RobolectricTestRunner.class)
|
|
public class PanelSlicesLoaderCountdownLatchTest {
|
|
|
|
private Context mContext;
|
|
private PanelSlicesLoaderCountdownLatch mSliceCountdownLatch;
|
|
|
|
private static final Uri[] URIS = new Uri[] {
|
|
Uri.parse("content://testUri"),
|
|
Uri.parse("content://wowUri"),
|
|
Uri.parse("content://boxTurtle")
|
|
};
|
|
|
|
@Before
|
|
public void setUp() {
|
|
mContext = RuntimeEnvironment.application;
|
|
mSliceCountdownLatch = new PanelSlicesLoaderCountdownLatch(URIS.length);
|
|
}
|
|
|
|
|
|
@Test
|
|
public void hasLoaded_newObject_returnsFalse() {
|
|
assertThat(mSliceCountdownLatch.isSliceLoaded(URIS[0])).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void hasLoaded_markSliceLoaded_returnsTrue() {
|
|
mSliceCountdownLatch.markSliceLoaded(URIS[0]);
|
|
|
|
assertThat(mSliceCountdownLatch.isSliceLoaded(URIS[0])).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void markSliceLoaded_onlyCountsDownUniqueUris() {
|
|
for (int i = 0; i < URIS.length; i++) {
|
|
mSliceCountdownLatch.markSliceLoaded(URIS[0]);
|
|
}
|
|
|
|
assertThat(mSliceCountdownLatch.isPanelReadyToLoad()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void areSlicesReadyToLoad_allSlicesLoaded_returnsTrue() {
|
|
for (int i = 0; i < URIS.length; i++) {
|
|
mSliceCountdownLatch.markSliceLoaded(URIS[i]);
|
|
}
|
|
|
|
assertThat(mSliceCountdownLatch.isPanelReadyToLoad()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void areSlicesReadyToLoad_onlyReturnsTrueOnce() {
|
|
for (int i = 0; i < URIS.length; i++) {
|
|
mSliceCountdownLatch.markSliceLoaded(URIS[i]);
|
|
}
|
|
|
|
// Verify that it returns true once
|
|
assertThat(mSliceCountdownLatch.isPanelReadyToLoad()).isTrue();
|
|
// Verify the second call returns false without external state change
|
|
assertThat(mSliceCountdownLatch.isPanelReadyToLoad()).isFalse();
|
|
}
|
|
} |