Only support explicitly approved Settings Slices, dictated by controllers which return true for the new method isSliceable. Updating the supported settings to a whitelist means that the method to return all available slices must be updated, and checking slicability when we index slices. Test: robotests Change-Id: I85848c2cdf3e151fa94b33dd1dc5c0374ef94b5b Merged-In: Ib2b9690cdd0036b5cc4a1cb846c52bce7c824ab9 Fixes: 79779103
169 lines
5.7 KiB
Java
169 lines
5.7 KiB
Java
/*
|
|
* Copyright (C) 2017 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.display;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import static org.mockito.ArgumentMatchers.anyInt;
|
|
import static org.mockito.Mockito.spy;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
import android.content.ContentResolver;
|
|
import android.content.Context;
|
|
import android.provider.Settings;
|
|
|
|
import com.android.internal.hardware.AmbientDisplayConfiguration;
|
|
import com.android.settings.search.InlinePayload;
|
|
import com.android.settings.search.InlineSwitchPayload;
|
|
import com.android.settings.testutils.SettingsRobolectricTestRunner;
|
|
import com.android.settings.testutils.shadow.ShadowSecureSettings;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Mock;
|
|
import org.mockito.MockitoAnnotations;
|
|
import org.robolectric.RuntimeEnvironment;
|
|
import org.robolectric.annotation.Config;
|
|
|
|
@RunWith(SettingsRobolectricTestRunner.class)
|
|
@Config(shadows = ShadowSecureSettings.class)
|
|
public class AmbientDisplayAlwaysOnPreferenceControllerTest {
|
|
|
|
@Mock
|
|
private AmbientDisplayConfiguration mConfig;
|
|
|
|
private Context mContext;
|
|
|
|
private ContentResolver mContentResolver;
|
|
|
|
private AmbientDisplayAlwaysOnPreferenceController mController;
|
|
private boolean mCallbackInvoked;
|
|
|
|
@Before
|
|
public void setUp() throws Exception {
|
|
MockitoAnnotations.initMocks(this);
|
|
mContext = RuntimeEnvironment.application;
|
|
mContentResolver = mContext.getContentResolver();
|
|
mController = new AmbientDisplayAlwaysOnPreferenceController(mContext, "key");
|
|
mController.setConfig(mConfig);
|
|
mController.setCallback(() -> mCallbackInvoked = true);
|
|
}
|
|
|
|
@Test
|
|
public void getAvailabilityStatus_available() {
|
|
when(mConfig.alwaysOnAvailableForUser(anyInt())).thenReturn(true);
|
|
|
|
assertThat(mController.getAvailabilityStatus()).isEqualTo(
|
|
AmbientDisplayAlwaysOnPreferenceController.AVAILABLE);
|
|
}
|
|
|
|
@Test
|
|
public void getAvailabilityStatus_disabled_unsupported() {
|
|
when(mConfig.alwaysOnAvailableForUser(anyInt())).thenReturn(false);
|
|
|
|
assertThat(mController.getAvailabilityStatus()).isEqualTo(
|
|
AmbientDisplayAlwaysOnPreferenceController.UNSUPPORTED_ON_DEVICE);
|
|
}
|
|
|
|
@Test
|
|
public void isChecked_enabled() {
|
|
when(mConfig.alwaysOnEnabled(anyInt())).thenReturn(true);
|
|
|
|
assertThat(mController.isChecked()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void isChecked_disabled() {
|
|
when(mConfig.alwaysOnEnabled(anyInt())).thenReturn(false);
|
|
|
|
assertThat(mController.isChecked()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void setChecked_enabled() {
|
|
mController.setChecked(true);
|
|
|
|
assertThat(Settings.Secure.getInt(mContentResolver, Settings.Secure.DOZE_ALWAYS_ON, -1))
|
|
.isEqualTo(1);
|
|
}
|
|
|
|
@Test
|
|
public void setChecked_disabled() {
|
|
mController.setChecked(false);
|
|
|
|
assertThat(Settings.Secure.getInt(mContentResolver, Settings.Secure.DOZE_ALWAYS_ON, -1))
|
|
.isEqualTo(0);
|
|
}
|
|
|
|
@Test
|
|
public void onPreferenceChange_callback() {
|
|
assertThat(mCallbackInvoked).isFalse();
|
|
mController.setChecked(true);
|
|
assertThat(mCallbackInvoked).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void testPreferenceController_ProperResultPayloadType() {
|
|
when(mConfig.alwaysOnAvailableForUser(anyInt())).thenReturn(false);
|
|
mController = spy(mController);
|
|
|
|
assertThat(mController.getResultPayload()).isInstanceOf(InlineSwitchPayload.class);
|
|
}
|
|
|
|
@Test
|
|
public void testSetValue_updatesCorrectly() {
|
|
when(mConfig.alwaysOnAvailableForUser(anyInt())).thenReturn(false);
|
|
mController = spy(mController);
|
|
final int newValue = 1;
|
|
Settings.Secure.putInt(mContentResolver, Settings.Secure.DOZE_ALWAYS_ON, 0 /* value */);
|
|
|
|
((InlinePayload) mController.getResultPayload()).setValue(mContext, newValue);
|
|
final int updatedValue = Settings.Secure.
|
|
getInt(mContentResolver, Settings.Secure.DOZE_ALWAYS_ON, 1 /* default */);
|
|
|
|
assertThat(updatedValue).isEqualTo(newValue);
|
|
}
|
|
|
|
@Test
|
|
public void testGetValue_correctValueReturned() {
|
|
when(mConfig.alwaysOnAvailableForUser(anyInt())).thenReturn(false);
|
|
mController = spy(mController);
|
|
final int currentValue = 1;
|
|
Settings.Secure.putInt(mContentResolver, Settings.Secure.DOZE_ALWAYS_ON, currentValue);
|
|
|
|
final int newValue = ((InlinePayload) mController.getResultPayload()).getValue(mContext);
|
|
|
|
assertThat(newValue).isEqualTo(currentValue);
|
|
}
|
|
|
|
@Test
|
|
public void isSliceableCorrectKey_returnsTrue() {
|
|
final AmbientDisplayAlwaysOnPreferenceController controller =
|
|
new AmbientDisplayAlwaysOnPreferenceController(mContext,
|
|
"ambient_display_always_on");
|
|
assertThat(controller.isSliceable()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void isSliceableIncorrectKey_returnsFalse() {
|
|
final AmbientDisplayAlwaysOnPreferenceController controller =
|
|
new AmbientDisplayAlwaysOnPreferenceController(mContext, "bad_key");
|
|
assertThat(controller.isSliceable()).isFalse();
|
|
}
|
|
}
|