In warm load, the app list is populated much faster, and we should not show the spinner if we can show the app list immediately. Adding 100ms delay in showing the loading container. If the app list is ready, show the list container directly without first showing the loading container. Change-Id: I8b3ea88d2382ece9226d5c7734fd1aa406160cf2 Fix: 36375109 Test: make RunSettingsRoboTests
261 lines
11 KiB
Java
261 lines
11 KiB
Java
/*
|
|
* Copyright (C) 2016 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.applications;
|
|
|
|
import android.app.Activity;
|
|
import android.content.Context;
|
|
import android.content.pm.ApplicationInfo;
|
|
import android.content.pm.PackageManager;
|
|
import android.os.Handler;
|
|
import android.os.Looper;
|
|
import android.view.LayoutInflater;
|
|
import android.view.Menu;
|
|
import android.view.MenuItem;
|
|
import android.view.View;
|
|
import android.view.ViewGroup;
|
|
import android.widget.TextView;
|
|
|
|
import com.android.settings.R;
|
|
import com.android.settings.Settings;
|
|
import com.android.settings.TestConfig;
|
|
import com.android.settings.testutils.SettingsRobolectricTestRunner;
|
|
import com.android.settings.testutils.shadow.SettingsShadowResources;
|
|
import com.android.settings.testutils.shadow.SettingsShadowResources.SettingsShadowTheme;
|
|
import com.android.settings.testutils.shadow.ShadowDynamicIndexableContentMonitor;
|
|
import com.android.settings.testutils.shadow.ShadowEventLogWriter;
|
|
import com.android.settingslib.applications.ApplicationsState;
|
|
import com.android.settingslib.applications.ApplicationsState.Callbacks;
|
|
import com.android.settingslib.core.lifecycle.Lifecycle;
|
|
|
|
import java.util.ArrayList;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Mock;
|
|
import org.mockito.MockitoAnnotations;
|
|
import org.robolectric.RuntimeEnvironment;
|
|
import org.robolectric.annotation.Config;
|
|
import org.robolectric.fakes.RoboMenuItem;
|
|
import org.robolectric.util.ReflectionHelpers;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static org.mockito.Matchers.any;
|
|
import static org.mockito.Matchers.anyInt;
|
|
import static org.mockito.Matchers.anyLong;
|
|
import static org.mockito.Matchers.eq;
|
|
import static org.mockito.Mockito.doNothing;
|
|
import static org.mockito.Mockito.mock;
|
|
import static org.mockito.Mockito.never;
|
|
import static org.mockito.Mockito.spy;
|
|
import static org.mockito.Mockito.verify;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
/**
|
|
* Tests for {@link ManageApplications}.
|
|
*/
|
|
@RunWith(SettingsRobolectricTestRunner.class)
|
|
// TODO: Consider making the shadow class set global using a robolectric.properties file.
|
|
@Config(manifest = TestConfig.MANIFEST_PATH,
|
|
sdk = TestConfig.SDK_VERSION,
|
|
shadows = {
|
|
SettingsShadowResources.class,
|
|
SettingsShadowTheme.class,
|
|
ShadowDynamicIndexableContentMonitor.class,
|
|
ShadowEventLogWriter.class
|
|
})
|
|
public class ManageApplicationsTest {
|
|
|
|
@Mock
|
|
private ApplicationsState mState;
|
|
@Mock
|
|
private ApplicationsState.Session mSession;
|
|
@Mock
|
|
private Menu mMenu;
|
|
private MenuItem mAppReset;
|
|
private Looper mBgLooper;
|
|
private ManageApplications mFragment;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
MockitoAnnotations.initMocks(this);
|
|
mAppReset = new RoboMenuItem(R.id.reset_app_preferences);
|
|
ReflectionHelpers.setStaticField(ApplicationsState.class, "sInstance", mState);
|
|
when(mState.newSession(any())).thenReturn(mSession);
|
|
mBgLooper = Looper.myLooper();
|
|
when(mState.getBackgroundLooper()).thenReturn(mBgLooper);
|
|
|
|
mFragment = new ManageApplications();
|
|
ReflectionHelpers.setField(mFragment, "mLifecycle", new Lifecycle());
|
|
}
|
|
|
|
@Test
|
|
public void launchFragment() {
|
|
SettingsRobolectricTestRunner.startSettingsFragment(
|
|
mFragment, Settings.ManageApplicationsActivity.class);
|
|
}
|
|
|
|
@Test
|
|
public void updateDisableView_appDisabledUntilUsed_shouldSetDisabled() {
|
|
final TextView view = mock(TextView.class);
|
|
final ApplicationInfo info = new ApplicationInfo();
|
|
info.flags = ApplicationInfo.FLAG_INSTALLED;
|
|
info.enabled = true;
|
|
info.enabledSetting = PackageManager.COMPONENT_ENABLED_STATE_DISABLED_UNTIL_USED;
|
|
ManageApplications fragment = mock(ManageApplications.class);
|
|
when(fragment.getActivity()).thenReturn(mock(Activity.class));
|
|
final ManageApplications.ApplicationsAdapter adapter =
|
|
new ManageApplications.ApplicationsAdapter(mState, fragment, 0);
|
|
|
|
adapter.updateDisableView(view, info);
|
|
|
|
verify(view).setText(R.string.disabled);
|
|
}
|
|
|
|
@Test
|
|
public void updateMenu_mainListType_showAppReset() {
|
|
setUpOptionMenus();
|
|
ReflectionHelpers.setField(mFragment, "mListType", ManageApplications.LIST_TYPE_MAIN);
|
|
ReflectionHelpers.setField(mFragment, "mOptionsMenu", mMenu);
|
|
|
|
mFragment.updateOptionsMenu();
|
|
assertThat(mMenu.findItem(R.id.reset_app_preferences).isVisible()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void updateMenu_batteryListType_hideAppReset() {
|
|
setUpOptionMenus();
|
|
ReflectionHelpers.setField(mFragment, "mListType", ManageApplications.LIST_TYPE_HIGH_POWER);
|
|
ReflectionHelpers.setField(mFragment, "mOptionsMenu", mMenu);
|
|
|
|
mFragment.updateOptionsMenu();
|
|
assertThat(mMenu.findItem(R.id.reset_app_preferences).isVisible()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void onCreateView_shouldNotShowLoadingContainer() {
|
|
final ManageApplications fragment = spy(new ManageApplications());
|
|
ReflectionHelpers.setField(fragment, "mResetAppsHelper",
|
|
mock(ResetAppsHelper.class));
|
|
doNothing().when(fragment).createHeader();
|
|
|
|
final LayoutInflater layoutInflater = mock(LayoutInflater.class);
|
|
final View view = mock(View.class);
|
|
final View loadingContainer = mock(View.class);
|
|
when(layoutInflater.inflate(anyInt(), eq(null))).thenReturn(view);
|
|
when(view.findViewById(R.id.loading_container)).thenReturn(loadingContainer);
|
|
|
|
fragment.onCreateView(layoutInflater, mock(ViewGroup.class), null);
|
|
|
|
verify(loadingContainer, never()).setVisibility(View.VISIBLE);
|
|
}
|
|
|
|
@Test
|
|
public void updateLoading_appLoaded_shouldNotDelayCallToHandleLoadingContainer() {
|
|
final ManageApplications fragment = mock(ManageApplications.class);
|
|
ReflectionHelpers.setField(fragment, "mLoadingContainer", mock(View.class));
|
|
ReflectionHelpers.setField(fragment, "mListContainer", mock(View.class));
|
|
when(fragment.getActivity()).thenReturn(mock(Activity.class));
|
|
final Runnable showLoadingContainerRunnable = mock(Runnable.class);
|
|
final Handler handler = mock(Handler.class);
|
|
final ManageApplications.ApplicationsAdapter adapter =
|
|
spy(new ManageApplications.ApplicationsAdapter(mState, fragment, 0));
|
|
ReflectionHelpers.setField(adapter, "mShowLoadingContainerRunnable",
|
|
showLoadingContainerRunnable);
|
|
ReflectionHelpers.setField(adapter, "mFgHandler", handler);
|
|
|
|
// app loading completed
|
|
ReflectionHelpers.setField(adapter, "mHasReceivedLoadEntries", true);
|
|
final ArrayList<ApplicationsState.AppEntry> appList = new ArrayList<>();
|
|
appList.add(mock(ApplicationsState.AppEntry.class));
|
|
when(mSession.getAllApps()).thenReturn(appList);
|
|
|
|
adapter.updateLoading();
|
|
|
|
verify(handler, never()).postDelayed(eq(showLoadingContainerRunnable), anyLong());
|
|
}
|
|
|
|
@Test
|
|
public void updateLoading_appNotLoaded_shouldDelayCallToHandleLoadingContainer() {
|
|
final ManageApplications fragment = mock(ManageApplications.class);
|
|
ReflectionHelpers.setField(fragment, "mLoadingContainer", mock(View.class));
|
|
ReflectionHelpers.setField(fragment, "mListContainer", mock(View.class));
|
|
when(fragment.getActivity()).thenReturn(mock(Activity.class));
|
|
final Runnable showLoadingContainerRunnable = mock(Runnable.class);
|
|
final Handler handler = mock(Handler.class);
|
|
final ManageApplications.ApplicationsAdapter adapter =
|
|
spy(new ManageApplications.ApplicationsAdapter(mState, fragment, 0));
|
|
ReflectionHelpers.setField(adapter, "mShowLoadingContainerRunnable",
|
|
showLoadingContainerRunnable);
|
|
ReflectionHelpers.setField(adapter, "mFgHandler", handler);
|
|
|
|
// app loading not yet completed
|
|
ReflectionHelpers.setField(adapter, "mHasReceivedLoadEntries", false);
|
|
|
|
adapter.updateLoading();
|
|
|
|
verify(handler).postDelayed(eq(showLoadingContainerRunnable), anyLong());
|
|
}
|
|
|
|
@Test
|
|
public void onRebuildComplete_shouldCancelDelayedRunnable() {
|
|
final Context context = RuntimeEnvironment.application;
|
|
final ManageApplications fragment = mock(ManageApplications.class);
|
|
final View loadingContainer = mock(View.class);
|
|
when(loadingContainer.getContext()).thenReturn(context);
|
|
final View listContainer = mock(View.class);
|
|
when(listContainer.getVisibility()).thenReturn(View.INVISIBLE);
|
|
when(listContainer.getContext()).thenReturn(context);
|
|
ReflectionHelpers.setField(fragment, "mLoadingContainer", loadingContainer);
|
|
ReflectionHelpers.setField(fragment, "mListContainer", listContainer);
|
|
when(fragment.getActivity()).thenReturn(mock(Activity.class));
|
|
final Runnable showLoadingContainerRunnable = mock(Runnable.class);
|
|
final Handler handler = mock(Handler.class);
|
|
final ManageApplications.ApplicationsAdapter adapter =
|
|
spy(new ManageApplications.ApplicationsAdapter(mState, fragment, 0));
|
|
ReflectionHelpers.setField(adapter, "mShowLoadingContainerRunnable",
|
|
showLoadingContainerRunnable);
|
|
ReflectionHelpers.setField(adapter, "mFgHandler", handler);
|
|
ReflectionHelpers.setField(adapter, "mFilterMode", -1);
|
|
|
|
// app loading not yet completed
|
|
ReflectionHelpers.setField(adapter, "mHasReceivedLoadEntries", false);
|
|
adapter.updateLoading();
|
|
|
|
// app loading completed
|
|
ReflectionHelpers.setField(adapter, "mHasReceivedLoadEntries", true);
|
|
final ArrayList<ApplicationsState.AppEntry> appList = new ArrayList<>();
|
|
appList.add(mock(ApplicationsState.AppEntry.class));
|
|
when(mSession.getAllApps()).thenReturn(appList);
|
|
|
|
adapter.onRebuildComplete(null);
|
|
|
|
verify(handler).removeCallbacks(showLoadingContainerRunnable);
|
|
}
|
|
|
|
private void setUpOptionMenus() {
|
|
when(mMenu.findItem(anyInt())).thenAnswer(invocation -> {
|
|
final Object[] args = invocation.getArguments();
|
|
final int id = (int) args[0];
|
|
if (id == mAppReset.getItemId()) {
|
|
return mAppReset;
|
|
}
|
|
return new RoboMenuItem(id);
|
|
});
|
|
}
|
|
}
|