This reverts commit 457c3cbec2
.
Revert with fix/test.
The fix is that we removed DevicePickerFragment#initDevicePreference(),
which incorrectly set a useless widget on preference, and removes the
gear icon from preference, preventing bind() call to go through
Change-Id: Ia70cdb51d13cca6035a4e7fe8008d195f7f00c6e
Fix: 36511169
Test: runtest --path tests/app/src/com/android/settings/bluetooth/DevicePickerActivityTest.java
140 lines
5.2 KiB
Java
140 lines
5.2 KiB
Java
/*
|
|
* Copyright (C) 2017 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
package com.android.settings.bluetooth;
|
|
|
|
import android.bluetooth.BluetoothDevice;
|
|
import android.content.Context;
|
|
import android.os.UserManager;
|
|
|
|
import com.android.internal.logging.nano.MetricsProto.MetricsEvent;
|
|
import com.android.settings.R;
|
|
import com.android.settings.SettingsRobolectricTestRunner;
|
|
import com.android.settings.TestConfig;
|
|
import com.android.settings.core.instrumentation.MetricsFeatureProvider;
|
|
import com.android.settings.testutils.FakeFeatureFactory;
|
|
import com.android.settingslib.bluetooth.CachedBluetoothDevice;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Mock;
|
|
import org.mockito.MockitoAnnotations;
|
|
import org.robolectric.RuntimeEnvironment;
|
|
import org.robolectric.annotation.Config;
|
|
import org.robolectric.util.ReflectionHelpers;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static org.mockito.Mockito.mock;
|
|
import static org.mockito.Mockito.spy;
|
|
import static org.mockito.Mockito.verify;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
@RunWith(SettingsRobolectricTestRunner.class)
|
|
@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION)
|
|
public class BluetoothDevicePreferenceTest {
|
|
|
|
private Context mContext;
|
|
@Mock
|
|
private CachedBluetoothDevice mCachedBluetoothDevice;
|
|
|
|
private FakeFeatureFactory mFakeFeatureFactory;
|
|
private MetricsFeatureProvider mMetricsFeatureProvider;
|
|
private BluetoothDevicePreference mPreference;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
MockitoAnnotations.initMocks(this);
|
|
mContext = spy(RuntimeEnvironment.application.getApplicationContext());
|
|
FakeFeatureFactory.setupForTest(mContext);
|
|
mFakeFeatureFactory = (FakeFeatureFactory) FakeFeatureFactory.getFactory(mContext);
|
|
mMetricsFeatureProvider = mFakeFeatureFactory.getMetricsFeatureProvider();
|
|
mPreference = new BluetoothDevicePreference(mContext, mCachedBluetoothDevice);
|
|
}
|
|
|
|
@Test
|
|
public void onClicked_deviceConnected_shouldLogBluetoothDisconnectEvent() {
|
|
when(mCachedBluetoothDevice.isConnected()).thenReturn(true);
|
|
|
|
mPreference.onClicked();
|
|
|
|
verify(mMetricsFeatureProvider).action(
|
|
mContext, MetricsEvent.ACTION_SETTINGS_BLUETOOTH_DISCONNECT);
|
|
}
|
|
|
|
@Test
|
|
public void onClicked_deviceBonded_shouldLogBluetoothConnectEvent() {
|
|
when(mCachedBluetoothDevice.isConnected()).thenReturn(false);
|
|
when(mCachedBluetoothDevice.getBondState()).thenReturn(BluetoothDevice.BOND_BONDED);
|
|
|
|
mPreference.onClicked();
|
|
|
|
verify(mMetricsFeatureProvider).action(
|
|
mContext, MetricsEvent.ACTION_SETTINGS_BLUETOOTH_CONNECT);
|
|
}
|
|
|
|
@Test
|
|
public void onClicked_deviceNotBonded_shouldLogBluetoothPairEvent() {
|
|
when(mCachedBluetoothDevice.isConnected()).thenReturn(false);
|
|
when(mCachedBluetoothDevice.getBondState()).thenReturn(BluetoothDevice.BOND_NONE);
|
|
when(mCachedBluetoothDevice.startPairing()).thenReturn(true);
|
|
|
|
mPreference.onClicked();
|
|
|
|
verify(mMetricsFeatureProvider).action(
|
|
mContext, MetricsEvent.ACTION_SETTINGS_BLUETOOTH_PAIR);
|
|
}
|
|
|
|
@Test
|
|
public void getSecondTargetResource_shouldBeGearIconLayout() {
|
|
assertThat(mPreference.getSecondTargetResId()).isEqualTo(R.layout.preference_widget_gear);
|
|
}
|
|
|
|
@Test
|
|
public void shouldHideSecondTarget_noDevice_shouldReturnTrue() {
|
|
ReflectionHelpers.setField(mPreference, "mCachedDevice", null);
|
|
|
|
assertThat(mPreference.shouldHideSecondTarget()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void shouldHideSecondTarget_notBond_shouldReturnTrue() {
|
|
when(mCachedBluetoothDevice.getBondState()).thenReturn(BluetoothDevice.BOND_NONE);
|
|
|
|
assertThat(mPreference.shouldHideSecondTarget()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void shouldHideSecondTarget_hasUserRestriction_shouldReturnTrue() {
|
|
final UserManager um = mock(UserManager.class);
|
|
ReflectionHelpers.setField(mPreference, "mUserManager", um);
|
|
when(um.hasUserRestriction(UserManager.DISALLOW_CONFIG_BLUETOOTH))
|
|
.thenReturn(true);
|
|
|
|
assertThat(mPreference.shouldHideSecondTarget()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void shouldHideSecondTarget_hasBoundDeviceAndNoRestriction_shouldReturnFalse() {
|
|
when(mCachedBluetoothDevice.getBondState()).thenReturn(BluetoothDevice.BOND_BONDED);
|
|
final UserManager um = mock(UserManager.class);
|
|
ReflectionHelpers.setField(mPreference, "mUserManager", um);
|
|
when(um.hasUserRestriction(UserManager.DISALLOW_CONFIG_BLUETOOTH))
|
|
.thenReturn(false);
|
|
|
|
assertThat(mPreference.shouldHideSecondTarget()).isFalse();
|
|
}
|
|
}
|