We were getting the following exception when you rotated the Bluetooth device details screen: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.android.settings/com.android.settings.SubSettings}: java.lang.IllegalStateException: This Activity already has an action bar supplied by the window decor. Do not request Window.FEATURE_ACTION_BAR and set android:windowActionBar to false in your theme to use a Toolbar instead. It turns out that allowing EntityHeaderController to inflate the settings_entity_header.xml view seems to cause this - if you instead manually include a LayoutPreference and hand that to EntityHeaderController, you don't have the problem. The rotation failure couldn't be tested with Robolectric because our version doesn't support using FragmentTestUtil.startFragment for fragments which use PreferenceScreen's ("sorry, not yet implemented"). So instead this includes an app test. Bug: 62447414 Test: runtest --path=BluetoothDeviceDetailsRotationTest.java Change-Id: I8d052d1f4ab6e2b0ca5c0e513ec366bdcc382d99
156 lines
5.6 KiB
Java
156 lines
5.6 KiB
Java
/*
|
|
* Copyright (C) 2017 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.bluetooth;
|
|
|
|
import static android.os.UserManager.DISALLOW_CONFIG_BLUETOOTH;
|
|
|
|
import android.bluetooth.BluetoothDevice;
|
|
import android.content.Context;
|
|
import android.os.Bundle;
|
|
import android.support.annotation.VisibleForTesting;
|
|
import android.view.Menu;
|
|
import android.view.MenuInflater;
|
|
import android.view.MenuItem;
|
|
|
|
import com.android.internal.logging.nano.MetricsProto;
|
|
import com.android.settings.R;
|
|
import com.android.settings.core.PreferenceController;
|
|
import com.android.settings.dashboard.RestrictedDashboardFragment;
|
|
import com.android.settingslib.bluetooth.CachedBluetoothDevice;
|
|
import com.android.settingslib.bluetooth.LocalBluetoothManager;
|
|
import com.android.settingslib.core.lifecycle.Lifecycle;
|
|
|
|
import java.util.ArrayList;
|
|
import java.util.List;
|
|
|
|
public class BluetoothDeviceDetailsFragment extends RestrictedDashboardFragment {
|
|
public static final String KEY_DEVICE_ADDRESS = "device_address";
|
|
private static final String TAG = "BTDeviceDetailsFrg";
|
|
|
|
@VisibleForTesting
|
|
static int EDIT_DEVICE_NAME_ITEM_ID = Menu.FIRST;
|
|
|
|
/**
|
|
* An interface to let tests override the normal mechanism for looking up the
|
|
* CachedBluetoothDevice and LocalBluetoothManager, and substitute their own mocks instead.
|
|
* This is only needed in situations where you instantiate the fragment indirectly (eg via an
|
|
* intent) and can't use something like spying on an instance you construct directly via
|
|
* newInstance.
|
|
*/
|
|
@VisibleForTesting
|
|
interface TestDataFactory {
|
|
CachedBluetoothDevice getDevice(String deviceAddress);
|
|
LocalBluetoothManager getManager(Context context);
|
|
}
|
|
|
|
@VisibleForTesting
|
|
static TestDataFactory sTestDataFactory;
|
|
|
|
private String mDeviceAddress;
|
|
private LocalBluetoothManager mManager;
|
|
private CachedBluetoothDevice mCachedDevice;
|
|
|
|
public BluetoothDeviceDetailsFragment() {
|
|
super(DISALLOW_CONFIG_BLUETOOTH);
|
|
}
|
|
|
|
@VisibleForTesting
|
|
LocalBluetoothManager getLocalBluetoothManager(Context context) {
|
|
if (sTestDataFactory != null) {
|
|
return sTestDataFactory.getManager(context);
|
|
}
|
|
return Utils.getLocalBtManager(context);
|
|
}
|
|
|
|
@VisibleForTesting
|
|
CachedBluetoothDevice getCachedDevice(String deviceAddress) {
|
|
if (sTestDataFactory != null) {
|
|
return sTestDataFactory.getDevice(deviceAddress);
|
|
}
|
|
BluetoothDevice remoteDevice =
|
|
mManager.getBluetoothAdapter().getRemoteDevice(deviceAddress);
|
|
return mManager.getCachedDeviceManager().findDevice(remoteDevice);
|
|
}
|
|
|
|
public static BluetoothDeviceDetailsFragment newInstance(String deviceAddress) {
|
|
Bundle args = new Bundle(1);
|
|
args.putString(KEY_DEVICE_ADDRESS, deviceAddress);
|
|
BluetoothDeviceDetailsFragment fragment = new BluetoothDeviceDetailsFragment();
|
|
fragment.setArguments(args);
|
|
return fragment;
|
|
}
|
|
|
|
@Override
|
|
public void onAttach(Context context) {
|
|
mDeviceAddress = getArguments().getString(KEY_DEVICE_ADDRESS);
|
|
mManager = getLocalBluetoothManager(context);
|
|
mCachedDevice = getCachedDevice(mDeviceAddress);
|
|
super.onAttach(context);
|
|
}
|
|
|
|
@Override
|
|
public int getMetricsCategory() {
|
|
return MetricsProto.MetricsEvent.BLUETOOTH_DEVICE_DETAILS;
|
|
}
|
|
|
|
@Override
|
|
protected String getLogTag() {
|
|
return TAG;
|
|
}
|
|
|
|
@Override
|
|
protected int getPreferenceScreenResId() {
|
|
return R.xml.bluetooth_device_details_fragment;
|
|
}
|
|
|
|
@Override
|
|
public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
|
|
MenuItem item = menu.add(0, EDIT_DEVICE_NAME_ITEM_ID, 0, R.string.bluetooth_rename_button);
|
|
item.setIcon(R.drawable.ic_mode_edit);
|
|
item.setShowAsAction(MenuItem.SHOW_AS_ACTION_ALWAYS);
|
|
super.onCreateOptionsMenu(menu, inflater);
|
|
}
|
|
|
|
@Override
|
|
public boolean onOptionsItemSelected(MenuItem menuItem) {
|
|
if (menuItem.getItemId() == EDIT_DEVICE_NAME_ITEM_ID) {
|
|
RemoteDeviceNameDialogFragment.newInstance(mCachedDevice).show(
|
|
getFragmentManager(), RemoteDeviceNameDialogFragment.TAG);
|
|
return true;
|
|
}
|
|
return super.onOptionsItemSelected(menuItem);
|
|
}
|
|
|
|
@Override
|
|
protected List<PreferenceController> getPreferenceControllers(Context context) {
|
|
ArrayList<PreferenceController> controllers = new ArrayList<>();
|
|
|
|
if (mCachedDevice != null) {
|
|
Lifecycle lifecycle = getLifecycle();
|
|
controllers.add(new BluetoothDetailsHeaderController(context, this, mCachedDevice,
|
|
lifecycle));
|
|
controllers.add(new BluetoothDetailsButtonsController(context, this, mCachedDevice,
|
|
lifecycle));
|
|
controllers.add(new BluetoothDetailsProfilesController(context, this, mManager,
|
|
mCachedDevice, lifecycle));
|
|
controllers.add(new BluetoothDetailsMacAddressController(context, this, mCachedDevice,
|
|
lifecycle));
|
|
}
|
|
return controllers;
|
|
}
|
|
}
|