356fb2d10d
The privilege for an app to write to the system settings is protected by an app-op signature permission. App-op permissions are special: if the app-op is deny/allow we deny/allow write access; if the app-op is default holding the permission determies write access. The settings code assumes that CHANGE_NETWORK_STATE is an app op permission (system|appop) while it is a normal permission which any app gets by declaring it used in the manifest. The side effect is that the state of the toggle in the UI for write system settings will initially be in the wrong state if the app uses both WRITE_SETTINGS and CHANGE_NETWORK_STATE. However, the code in the public API an app uses to check write settings access would return the opposite since it checks the WRITE_SETTINGS permission and its app op. Hence, if an app requires write settings to start the user will see in the settings UI it has access but the app will not have access, so the app would prompt the user to allow write settings. The non-obvious fix is for the user to toggle the setting off and on to get the app op in the right state and be able to launch the app. bug:25843134 Change-Id: I3d726a66c7f9857bc7dbd5946fdbb8f340c6eb4d
87 lines
3.3 KiB
Java
87 lines
3.3 KiB
Java
/*
|
|
* Copyright (C) 2015 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
package com.android.settings.applications;
|
|
|
|
import android.Manifest;
|
|
import android.app.AppOpsManager;
|
|
import android.content.Context;
|
|
|
|
import com.android.settingslib.applications.ApplicationsState;
|
|
import com.android.settingslib.applications.ApplicationsState.AppEntry;
|
|
import com.android.settingslib.applications.ApplicationsState.AppFilter;
|
|
|
|
/*
|
|
* Connects info of apps that draw overlay to the ApplicationsState. Wraps around the generic
|
|
* AppStateAppOpsBridge class to tailor to the semantics of SYSTEM_ALERT_WINDOW. Also provides app
|
|
* filters that can use the info.
|
|
*/
|
|
public class AppStateWriteSettingsBridge extends AppStateAppOpsBridge {
|
|
|
|
private static final String TAG = "AppStateWriteSettingsBridge";
|
|
private static final int APP_OPS_OP_CODE = AppOpsManager.OP_WRITE_SETTINGS;
|
|
private static final String PM_WRITE_SETTINGS = Manifest.permission.WRITE_SETTINGS;
|
|
|
|
private static final String[] PM_PERMISSIONS = {
|
|
PM_WRITE_SETTINGS
|
|
};
|
|
|
|
public AppStateWriteSettingsBridge(Context context, ApplicationsState appState, Callback
|
|
callback) {
|
|
super(context, appState, callback, APP_OPS_OP_CODE, PM_PERMISSIONS);
|
|
}
|
|
|
|
@Override
|
|
protected void updateExtraInfo(AppEntry app, String pkg, int uid) {
|
|
app.extraInfo = getWriteSettingsInfo(pkg, uid);
|
|
}
|
|
|
|
public WriteSettingsState getWriteSettingsInfo(String pkg, int uid) {
|
|
PermissionState permissionState = super.getPermissionInfo(pkg, uid);
|
|
return new WriteSettingsState(permissionState);
|
|
}
|
|
|
|
// TODO: figure out how to filter out system apps for this method
|
|
public int getNumberOfPackagesWithPermission() {
|
|
return super.getNumPackagesDeclaredPermission();
|
|
}
|
|
|
|
// TODO: figure out how to filter out system apps for this method
|
|
public int getNumberOfPackagesCanWriteSettings() {
|
|
return super.getNumPackagesAllowedByAppOps();
|
|
}
|
|
|
|
public static class WriteSettingsState extends AppStateAppOpsBridge.PermissionState {
|
|
public WriteSettingsState(PermissionState permissionState) {
|
|
super(permissionState.packageName, permissionState.userHandle);
|
|
this.packageInfo = permissionState.packageInfo;
|
|
this.appOpMode = permissionState.appOpMode;
|
|
this.permissionDeclared = permissionState.permissionDeclared;
|
|
this.staticPermissionGranted = permissionState.staticPermissionGranted;
|
|
}
|
|
}
|
|
|
|
public static final AppFilter FILTER_WRITE_SETTINGS = new AppFilter() {
|
|
@Override
|
|
public void init() {
|
|
}
|
|
|
|
@Override
|
|
public boolean filterApp(AppEntry info) {
|
|
return info.extraInfo != null;
|
|
}
|
|
};
|
|
}
|