2b0dbf7d24
* The first option in Bluetooth max connected audio devices preference
should be using system default
* Added template based string array to show system default in the list
preference and in preference summary when default is chosen
* Reset max connected audio devices property to empty string when
development setting is disabled or when system default is chosen
* Added instrumentation test to check preference array size and whether
default value is within range of preference array values
* Modified robolectric tests to verify the updated behaviors
Bug: 64767509
Test: Enable and disable multi-device mode in development settings
make -j32 RunSettingsRoboTests
atest SettingsUnitTests:BluetoothMaxConnectedAudioDevicesPreferenceControllerInstrumentationTest
Change-Id: I4915f12df0ac0e6f715e44e0df4a3707dde8d1a4
108 lines
4.1 KiB
Java
108 lines
4.1 KiB
Java
/*
|
|
* Copyright (C) 2018 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.development;
|
|
|
|
import android.content.Context;
|
|
import android.os.SystemProperties;
|
|
import android.support.annotation.VisibleForTesting;
|
|
import android.support.v7.preference.ListPreference;
|
|
import android.support.v7.preference.Preference;
|
|
import android.support.v7.preference.PreferenceScreen;
|
|
|
|
import com.android.settings.core.PreferenceControllerMixin;
|
|
import com.android.settingslib.development.DeveloperOptionsPreferenceController;
|
|
|
|
public class BluetoothMaxConnectedAudioDevicesPreferenceController extends
|
|
DeveloperOptionsPreferenceController implements Preference.OnPreferenceChangeListener,
|
|
PreferenceControllerMixin {
|
|
|
|
private static final String MAX_CONNECTED_AUDIO_DEVICES_PREFERENCE_KEY =
|
|
"bluetooth_max_connected_audio_devices";
|
|
|
|
@VisibleForTesting
|
|
static final String MAX_CONNECTED_AUDIO_DEVICES_PROPERTY =
|
|
"persist.bluetooth.maxconnectedaudiodevices";
|
|
|
|
private final int mDefaultMaxConnectedAudioDevices;
|
|
private ListPreference mPreference;
|
|
|
|
public BluetoothMaxConnectedAudioDevicesPreferenceController(Context context) {
|
|
super(context);
|
|
mDefaultMaxConnectedAudioDevices = mContext.getResources().getInteger(
|
|
com.android.internal.R.integer.config_bluetooth_max_connected_audio_devices);
|
|
}
|
|
|
|
@Override
|
|
public String getPreferenceKey() {
|
|
return MAX_CONNECTED_AUDIO_DEVICES_PREFERENCE_KEY;
|
|
}
|
|
|
|
@Override
|
|
public void displayPreference(PreferenceScreen screen) {
|
|
super.displayPreference(screen);
|
|
mPreference = (ListPreference) screen.findPreference(getPreferenceKey());
|
|
final CharSequence[] entries = mPreference.getEntries();
|
|
entries[0] = String.format(entries[0].toString(), mDefaultMaxConnectedAudioDevices);
|
|
mPreference.setEntries(entries);
|
|
}
|
|
|
|
@Override
|
|
public boolean onPreferenceChange(Preference preference, Object newValue) {
|
|
String newValueString = newValue.toString();
|
|
final ListPreference listPreference = (ListPreference) preference;
|
|
if (listPreference.findIndexOfValue(newValueString) <= 0) {
|
|
// Reset property value when default is chosen or when value is illegal
|
|
newValueString = "";
|
|
}
|
|
SystemProperties.set(MAX_CONNECTED_AUDIO_DEVICES_PROPERTY, newValueString);
|
|
updateState(preference);
|
|
return true;
|
|
}
|
|
|
|
@Override
|
|
public void updateState(Preference preference) {
|
|
final ListPreference listPreference = (ListPreference) preference;
|
|
final CharSequence[] entries = listPreference.getEntries();
|
|
final String currentValue = SystemProperties.get(MAX_CONNECTED_AUDIO_DEVICES_PROPERTY);
|
|
int index = 0;
|
|
if (!currentValue.isEmpty()) {
|
|
index = listPreference.findIndexOfValue(currentValue);
|
|
if (index < 0) {
|
|
// Reset property value when value is illegal
|
|
SystemProperties.set(MAX_CONNECTED_AUDIO_DEVICES_PROPERTY, "");
|
|
index = 0;
|
|
}
|
|
}
|
|
listPreference.setValueIndex(index);
|
|
listPreference.setSummary(entries[index]);
|
|
}
|
|
|
|
@Override
|
|
protected void onDeveloperOptionsSwitchEnabled() {
|
|
mPreference.setEnabled(true);
|
|
updateState(mPreference);
|
|
}
|
|
|
|
@Override
|
|
protected void onDeveloperOptionsSwitchDisabled() {
|
|
mPreference.setEnabled(false);
|
|
SystemProperties.set(MAX_CONNECTED_AUDIO_DEVICES_PROPERTY, "");
|
|
updateState(mPreference);
|
|
}
|
|
}
|
|
|