9e50419c75
The NFC Slice would jank on enable and disable, because of the
intent filter it registered with SysUI. The intent filter would
broadcast an update for four states:
1) On
2) Off
3) Turning On
4) Turning off
The first two caused no problems. The third and fourth caused jank,
since when clicked, the switch in the NFC slice would turn on / off
asynchronously - that is, it turned on or off based on the previous
state of the switch, rather than on the actual value of NFC. It does
this to feel fluid in the app in which it is rendered.
From the off state, the order of events is:
1. Switch clicked
2. Switch animates on
2. Background intent is fired to settings to turn on Nfc (happens at
the same time as animation)
3. Settings calls the NFC enable API
4. A broadcast for Turning On is sent
5. The receiver in SysUI gets the broadcast and forwards it to settings
6. Settings tells the Slice to make sure it is up to date
7. The Slice checks for the current value - IMPORTANTLY - which is
currently off, it is only in the process of being enabled.
8. The Slice flips back off
9. Nfc finishes getting enabled in the background
10. The framework pushes the NFC ON broadcast
11. SysUI gets the broadcast, and forwards it to settings
12. Settings tells the slice to update
13. The slice checks again and finds that NFC is on, flipping on.
This CL creates a new background slice worker for NFC and registers
the intent filter there, rather than in SysUI. When the background
worker gets the broadcast, it checks if it is in state 3/4, and if so,
it drops the update silently.
Fixes: 115737701
Test: robotests
Change-Id: I17043828ad3a67a2a5acdf5c75d9cc51ff7e91d0
110 lines
2.9 KiB
Java
110 lines
2.9 KiB
Java
/*
|
|
* Copyright (C) 2018 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*
|
|
*/
|
|
|
|
package com.android.settings.testutils;
|
|
|
|
import android.content.Context;
|
|
import android.content.IntentFilter;
|
|
import android.net.Uri;
|
|
import android.net.wifi.WifiManager;
|
|
import android.provider.Settings;
|
|
|
|
import com.android.settings.core.TogglePreferenceController;
|
|
import com.android.settings.slices.SliceBackgroundWorker;
|
|
|
|
import java.io.IOException;
|
|
|
|
public class FakeToggleController extends TogglePreferenceController {
|
|
|
|
public static final String AVAILABILITY_KEY = "fake_toggle_availability_key";
|
|
|
|
public static final IntentFilter INTENT_FILTER = new IntentFilter(
|
|
WifiManager.WIFI_AP_STATE_CHANGED_ACTION);
|
|
|
|
private static final String SETTING_KEY = "toggle_key";
|
|
|
|
private static final int ON = 1;
|
|
private static final int OFF = 0;
|
|
|
|
private boolean mIsAsyncUpdate = false;
|
|
|
|
public FakeToggleController(Context context, String preferenceKey) {
|
|
super(context, preferenceKey);
|
|
}
|
|
|
|
@Override
|
|
public boolean isChecked() {
|
|
return Settings.System.getInt(mContext.getContentResolver(),
|
|
SETTING_KEY, OFF) == ON;
|
|
}
|
|
|
|
@Override
|
|
public boolean setChecked(boolean isChecked) {
|
|
return Settings.System.putInt(mContext.getContentResolver(), SETTING_KEY,
|
|
isChecked ? ON : OFF);
|
|
}
|
|
|
|
@Override
|
|
public int getAvailabilityStatus() {
|
|
return Settings.Global.getInt(mContext.getContentResolver(),
|
|
AVAILABILITY_KEY, AVAILABLE);
|
|
}
|
|
|
|
@Override
|
|
public IntentFilter getIntentFilter() {
|
|
return INTENT_FILTER;
|
|
}
|
|
|
|
@Override
|
|
public boolean isSliceable() {
|
|
return true;
|
|
}
|
|
|
|
@Override
|
|
public Class<? extends SliceBackgroundWorker> getBackgroundWorkerClass() {
|
|
return TestWorker.class;
|
|
}
|
|
|
|
@Override
|
|
public boolean hasAsyncUpdate() {
|
|
return mIsAsyncUpdate;
|
|
}
|
|
|
|
public void setAsyncUpdate(boolean isAsyncUpdate) {
|
|
mIsAsyncUpdate = isAsyncUpdate;
|
|
}
|
|
|
|
public static class TestWorker extends SliceBackgroundWorker<Void> {
|
|
|
|
public TestWorker(Context context, Uri uri) {
|
|
super(context, uri);
|
|
}
|
|
|
|
@Override
|
|
protected void onSlicePinned() {
|
|
}
|
|
|
|
@Override
|
|
protected void onSliceUnpinned() {
|
|
}
|
|
|
|
@Override
|
|
public void close() throws IOException {
|
|
}
|
|
}
|
|
}
|