Context#getResources loading is done based on the last SIM to come up, we may get wrong customization settings. This fix check the setting of active subscription and shows the preference. Bug: 138956509 Test: CellularFallbackPreferenceControllerTest manual test: 1. Insert feature supported SIM and check UI. 2. Remove feature supported SIM and check UI. 3. Turn airplane mode on and check 1. and 2.. Change-Id: I72b6db415429181395a02f163889bb1b9c0f070f Merged-In: I72b6db415429181395a02f163889bb1b9c0f070f
88 lines
3.1 KiB
Java
88 lines
3.1 KiB
Java
/*
|
|
* Copyright (C) 2017 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.wifi;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import static org.mockito.ArgumentMatchers.anyInt;
|
|
import static org.mockito.Mockito.doReturn;
|
|
import static org.mockito.Mockito.mock;
|
|
import static org.mockito.Mockito.spy;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
import android.content.Context;
|
|
import android.content.res.Resources;
|
|
import android.telephony.SubscriptionManager;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Mock;
|
|
import org.mockito.MockitoAnnotations;
|
|
import org.robolectric.RobolectricTestRunner;
|
|
import org.robolectric.RuntimeEnvironment;
|
|
|
|
@RunWith(RobolectricTestRunner.class)
|
|
public class CellularFallbackPreferenceControllerTest {
|
|
private static final String KEY_CELLULAR_FALLBACK = "wifi_cellular_data_fallback";
|
|
|
|
private CellularFallbackPreferenceController mController;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
MockitoAnnotations.initMocks(this);
|
|
|
|
mController = spy(new CellularFallbackPreferenceController(RuntimeEnvironment.application,
|
|
KEY_CELLULAR_FALLBACK));
|
|
}
|
|
|
|
@Test
|
|
public void isAvailable_invalidActiveSubscriptionId_shouldReturnFalse() {
|
|
doReturn(SubscriptionManager.INVALID_SUBSCRIPTION_ID)
|
|
.when(mController).getActiveDataSubscriptionId();
|
|
|
|
assertThat(mController.isAvailable()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void isAvailable_avoidBadWifiConfigIsFalse_shouldReturnTrue() {
|
|
final Resources resources = mock(Resources.class);
|
|
|
|
doReturn(SubscriptionManager.DEFAULT_SUBSCRIPTION_ID)
|
|
.when(mController).getActiveDataSubscriptionId();
|
|
doReturn(resources).when(mController).getResourcesForSubId(anyInt());
|
|
when(resources.getInteger(
|
|
com.android.internal.R.integer.config_networkAvoidBadWifi))
|
|
.thenReturn(0);
|
|
|
|
assertThat(mController.isAvailable()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void isAvailable_avoidBadWifiConfigIsTrue_shouldReturnFalse() {
|
|
final Resources resources = mock(Resources.class);
|
|
|
|
doReturn(SubscriptionManager.DEFAULT_SUBSCRIPTION_ID)
|
|
.when(mController).getActiveDataSubscriptionId();
|
|
doReturn(resources).when(mController).getResourcesForSubId(anyInt());
|
|
when(resources.getInteger(
|
|
com.android.internal.R.integer.config_networkAvoidBadWifi))
|
|
.thenReturn(1);
|
|
|
|
assertThat(mController.isAvailable()).isFalse();
|
|
}
|
|
} |