7d2b4f5fc7
Add the ability to define a Preference Controller in xml using the 'controller' tag. This is useful for two reasons: - It allows the controllers to be instantiated via reflection for Slices and Dashboard fragment - Removes the requirement that controllers be defined manually in Fragments In order to be instantiable, they must have a unified construction following either: ClassName(Context) ClassName(Context, String) Also added a robotest that verifies that all controllers defined in XML follow the constructor schema, and extend BasePreferenceController. Test: robotests Bug: 67996923 Change-Id: I304b35dc666daebecf0c9e286696f3f2a510704a
119 lines
3.9 KiB
Java
119 lines
3.9 KiB
Java
/*
|
|
* Copyright (C) 2016 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
package com.android.settings.deviceinfo;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static org.mockito.Answers.RETURNS_DEEP_STUBS;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
import android.content.Context;
|
|
import android.os.Build;
|
|
import android.os.UserManager;
|
|
import android.support.v7.preference.Preference;
|
|
import android.support.v7.preference.PreferenceScreen;
|
|
|
|
import com.android.settings.R;
|
|
import com.android.settings.TestConfig;
|
|
import com.android.settings.testutils.SettingsRobolectricTestRunner;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Mock;
|
|
import org.mockito.MockitoAnnotations;
|
|
import org.robolectric.RuntimeEnvironment;
|
|
import org.robolectric.annotation.Config;
|
|
|
|
import java.util.ArrayList;
|
|
import java.util.List;
|
|
|
|
@RunWith(SettingsRobolectricTestRunner.class)
|
|
@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION)
|
|
public class SystemUpdatePreferenceControllerTest {
|
|
|
|
@Mock(answer = RETURNS_DEEP_STUBS)
|
|
private Context mContext;
|
|
@Mock
|
|
private UserManager mUserManager;
|
|
@Mock
|
|
private PreferenceScreen mScreen;
|
|
|
|
private SystemUpdatePreferenceController mController;
|
|
private Preference mPreference;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
MockitoAnnotations.initMocks(this);
|
|
|
|
when(mContext.getSystemService(Context.USER_SERVICE)).thenReturn(mUserManager);
|
|
mController = new SystemUpdatePreferenceController(mContext);
|
|
mPreference = new Preference(RuntimeEnvironment.application);
|
|
mPreference.setKey(mController.getPreferenceKey());
|
|
when(mScreen.findPreference(mController.getPreferenceKey())).thenReturn(mPreference);
|
|
}
|
|
|
|
@Test
|
|
public void updateNonIndexable_bothAvailable_shouldNotUpdate() {
|
|
final List<String> keys = new ArrayList<>();
|
|
when(mUserManager.isAdminUser()).thenReturn(true);
|
|
when(mContext.getResources().getBoolean(
|
|
R.bool.config_additional_system_update_setting_enable))
|
|
.thenReturn(true);
|
|
|
|
mController.updateNonIndexableKeys(keys);
|
|
|
|
assertThat(keys).isEmpty();
|
|
}
|
|
|
|
@Test
|
|
public void updateNonIndexable_nothingAvailable_shouldUpdateWith2Prefs() {
|
|
final List<String> keys = new ArrayList<>();
|
|
|
|
mController.updateNonIndexableKeys(keys);
|
|
|
|
assertThat(keys).hasSize(1);
|
|
}
|
|
|
|
@Test
|
|
public void displayPrefs_nothingAvailable_shouldNotDisplay() {
|
|
mController.displayPreference(mScreen);
|
|
|
|
assertThat(mPreference.isVisible()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void updateState_shouldSetToAndroidVersion() {
|
|
mController = new SystemUpdatePreferenceController(RuntimeEnvironment.application);
|
|
|
|
mController.updateState(mPreference);
|
|
|
|
assertThat(mPreference.getSummary())
|
|
.isEqualTo(RuntimeEnvironment.application.getString(R.string.about_summary,
|
|
Build.VERSION.RELEASE));
|
|
}
|
|
|
|
@Test
|
|
public void displayPrefs_oneAvailable_shouldDisplayOne() {
|
|
when(mContext.getResources().getBoolean(
|
|
R.bool.config_additional_system_update_setting_enable))
|
|
.thenReturn(true);
|
|
|
|
mController.displayPreference(mScreen);
|
|
|
|
assertThat(mPreference.isVisible()).isFalse();
|
|
}
|
|
}
|