Files
app_Settings/tests/robotests/src/com/android/settings/wifi/AppStateChangeWifiStateBridgeTest.java
xshu 0aabe7f3a8 Hide apps with NETWORK_SETTINGS from special wifi settings
A recent change is made in the wifi framework to allow apps with
NETWORK_SETTINGS permission to bypass checks for the CHANGE_WIFI_STATE
permission. Remove apps with NETWORK_SETTINGS permission from
the list because turning off CHANGE_WIFI_STATE for those apps will not
do anything.

Bug: 78228349
Test: compile, robo test
Manual test:
flash
go to Settings -> Apps & notifications -> Advanced -> Special app access
-> Wi-Fi control
Verify that the "Settings" app is no longer in the list
Top right corner -> show system
Verify that "System UI" is no longer in the list
Change-Id: Ia430a6fb4d5dee534a03609ad1877976204935b2
2018-04-25 16:13:12 -07:00

84 lines
2.7 KiB
Java

/**
* Copyright (C) 2018 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settings.wifi;
import static com.google.common.truth.Truth.assertThat;
import static org.mockito.Mockito.mock;
import android.content.pm.PackageInfo;
import android.Manifest;
import com.android.settings.testutils.SettingsRobolectricTestRunner;
import com.android.settingslib.applications.ApplicationsState.AppEntry;
import com.android.settingslib.applications.ApplicationsState.AppFilter;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mock;
import org.mockito.MockitoAnnotations;
@RunWith(SettingsRobolectricTestRunner.class)
public class AppStateChangeWifiStateBridgeTest {
@Mock
private AppEntry mEntry;
@Mock
private AppStateChangeWifiStateBridge.WifiSettingsState mState;
private AppFilter mFilter;
@Before
public void setUp() {
MockitoAnnotations.initMocks(this);
mFilter = AppStateChangeWifiStateBridge.FILTER_CHANGE_WIFI_STATE;
}
@Test
public void testFilterApp_inputNull_returnFalse() {
assertThat(mFilter.filterApp(null)).isFalse();
}
@Test
public void testFilterApp_extraInfoNull_returnFalse() {
mEntry.extraInfo = null;
assertThat(mFilter.filterApp(mEntry)).isFalse();
}
@Test
public void testFilterApp_permissionedDeclaredTrue_returnTrue() {
mState.permissionDeclared = true;
mEntry.extraInfo = mState;
assertThat(mFilter.filterApp(mEntry)).isTrue();
}
@Test
public void testFilterApp_permissionedDeclaredFalse_returnFalse() {
mState.permissionDeclared = false;
mEntry.extraInfo = mState;
assertThat(mFilter.filterApp(mEntry)).isFalse();
}
@Test
public void testFilterApp_networkSettingsGranted_returnFalse() {
mState.permissionDeclared = true;
mState.packageInfo = mock(PackageInfo.class);
mState.packageInfo.requestedPermissions
= new String[]{ Manifest.permission.NETWORK_SETTINGS };
mEntry.extraInfo = mState;
assertThat(mFilter.filterApp(mEntry)).isFalse();
}
}