Root cause:
RequestIgnoreBatteryOptimizations adds package in
PowerWhitelistManager#addToWhitelist for intent
Settings.ACTION_REQUEST_IGNORE_BATTERY_OPTIMIZATIONS.
Settings UI uses PowerAllowlistBackend to check if
an APP is in power allow list. Each UI component should
PowerAllowlistBackend#refreshList() or UI will get
a stale result.
Solution:
This change fixes below display problems by refreshing
allow list from DeviceIdleController service.
1. Battery optimization summary in Battery usage details.
2. Battery optimization list.
BYPASS_INCLUSIVE_LANGUAGE_REASON=I need the object name
to describe the root cause.
Bug: 171064162
Test: make RunSettingsRoboTests ROBOTEST_FILTER=BatteryOptimizationPreferenceControllerTest
manual
Switch battery optimazion of a APP and observer the UI display.
Change-Id: I75b269eec5d1b904dcaa71948798f169d4e4ddfa
137 lines
4.5 KiB
Java
137 lines
4.5 KiB
Java
/*
|
|
* Copyright (C) 2017 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.fuelgauge;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import static org.mockito.ArgumentMatchers.any;
|
|
import static org.mockito.Mockito.doReturn;
|
|
import static org.mockito.Mockito.never;
|
|
import static org.mockito.Mockito.spy;
|
|
import static org.mockito.Mockito.verify;
|
|
|
|
import android.content.Context;
|
|
import android.content.Intent;
|
|
|
|
import androidx.preference.Preference;
|
|
import androidx.preference.SwitchPreference;
|
|
|
|
import com.android.settings.R;
|
|
import com.android.settings.SettingsActivity;
|
|
import com.android.settings.dashboard.DashboardFragment;
|
|
import com.android.settingslib.fuelgauge.PowerAllowlistBackend;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Mock;
|
|
import org.mockito.MockitoAnnotations;
|
|
import org.robolectric.RobolectricTestRunner;
|
|
import org.robolectric.RuntimeEnvironment;
|
|
|
|
@RunWith(RobolectricTestRunner.class)
|
|
public class BatteryOptimizationPreferenceControllerTest {
|
|
|
|
private static final String PKG_IN_ALLOWLIST = "com.pkg.in.allowlist";
|
|
private static final String PKG_NOT_IN_ALLOWLIST = "com.pkg.not.in.allowlist";
|
|
private static final String KEY_OPTIMIZATION = "battery_optimization";
|
|
private static final String KEY_OTHER = "other";
|
|
@Mock
|
|
private SettingsActivity mSettingsActivity;
|
|
@Mock
|
|
private DashboardFragment mFragment;
|
|
@Mock
|
|
private TestPowerAllowlistBackend mBackend;
|
|
|
|
private BatteryOptimizationPreferenceController mController;
|
|
private Preference mPreference;
|
|
private Context mContext;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
MockitoAnnotations.initMocks(this);
|
|
|
|
mContext = RuntimeEnvironment.application;
|
|
doReturn(false).when(mBackend).isAllowlisted(PKG_NOT_IN_ALLOWLIST);
|
|
doReturn(true).when(mBackend).isAllowlisted(PKG_IN_ALLOWLIST);
|
|
|
|
mPreference = new SwitchPreference(mContext);
|
|
mController = spy(new BatteryOptimizationPreferenceController(mSettingsActivity, mFragment,
|
|
PKG_NOT_IN_ALLOWLIST, mBackend));
|
|
}
|
|
|
|
@Test
|
|
public void testHandlePreferenceTreeClick_OptimizationPreference_HandleClick() {
|
|
mPreference.setKey(KEY_OPTIMIZATION);
|
|
|
|
final boolean handled = mController.handlePreferenceTreeClick(mPreference);
|
|
|
|
assertThat(handled).isTrue();
|
|
verify(mSettingsActivity).startActivity(any(Intent.class));
|
|
}
|
|
|
|
@Test
|
|
public void testHandlePreferenceTreeClick_OtherPreference_NotHandleClick() {
|
|
mPreference.setKey(KEY_OTHER);
|
|
|
|
final boolean handled = mController.handlePreferenceTreeClick(mPreference);
|
|
|
|
assertThat(handled).isFalse();
|
|
verify(mSettingsActivity, never()).startActivity(any(Intent.class));
|
|
}
|
|
|
|
@Test
|
|
public void testUpdateState_appInAllowlist_showSummaryNotOptimized() {
|
|
BatteryOptimizationPreferenceController controller =
|
|
new BatteryOptimizationPreferenceController(mSettingsActivity, mFragment,
|
|
PKG_IN_ALLOWLIST, mBackend);
|
|
|
|
controller.updateState(mPreference);
|
|
|
|
assertThat(mPreference.getSummary()).isEqualTo(mContext.getString(R.string.high_power_on));
|
|
}
|
|
|
|
@Test
|
|
public void testUpdateState_appNotInAllowlist_showSummaryOptimized() {
|
|
mController.updateState(mPreference);
|
|
|
|
assertThat(mPreference.getSummary()).isEqualTo(mContext.getString(R.string.high_power_off));
|
|
}
|
|
|
|
@Test
|
|
public void testUpdateState_refreshList() {
|
|
mController.updateState(mPreference);
|
|
|
|
verify(mBackend).refreshList();
|
|
}
|
|
|
|
/**
|
|
* Create this test class so we could mock it
|
|
*/
|
|
public static class TestPowerAllowlistBackend extends PowerAllowlistBackend {
|
|
|
|
public TestPowerAllowlistBackend(Context context) {
|
|
super(context);
|
|
}
|
|
|
|
@Override
|
|
public void refreshList() {
|
|
// Do nothing so we could mock it without error
|
|
}
|
|
}
|
|
}
|