f1030e8cdf
When setting a new locale, SettingsActivity restarts to load everything in the new locale. Data (containing locale specific title/summary etc) is reloaded correctly and triggers a callback to UI to redraw. However we skip the first callback as an optimization for app startup time. When we restart fragment, we failed to save the state whether we have already seen the first callback. So when data with new locale text triggers the callback, it's being skipped and this make UI still render in old locale. The fix is to just save the state before fragment gets destroyed before locale change so the callback can trigger later. A better fix is: make data (Tile object) not cache text. Then we don't need to worry about locale cache at all. We should do this fix in the long term. Test: localeswitcher Test: adb shell am broadcast -a com.google.android.testing.i18n.localeswitcher.CHANGE_LOCALE -e LANGUAGE_TAG "zh" Test: adb shell am broadcast -a com.google.android.testing.i18n.localeswitcher.CHANGE_LOCALE -e LANGUAGE_TAG "ja" Fixes: 77470788 Bug: 77600770 Change-Id: Ic4223ddbb679db64d0fc3c29d16a5f61a66cc99c
80 lines
2.7 KiB
Java
80 lines
2.7 KiB
Java
/*
|
|
* Copyright (C) 2018 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.dashboard;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import android.app.Activity;
|
|
import android.app.Fragment;
|
|
import android.app.Instrumentation;
|
|
import android.content.Context;
|
|
import android.content.Intent;
|
|
import android.content.pm.ActivityInfo;
|
|
import android.provider.Settings;
|
|
import android.support.test.InstrumentationRegistry;
|
|
import android.support.test.filters.SmallTest;
|
|
import android.support.test.runner.AndroidJUnit4;
|
|
import android.support.test.uiautomator.By;
|
|
import android.support.test.uiautomator.UiDevice;
|
|
import android.support.test.uiautomator.UiObject2;
|
|
import android.support.test.uiautomator.Until;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
|
|
import java.util.List;
|
|
|
|
@RunWith(AndroidJUnit4.class)
|
|
@SmallTest
|
|
public class DashboardSummaryInstrumentationTest {
|
|
|
|
private static final long TIMEOUT = 2000l;
|
|
|
|
private Context mContext;
|
|
private Instrumentation mInstrumentation;
|
|
|
|
private UiDevice mDevice;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
mInstrumentation = InstrumentationRegistry.getInstrumentation();
|
|
mDevice = UiDevice.getInstance(mInstrumentation);
|
|
mContext = InstrumentationRegistry.getTargetContext();
|
|
}
|
|
|
|
@Test
|
|
public void rotate_shouldSaveCategoriesChangedState() {
|
|
final Intent intent = new Intent(Settings.ACTION_SETTINGS)
|
|
.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
|
|
final Activity activity = mInstrumentation.startActivitySync(intent);
|
|
|
|
activity.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE);
|
|
activity.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_PORTRAIT);
|
|
|
|
final UiObject2 item = mDevice.wait(Until.findObject(By.res("android:id/title")
|
|
.text("Network & internet")), TIMEOUT);
|
|
assertThat(item).isNotNull();
|
|
|
|
final List<Fragment> fragments = activity.getFragmentManager().getFragments();
|
|
final DashboardSummary fragment = (DashboardSummary) fragments.get(0);
|
|
|
|
assertThat(fragment.mIsOnCategoriesChangedCalled).isTrue();
|
|
}
|
|
|
|
}
|