Commit Graph

61610 Commits

Author SHA1 Message Date
Bonian Chen
97de75fa83 Merge "[Settings] Allow talkback to focus and select APN" into rvc-dev 2020-06-15 07:51:17 +00:00
tim peng
0fd0fc3ff3 Merge "Unable to adjust remote session volume in Sound Setting" into rvc-dev am: e5c9b113b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11862419

Change-Id: I42600809d4264a3a09ff5b239e13adbd26ce9093
2020-06-15 06:40:24 +00:00
Mark Chien
f9cc4577bc Merge "Replace ConnectivityManager as TetheringManager" into rvc-dev am: 2aa2b0a2f8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11770823

Change-Id: Iba3e5e6b6155fdf6bb807fc24375fa8d2114526d
2020-06-15 06:40:18 +00:00
Mark Chien
b8720615a8 Merge "Remove schedule recheck logic from TetherService" into rvc-dev am: 49b74e24d6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11524846

Change-Id: I5eb68123c8dc0b34773f12daaae4282108808598
2020-06-15 06:40:12 +00:00
tim peng
e5c9b113b6 Merge "Unable to adjust remote session volume in Sound Setting" into rvc-dev 2020-06-15 06:29:32 +00:00
Tim Peng
e3a821d6fe Unable to adjust remote session volume in Sound Setting
-It is incorrect to compare the device ID with session ID
-The preference key is the session ID and we should adjust remote session volume by it

Fix: 158956140
Test: make -j42 RunSettingsRoboTests
Change-Id: Ia815b7bfdf6d7e44aca9832f11371669e973d363
2020-06-15 06:27:49 +00:00
Mark Chien
2aa2b0a2f8 Merge "Replace ConnectivityManager as TetheringManager" into rvc-dev 2020-06-15 06:23:28 +00:00
Mark Chien
49b74e24d6 Merge "Remove schedule recheck logic from TetherService" into rvc-dev 2020-06-15 06:23:11 +00:00
TreeHugger Robot
cbe9c7cb5b [automerger skipped] Merge "Import translations. DO NOT MERGE" into rvc-dev am: 9ebeb21c36 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11862718

Change-Id: Ie79944b447cbd4bb13b9ffe6e71b60daeadc0eed
2020-06-15 06:07:29 +00:00
TreeHugger Robot
9ebeb21c36 Merge "Import translations. DO NOT MERGE" into rvc-dev 2020-06-15 05:49:54 +00:00
Bonian Chen
3e8425468b [Settings] WEA title wording change
The wording of WEA need to align in UI entry and UIs within.
The "Wireless Emergency Alerts" should be the official wording for it.

Bug: 158498436
Test: build pass
Change-Id: I17e6659915e1038c8ab11ad4003c08f87bbdb82e
2020-06-15 03:16:15 +00:00
SongFerng Wang
4634271464 Merge "Revert "Mainline: removed legacy UI for network selection mode."" into rvc-dev am: 518ffd7c76
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11837795

Change-Id: I3dd99e8b9fe4cef8d01c7d32c76c8a1c88d575d0
2020-06-15 03:13:09 +00:00
SongFerng Wang
518ffd7c76 Merge "Revert "Mainline: removed legacy UI for network selection mode."" into rvc-dev 2020-06-15 03:09:21 +00:00
Bonian Chen
723c251c13 [Settings] Allow talkback to focus and select APN
Change the focus area to help talkback focus on APN items.

Bug: 149794675
Test: manual
Change-Id: I5f391be89a5b22095d6f0d04b187ea18970f18d4
2020-06-15 03:08:31 +00:00
Yanting Yang
89b1cc1a94 Merge "Update App info behavior for mainline module" into rvc-dev am: 8357871465
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11822585

Change-Id: I8d436e39ab602190e35302bea66df38d2f802bba
2020-06-15 03:07:15 +00:00
TreeHugger Robot
4a9a22839e Merge "NetworkRequestDialog: Exit the dialog on connect failure" into rvc-dev am: eac45c6a89
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11852224

Change-Id: I4cdfd94bcdf25f6f2d89d78e19c3f5ec5769c3d9
2020-06-15 03:06:36 +00:00
Yanting Yang
8357871465 Merge "Update App info behavior for mainline module" into rvc-dev 2020-06-15 02:59:13 +00:00
TreeHugger Robot
eac45c6a89 Merge "NetworkRequestDialog: Exit the dialog on connect failure" into rvc-dev 2020-06-15 02:52:27 +00:00
tim peng
634dc7f8a3 Merge "Refine layout for output switcher panel" into rvc-dev am: 7874c0fdc4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11596546

Change-Id: I77f3b9a35e760c1c8f1f1839d979940d67501fed
2020-06-15 01:29:16 +00:00
tim peng
7874c0fdc4 Merge "Refine layout for output switcher panel" into rvc-dev 2020-06-15 01:14:57 +00:00
Bill Yi
451ae5441e Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I9d2dd999c963161e7283fc6a6bd7d76c7d44bafa
2020-06-15 00:45:36 +00:00
Jason Chiu
4f2cd6ab5f Merge "Improve BT slice card loading performance" into rvc-dev am: 85f03668a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11833854

Change-Id: Ic338f8e2106ef256cbef1b7a93feaeba31fb7a0f
2020-06-14 17:30:15 +00:00
Jason Chiu
85f03668a5 Merge "Improve BT slice card loading performance" into rvc-dev 2020-06-14 17:14:11 +00:00
Roshan Pius
924e9e39c1 NetworkRequestDialog: Exit the dialog on connect failure
Connection failure (similar to connection success) is the end of the
processng of a request. We should dismiss the dialog on connection
failure.

Bug: 158844146
Bug: 158616070
Test: Manual tests - Simulate connection failure and ensure that the
dialog vanishes with a toast.

Change-Id: I625ca76298ed549dbed76d398aea0c957c9102fc
Merged-In: I625ca76298ed549dbed76d398aea0c957c9102fc
2020-06-14 15:19:30 +00:00
TreeHugger Robot
6ccd5339fa [automerger skipped] Merge "Import translations. DO NOT MERGE" into rvc-dev am: 4b25f3f159 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11854964

Change-Id: I125b53a89f8a3dddb24a50bd02f549a700d7c41b
2020-06-13 00:30:59 +00:00
TreeHugger Robot
2718f1d42b Merge "Explicitly request focus after button pressed" into rvc-dev am: d9a246c49e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11851989

Change-Id: I3c25415f84b9c59b5a59d9979ab383c0572ca17a
2020-06-13 00:30:52 +00:00
TreeHugger Robot
4b25f3f159 Merge "Import translations. DO NOT MERGE" into rvc-dev 2020-06-13 00:26:09 +00:00
TreeHugger Robot
d9a246c49e Merge "Explicitly request focus after button pressed" into rvc-dev 2020-06-13 00:19:44 +00:00
Bill Yi
23e3832fe0 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I4248ba5dd6eddcba4c94f9b25e6ef46ffec387c6
2020-06-12 15:02:57 -07:00
Kevin Chyn
4b59ce96e2 Merge "BiometricFragment should commitAllowingStateLoss" into rvc-dev am: 5c4334276f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11838911

Change-Id: I7541fb18e9be1624220bd61929736452fdb342a7
2020-06-12 20:08:39 +00:00
Kevin Chyn
5c4334276f Merge "BiometricFragment should commitAllowingStateLoss" into rvc-dev 2020-06-12 19:56:01 +00:00
Beverly
258fd7c03b Explicitly request focus after button pressed
Don't use focusableInTouchMode, it was causing focus/clickability issues
when the device wasn't in touch mode.

Test: manually tap button (tap works first try)
Test: turn on talkback and toggle buttons, also try toggling QS tile
while on the Settings page - doesn't reannounce state
Fixes: 158717450
Change-Id: I785d0200dd61235aa3308a8588f9ee998e7cb6e5
2020-06-12 16:01:50 +00:00
Rubin Xu
670a30e766 Remove password shards from memory
Force a garbage collection and zeroize some fields after Activity finishes

Test: Goes through password change flow, then grab a heap dump via
      adb shell 'am dumpheap $(pidof com.android.settings)
      /data/local/tmp/settings.hprof'
      And grep for password in the dump
Bug: 144537463
Change-Id: Idd0a04ada98900aeb2a6d20bb1270a4a4aec2cfd
2020-06-12 15:56:04 +01:00
Jason Chiu
72a9dc4c8b Merge "Fix Slice not pinned error" into rvc-dev am: 8cbee49d28
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11833849

Change-Id: I1d64558f189ca6b14d71cc71e574dae5dd21146d
2020-06-12 11:43:59 +00:00
Jason Chiu
8cbee49d28 Merge "Fix Slice not pinned error" into rvc-dev 2020-06-12 11:31:23 +00:00
SongFerng Wang
c3703cb4fe Revert "Mainline: removed legacy UI for network selection mode."
This reverts commit 521ebeafd3.

Reason for revert: to fix b/157880043

Bug: 157880043
Test: test legacy UI. PASS
Change-Id: I4116457a1f7fc0a3be142671c5d0439cd6bdf11d
2020-06-12 19:03:54 +08:00
Tim Peng
9bdeef43fd Refine layout for output switcher panel
1. only make the output switcher tall enough to show 6.5 devices
2. enlarge album art to 52*52 and keep same size on group panel
3. reduce panel header top padding
4. enlarge slice first item top padding
5. update slider bar right padding
6. update panel height
7. align slice title item left with panel title icon
8. enlarge slice end item right padding

Bug: 156045699
Test: manual test
Change-Id: I51321d98ef483665689b7e258d6071df76382759
2020-06-12 15:15:00 +08:00
TreeHugger Robot
1d02b72826 [automerger skipped] Merge "Import translations. DO NOT MERGE" into rvc-dev am: 05103c79d1 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11844686

Change-Id: I73b81a96482fb4423f628ec878df55dd2022bb0b
2020-06-12 05:10:58 +00:00
tim peng
a4642718b4 Merge "Output switcher panel requires large title icon for Slice slider style" into rvc-dev am: c21406a0a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11818502

Change-Id: I7cd8987d1472b308e4a918316e4877044c48816d
2020-06-12 05:10:53 +00:00
TreeHugger Robot
05103c79d1 Merge "Import translations. DO NOT MERGE" into rvc-dev 2020-06-12 05:09:30 +00:00
tim peng
c21406a0a2 Merge "Output switcher panel requires large title icon for Slice slider style" into rvc-dev 2020-06-12 04:58:04 +00:00
Bill Yi
a891edabdb Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: Ibb02d904bcceffdd07fb13dec9b62e72e89ea32d
2020-06-12 03:50:41 +00:00
Tim Peng
27b0ef6eb3 Output switcher panel requires large title icon for Slice slider style
-Add "VIEW_TYPE_SLIDER_LARGE_ICON" to be a new panel type which would enlarge its title icon
-Set "VIEW_TYPE_SLIDER_LARGE_ICON" to MediaOutputPanel and MediaOutputGroupPanel
-Extend slider style and add customized icon size
-Add test cases

Bug: 157208551
Test: make -j42 RunSettingsRoboTests
Change-Id: I9b4de4aa552e8b26e766411f7eff93ea1a2d1910
2020-06-12 11:22:17 +08:00
Chen Xu
0bc52c8262 Merge "rename "Emergency Alert" to "Public Warning" per IT requirements" into rvc-dev am: 6ebe9ae0ff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11814763

Change-Id: I31840ef2c88776cfb3ee930e8757ef32ddaf2a2a
2020-06-12 02:41:11 +00:00
TreeHugger Robot
e26dfb6d10 Merge "Unicode-wrap app names for default apps summary." into rvc-dev am: 6791e1c09b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11844071

Change-Id: I7940ffb602a06eb0fa379d8879458dbc5bbc7fa7
2020-06-12 02:41:05 +00:00
Chen Xu
6ebe9ae0ff Merge "rename "Emergency Alert" to "Public Warning" per IT requirements" into rvc-dev 2020-06-12 02:29:17 +00:00
TreeHugger Robot
6791e1c09b Merge "Unicode-wrap app names for default apps summary." into rvc-dev 2020-06-12 02:28:48 +00:00
Hai Zhang
3f511d8ca9 Unicode-wrap app names for default apps summary.
This was done for permissions summary inside PermissionController, so
also do it in Settings.

Bug: 153804329
Test: manually confirm that the summary matches what linguist
      suggested after fix
Change-Id: I650fbed4488abfd871adafba5afb1ae9a2995c62
2020-06-11 16:54:25 -07:00
Jason Chiu
f7afded1d1 Fix Slice not pinned error
Slices should be pinned before being bound. The original design calls
registerSliceCallback() to pin a slice, and then calls bindSlice() and
passes the result to the callback directly. When the callback is
called, it executes unregisterSliceCallback() and unpins the slice.

However, registerSliceCallback() starts to observe the slice change and
then rebind it in an AsyncTask. If the slice is updating via its
background worker and the timing of the binding overlaps the callback
execution, it's possible to bind the slice right after unpinning it and
causes the error.

The solution is to remove the callback mechanism, and just to pin, bind
and unpin the slice directly.

Fixes: 157387583
Test: robotest
Change-Id: I8748dd3038a3662599935f07420d07cf254a4073
2020-06-12 04:14:46 +08:00
Kevin Chyn
895ddf239a BiometricFragment should commitAllowingStateLoss
This is a terminal case for both authentication as well as the
activity itself, so this should be safe.

Fixes: 158635014

Test: Builds
Change-Id: Ieef1ab305e6518dbc0ae34ad59d52da82895972a
2020-06-11 12:59:05 -07:00