Commit Graph

7 Commits

Author SHA1 Message Date
Stanley Wang
e11d9e9ef3 Fix the problem that the autofill could be searched.
PreferenceCategory will not be indexed by default. The auto fill
category use the AutofillPreferenceCategory class in the xml so
it will be indexed.
The solution is to create a controller to replace AutofillPreferenceCategory.

Fix: 185914894
Test: manual adb test to see the log
Change-Id: Id0e3bcc33a3132434a6bd1fe91e1c6915116d06d
2022-03-02 14:02:56 +08:00
Stanley Wang
f838aa1059 Fix Developer options page memory leak
Change-Id: I12d53c41adee56850cd294ae89e7a56328639558
Fixes: 117583710
Test: manual
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.development
2018-10-30 17:49:59 +08:00
Fan Zhang
23f8d59d02 Sort imports
Having consistent import order will reduce chance of merge
conflict between internal and external master

Test: rebuild
Change-Id: I0b1a170967ddcce7f388603fd521f6ed1eeba30b
2018-08-28 22:13:15 +00:00
Felipe Leme
934278e050 Fixed NPE that crashes Settings.
It happens due to a race condition when the AutofillDeveloperSettingsObserver
is triggered by a settings change while the underlying preferences activity is
being finished.

Fixes: 113030661

Test: echo 'could not reproduce this issue'
Test: runtest --path \
      packages/apps/Settings/tests/unit/src/com/android/settings/core/\
      PreferenceControllerContractTest.java
Test: atest AutofillResetOptionsPreferenceControllerTest \
            AutofillLoggingLevelPreferenceControllerTest

Change-Id: I761195df13ac10705b9ce6b0c7546ec66a85d3ef
2018-08-22 11:58:52 -07:00
Fan Zhang
a79c377fbc Declare "searchable" attribute for preferences.
Now we can easily mark a preference nonIndexable in xml instead of
adding key into searchIndexProvider.

Bug: 112608186
Test: robotests
Change-Id: I0ff16d44bb7b6ad148d3d35f09ca0da0163f73f4
2018-08-16 09:06:39 -07:00
Felipe Leme
a305b779e8 Fixed AutofillPreferenceCategory so it's UI is properly refreshed.
Test: manual verification
Test: runtest --path packages/apps/Settings/tests/unit/src/com/android/settings/core/PreferenceControllerContractTest.java
Bug: 65700540
Bug: 111838239

Change-Id: If4e80a47d65aea34b94271e43ac38612373f4fa2
2018-07-30 09:58:59 -07:00
Felipe Leme
9bf591b832 Added autofill options on Developer Options screen.
Test: manual verification
Test: atest AutofillResetOptionsPreferenceControllerTest\
            AutofillLoggingLevelPreferenceControllerTest
Test: runtest --path packages/apps/Settings/tests/unit/src/com/android/settings/core/PreferenceControllerContractTest.java
Fixes: 65700540

Change-Id: I6b35fbf549529f4d97df164ce3fb6d641ee37650
2018-07-26 09:53:11 -07:00