Commit Graph

2091 Commits

Author SHA1 Message Date
Maurice Lam
90cb8a1224 Merge "Sticky footer for GLIF theme" 2017-04-04 18:42:30 +00:00
Maurice Lam
a857c8da4f Sticky footer for GLIF theme
For settings screens using GLIF theme, update to sticky footers.

Test: Existing tests pass
Bug: 35448201
Change-Id: If26e7e25f7f02b4c24979503e0c9359b88ff16d1
2017-03-31 11:54:39 -07:00
jackqdyulei
edfd09d590 Ui changes in battery main page
1. Refine the battery header view
2. Move stats section to the place above power management
3. Add last full charge battery stat
4. Add the disclaimer as a footer

Also update the method name in test file, and this ui changes
also fix the header flash problem.

Bug: 36576021
Bug: 36494178
Test: RunSettingsRoboTests
Change-Id: I9784dbbbe16e61da7287f300183347dd4eee6a2b
2017-03-31 10:16:14 -07:00
TreeHugger Robot
a61da379cd Merge "Adds the lightning badge for Instant Apps" 2017-03-30 00:06:36 +00:00
Maurice Lam
2aa5a7d3d3 Merge "Allow remote views to be used in Tiles" 2017-03-29 22:56:53 +00:00
Jesse Evans
2400d31651 Adds the lightning badge for Instant Apps
Adds the lightning bolt badge for Instant Apps to the
InstalledAppDetails page.

Test: Robolectric test to ensure the badge is shown for Instant Apps
and also that it is not shown for installed apps.

Bug: 36512295
Change-Id: I8496d684fa3a9dc316fa5af16399e6d07f68255a
2017-03-29 11:08:05 -07:00
Maurice Lam
97f35625b7 Merge "Revert choose lock header file to non-setup theme" into oc-dev am: 1ecbb7d16d
am: 40c22ec75a

Change-Id: I6d2d29f3166ff88a38c92b1eb3fa00c7c2abe61c
2017-03-29 16:53:56 +00:00
Maurice Lam
1ecbb7d16d Merge "Revert choose lock header file to non-setup theme" into oc-dev 2017-03-29 15:45:22 +00:00
Maurice Lam
f8fb4806cf Revert choose lock header file to non-setup theme
The activity ChooseLockGeneric which inflates the layout file
choose_lock_generic_fingerprint_header is not setup themed, and
therefore should not use setup resources.

Test: Run ChooseLockGenericTest via `am instrument`
Bug: 36688431
Change-Id: I7286958345d1762d4a93176afe300d1e4d168f6d
2017-03-28 20:24:12 -07:00
Yohei Yukawa
7a76a5ed37 Merge "Set flagForceAscii for device password entries" into oc-dev am: ef34273654
am: 6c4d4600e3

Change-Id: Ifd213e69ff9dce07da1ccdf93698051a3447cb02
2017-03-28 23:31:44 +00:00
TreeHugger Robot
ef34273654 Merge "Set flagForceAscii for device password entries" into oc-dev 2017-03-28 23:21:02 +00:00
TreeHugger Robot
9502f112e6 Merge "Use buttons for EncryptionInterstitial" 2017-03-28 23:11:41 +00:00
Doris Ling
e3716b9be3 Revert "Convert BT preference to use TwoTargetPreference" am: 457c3cbec2
am: 6226a2b825

Change-Id: I3b3ab282b7f58c52baad57f3fa1fe51a090372ec
2017-03-28 20:21:52 +00:00
Doris Ling
457c3cbec2 Revert "Convert BT preference to use TwoTargetPreference"
This reverts commit 09c7f15b12.

Change-Id: I29aa67f026c0b54da08b19657f9916275e5a3459
2017-03-28 20:03:10 +00:00
Youhan Wang
fd781e91d4 OMADM Trigger in *#*#INFO#*#* hidden menu.
Test: make

Bug:32874442
Change-Id: Ie64eb28671ec4afafd352d1f86b61c4ce1108338
2017-03-28 11:01:26 -07:00
Yohei Yukawa
e2a7bddbe1 Set flagForceAscii for device password entries
Since the beginning [1], ChooseLockPassword#validatePassword() has never
accepted non-ASCII characters [2].  Hence we can safely specify
EditorInfo#IME_FLAG_FORCE_ASCII so that IMEs can optimize their UX based
on this flag.  Note that EditorInfo#IME_FLAG_FORCE_ASCII is just a hint
for the IME so there should be no behavior change in the system side.

Note also that EditorInfo#IME_FLAG_FORCE_ASCII has been used in KeyGuard
(keyguard_password_view.xml) since JB MR-1 [3] so this flag is considered
to be well tested.

 [1]: 00d2476d8f
 [2]: Only character c where 32 <= c <= 126 is accepted
 [3]: Id75286113771ca1407e9db182172b580f870b612

Test: Run `adb shell dumpsys input_method` when the password entry
      field is focused to make sure that 'imeOptions' parameter
      has 0x80000000 bit. Tested the following scenarios:
       - PIN on a direct-boot disabled device
       - PIN on a direct-boot enabled device
       - Password on a direct-boot disabled device
       - Password on a direct-boot enabled device
Fixes: 27858858
Change-Id: I3075e24c6dac4d49f4d0e56a0d4d8434a323754d
2017-03-28 16:42:17 +00:00
Maurice Lam
fc972a75a9 Allow remote views to be used in Tiles
If a suggeested action Tile has a remote view defined, inflate a card
layout to contain the remote view, instead of showing the default
title-summary layout.

Additionally, if the remote view has a view with ID
@android:id/primary, that will be used as the click target rather
than the entire card.

Test: cd tests/robotests && mma
Bug: 35668836
Change-Id: I0fd1b9c637b6d7a3d7d2f6268669917408a882eb
2017-03-27 20:32:20 -07:00
TreeHugger Robot
f85ebb24bb Merge "Changes to installed app details screen for instant apps" 2017-03-28 01:22:47 +00:00
Antony Sargent
09955c3865 Changes to installed app details screen for instant apps
Bug: 35098444
Test: make RunSettingsRoboTests

This implements the following changes to the app details screen:

-Suppresses the "Uninstall" and "Force Stop" buttons
-Adds "Install app" and "Clear app" buttons
-Adds a mechanism for showing a link to the store's app details
 page that can be different from the default for installed apps.

Change-Id: Icea83f7d1fde62d4101cb0c8a6d03849f6c56bca
2017-03-27 14:34:56 -07:00
Maurice Lam
40a0db9afd Merge "Support center alignment" 2017-03-27 20:27:22 +00:00
Maurice Lam
8d5a4f1689 Support center alignment
Update styles to reference the theme attribute suwGlifHeaderGravity
to, directly or indirectly via SuwDescription.Glif.

Test: Existing tests pass
Bug: 36368632
Change-Id: I6c7c234c32fdd614d4a9cdfabbef05626dad0a93
2017-03-24 15:48:14 -07:00
Yohei Yukawa
63ca922354 Merge "Deprecate IMM#showSoftInputUnchecked() part 2" 2017-03-24 18:50:24 +00:00
Daniel Nishi
49118e7e01 Add icons to the main static storage setting prefs.
The dynamic user icons require more than just XML changes to
successfully fetch the badged user icons and are coming in a future
patch.

Bug: 35801039
Test: Manual -- this is purely XML and comment changes.
Change-Id: Id493c0335037a5c6e4f8b4734700611bfc0da7f1
2017-03-23 10:34:06 -07:00
TreeHugger Robot
51d6bcca4f Merge "New iteration of the Text-to-Speech settings." 2017-03-23 13:56:00 +00:00
Charles He
b436519129 Merge "VPN settings: gray out always-on checkbox dynamically" 2017-03-23 08:49:47 +00:00
Maurice Lam
9be96e06bb Use buttons for EncryptionInterstitial
Bug: 30742121
Test: Run EncryptionInterstitialTest via `am instrument`
Change-Id: I04d304da4153ebc7f8809ce9c640bccc5e1f5685
2017-03-22 18:37:56 -07:00
TreeHugger Robot
b0967c8287 Merge changes from topic 'two_target_preference'
* changes:
  Update string character limit
  Convert BT preference to use TwoTargetPreference
  Refactor the layout for MasterSwitch to a 2 target pref
2017-03-23 01:26:48 +00:00
Fan Zhang
09c7f15b12 Convert BT preference to use TwoTargetPreference
Change-Id: I0b49af4afb4b782a6057060b2666f6528bc003b2
Fix: 36511169
Test: make RunSettingsRoboTests
2017-03-22 16:03:45 -07:00
Fan Zhang
fe292515d8 Refactor the layout for MasterSwitch to a 2 target pref
And move the layout to settingslib.

The new TwoTargetPreference is a preference object that has a vertical
divider between main panel and widget (if it exists).

Converted master switch, restricted preference, gear preference to use
the new style

Change-Id: Ia3848cebb06b8edc4e60abf9b0caf13cdb29c22c
Fix: 36511169
Test: make RunSettingsRoboTests
2017-03-22 16:03:40 -07:00
Lei Yu
9635123aab Merge "Remove the hardcoded color in main page" 2017-03-22 21:48:02 +00:00
Charles He
ad828f1551 VPN settings: gray out always-on checkbox dynamically
In the ConfigDialog for legacy VPNs, many configurations do not support
Always-on VPN. Previously, when a user entered an unsupported set of
settings, the Always-on VPN checkbox could still be ticked, and the
Save or Connect action buttons would be disabled. This was not intuitive
as the user could not easily figure out which part of the settings was
incompatible that grayed out the action buttons.

With this change, we disable the Always-on VPN checkbox immediately as
the user enters any incompatible setting. We also display the reason why
Always-on VPN is disabled. This will make it more straightforward for
the users to understand which setting is conflicting with the Always-on
feature.

This change is also the first step towards refactoring the ConfigDialog
for legacy VPNs with PreferenceFragment.

Test: manual
Bug: 29208008
Bug: 28072644
Change-Id: I1e6d32a1069ca0b936513f4985ffb9a9412b249c
2017-03-22 20:29:46 +00:00
jackqdyulei
8a05c9b38b Remove the hardcoded color in main page
Since we don't have grey background in settings page, we could
delete selectable_card and use default selectableItemBackground
instead.

Fix: 28129641
Fix: 36508801
Test: Screenshot
Change-Id: I2b61d8f2214df681a0db7f697fcc6a87dc7d78cb
2017-03-22 11:36:02 -07:00
Matthew Fritze
fb8e0dc545 Merge "Rename remaining layouts to original search names" 2017-03-22 17:32:19 +00:00
Matthew Fritze
28f389e553 Rename remaining layouts to original search names
Change-Id: Ibb0aa087e797c3e7ae93556cf4a00d9746694532
Fixes: 32590887
Test: make RunSettingsGoogleRoboTests
2017-03-22 16:05:24 +00:00
jackqdyulei
3a03b722c6 Delete the estimated time in battery usage graph
Bug: 31012673
Test: RunSettingsRoboTests
Change-Id: Icac85a5fc523b70904e048d17eace30c91fe54ee
2017-03-21 13:39:21 -07:00
Yohei Yukawa
f6af093e2d Deprecate IMM#showSoftInputUnchecked() part 2
This is the 2nd attempt to have CryptKeeper stop depending on
InputMethodManager#showSoftInputUnchecked() do avoid non-deterministic
behaviors.  Note that the original one [1] was reverted [2] due to
ClassCastException as crypt_keeper_pin_field.xml was not updated to
use ImeAwareEditText.

We have been receiving more and more strange bug reports regarding
the initial IME visibility on CryptKeeper (Bug 31915865, Bug 35198715,
and Bug 36148078).  Most likely we have introduced more bugs before
fixing previous bugs.

As the first step to disentangle multiple problems, this CL addresses
a long standing issue that CryptKeeper relies on @hide internal API
InputMethodManager#showSoftInputUnchecked().  As explained in
Bug 36015425, IMM#showSoftInputUnchecked() is considered harmful in
terms of bypassing standard IME focus handling flows, which prevents
us from taking advantage of historical debugging mechanism that we
have added recently in Bug 35079353.

 [1]: I3cffeec286d9372ff05e85a49b82287cb1add8a2
      4ae46cd1ad
 [2]: I776ad2e6ba0eabacb3d6be6de23ba37fe5ce7bc7
      cf026ead80

Test: Manually verified that Bug 31915865 is still broken but this CL
      does not make it worse.
      1. Flash an image into a non direct-boot device.
      2. Set up a device boot password.
      3. adb reboot
      After the step 3, the software keyboard shows up automatically
      then suddenly disappears (Bug 35198715). Do the same test for
      device boot PIN instead of password.
Bug: 36015425
Change-Id: I182b05d3ff59fb3b4732d60d0d5a464f0e0e0235
2017-03-21 12:38:44 -07:00
Niels Egberts
46f38575ec New iteration of the Text-to-Speech settings.
- Moves speech rate and pitch back to first page.
- Voice selection is now expected to happen in Engine settings
- Play/reset buttons are now actual buttons.

Test: mmma packages/apps/Settings
Change-Id: I917298473ec473e11eccededee1cb948b0afe911
2017-03-21 12:06:34 +00:00
Daniel Nishi
af11138589 Merge "Re-add the progress bar for storage preferences." 2017-03-20 22:54:03 +00:00
TreeHugger Robot
e0090cc711 Merge "Revert "Use color accent as background color for app info pages."" 2017-03-20 21:02:25 +00:00
Doris Ling
6743407475 Revert "Use color accent as background color for app info pages."
This reverts commit b2032416e9.

Change-Id: Ie80e061e6ccecbcf96404c5349ab136da7ca599f
2017-03-20 19:02:42 +00:00
Daniel Nishi
cf0e659a6c Re-add the progress bar for storage preferences.
This re-adds the progress bar and unifies the
StorageItemPreference and its alternate.

Change-Id: Iefc12b4b554306c706c83be232175dd2b84227b7
Fixes: 36223433
Test: Settings robotest
2017-03-20 11:42:46 -07:00
Christine Franks
c53ab43d94 Add color temperature preference to Night Display
Bug: 32463283
Test: make RunSettingsRoboTests
Change-Id: Ibf3cf9af05b44a071603d3d7efa6e90ae00c823a
2017-03-20 15:47:41 +00:00
Fan Zhang
11d2d68e23 Move developer options related class to development package
Bug: 34203528
Test: none, purely moving classes around
Change-Id: I3cd1d257f948729fda5c04632e7ce9114c40bd0c
2017-03-17 16:51:21 -07:00
TreeHugger Robot
edec9f1795 Merge changes from topic 'FrictionIcons'
* changes:
  Revert picker icon sizes to 24dp.
  Comment changes from ag/1991360.
  Clean up wifi_friction icon unused states.
  Fix list item spacing for preferences.
2017-03-17 23:06:10 +00:00
Daniel Nishi
3788262dac Merge "Size and position the donut." 2017-03-17 22:54:44 +00:00
Sundeep Ghuman
6f98b97687 Fix list item spacing for preferences.
Bug: b/33970117
Test: Existing tests pass - purely UI margin change. See screenshots in
bug.

Change-Id: I08ce646c9db2401c1462801ab39713fca8f5cc26
2017-03-17 12:44:54 -07:00
Daniel Nishi
b57795c311 Merge "Update the spacing on the Storage header." 2017-03-17 19:41:20 +00:00
Lei Yu
dc8d9b138d Merge "Change ripple in battery pages" 2017-03-17 17:11:46 +00:00
jackqdyulei
26bc34a8b4 Change ripple in battery pages
1. Add ripple for battery header
2. Remove ripple for battery usage graph

Bug: 35959227
Bug: 35957849
Test: Manual
Change-Id: I7b9965304d0c79b59bdac92719e303931206b672
2017-03-16 16:08:42 -07:00
Matthew Fritze
0b431fc003 Purify SettingsActivity from old search code.
Bug:35763944, 32590887
Test: make RunSettingsRoboTests
Change-Id: Id8140b68a676e595bff095546fa119cd3ced2c4a
2017-03-16 14:14:44 -07:00