Commit Graph

580 Commits

Author SHA1 Message Date
Edgar Wang
e19ee9a01f Revert "Settings search - Navigate user to exact page"
This reverts commit 08f2a58459.

Reason for revert: design changed, we decide to take the user to
the entry after clicking on a search result.
It's opposite with what we did, so we revert related CL first.

Test: robotest

Change-Id: Iadb9a94a7ef7838be34a54499e2d934d6396c336
2020-01-16 14:07:38 +08:00
menghanli
cb718d7d25 Color correction improvement (4/n)
Integrate with the multiple shortcut selections and change the behavior as below:
- Register a setting content observer to monitor the service on/off
status to update switch toggle UI.

Bug: 145968068
Test: make RunSettingsRoboTests2
Change-Id: Ib195aab720d965a7a3047070999783fe9525bfd9
2020-01-16 10:35:42 +08:00
jasonwshsu
4605005374 Accessibility shortcut secondary action - correct invisible type fragment checkbox logic
- checkbox logic need to follow shortcutPreference checked status

Bug: 142530063
Test: manual
Change-Id: Ibc079f116c16b6e1c32b573de693b4a23388858c
2020-01-15 20:29:23 +08:00
Minche Li
8b1bf8a477 Merge "Create settings for window magnification (3/n)" 2020-01-15 11:00:04 +00:00
mincheli
5b59e62ecb Create settings for window magnification (3/n)
This change is for internal test.
Add a switch preference for magnification enable mode.

Bug: 146019459
Bug: 146473544
Test: make RunSettingsRoboTests ROBOTEST_FILTER=MagnificationEnablePreferenceControllerTest -j64
Change-Id: I85fdbb5b0efc106d5301d95802b8d6b7dbe8145d
2020-01-15 16:11:38 +08:00
jasonwshsu
64426cc868 Accessibility shortcut secondary action - correct magnification shortcut logic
- correct magnification shortcut logic
- add magnification tests

Bug: 142530063
Test: make RunSettingsRoboTests -j52 ROBOTEST_FILTER=ToggleScreenMagnificationPreferenceFragmentTest
Change-Id: I15f8bccde63570e93e28399bc1730fb1afdb1242
2020-01-15 15:15:38 +08:00
Jason Hsu
d53cbefcc0 Merge "Accessibility shortcut secondary action - handle all preferred shortcut type key" 2020-01-14 05:53:38 +00:00
Jason Hsu
d5095abc91 Merge "Accessibility shortcut secondary action - legacy type fragment only have hardware shortcut" 2020-01-14 05:53:19 +00:00
Jason Hsu
d8e3fbc5f7 Merge "Accessibility shortcut secondary action - Settings view status link with checkbox" 2020-01-14 04:30:10 +00:00
jasonwshsu
fb576356aa Accessibility shortcut secondary action - handle all preferred shortcut type key
- save and restore all preferredShortcutType: SOFTWARE, HARDWARE, TRIPLETAP

Bug: 142530063
Test: manual
Change-Id: I7dd714d1516f49e89c42822241f9cb2b41ae2d2e
2020-01-14 12:15:14 +08:00
Jason Hsu
fd17fcbf11 Merge "Accessibility shortcut secondary action - Invisible type fragment need to handle AccessibilityServiceState" 2020-01-14 02:46:46 +00:00
jasonwshsu
802fad998e Accessibility shortcut secondary action - legacy type fragment only have hardware shortcut
- LegacyAccessibilityServicePreferenceFragment only allowed hardware shortcut, software shortcut appear is controlled by flagRequestAccessibilityButton

Bug: 142530063
Test: manual
Change-Id: I90c7246c83b5525613e22ff5f0ad03295288c53d
2020-01-13 16:28:50 +08:00
jasonwshsu
5469cffa58 Accessibility shortcut secondary action - Invisible type fragment need to handle AccessibilityServiceState
- InvisibleToggleAccessibilityServicePreferenceFragment need to set
AccessibilityServiceState according to ShortcutPreference checkbox's stauts.

Bug: 142530063
Test: manual
Change-Id: I9ff21b66ebf72a51e62a958e3e391624c7925c27
2020-01-13 15:22:50 +08:00
jasonwshsu
5fd157b404 Accessibility shortcut secondary action - Settings view status link with checkbox
Lets settings view auto enabled by checkbox click status.

Bug: 142530063
Test: make -j52 RunSettingsRoboTests ROBOTEST_FILTER=ShortcutPreferenceTest
Change-Id: I588d2ada85ae1169f439db9c6ce254c20119b2e5
2020-01-13 15:05:47 +08:00
Menghan Li
7ad9008ce9 Merge "Support accessibility shortcut secondary action (7/n)" 2020-01-13 06:13:10 +00:00
menghanli
334dc4f20b Support accessibility shortcut secondary action (7/n)
Implements sharedPreference to keep the user preferred shortcut for each
service.

Bug: 142530063
Bug: 142531156
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ToggleFeaturePreferenceFragmentTest
Test: make RunSettingsRoboTests2
Change-Id: I2a7c54ddc32764f6d88f2efed87982d469acc183
2020-01-13 12:34:04 +08:00
Jean Chen
4ae8991222 Merge "Support caption second UI structure (3/n)" 2020-01-13 02:24:01 +00:00
Kevin Chang
ca149c7d04 Merge "Modify the code logic of OnLayoutChangeListener in Caption preferences" 2020-01-13 02:00:14 +00:00
Tsung-Mao Fang
7f5986b78a Add a RTT setting in A11y screen
- Add RTT setting in Accessibility screen.
- Create a controller for RTT setting preference.
- Create an array strings.

Test: Rebuild, and visual
Change-Id: I248654c822284473b8a8265de4a3938af89cdf7a
Fix: 146540478
2020-01-09 16:43:34 +08:00
ChenJean
2c37f45a35 Support caption second UI structure (3/n)
Removed unenable behovior when turn off Show captions.

Bug: 143502915
Test: Manual
Change-Id: Idb59172967872f4c8ba76e6cdcb83ba0a7faeadd
2020-01-09 14:45:54 +08:00
Kevin Chang
8416d8efd7 Modify the code logic of OnLayoutChangeListener in Caption preferences
Remove the listener and add statement to refresh the text when the caption turns on.

Bug: 142632389
Test: Manual
Change-Id: Ic5711309c5b8af9834e5439d825b4cb2ed55fe01
2020-01-08 18:44:58 +08:00
Menghan Li
65a0488e1b Merge "Maginfy Improvement" 2020-01-08 07:30:38 +00:00
menghanli
f3eb2de691 Maginfy Improvement
Implements the magnify new accessbility settings UI,
including the setupwizard and a11y settings

Bug: 146019459
Test: make RunSettingsRoboTests2
Change-Id: If11849a539c7841e2db495b63132e6d02b7285c0
2020-01-07 20:28:22 +08:00
PETER LIANG
69a9f26c7c Merge "Accessibility scary dialog for android R changed." 2020-01-07 11:56:16 +00:00
Peter_Liang
ec2fa7e872 Accessibility scary dialog for android R changed.
Show scary dialog only once when toggle shortcut preference and use
  service.

Fix: b/142532185
Test: manual test
Change-Id: Ic36fdd5eec8ec20ead79ce47cd5e5e19d2ef5768
2020-01-07 11:54:27 +00:00
Jasper Chang
875727c2ab Merge "Create palette preview for color correction." 2020-01-07 03:20:54 +00:00
JasperChang
556687661c Create palette preview for color correction.
Bug: 145968068
Test: make RunSettingsRoboTests ROBOTEST_FILTER=PaletteListViewTest
Test: make RunSettingsRoboTests2

Change-Id: If624c8ab5b6c212b5a3ad97ceac57404d34b9deb
2020-01-07 10:15:32 +08:00
jasonwshsu
8ef01d25fb Accessibility shortcut secondary action - save and restore shortcut key
- Implement onCheckboxClicked() to save shortcut key
- restore shortcut key when onViewCreated()
- Use preferredShortcutType to handle settings key

Bug: 142530063
Test: make -j52 RunSettingsRoboTests ROBOTEST_FILTER=AccessibilityUtilTest
Change-Id: Iabe636641968d346e52becea19b6e201ea5bc1fb
2020-01-06 13:56:48 +08:00
Jason Hsu
bda73ed270 Merge "Accessibility shortcut secondary action - auto hide divider in shortcutPreference" 2020-01-02 07:15:55 +00:00
menghanli
a5d8e12766 Support accessibility shortcut secondary action (6/n)
Implements new edit shortcut dialog selection and save what user
prefered key back for color inversion, color correction, magnifiction,
downlaoded service - LEGACY, INVISIBLE, INTUITIVE case.

Bug: 142530063
Bug: 142531156
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilityUtilTest
Test: make RunSettingsRoboTests2
Change-Id: I94607db918047ae4082457dd33f17c8675934e2c
2019-12-31 17:42:06 +08:00
jasonwshsu
a2cf6a1313 Accessibility shortcut secondary action - auto hide divider in shortcutPreference
- Hide divider when settings view is gone.

Bug: 142530063
Test: manual
Change-Id: I07c9aa628c4e300d1fd21fe5b87c18ff1c294e17
2019-12-31 12:12:49 +08:00
Menghan Li
7cbba20eec Merge "Fix CodeInspectionTest for CaptionPropertiesFragment" 2019-12-27 02:32:13 +00:00
Jason Hsu
24af3f4c81 Merge "Accessibility shortcut secondary action - divide different fragment for different fragment type" 2019-12-26 13:42:17 +00:00
menghanli
4a1617e44f Fix CodeInspectionTest for CaptionPropertiesFragment
Bug: 146883790
Test: make RunSettingsRoboTests2
Change-Id: I387149fa720c9c98291c00c63f99dc4d838c06aa
2019-12-26 20:56:14 +08:00
Raff Tsai
1c0358aca4 Merge "Support caption second UI structure (2/n)" 2019-12-26 10:01:08 +00:00
ChenJean
f55c5a44f1 Support caption second UI structure (2/n)
Group text size and style into appearance page.
Move language under more options page.

Bug: 143502915
Test: Maunal
Change-Id: Ice104ed844dc3a10a22c91a10211a8978da68cc3
2019-12-26 15:19:21 +08:00
menghanli
b7306044c9 Create settings for color inversion (2/n)
Provide a setting for new color inversion design.

Bug: 146019226
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ColorInversionPreferenceControllerTest
Test: make RunSettingsRoboTests2
Change-Id: I1d081c6321ee96d48e8f52304893e4a5fb59333a
2019-12-26 06:39:44 +00:00
jasonwshsu
3d94a57d97 Accessibility shortcut secondary action - divide different fragment for different fragment type
Different accessibility service fragment type have different UI.
- AccessibilityServiceFragmentType.LEGACY will use LegacyAccessibilityServicePreferenceFragment
- AccessibilityServiceFragmentType.INVISIBLE will use InvisibleToggleAccessibilityServicePreferenceFragment
- AccessibilityServiceFragmentType.INTUITIVE will use ToggleAccessibilityServicePreferenceFragment

Bug: 142530063
Test: Manual
Change-Id: Ib32a4f97514450e5c0d29e99c22935efecf8b6df
2019-12-26 11:40:11 +08:00
TreeHugger Robot
69a59c9895 Merge "Settings search - Navigate user to exact page" 2019-12-25 08:13:17 +00:00
Menghan Li
3b87b777b0 Merge "Remove all "Tapping Stop will stop x" dialog while turning off an accessibility service" 2019-12-25 01:29:00 +00:00
Edgar Wang
08f2a58459 Settings search - Navigate user to exact page
- remove duplicate index preference
- default set searchable = false when the preference has fragment
- make some fragments indexable

Bug: 143057584
Test: robotest & manual

Change-Id: I4d64f6106d2f92f0a45e8c7e26388677f593f412
2019-12-24 21:04:11 +08:00
menghanli
f74f3061e3 Remove all "Tapping Stop will stop x" dialog while turning off an accessibility service
Bug: 146539308
Test: make RunSettingsRoboTests2
Change-Id: Ib3124aea307e42e648ba8d3f561dadb2901c06e5
2019-12-24 02:45:45 +00:00
jasonwshsu
0dd53520a5 Accessibility shortcut secondary action - improve shortcutPreference
1. Use setWidgetLayoutResource() for the controllable widget at the
right side.
2. Improve listener structure.
3. Extend checkbox clickable area.

Bug: 142530063
Test: make -j52 RunSettingsRoboTests ROBOTEST_FILTER=ShortcutPreferenceTest
Change-Id: Iebb9f62653914a0d7200c627f01cf7953d576960
2019-12-24 10:37:55 +08:00
menghanli
756104417a Create settings for window magnification (2/n)
Provide a setting for new Magnify area feature and joystick controller

Bug: 146019459
Bug: 146473544
Test: make RunSettingsRoboTests ROBOTEST_FILTER=MagnificationModePreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=MagnificationWindowControlPreferenceControllerTest
Test: make RunSettingsRoboTests2
Change-Id: Ia32fa073c59ad304e9ef9eb530ba37dd24c2f2f6
2019-12-19 18:08:10 +08:00
Kevin Chang
ea3d3520c3 Support accessibility shorcut secondary action (4/n)
Replace metrics constants of different edit dialogs.

Bug: 142531156
Test: Maunal
Change-Id: I52b3d481d815edab17b954283ae5e366723a842c
2019-12-18 16:37:14 +08:00
Kevin Chang
4fc76cb17d Merge "Support accessibility shorcut secondary action (3/n)" 2019-12-18 03:17:34 +00:00
Kevin Chang
e65ed3ebb0 Support accessibility shorcut secondary action (3/n)
Combine the UI with both shortcut preference and edit dialog.

This CL only contains UI and related connections.
Related logic implementation will be added in next CL.

Since the drawable resources are not ready, put the mock
drawables as temporary. Once the drawbles are provided by UX,
create a CL to replace the related resources.

Bug: 142530063
Bug: 142531156
Test: Maunal
Change-Id: I21e4c6e99c2d1731c15d7c9553594160b8809eb5
2019-12-18 09:25:16 +08:00
Stanley Wang
96dc223f0c Merge "Index Caption preferences page" 2019-12-17 10:20:02 +00:00
menghanli
657189062f Color correction improvement (3/n)
1. Add summary in accessibility settings page by controller
2. Fix "XmlControllerAttributeTest" for ColorCorrection

Bug: 145968068
Bug: 146319816
Test: make RunSettingsRoboTests2
Change-Id: Ia4dfb2290953eea33c266bd9f7c825c956bcc93a
2019-12-17 13:44:40 +08:00
Stanley Wang
5b580d5d00 Index Caption preferences page
- Add indexable raw data.
- Add dynamic indexable raw data.

Fixes: 146390416
Test: make RunSettingsGoogleRoboTests -j & manual
Change-Id: Ic48b05b5ee74518f944e4d1ef1b19122ceb484dd
2019-12-17 11:35:19 +08:00