Commit Graph

49033 Commits

Author SHA1 Message Date
TreeHugger Robot
e78e2061f1 Merge "Fix Wifi-Detail page colors" 2018-11-30 21:45:20 +00:00
Matthew Fritze
c14316c4a9 Update SettingsPanel UI
UI changes include:
- RecyclerView to host slices
- Font family to headline font
- Title is now centered
- Added SeeMore & Done buttons
- Horizontal Dividers between slices
- Indented Slices
- Landscape layout is fullscreen

Change-Id: I3549c847fc88edd81f670ddfa2907dd3741441e0
Screenshot: https://screenshot.googleplex.com/RzWktzOZJkc
Test: Robolectric
Test: Manual app
Bug: 118622007
2018-11-30 13:26:50 -08:00
Sunny Shao
86b1c7d0b1 Refined the Search Bar layout
Removed the background color of the search bar.
Set the background of the AppBarLayout as transparent.
Set the app bar height.

Bug: 118886724
Test: manual review
Change-Id: I7faedc693ce61d5a5237e8a72909b77b56268a4c
2018-11-30 12:00:15 -08:00
TreeHugger Robot
6334cfa89e Merge "Remove the 2 seconds wait time to sync app data usage list." 2018-11-30 19:58:05 +00:00
TreeHugger Robot
886cf1faac Merge "Update string for "Reset" screens" 2018-11-30 17:42:38 +00:00
Edgar Wang
47610f149a Update string for "Reset" screens
- Update "Reset phone" to "Erase all data"

Change-Id: I410fb4916ae9b0234b47d5a35a038d280b24fe0b
Fixes: 79172587
Test: robotests & visual
2018-11-30 20:26:35 +08:00
Yanting Yang
b8850fc679 Fix NPE in slice data generation
NPE will be occurred when clients gives invalid slice uri for Settings.
We have defined some rules in getPathData() and it will return null
object when the invalid uri was given. NPE will be happened in next.

Change-Id: I6ebadd4383aee6e69b1c2eb6c84071c961fd72a7
Fixes: 120259627
Test: robotests
2018-11-30 20:25:22 +08:00
chen xu
54d5a727c1 address API council feedbacks for Telephony.Carriers
Bug: 118296421
Test: telephony unit test
Change-Id: Idf8bcad4fe9d765a73563e9b0c1c659175835447
Merged-in: Idf8bcad4fe9d765a73563e9b0c1c659175835447
2018-11-29 23:20:13 -08:00
chen xu
3b76d0f9ef address API council feedbacks for Telephony.Carriers
Bug: 118296421
Test: telephony unit test
Change-Id: Idf8bcad4fe9d765a73563e9b0c1c659175835447
2018-11-29 23:13:18 -08:00
cosmohsieh
c393fc1fe7 Create WiFi MAC randomization icon
Preference icon for WiFi MAC randomization

Bug: 117192879
Test: Visual
Change-Id: Ifafa801ad96df16c5d96da847dd45bbbc16f4a1f
2018-11-30 14:00:21 +08:00
TreeHugger Robot
0173c5f532 Merge "Bump string length limits" 2018-11-30 05:05:26 +00:00
Stanley Wang
4feb4bb8af Merge "Fix adaptive brightness not appearing in Settings search" 2018-11-30 03:23:13 +00:00
Raff Tsai
1ad5c9805a Merge "Add log feature" 2018-11-30 02:58:38 +00:00
Arc Wang
6f8dc162df Merge "Upload basic UI files for Wi-Fi DPP Settings development II." 2018-11-30 02:48:53 +00:00
Fan Zhang
53f75f0df9 Move all custom slice uris to a registry class.
Change-Id: I192320f95ac81d14c8891ce2531d603912e59f56
Fixes: 119776308
Test: robotests
2018-11-29 16:41:21 -08:00
John Reck
134332fafa Bump string length limits
Bug: 119882754
Test: strings can be longer
Change-Id: I9545387639166ba6150d8a9d8e99c9ea9cd03e24
2018-11-29 16:00:08 -08:00
Raff Tsai
da7a5d1171 Add log feature
- Add ContextualCardFeatureProvider to handle card interaction

Bug: 79698338
Test: manual
Change-Id: I2a76f5ccfd07072a98ee927bed7dc39731d4cb09
2018-11-30 06:41:22 +08:00
Fan Zhang
154f34a35e Merge "Update the strings of conditional cards" 2018-11-29 21:56:56 +00:00
Doris Ling
d13b50b39e Remove the 2 seconds wait time to sync app data usage list.
- in v2, completely remove the asyn task to force update the network
stats since the network stats apis is actually not used.
- in v1, remove the 2s delay and only update the list when the asyn task
is done.

Change-Id: I10e887022d07fe38504036cbf3f12362eec939b3
Fixes: 119562454
Test: manual
2018-11-29 13:18:21 -08:00
Fan Zhang
8e14ca0058 Remove obsolete logic in SettingsActivity.
mIsShowingDashboard is always false, it used to be true when we are
displaying homepage, but now homepage is hosted in a entirely different
activity.

so all related logic can now be removed.

Test: robotests

Misc clean up: remove unused colors

Test: rebuild, color-lint
Change-Id: I1e1628c1e9606c2b7dc40ef3c21d4ed1391a8c03
2018-11-29 11:37:00 -08:00
Salvador Martinez
807d3d98ec Fix Wifi-Detail page colors
There were some hardcoded colors in this page that should have
been using colorControlNormal. This CL just updates it to use those.

Test: Visual inspection
Fixes: 37628554
Change-Id: I431744e7613eeb0ac751cf1505bcf2ef9e19d95d
2018-11-29 11:17:38 -08:00
TreeHugger Robot
662b209b15 Merge "Connect button should have correct icon" 2018-11-29 18:01:53 +00:00
TreeHugger Robot
91ff3491db Merge "Set min height of zen radio button to 48dp" 2018-11-29 15:09:30 +00:00
Michal Karpinski
642ff61147 Add a developer option to allow all background activity starts
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AllowBackgroundActivityStartsPreferenceControllerTest
Bug: 110956953
Change-Id: I45db536d8a60aa6c3a81c01b93ff8e13bf52a77b
2018-11-29 11:20:46 +00:00
Stanley Wang
da296233bc Fix adaptive brightness not appearing in Settings search
Change-Id: I33ed525b3c051a982869114754bd3b7423b61d22
Fixes: 117449384
Test: manual
2018-11-29 18:56:39 +08:00
Edgar Wang
133c73f5f7 Update icon color for "Accessibility" and "Support & Tips" for Dark mode
Change-Id: I874354f3eb669b36822a3fac7e9160ac19d65d35
Fixes: 119785748
Test: robotests & visual
2018-11-29 15:48:11 +08:00
TreeHugger Robot
d949f7d02a Merge "Remove WifiDetailPreference." 2018-11-29 07:43:15 +00:00
tmfang
fe03fa546a Connect button should have correct icon
Test: visual
Change-Id: I3688a309a538112c60f5d6084c774c08a2ac05d5
Fixes: 119758987
2018-11-29 15:21:27 +08:00
Arc Wang
f5d6089d35 Upload basic UI files for Wi-Fi DPP Settings development II.
Add 3 fragments:

  WifiDppQrCodeGeneratorFragment
  WifiDppChooseSavedWifiNetworkFragment
  WifiDppAddDeviceFragment

Bug: 118797380
     118797202
     118794978
     118796825
     118794858
Test: atest WifiDppConfiguratorActivityTest
      atest WifiDppQrCodeScannerFragmentTest
      atest atest RunSettingsRoboTests

Change-Id: I2fbc2f46f941d49b63e4ac74d92f94bf617d2b9b
2018-11-29 07:11:29 +00:00
TreeHugger Robot
d4fc724f95 Merge "Add contextual card feedback email mechanism." 2018-11-29 03:43:39 +00:00
TreeHugger Robot
f22268c854 Merge "Fix conditional cards disappeared from contextual homepage" 2018-11-29 03:31:50 +00:00
Bill Yi
03812c93d1 Merge pi-qpr1-release PQ1A.181105.017.A1 to pi-platform-release
Change-Id: I120adda515fd4891b6b9b68e93cef5555951bacc
2018-11-28 18:34:54 -08:00
Yi-Ling Chuang
68f37a19ae Add contextual card feedback email mechanism.
When users dismiss a card, ask them for feedback.

Bug: 113783548
Test: robotests
Change-Id: I4f53f89ff8377b0dae8c1fc13c6e474456f90c2f
2018-11-29 10:10:57 +08:00
Mill Chen
e44d953a25 Fix conditional cards disappeared from contextual homepage
This symptom only occurred in the case of more than 3 conditional cards
and no suggestion cards in homepage. It is caused by incompletely keeping
conditional cards. So adding missing card types makes conditional cards
be kept correctly.

Bug: 120115919
Test: robotest
Change-Id: Ic67c0a813de4f966c164bf92e4d4d64debcf95be
2018-11-29 10:00:13 +08:00
TreeHugger Robot
2315e7b74e Merge "Visual update: remove card elevation for homepage cards." 2018-11-29 01:49:22 +00:00
Fan Zhang
2183027073 Merge "Remove TODO item from ContextualCardsAdapter in homepage" 2018-11-28 23:17:05 +00:00
Doris Ling
52552ab0ab Remove WifiDetailPreference.
- use the standard Preference instead to display the wifi details, and
enable sumary copying for the preferences under Wifi Network details.

Change-Id: I5371ac667d9239276f6492896123d617f5193871
Fixes: 62493282
Test: make RunSettingsRoboTests
2018-11-28 15:06:58 -08:00
Doris Ling
077d75697c Merge "Enable copying for some settings preferences." 2018-11-28 23:03:33 +00:00
Josh Hou
170afc4827 Merge "Refine APN fetching logic" 2018-11-28 22:24:35 +00:00
Christine Franks
bce91d9418 Move color management check to ColorDisplayManager
Bug: 111215474
Test: make RunSettingsRoboTests -j100
Change-Id: I8ab675a49e119014e59fcfdb61fcd9253e8c0da1
2018-11-28 13:09:47 -08:00
Fan Zhang
eba6143a05 Add an res id to scrollable view to help with testing
Change-Id: I9851c808866c0d82da354f2c7918ae53cc68ea64
Fixes: 120145871
Test: rebuild
2018-11-28 12:58:14 -08:00
Doris Ling
74f7b307b0 Enable copying for some settings preferences.
- add enableCopying attribute to app version, wifi ipv6 address, and
other preferences in About Phone settings.

Bug: 62493282
Test: manual
Change-Id: I6ff0848909ec6ade6605967116bf3178ab069c32
2018-11-28 12:25:39 -08:00
Fan Zhang
a60652a973 Visual update: remove card elevation for homepage cards.
- Replace CardView with MaterialCardView
- Add strokeColor and strokeWidth to MaterialCardView
- Set cardElevation to 0dp.

And remove a few unused layout, clean up color lint whitelist.

Test: rebuild, visual
Change-Id: I34a4b9a985cb85c212e123b8af5353d8c548923a
2018-11-28 10:42:00 -08:00
Beverly
c4b72388b0 Set min height of zen radio button to 48dp
Test: manual using accessibility scanner
Change-Id: I5fd92a3420bca2b3eb371241ef2ee463f9f27009
Fixes: 119585103
2018-11-28 11:31:50 -05:00
Mill Chen
8552458b7e Update the strings of conditional cards
Bug: 113451905
Test: visual
Change-Id: I023e005a0a913981f0e0445fa42b7a76b51d3021
2018-11-28 20:33:08 +08:00
Mill Chen
d780928149 Remove TODO item from ContextualCardsAdapter in homepage
Bug: 114009676
Test: rebuild
Change-Id: I57138d766d75c717189c81ddab21503bd1cb9471
2018-11-28 19:32:10 +08:00
Cosmo Hsieh
59099f19cb Merge "Add NetworkRequestDialogActivity" 2018-11-28 05:59:11 +00:00
TreeHugger Robot
0237c3cd48 Merge "Expand more buttons for ActionButtonPreference" 2018-11-28 05:09:47 +00:00
tmfang
15f2fe9551 Expand more buttons for ActionButtonPreference
Old design, we only need two action buttons in Settings app.
In the future, we need four buttons for some use cases.

Test: visual, robotest
Bug: 120005054
Change-Id: I859fee8d7167ce59222059cc441e4a3c167c7b34
2018-11-28 10:24:07 +08:00
TreeHugger Robot
926571dc29 Merge "Hide the SelfAvailablePreference if it is not available." 2018-11-28 00:51:17 +00:00