Commit Graph

3827 Commits

Author SHA1 Message Date
Mill Chen
747597c72a Make Reset Wi-Fi, mobile & bluetooth scrollable
After setting both font size and display size to largest and enabling
collapsing toolbar, the content in this page will be out of screen
and be unable to scroll. Updating ScrollView to NestedScrollView can fix
this kind of issue since ScrollView can't work with CoordinatorLayout.

Bug: 178458729
Test: visual verified
1) Set font size and display size to largest
2) Navigate to Settings -> System -> Reset options -> Reset Wi-Fi mobile
& bluetooth
3) Observe and check if the content area is able to scroll.

Change-Id: I63451b99c6caa9283a45499e1374a58ccc224bfb
2021-02-27 04:06:20 +08:00
Ryan Lin
296c42e4ce Merge "Add uninstall option in the capabilities confirm dialog" into sc-dev 2021-02-24 13:12:45 +00:00
TreeHugger Robot
588c4e1508 Merge "[Bug] Private DNS shows odd message about Bluetooth" into sc-dev 2021-02-24 13:03:13 +00:00
Tim Peng
8467b9f484 [Bug] Private DNS shows odd message about Bluetooth
-Private DNS dialog uses preference_widget_dialog_summary
layout. It is wrong to set Bluetooth string for it.
-Remove default string from preference_widget_dialog_summary
-Set the customized string in BaseBluetoothDialogPreference

Bug: 179329046
Test: manual test
Change-Id: I749647f48e4bba7d4d0f9099d1c40d788778c15e
2021-02-24 14:21:38 +08:00
ryanlwlin
4806a38516 Add uninstall option in the capabilities confirm dialog
Uninstall option is visible only when the application of the
service is not system App. It provides an efficient way to
uninstall the App if users are shocked with the perimssions
they need to grant.

Bug: 176877955
Test: Install an App with AccessibilityService and uninstall
it with this option.

Change-Id: I6b60cc56d8d34c2983458a676b500035551ec9df
2021-02-23 20:43:27 +08:00
Stanley Wang
86cc0579f3 Replace the SwitchBar with MainSwitch.
- Update wi-fi calling switch.
- Update the switches in Accessibility

Fix: 178673860
Fix: 177968565
Test: Run robotest and apply the widget in Settings and see the ui
Change-Id: Id10e6a110f418ea500a2eaf3c54752bef4f36507
2021-02-23 16:21:52 +08:00
Mill Chen
2ad549e13a Update FingerprintEnrollEnrolling for UDFPS
The BC theme didn't work in the fingerprint enrollment page since this
page was using a customized layout and wasn't following the SUD
template. Also the fingerprint sensor icon has been moved to SysUI so
it's unnecessary to have the customized layout.

This CL is trying to merge two layouts together and make BC theme apply
to the fingerprint enrollment page.

Bug: 177026664
Test: visual verified
Change-Id: Ia22ea14244cd4b508a1fa6341aa15bd741c195f4
2021-02-20 16:58:32 +08:00
TreeHugger Robot
fcdd955dff Merge "Restructure app info page" into sc-dev 2021-02-18 11:03:38 +00:00
Kevin Chyn
2eca234af7 Remove UDFPS ProgressBar from Settings
Moving it to SystemUI, which handles rotation and position calculation
much easier.

Bug: 177965281
Test: manual
Change-Id: I9b7aadce95aae26330192074295d91283e49a24d
2021-02-05 18:37:35 -08:00
TreeHugger Robot
26ffb4d3d6 Merge "Fix the scrolling problems in homepage" into sc-dev 2021-02-05 03:22:26 +00:00
Jason Chiu
530bee333b Fix the scrolling problems in homepage
- Remove the deprecated API and parameter usages of setting system ui
  visibility, which make the app bar scrolling behavior abnormal when
  the navigation bar is enabled.
- Remove the duplicate navigationBarColor of the homepage theme since
  Theme.Settings has configured it.
- Remove the unused scroll flags in search bar layout since its parent
  is no longer AppBarLayout.

Test: visual, robotest
Fixes: 178497625
Fixes: 179122861
Change-Id: I91537cff4f3d98e4bc31e6e42d23895df312fbd4
2021-02-05 02:52:43 +00:00
Mill Chen
d072e8501a Restructure app info page
When the collapsing toolbar is applied in the Settings app, some pages
they used manage_applications_apps will have the collapsing toolbar not
work properly. This was caused by using multiple CoordinatorLayout and
AppBarLayout in these pages.

Bug: 177375909
Test: visual verified
Change-Id: Ibfeeab9cf907a23d18ee1ec2c450c523316cfc92
2021-02-04 18:53:44 +08:00
Weng Su
7a62ab1fff [Provider Model] Internet Panel - Airplane mode is on
- Add "Airplane mode is on" to sub-title
  - Set the header layout to CENTER_HORIZONTAL if it's no icon

- Hide "Settings" button

- Screenshot
  https://screenshot.googleplex.com/6m5dFVZu7ar4nKW

Bug: 178717651
Test: manual test
atest InternetConnectivityPanelTest \
      PanelFragmentTest \
      ProviderModelSliceTest

Change-Id: I899a817fd99415e9cad608aa4deac1e45365696a
2021-02-04 18:48:34 +08:00
Stanley Wang
10b7a7d483 Use MainSwitchPreference to replace the button style switches.
Fix: 177967926
Fix: 177968295
Fix: 177967925
Fix: 177968078

Test: Run robotest and apply the widget in Settings and see the ui
Change-Id: Ie854de96e5495fa564fb8a097ed4547bbd2b10c5
2021-02-02 08:39:37 +00:00
Jiashen Wang
428273765b Merge "Slot Change Receiver Migration" into sc-dev 2021-02-01 23:57:09 +00:00
Jason Chiu
8863015827 Fix the suggestion button distortion
- The button is distorted when setting font/display size to largest.
- Auto resize and limit the max lines of the header so that the button
  won't be squeeze to the bottom.

Fixes: 178459387
Test: visual, robotest
Change-Id: I491be5c3d70c643244fa989324e828774e15b34d
2021-01-29 17:06:43 +08:00
Jiashen Wang
b54d25ee13 Slot Change Receiver Migration
Implemented slot change cases when pSIM is inserted and removed.
Bug: 153811431
Bug: 170508680
Test: Manually tested

Change-Id: Ib0a96da1d7d702f7c64e75b929c73b8548f8e459
2021-01-28 14:15:53 -08:00
TreeHugger Robot
3b61be8766 Merge "Adjust margin to fix title overlapped with arrow" 2021-01-26 08:17:34 +00:00
Mill Chen
01a48cdf3e Adjust margin to fix title overlapped with arrow
When both display size and font size are changed to largest option, a
word in the title of subsetting page will probably be wrapped into
multiple lines. Update the margin end of expanded title to prevent from
wrapping a word into multiple lines.

Fixex: 177969094
Test: visual verified
1) Enlarge both display size and font size as largest
2) Settings -> Display -> Lock screen -> Tap to check phone
or
Settings -> Notifications
3) Observe these titles of pages

Change-Id: Icecdf912e4764cb4592ff460cbc12cc1a7dd6b48
2021-01-25 16:56:39 +08:00
Jason Chiu
b56ea7e9e3 Adjust homepage styles and layouts
- Fine tune the header text size and position
- Fix the header overlapping problem on the homepage and collapsing
  toolbar pages when configuration changes by adding android:id.
- New AppBarScrollingViewBehavior for the homepage to avoid manually
  offsetting the IA
- Correct the formula of counting search box height

Test: robotest, manual
Fixes: 177967923
Fixes: 177968564
Change-Id: Id3ed44f4296fa2a19d6890b009d3881a5c140bbd
2021-01-22 13:27:22 +00:00
Abel Tesfaye
fc2582c0ea Merge "Correct Wifi Share UI margins and capitalization" 2021-01-19 20:00:49 +00:00
TreeHugger Robot
544310993e Merge "Update FingerprintEnrollFindSensor for UDFPS" 2021-01-19 17:51:32 +00:00
Mill Chen
057ce4055e Update FingerprintEnrollFindSensor for UDFPS
Since the education page of UDFPS is different from the one for rear
fingerprint, it's necessary to create a new education page for UDFPS and
update the decription.

Bug: 177026524
Test: visual verified
Change-Id: I70eb80484cccfbb583c32dbaadbc6c2744b5db60
2021-01-20 00:01:35 +08:00
Weng Su
598934d645 [Provider Model] Add Fix connectivity toggle to Internet Settings
- Add Fix connectivity toggle in menu item

- Show "Resetting your internet..." when recovering

- Screenshot:
  https://screenshot.googleplex.com/BPyRADfNUoPE8Dc

Bug: 172297799
Test: manual test
- make RunSettingsRoboTests ROBOTEST_FILTER=NetworkProviderSettingsTest

Change-Id: I27594d24659ca281e224f86accc20d49514d5001
2021-01-19 06:08:53 +00:00
Abel Tesfaye
cb03fb955f Correct Wifi Share UI margins and capitalization
Test: locally with crosshatch

Bug: 176926579
Change-Id: Ida59174f93ae696e4f2a91c353cf9b1649f1faac
2021-01-15 20:15:45 +00:00
TreeHugger Robot
0cb063c9e4 Merge "Remove redundant toolbar from CollapsingToolbarLayout" 2021-01-15 10:21:38 +00:00
Weng Su
7686bf26dc Merge "[Provider Model] View airplane mode networks button" 2021-01-15 08:32:59 +00:00
Weng Su
ee414fdc81 [Provider Model] View airplane mode networks button
- Airplane mode message
  - WiFi Disable: “Airplane mode is on”
  - WiFi Enabled: “Viewing airplane mode networks”

- “View airplane mode networks” button
  - WiFi Disable: “View airplane mode networks”
  - WiFi Enabled: hide button

- Screenshot
  https://screenshot.googleplex.com/7PuKwaJMLpiDdKh

Bug: 177155647
Test: manual test
- atest ViewAirplaneModeNetworksLayoutPreferenceControllerTest
- make RunSettingsRoboTests ROBOTEST_FILTER=NetworkProviderSettingsTest

Change-Id: I3222cb04a66d07681709cc95b729b5ecdf999298
2021-01-15 07:10:57 +00:00
Mill Chen
7b163e2566 Remove redundant toolbar from CollapsingToolbarLayout
The new material library has been updated to be able to support
android.widget.Toolbar, so the redundant toolbar has to be removed.

Bug: 176882938
Test: visual verified
Change-Id: Ibada6b9d315c14d79e9f9f8015cbb5e00fbeea38
2021-01-15 14:43:30 +08:00
TreeHugger Robot
6987b78782 Merge "Redirect users from Search to Settings with transition." 2021-01-15 06:12:49 +00:00
Stanley Wang
6a824b3535 Merge "Use SettingsLib's MainSwitchBar to replace SwitchBar in Settings." 2021-01-15 02:14:52 +00:00
Stanley Wang
b87ddba6cd Use SettingsLib's MainSwitchBar to replace SwitchBar in Settings.
To log Settings metrics, the MainSwitch extends MainSwitchBar and
replace the SwitchBar in SettingsActivity.

Bug: 175181773
Test: Run robotest and apply the widget in Settings and see the ui

Change-Id: I3add3702e9058ad9192b5172c7cf0e2ccfb55a70
2021-01-14 22:48:31 +08:00
Yi-Ling Chuang
2af2d0bf39 Redirect users from Search to Settings with transition.
Currently there is no transition while redirecting users from Settings
Search result to Settings. This CL gets Shared X-Axis transition applied
to make a better visual experience.

Bug: 177480699
Test: Click on a search result and see the transition.
Change-Id: Iad9b0c1168a939582e2648bc023c1321f9ec8049
2021-01-14 19:07:18 +08:00
Mill Chen
02811e52bd Visual updated for CollapsingToolbarLayout
- Tweak the margin for expanded title
- Increase the height of content scrim
- Enlarge the font size for expanded title

Bug: 177191754
Test: visual verified
Change-Id: I2463aa45cd60de1333b6433310f9bf69f090c958
2021-01-14 15:11:50 +08:00
TreeHugger Robot
83f7895fe3 Merge "Update FingerprintEnrollEnrolling for UDFPS" 2021-01-14 03:30:56 +00:00
Wesley.CW Wang
f3db5cb678 Adjust Battery Saver percentage slide size
- Increase seekbar size to 48dp to fit the GAR requirement
 Screenshots:
     https://screenshot.googleplex.com/72qRevtZXA4PTcg.png
     https://screenshot.googleplex.com/3rJjDRehdsPL8AQ.png

Bug: 157532287
Test: make SettingsGoogleRoboTests
Change-Id: Ibeaec5e09b45bf1145cff1b2515a3f79548a25a5
2021-01-13 18:52:48 +00:00
Kevin Chyn
95ca345b23 Update FingerprintEnrollEnrolling for UDFPS
SysUI is now responsible for showing the fingerprint icon and
circle (when finger is not down). This changes makes slight tweak
so the progress indicator is not covered by SysUI.

Fixes a few corner cases when onConfigurationChange occurs

Bug: 177026664
Bug: 177275693
Test: No effect on existing devices

Change-Id: Id06eab00861878a867804a27f4778f1e3fbd174e
2021-01-12 18:31:13 -08:00
Stanley Wang
57098f4589 Use SettingsLib's MainSwitchPreference to replace the Switches which use
LayoutPreference.

Bug: 175181773
Test: Run robotest and apply the widget in Settings and see the ui
Change-Id: I4588d1fc3004970b174e7c5c5d1aa7745f774985
2021-01-12 23:12:01 +08:00
Tsung-Mao Fang
6c921e5b6c Refine the preference layout for homepage
Based on the Android S design, we update the layout
for homepage.

The scope covers the layout of preference and icons itself.

- Change the icon size for IA items.
- Change the layout spacing of preference.
- Change the margin or search bar.

Test: See the screen and confirm with UX
Bug: 177213699
Change-Id: I985966fdf39a5989d51991aa3c06ea5fd31e8fe2
2021-01-12 12:42:44 +08:00
TreeHugger Robot
b63f537238 Merge changes from topic "settings_collapsing_toolbar"
* changes:
  Disable the title of mobile network
  Add CollapsingToolbarLayout for sub settings
2021-01-12 02:14:38 +00:00
TreeHugger Robot
e732adcd81 Merge "Update ScrollView to NestedScrollView in the font size page" 2021-01-12 02:14:38 +00:00
Mill Chen
1b37291364 Change ScrollView to NestedScrollView for screen size page
To make sure the collapsing toolbar work as usual, we need to use
NestedScrollView instead of ScrollView in the screen size page.

Bug: 176896338
Test: manual test and visual verified
1) Navigate to Settings -> Display -> Display size
2) Change the size on the seekbar
3) Observe and check if the preview window can be scrolled

Change-Id: Ia5bb66ef63b9d9a7713cebddbf6ab6258ff82b8d
2021-01-12 02:56:32 +08:00
Mill Chen
14cfd2f2ca Add CollapsingToolbarLayout for sub settings
Settings app is planning to make toolbar collapsible for next
Android release. This CL is to add a new layout for
CollapsingToolbarLayout in the Settings app and to update the theme
correspondly. This feature will be controlled by feature flag, which
makes Settings app compacitible with the existing layout.

Bug: 174451673
Test: manul test and visual verification
1) Enable the feature and open Settings app
2) Navigate to each sub page and check if toolbar is collapsible

Change-Id: Ibef524bbaa7ae3f0a43db7e40e599f42e009437f
2021-01-11 18:30:20 +08:00
Mill Chen
dda4c34d59 Update ScrollView to NestedScrollView in the font size page
To ensure that the collapsing toolbar work as usual, we need to change
the ScrollView to NestedScrollView.

Bug: 176884647
Test: manual test and visual verified
1) Navigate to Settings -> Display -> Font size
2) Check if the sample text area is scrollable

Change-Id: I1cb8a20f1efd69213e1eaadfe84a53aff9bc640f
2021-01-11 18:00:11 +08:00
TreeHugger Robot
1d4857d8dd Merge "Animate the search bar expansion" 2021-01-08 12:51:38 +00:00
Tsung-Mao Fang
902a3469f0 Animate the search bar expansion
Enable the transition between Settings app and Settings Search

Test: Record the transition video and confirm it.
Fix: 175764903
Change-Id: I95125fba17bbf517feee9a10fd828ff8017f7106
2021-01-08 07:48:54 +00:00
Mill Chen
7dc12ac274 Update the message for FingerprintEnrollIntroduction
Seperate the original message into top info and footer info.

Bug: 176856169
Test: visual verified
Change-Id: I9f79619f84949cd88e1f80024d8689033ab4304a
2021-01-08 01:41:52 +08:00
Jason Chiu
bd854ccd10 Support contextual suggestion
- add a suggestion layout
- add an interface to get fragment in suggestion feature provider
- remove the first preference category of homepage IA to align its top
  with the bottom of the search box

Bug: 173768418
Test: robotest
Change-Id: I784e3eef29ca474c4c89f07b916c6500fabbf7d4
2020-12-27 01:37:30 +08:00
timhypeng
e11b1e6ede Remove panel_slice_slider_row_large_icon.xml
-unused resource

Bug: 175850711
Test: build pass
Change-Id: Ibf344d2c1e54f4aaaa945afbca46e278089e9e01
2020-12-22 04:41:44 +00:00
TreeHugger Robot
0cb322b44e Merge "a11y fix: read emergency numbers as digits, not numbers." 2020-12-16 20:04:54 +00:00