Commit Graph

20944 Commits

Author SHA1 Message Date
Fan Zhang
fc520ee38a Move instantiation-through-reflection method to controller
Bug: 73668763
Test: rerun robotest
Change-Id: If1b263dfd6a8c40f563ce53ce3f368aef5ca5a9f
2018-02-21 11:28:41 -08:00
Fan Zhang
b297abc1fe Minor cleanup in DashboardFragment: remove unused code
Bug: 73668763
Test: n/a
Change-Id: I95afbcf03987123e4ed8b76efbed299a7beb4448
2018-02-21 09:48:50 -08:00
TreeHugger Robot
28188cdd21 Merge "Move xmlParserUtils to core" 2018-02-21 03:34:37 +00:00
TreeHugger Robot
931f305121 Merge "Update suggestion/condition UI" 2018-02-21 03:13:46 +00:00
Fan Zhang
e8afdb819f Merge "Convert VibrationSettings to DashboardFragment." 2018-02-21 02:18:56 +00:00
Fan Zhang
1ac5a01253 Move xmlParserUtils to core
This class is currently used by both search and slice, in the future
will be used by DashboardFragment to build controller list. So the scope
of this class is beyond search now.

Test: rerun robotests
Change-Id: If43ebca065aac31ad24f95a94bfe5be784109605
2018-02-20 17:43:28 -08:00
TreeHugger Robot
46b8ef9b7a Merge "Put Security-related controllers into a PreferenceCategoryController." 2018-02-21 01:08:31 +00:00
Fan Zhang
6ccc81818d Convert VibrationSettings to DashboardFragment.
- DashboardFragment integrates Slices and settings search better than
  SettingsPreferenceFragment, and is more testable.

Test: robotests
Change-Id: I5f73836f94712c03521eac6b3f67964524381078
2018-02-20 16:20:59 -08:00
Fan Zhang
3befdd2c54 Merge "Fix search highlight" 2018-02-20 23:38:46 +00:00
Doris Ling
5b3332547a Update suggestion/condition UI
- reduce top padding for suggestion container
- match condition card corner radius with suggestion card.
- change condition card background color to white
- update suggestion title font from medium to regular.

Change-Id: I0267b37822facf4bd389e2b21c47a1fcf0d00264
Fixes: 70573674
Test: visual
2018-02-20 15:30:47 -08:00
Fan Zhang
72456a9ea6 Fix search highlight
- Fragments should not have advanced button when coming from search.

Change-Id: I10a192216b7ff702e73b791acbcc1eb1d71cb407
Fixes: 73348428
Test: robotests
2018-02-20 13:19:26 -08:00
TreeHugger Robot
c26ea56fe4 Merge "Get rid of direct usage of Utils.onBuildStartFragmentIntent" 2018-02-20 21:03:04 +00:00
Fan Zhang
e5b8a5b24f Merge changes I34732bdb,Ieafd3be6
* changes:
  Remove some unused code
  Remove unused slice metadata
2018-02-20 20:02:29 +00:00
TreeHugger Robot
87e71c96ea Merge "Update FakeUid for new methods" 2018-02-20 18:52:24 +00:00
Fan Zhang
deec75fa9d Remove some unused code
Bug: n/a
Test: rebuild
Change-Id: I34732bdbf59d8380bef50f9a5da8b974375ea345
2018-02-20 10:18:54 -08:00
TreeHugger Robot
99b22304c0 Merge "Migrate more places to subsetting launcher" 2018-02-20 17:57:53 +00:00
Fan Zhang
1f6d24a991 Get rid of direct usage of Utils.onBuildStartFragmentIntent
Change-Id: I87eb97d6da4cd4f99be5bcdb1e3e245eb1c7bd1c
Fixes: 73250851
Test: robotests
2018-02-20 09:42:31 -08:00
Lei Yu
32876ff6d2 Merge "Change the order of battery tips" 2018-02-20 17:06:18 +00:00
Narayan Kamath
b61f89d268 Merge "Remove uses of libcore.util.Objects.hashCode / equals." 2018-02-20 13:55:53 +00:00
Fan Zhang
47854c2945 Migrate more places to subsetting launcher
Bug: 73250851
Test: robotests
Change-Id: Iaf29df45ddb42fd58f181cb01e10998a97cb7c34
2018-02-19 14:21:05 -08:00
Fan Zhang
be45f9c865 Migrate more settings to SubSettingsLauncher
Bug: 73250851
Test: robotests
Change-Id: I4100bef20e2ed477e4e31c9b7816f1b03f3f2809
2018-02-19 13:36:57 -08:00
Narayan Kamath
facb59a13f Remove uses of libcore.util.Objects.hashCode / equals.
Use public API in java.util.Objects instead.

Test: make
Change-Id: I2644164cc8ae5a6a25339abf7f2ed6e1c428c4ac
2018-02-19 14:09:56 +00:00
Fan Zhang
b1d6c76b53 Migrate more settings to SubSettingLauncher
Bug: 73250851
Test: robotest
Change-Id: Ifc27b90d68bf4a907f169e19338e9b52ea5f9922
2018-02-18 21:10:03 -08:00
Fan Zhang
7cf99f5f12 Migrate more settings to use SubSettingsLauncher
Bug: 73250851
Test: robotests
Change-Id: I08f6f380489646231d6d8ceb1488e2efb036bf69
2018-02-18 21:10:03 -08:00
TreeHugger Robot
657270aba1 Merge "Allow extras to be passed to app info subscreens" 2018-02-17 03:48:02 +00:00
TreeHugger Robot
feec804395 Merge "Make BatteryDatabaseManager singleton" 2018-02-17 02:33:14 +00:00
Amith Yamasani
7366878829 Update FakeUid for new methods
Bug: 70297451
Test: N/A

Change-Id: I8a9db76c85df2b3e3c5027f52d36914ad338aa35
2018-02-16 16:39:30 -08:00
jackqdyulei
f8ef23b63e Change the order of battery tips
Bug: 72492206
Test: RunSettingsRoboTests
Change-Id: I27b2d5c27fbac2259d9ee483b755ac799dd0de68
2018-02-16 16:37:55 -08:00
Ben Lin
7d5a53f03c Put Security-related controllers into a PreferenceCategoryController.
This way when everything is hidden in security, the whole category is
hidden also.

Bug: None
Test: Robotests
Change-Id: Ib4120975133df7910c5d5229a82d4052364501ac
2018-02-16 15:26:13 -08:00
Adrian Roos
5bc4bdf35c Merge "Use new OverlayManager categories" 2018-02-16 22:47:11 +00:00
Fan Zhang
c85e701b3d Merge changes I1c3620d3,Ic0bf23f6
* changes:
  Move some subsetting launch to SubSettingLauncher
  Migrate more subsetting launching to SubSettingLauncher
2018-02-16 16:58:51 +00:00
Fan Zhang
7334a16a49 Merge "Ignore null value in Account settings summary." 2018-02-16 05:54:03 +00:00
Fan Zhang
9ea3615053 Merge "Refactor Utils.startWithFragment to SubSettingLauncher" 2018-02-16 04:49:41 +00:00
Fan Zhang
3fff7bc35f Move some subsetting launch to SubSettingLauncher
Bug: 73250851
Test: robotests
Change-Id: I1c3620d335eaf99bb110bcbb3e33ff3b2a05f84e
2018-02-15 16:40:06 -08:00
Fan Zhang
615563db0c Migrate more subsetting launching to SubSettingLauncher
Bug: 73250851
Test: robotests
Change-Id: Ic0bf23f6ac6f717bdd3d477fdb84af68badae8e6
2018-02-15 15:39:56 -08:00
Fan Zhang
2ecef333e9 Refactor Utils.startWithFragment to SubSettingLauncher
- Use the new launcher in AccountTypePrefernce for now. Will migrate the
  rest in follow up CLs.

Change-Id: I67aa49f54b39ecea4ecfdc32ccbd827d21fc79b8
Bug: 73250851
Test: robotest
2018-02-15 15:04:04 -08:00
Julia Reynolds
bf3e2243ef Allow extras to be passed to app info subscreens
And pass though some extras through to notification settings.

This enables us to highlight appropriate preferences on the
subscreens while still funneling users through the app info
screen.

Test: make RunSettingsRoboTests
Bug: 72764587
Change-Id: I0197b595fe4bf3504588d9dd2985dd20de73c640
2018-02-15 15:33:23 -05:00
Doris Ling
fc4d46495d Ignore null value in Account settings summary.
If an account type has no valid label, null is returned. Check the value
to make sure that it is a valid label before adding it to the summary.

Change-Id: I0cf3ef9a976e1a7fe16720da237f416c674791fc
Fixes: 73375480
Test: make RunSettingsRoboTests
2018-02-15 10:47:29 -08:00
Fan Zhang
970bacd8cb Remove IA mapping for old connected device page
Change-Id: I201c09facb9e21d452c58ff3d257bdd37e6b854d
Fixes: 69471219
Test: robotest
2018-02-15 10:36:16 -08:00
jackqdyulei
c76bb78758 Make BatteryDatabaseManager singleton
In BatteryTipLoader, two threads may access BatteryDatabaseManager
simultaneously. In this case thread A may close the database thread B
holds, then settings will crash.

In this cl, we make the BatteryDatabaseManager as singleton and
synchronize all the database related method. Then it shouldn't have
the crash anymore.

Bug: 73346734
Test: RunSettingsRoboTests
Change-Id: Ib53b2894b25155cca0c6ec60d1a816663d27a578
2018-02-14 14:24:02 -08:00
Daniel Nishi
da4fa80717 Centralize the automatic storage manager on check.
Bug: 70893105
Test: Existing tests pass.
Change-Id: I83fa0e1033eb530a02eca230d0dd79495cbcbc9d
2018-02-14 11:13:55 -08:00
TreeHugger Robot
956dd9451b Merge "Re-added support for deprecated BIND_AUTOFILL permission." 2018-02-14 17:34:56 +00:00
TreeHugger Robot
d32b62d887 Merge "Handle Looper in PreferenceController" 2018-02-14 17:22:55 +00:00
Adrian Roos
807cf8d2c5 Use new OverlayManager categories
Using this, we split overlays based on their category, so that
cutout emulation and theme overlays no longer clash in their
respective settings.

Bug: 72436677
Test: make ROBOTEST_FILTER=EmulateDisplayCutoutPreferenceControllerTest RunSettingsRoboTests
Change-Id: I23f22113351b3948beb9e3a1fb969700852539cc
2018-02-13 19:13:10 -08:00
TreeHugger Robot
03017fc928 Merge "Don't set USB mode if user is a monkey" 2018-02-14 02:35:10 +00:00
Felipe Leme
b25ffe2c9f Re-added support for deprecated BIND_AUTOFILL permission.
This permission was renamed during the O previews but it was supported on the
final O release, so we need to carry it over.

Test: manual verification
Bug: 70682223

Change-Id: I24b41358fba7449d9216b49aa8b90480906cfb67
2018-02-13 18:09:30 -08:00
Jerry Zhang
9e16092cb3 Don't set USB mode if user is a monkey
Test: tests pass
Fixes: 73246183
Change-Id: I9570c8bd8b11edd6eb0944a4aa766c22b4cc3619
2018-02-13 16:51:21 -08:00
TreeHugger Robot
bee1a6d990 Merge "Introduce config_disable_uninstall_update flag." 2018-02-14 00:33:59 +00:00
TreeHugger Robot
c0850a75e4 Merge "Add summary for hostspot when airplane is on." 2018-02-14 00:14:09 +00:00
TreeHugger Robot
1bbe424e6e Merge "Mark AccessibilitySettings#update methods as protected." 2018-02-13 22:51:32 +00:00