Commit Graph

51381 Commits

Author SHA1 Message Date
Pasty Chang
ee38c9bc1c Update strings for the title of lock screen skip dialog
First letter should be lowercase

Bug: 129870122
Test: Manual
Change-Id: If6ed383cccf56007691ca24d02919b41f1c69281
2019-04-17 04:16:24 +00:00
TreeHugger Robot
f93ca46ea7 Merge "Fix string comment" into qt-dev 2019-04-17 03:36:26 +00:00
Cyril Lee
a60def7db7 Merge "The labels of button in Wi-Fi input and "skip screen lock" dialog doesn't apply GlifV3 style" into qt-dev 2019-04-17 03:20:29 +00:00
Clown SHEN
5466ef6da5 Merge "Retrieve WiFi detail test cases" into qt-dev 2019-04-17 02:48:24 +00:00
Arc Wang
a713243db4 Merge "Hide 'Share' button and 'Add device' preference for a Passpoint Wi-Fi network" into qt-dev 2019-04-17 01:07:12 +00:00
lindatseng
634d8b3ee4 Set max num of slices allowed in panel view
Setup a max allowed num for PanelSlicesAdapter to prevent too
many slices showing in single panel.

Test: Manual verify
Test: atest PanelSlicesAdapterTest
Fixes: 129358092
Change-Id: I7b72a29489e597b8309d74841eaeab0fe42aace6
2019-04-16 17:28:14 -07:00
Kevin Chyn
bf121dd46b Fix string comment
Bug: 130642861

Test: Builds
Change-Id: Ib889b1a69b5225579ffad6f63b0d98ded9841614
2019-04-16 17:02:17 -07:00
Joel Galenson
2102faf3e3 Do not special case the storage permission group.
We are now not showing storage usages in Permission Controller,
including in the API Settings uses.  We can thus remove this code so
that Settings will reflect what Permissions Hub shows.

Bug: 130567526
Test: See the same graph here and in the dashboard.
Change-Id: Iaa7d95b05f4321543ed42833ac3a7babdb9914f0
2019-04-16 15:44:52 -07:00
TreeHugger Robot
e991b05b29 Merge "Check for attention permissions" into qt-dev 2019-04-16 22:02:43 +00:00
joshmccloskey
a104d290de Updated ConfirmDeviceCredential strings
Test: Verified with BiometricPromptdemo that pin/pattern/pass
show up correctly.
Fixes: 129797243
Change-Id: Ib075d6742f7e2ad03e491132ae9506dce67558fc
2019-04-16 14:19:29 -07:00
TreeHugger Robot
cef4e42dc2 Merge "Enforce min value on panel slices slider" into qt-dev 2019-04-16 21:18:05 +00:00
Lei Yu
ad06c36882 Merge "Hide Mobile preference for secondary user" into qt-dev 2019-04-16 20:47:17 +00:00
Quang Luong
0af9b83644 Fixed Passpoint network "Not in range" issue and forget button
Passpoint networks now correctly allow the user to connect and forget
from the saved networks network detail page.

Bug: 130373102
Test: atest WifiDetailPreferenceControllerTest

Change-Id: I6ed2817bb3a1ac657695272ceb9d5e3f3e944f16
2019-04-16 12:52:25 -07:00
Linda Tseng
71df263db9 Merge "Add entry animation to Settings Panels." into qt-dev 2019-04-16 18:57:47 +00:00
TreeHugger Robot
421ca22a58 Merge "Disable Mobile settings in one condition." into qt-dev 2019-04-16 18:20:11 +00:00
TreeHugger Robot
3b8a0b82bf Merge "Change dark theme screen to toggle" into qt-dev 2019-04-16 18:16:54 +00:00
TreeHugger Robot
03c461b3ee Merge "Hide filter spinner when data is loading." into qt-dev 2019-04-16 18:07:24 +00:00
TreeHugger Robot
b298e2ae6c Merge "Revert "Fix voice access issue on home page"" into qt-dev 2019-04-16 18:02:26 +00:00
Sean Stout
5a8b2cf1dc Merge "Rename ACTION_VIEW_ADVANCED_POWER_USAGE_DETAIL" into qt-dev 2019-04-16 17:47:29 +00:00
Alex Salo
c821ae1ee6 Check for attention permissions
If attention package does not have sufficient permissions - disable the
setting.

Bug: 130246574, 130350903
Test: make RunSettingsRoboTests and manually confirmed
Change-Id: Ia7a86c940522e72f7e895d6aec7500f1ef6f9889
2019-04-16 17:43:15 +00:00
clownshen
5e3261616f Retrieve WiFi detail test cases
1. fix test case failure
2. remove redundant test cases

Bug: 130640128
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi.details.WifiDetailPreferenceControllerTest
Change-Id: Ia59287d7f9adb37a6b56301a2178b6e307fd892d
2019-04-17 01:11:49 +08:00
TreeHugger Robot
75691d29ef Merge "Use android:attr for display font preview layout background" into qt-dev 2019-04-16 17:05:43 +00:00
TreeHugger Robot
1fa45975eb Merge "Clean up NotificationChannelSlice" into qt-dev 2019-04-16 16:31:22 +00:00
lindatseng
fadedb321c Enforce min value on panel slices slider
We did not set the min value on slider slices when converting them
from preference to slices, which makes the slices all have min 0.
However, there are some slider which should have min value greater
than 0, for example, call and alarm.

We should get the min value and apply it to slider slice to make it
consistent with what we have in settings pref.

Test: Manual verification
Test: make -j40 RunSettingRobotests
Test: atest VolumeSeekBarPreferenceControllerTest
Fixes: 130439216
Fixes: 130358208
Change-Id: Ib4399c36c7da3ac41a6d46a6c150f0ec1b9b0b0f
2019-04-16 16:30:08 +00:00
Matthew Fritze
b6fdd25c23 Add entry animation to Settings Panels.
Settings Panels as a dialog have a default animation for entering the
screen, but Slices complicate the animation. While the dialog enters the
screen, Slices begin to bind, thus changing the height of the dialog as
it enters, causing perceived bounce / jank in the animation.

This CL is cherry-picked/based on ag/6671083 but do the following modification:
(See the original commit message for the whole concept)

When trying to load all the Slices, there are few possible situations:
1. Slice starts loading slowly, starting at state LOADED_NONE
2. Slice is loading in progress, having state LOADED_PARTIAL
3. Slice is loaded, but there's error return from the Slice data (We don't
need to show the Slice in this case)
4. Slice is loaded, progress to state LOADED_ALL
5. Slice starts from state LOADED_NONE, but never progress to the next state
because it crashes at setting backend.

Notice that there are two cases that the state will stay at LOADED_NONE and
we can't distinguish them.

Hence, we decide to do the following:

If Slice is with error (case 3) we remove the slice from the list and mark it
loaded.

If Slice is loaded with LOADED_ALL (case 4, which is the ideal case), we mark
it as loaded.

In the other cases, we fire a handler to mark the slice loaded anyway after
250ms timeout.

When all the slices are marked loaded (which should happen after 250ms timeout,
we will animate the panel out.  Although there might be slices which are still
partial loaded, we can still have the slice in the panel once it is ready.
The panel might bounce/jank in this case, but at least it will still showing
correctly, and should show up smoothly in most cases.

The solution to this problem is twofold:
1. Load all Slices first
2. Create a custom animation to draw the panel once the recyclerview has
been laid out.

Test: Manual/Visual inspection
Test: make -j40 RunSettingsRobotests
Bug: 123942159

Change-Id: I639a707aa4ba3f906bd6f9752c92727aaba28142
2019-04-16 16:29:04 +00:00
Fan Zhang
22f3944432 Revert "Fix voice access issue on home page"
This reverts commit 0f3049d4b7.

Reason for revert: b/129456622
Fixes: 129456622
Test: rebuild

Change-Id: Ic883722a9ebe6a2905067dc9cc503c9878acd2fc
2019-04-16 09:27:49 -07:00
TreeHugger Robot
77c56714ed Merge "Tint battery fix icon" into qt-dev 2019-04-16 16:25:34 +00:00
Fan Zhang
957da73a7d Merge "Correct the state when prevent ringing page is launched." into qt-dev 2019-04-16 15:22:26 +00:00
Fan Zhang
cae16fa07b Merge "Update switchbar background color in disabled state." into qt-dev 2019-04-16 15:19:25 +00:00
TreeHugger Robot
c4e7cf594c Merge "Create TintDrawable in Settings." into qt-dev 2019-04-16 15:16:26 +00:00
Yanting Yang
ce3359f4d4 Clean up NotificationChannelSlice
- Remove unused variable.
- Change function interface.

Bug: 123065955
Test: visual, robotests
Change-Id: I39c0a92539d45cdbc11bd9090a3ab97a72482632
2019-04-16 23:08:40 +08:00
TreeHugger Robot
ee6825fd5b Merge "Add remote volume slider conditionally." into qt-dev 2019-04-16 12:46:55 +00:00
Cyril Lee
80d2a3274c The labels of button in Wi-Fi input and "skip screen lock" dialog doesn't apply GlifV3 style
Wi-Fi dialog
https://hsv.googleplex.com/6008335912402944

"Skip screen lock?" dialog
https://hsv.googleplex.com/6299831188324352

Bug: b/112707845
Test: manual test
Change-Id: I27f747268991240faa0970ca4be4ca472f24338f
2019-04-16 11:51:02 +00:00
Chandan Nath
2ec2c6330e Merge "If backup service is not available, remove Settings->Backup and Backup->"Backup is disabled by admin" from search results." into qt-dev 2019-04-16 11:21:10 +00:00
Raff Tsai
006582b48e Tint battery fix icon
Fixes: 129492004
Test: manual
Change-Id: I161284619bc47e342d78f1507ae291f7c23ad3ff
2019-04-16 17:05:52 +08:00
Yi-Ling Chuang
9a7ead8962 Hide filter spinner when data is loading.
When the filter spinner is initialized, set GONE to its visibility.
Only make it visible after network cycle data finishes loading to
avoid presenting an empty filter spinner.

Fixes: 130397929
Test: robotests
Change-Id: I740fdad35ec82bc0be386c24e53348917bf6bfba
2019-04-16 16:53:32 +08:00
Arc Wang
994929ecc7 Hide 'Share' button and 'Add device' preference for a Passpoint Wi-Fi network
Passpoint provisioning is much different from other Wi-Fi networks and ZXing
does not support a QR code format to share a passpoint Wi-Fi network. We
should not show any button to share a passpoint Wi-Fi network.

Bug: 130609037
Test: manual
Change-Id: Ie2538ed9e030e5aa2e88452b50b6592223ca46a8
2019-04-16 16:51:04 +08:00
TreeHugger Robot
01b633275a Merge "Fix problem of multiple stacked copies of "Select SIM" dialog" into qt-dev 2019-04-16 08:30:30 +00:00
cosmohsieh
faede7ceb9 Implement context menu for ConnectedAccessPointPreference
1) User wants to long press ConnectedAccessPointPreference to forget network if this
is a captive portal network.
2) Change context menu string

Bug: 113756562
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi
Change-Id: If5c45c45fe126f627eeb53a6c1873a070ad23ae8
(cherry picked from commit 9f8522565a)
2019-04-16 07:35:36 +00:00
TreeHugger Robot
e128d27a7a Merge "Remove error slice from Settings in rendering time" into qt-dev 2019-04-16 05:20:58 +00:00
Felipe Leme
d51e020cc6 Merge "Change Content Capture strings." into qt-dev 2019-04-16 04:51:24 +00:00
TreeHugger Robot
ad4483c2a2 Merge "Rename screen aware into screen attention" into qt-dev 2019-04-16 03:17:50 +00:00
TreeHugger Robot
83fcc3582e Merge ""Disallow adjust volume" restricted dialog didn't show" into qt-dev 2019-04-16 03:12:41 +00:00
Pasty Chang
997128ee91 Merge "Set WifiDialog to light theme in setup flow" into qt-dev 2019-04-16 02:53:29 +00:00
Salvador Martinez
ef7ce46657 Change dark theme screen to toggle
The dark theme screen has been removed in favor of a simple
toggle with a dialog that shows up the first time a user
tries to enable dark theme when in light theme.

Test: robotests pass
Bug: 130251804
Change-Id: I48f8e24a2b2a117e5a8054c5bc0b240ba68fe1ad
2019-04-15 19:52:49 -07:00
Fan Zhang
12ee53f122 Merge "Clean up DND slice in search." into qt-dev 2019-04-16 02:50:10 +00:00
Edgar Wang
73454f2607 "Disallow adjust volume" restricted dialog didn't show
root casue: VolumeSeekBarPreference & SeekBarPreference will return
false when call isSelectable() then this preference won't perform Click

Fixes: 123745455
Test: Manual & robotest
Change-Id: Iba27b503e8a272260c80bd41aecdd5cdbc39f962
2019-04-16 09:41:07 +08:00
Sean Stout
44eecb7375 Rename ACTION_VIEW_ADVANCED_POWER_USAGE_DETAIL
ACTION_VIEW_ADVANCED_POWER_USAGE_DETAIL is now ACTION_APP_BATTERY_SETTINGS

Test: adb shell am start -a \
"android.settings.VIEW_ADVANCED_POWER_USAGE_DETAIL" -d \
"package:com.google.android.deskclock" --ez \
"request_ignore_background_restriction" 1
Bug: 129901520

Change-Id: Iec103ee46863c05497f9aa53f0ae81b105fdd309
2019-04-15 17:20:02 -07:00
Raff Tsai
000ba3fabe Remove error slice from Settings in rendering time
We filter error slice in EligibleCardChecker but not filter it in
SliceContextualCardRenderer, these two part should use the same
logic.

Fixes:128687331
Test: manual
Change-Id: I217bc6b578ceb36b0a67b44dc8a08ecd02771d82
2019-04-16 07:41:31 +08:00
Mill Chen
13568b6301 Fix wrong color for rippleColor
Fixes: 130328361
Test: visual
Change-Id: Ia72387d3208f3884af229b5de33d0ca675db0213
2019-04-15 15:18:39 -07:00