Commit Graph

20456 Commits

Author SHA1 Message Date
Jordan Liu
9afa720abe Merge "Hide signal strength when told by carrier" 2017-12-04 23:20:31 +00:00
Fan Zhang
cbc97bc7dd Hack to wait for both suggestion/category to load
- This is unfortunately necessary to avoid a jank when category
  load completes before suggestion load, in which case user has to
  manually scroll up to see the suggestions.
- We could technically just add scrollTo(0), but that causes the list
  scroll on its own within 0.5 second of settings start, and that's bad.

Change-Id: I8dc869a69a5bf11bbf7644b281cc1778dd1a90e8
Fixes: 69068691
Test: visual
Test: robotests
2017-12-04 15:06:56 -08:00
jeffreyhuang
c8badc7ceb Display IMEI info when sim is removed
Change-Id: I9c6db4481e9b03c8984d350cd54722a3667b6c49
Fixes: 70165342
Test: make RunSettingsRoboTests -j40
2017-12-04 14:33:58 -08:00
jackqdyulei
e978f8c5b4 Add preference Received files
Given that BluetoothFilesPreferenceController is already
exist, we could reuse this controller and only add
preference to xml.

Bug: 69333961
Test: Screenshot
Change-Id: I11285fd9a2b6c297dbf43a9a0b118c21780e6710
2017-12-04 12:56:20 -08:00
jackqdyulei
d3f314077b Add(copy) AdvancedConnectedDeviceDashboardFragment
AdvancedConnectedDeviceDashboardFragment is the same as
ConnectedDeviceDashboardFagment except for:
1. Bt preference is not MasterSwitchPreference anymore.
2. New Bluetooth file preference.

This cl copies following files:
1. connected_devices_advanced(from *_old)
2. Advanced*Fragment(from *Old)
3. Advanced*Test(from old test)

Future cl will work on differences.

Bug: 69333961
Test: RunSettingsRoboTests
Change-Id: I4a7cb7225482fb8919af95bc5586e3bf0a80b1cb
2017-12-04 12:56:20 -08:00
TreeHugger Robot
d786fc5bdd Merge "Delete deprecated controller" 2017-12-04 18:43:26 +00:00
TreeHugger Robot
312d6c4912 Merge "ZenPreferences observe zen changes from USER_ALL" 2017-12-03 16:24:46 +00:00
Chien-Yu Chen
890c9a7ad3 Merge changes from topic "easel-dev-to-oc-mr1-dev" into oc-mr1-dev
am: fa3af7b0e7

Change-Id: I67347d636270ab4995dcb315c0adc0f67bf82795
2017-12-03 03:28:40 +00:00
Chien-Yu Chen
c8d91c6066 Revert "Revert "Settings: Enable HAL HDR+ by default""
am: 24721e7d96

Change-Id: Iec2832d2ae85edb92576af5688a067b88528fb1a
2017-12-03 03:28:03 +00:00
TreeHugger Robot
2b7c0f2265 Merge "Add controllers for default app shortcut preferences." 2017-12-02 03:12:50 +00:00
TreeHugger Robot
61691b5a4f Merge changes I8ce427ea,If33c3d3a,I579be569,I755c04da
* changes:
  move search test package to sdk 26
  Update accessibilityserviceresult test to sdk 26
  Update IntentSearchViewHolderTest to sdk 26
  fix DatabaseIndexingManagerTest hanging in tests
2017-12-02 01:32:49 +00:00
TreeHugger Robot
2d5aa05f8e Merge "Fix crash for AirplaneModePreferenceController when not available." 2017-12-02 01:30:28 +00:00
Doris Ling
86daa8f4c6 Add controllers for default app shortcut preferences.
For AppInfoDashboardFragment:
- add the default app shortcut preferences into the preference screen
instead of creating them dynamically.
- add controller for each of the shortcut preference.

Bug: 69384089
Test: make RunSettingsRoboTests
Change-Id: I1e81944a3bc867fd6a3a0d484bab77c3ad0e6441
2017-12-01 17:21:49 -08:00
Ben Lin
6c216c06f5 Fix crash for AirplaneModePreferenceController when not available.
Bug: 70043779
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=AirplaneModePreferenceControllerTest passes 1/1.
Change-Id: Ide9e1dda0589414467a4952e67d2e4e39e90845a
2017-12-01 15:39:54 -08:00
jeffreyhuang
285dd79a66 Delete deprecated controller
Test: Compiles
Change-Id: Ie39e412bca703822a98e9ba6045540a4b45870ab
2017-12-01 15:35:22 -08:00
TreeHugger Robot
b5931a6624 Merge "Add preferences in new connected device page" 2017-12-01 23:00:20 +00:00
jeffreyhuang
f28803ec83 Update IntentSearchViewHolderTest to sdk 26
Test: make RunSettingsRoboTests -j40
Change-Id: I579be569a9a56175e45abc329b61cb1b9daf3ac7
2017-12-01 12:32:52 -08:00
jackqdyulei
b79e0d4279 Add preferences in new connected device page
1. Add device preference
2. connection preference

This cl add click action for Add device preference. Action for
connection preference will be added in future cl.

Bug: 69333961
Test: Screenshot | RunSettingsRoboTests
Change-Id: Ifb1afc8371ee45165ea22a7a195a774ba04fdeea
2017-12-01 12:28:15 -08:00
Dianne Hackborn
c383932a8a Update to support long version codes.
Bug: 64459786
Test: manual
Change-Id: I2d4af47f6ace237aa4c37af95d1de97be2870acd
2017-12-01 11:20:45 -08:00
Lei Yu
7e315a937b Merge "Remove the getSwitch() in SwitchWidgetController" 2017-12-01 19:13:56 +00:00
jeffreyhuang
387bffcd46 fix DatabaseIndexingManagerTest hanging in tests
Test: make RunSettingsRoboTests -j40
Change-Id: I755c04daadcb8804d97f72521d84573d80b4ff19
2017-12-01 10:20:18 -08:00
Beverly
71a191c222 ZenPreferences observe zen changes from USER_ALL
Zen manual rule changes are changed by USER_SYSTEM, so Zen Preference
Controllers must register their content observers for zen changes and
zen config changes to USER_ALL instead of just their own user id.

Change-Id: I75194b62ab5e5b21dffbf04bba5009659bb41d81
Fixes: 70028673
Test: make ROBOTEST_FILTER=ZenModeButtonPreferenceControllerTest RunSettingsRoboTests -j40
2017-12-01 13:08:20 -05:00
Chien-Yu Chen
7bae205499 Settings: Remove HAL HDR+ option
Test: RunSettingsRoboTests
Bug: 68223991
Merged-In: I9eb27c7e205ac005c6a71726e125ed1e512da33b
Change-Id: I9eb27c7e205ac005c6a71726e125ed1e512da33b
2017-12-01 08:11:56 -08:00
Chien-Yu Chen
24721e7d96 Revert "Revert "Settings: Enable HAL HDR+ by default""
This reverts commit 781e762c2c.

Test: CTS
Bug: 67590972
Change-Id: I3c1459e432df10d075072e531ef6fc65e3ae4f24
Merged-In: I3c1459e432df10d075072e531ef6fc65e3ae4f24
2017-12-01 08:11:44 -08:00
TreeHugger Robot
e48f75b134 Merge "Convert install app detail to dashboard fragment." 2017-12-01 02:16:26 +00:00
TreeHugger Robot
302bdac10f Merge "Change style of search bar text to allow OEM costomization." 2017-12-01 00:36:42 +00:00
Doris Ling
6eb8877848 Convert install app detail to dashboard fragment.
- first round for changing AppInfoDashboardFragment to inherits from
DashboardFragment instead.
- add controller for Battery, DataUsage, Memory, Notification, Storage,
Permission, Version, and Open by Default settings.

Bug: 69384089
Test: make RunSettingsRoboTests
Change-Id: I60079e5442b4eef46a178e27de96a8635e15ebde
2017-11-30 16:19:28 -08:00
Malcolm Chen
f612f591ee Rename setDataEnabled to setUserDataEnabled.
Test: unittest
Bug: 69814555
Change-Id: I1d43dc1d2f720383a2f0be18560fc0fd4ff349fd
2017-11-30 16:03:16 -08:00
Fan Zhang
e096ae7acb Change style of search bar text to allow OEM costomization.
Change-Id: I78dbe6780e3a4adefe82a36400d9fff8c1de92e3
Fixes: 68814716
Test: visual
2017-11-30 14:51:27 -08:00
TreeHugger Robot
cfcef072d9 Merge changes I7925482b,Ia4ed8863,Ia322a8c9
* changes:
  move gestures package to sdk 26
  Update DoubleTapScreenPrefCtrl to sdk 26
  Update PickupGesturePrefCtrlTest to sdk 26
2017-11-30 22:08:40 +00:00
jackqdyulei
9891b74533 Remove the getSwitch() in SwitchWidgetController
IMHO we don't need to expose switch in SwitchWidgetController.
This controller already has enough API to control the switch.

Also rename mSwitchWidget to mSwitchController because it is not a
widget.

Bug: 69973752
Test: test still pass
Change-Id: I0ac247e34468a44109ab26019f1303c814e381f2
2017-11-30 13:58:57 -08:00
jeffreyhuang
dbb32b86c6 Update DoubleTapScreenPrefCtrl to sdk 26
Test: make RunSettingsRoboTests -j40
Change-Id: Ia4ed886381e2758b7b1523648833fc57ca58a5b3
2017-11-30 12:16:24 -08:00
TreeHugger Robot
06747ef9e8 Merge "Add search menu to all pages" 2017-11-30 20:10:27 +00:00
Fan Zhang
681a4cdd47 Add search menu to all pages
Change-Id: I0910df3d26fe583deb70d7052bde28b64e7844a7
Fixes: 68814716
Test: robotests
2017-11-30 10:43:18 -08:00
jeffreyhuang
3d1acfeab7 Update PickupGesturePrefCtrlTest to sdk 26
Test: make RunSettingsRoboTests -j40
Change-Id: Ia322a8c98760c1074732369d084e6a57a29903af
2017-11-30 10:35:58 -08:00
TreeHugger Robot
2d79a9c34e Merge "Index Nightdisplay Settings into search" 2017-11-30 18:25:29 +00:00
Hemant Gupta
0a86571705 Merge "Bluetooth: Give PBAP permission only if device is AUDIO_VIDEO_HANDSFREE" am: b21a10b2ff am: a84a535729
am: cf2557e8f4

Change-Id: I207d63ade137f41a1ac6d6184f019b0a21cffd9d
2017-11-30 17:45:18 +00:00
Hemant Gupta
cf2557e8f4 Merge "Bluetooth: Give PBAP permission only if device is AUDIO_VIDEO_HANDSFREE" am: b21a10b2ff
am: a84a535729

Change-Id: Ia8ed56e2da6641a107af912efdf497d90c0d43ed
2017-11-30 17:43:08 +00:00
Hemant Gupta
a84a535729 Merge "Bluetooth: Give PBAP permission only if device is AUDIO_VIDEO_HANDSFREE"
am: b21a10b2ff

Change-Id: Id0378b1c410afcc0566652e3308cd812dcd68470
2017-11-30 17:40:31 +00:00
Matthew Fritze
c448863577 Index Nightdisplay Settings into search
Adds a SearchIndexProvider into NightDisplaySettings
to index night_display_settings.xml. It will show
up in search as long as ColorDisplayController
is available.

Also, supress the search result for Night Display
under Display settings in favor of the actual toggle.

Test: robotests
Fixes: 69852201

Change-Id: Id014a5ab03e7a6b5fc99f79a1cb41a0c06323f9c
2017-11-30 08:56:20 -08:00
TreeHugger Robot
4031bc78e4 Merge changes from topic "settings_presubmit_instr_test"
* changes:
  Refactor help menu stuff into a controller
  Fix UniquePreferenceTest
2017-11-30 01:38:33 +00:00
Fan Zhang
e0b0e9f902 Refactor help menu stuff into a controller
This is a clean up to action bar menu item pattern, we will use the same
pattern to build search icon on all pages in a later change.

Bug: 68814716
Test: robotests
Change-Id: Iedd3ec263e8ccb63ed75ec7a95b28c00878b1de4
2017-11-29 15:51:04 -08:00
TreeHugger Robot
64f9275f4f Merge "Fix indexing in cast and zen mode settings" 2017-11-29 22:36:18 +00:00
TreeHugger Robot
211550f596 Merge "Add preference group for saved devcies." 2017-11-29 21:14:14 +00:00
Hemant Gupta
5b84cfae44 Bluetooth: Give PBAP permission only if device is AUDIO_VIDEO_HANDSFREE
Step by step:
1. Pair and connect with BTHS (e.g. SBH50).
2. Click the settings icon of paired device, and check "Use for" items.
-----------------------------------------------------------------
Expected Result:
After step 2, "Contact sharing" should not be checked.

Actual Result:
After step 2, "Contact sharing" is checked.

Fix:
Set phone book permission as REJECTED if class of Device is
not AUDIO_VIDEO_HANDSFREE

Test: Checked above usecase and issue is not observed

Bug: 64372703
Change-Id: I178a09dd9e76d67c461c4b04d9b2ee0078ed24c9
2017-11-29 20:37:05 +00:00
TreeHugger Robot
dbc354113a Merge "Fix ConcurrentModificationException in SummaryLoader." 2017-11-29 19:57:40 +00:00
Patrik Bannura
5a84add99f Hide signal strength when told by carrier
Bug: 69730732
Test: Add different values for two carriers in vendor.xml
and see them change when swapping sim card
Depends-On: I155c8f619a451edab85cf6422cef73e8e1686629
Change-Id: I241ddb3c20002db781308d94c6c165b8d13b2474
2017-11-29 12:18:49 +00:00
TreeHugger Robot
e62023cd1c Merge "Update the usage of getDefaultUserIcon" 2017-11-29 11:13:11 +00:00
Fan Zhang
1ae1e17199 Fix indexing in cast and zen mode settings
- Fragment should either not implement serach provider or return a valid
  xml. Search provider with 0 resource is invalid.

Change-Id: Ie87c739bf72c926cecf48d271c6c2d72459787c4
Fixes: 69864274
Test: robotests
2017-11-28 17:50:15 -08:00
Doris Ling
bcb76351b3 Fix ConcurrentModificationException in SummaryLoader.
When the dashboard summary is being initialized, it will rebuild the UI
while the summary loader tries to to go through the tiles to update the
summary. Both is being done on a separate backgroud thread, and it will
run into concurrent modification issue if the thread is being swapped
while one is looping through the list.

Instead of letting clients access the list of tiles directly, add a
getter method in DashboardCategory to get a copy of the list of tiles
for all read-only operations.

Change-Id: I479669abd8d1d0a8ee9a4113d8ad2244da56f4d8
Fixes: 69677575
Test: make RunSettingsRoboTests
2017-11-28 16:43:07 -08:00