Commit Graph

54129 Commits

Author SHA1 Message Date
Matías Hernández
3cd8fc86e1 Add "rename" option to 3-dot menu
(And remove the segmented buttons).

Fixes: 346278854
Test: manual
Flag: android.app.modes_ui
Change-Id: I6d45ba91cc400e5f3f01245c315cc5f0322c3bb1
2024-07-10 00:44:32 +00:00
Julia Reynolds
f9ce78e87b Merge "Create a new link preference for priority modes entry" into main 2024-07-09 13:17:06 +00:00
Treehugger Robot
b519dc9f32 Merge "Fix display problem in the freeform mode" into main 2024-07-09 13:08:55 +00:00
Treehugger Robot
fbfacbb9e5 Merge "FRP bypass defense in App battery usage page" into main 2024-07-09 11:46:46 +00:00
Alina Zaidi
9233fe7b46 Merge "[Dev option] Use DesktopModeStatus and ToggleOverride from wm/shell in Settings DesktopModePreferenceController" into main 2024-07-09 10:04:13 +00:00
Haijie Hong
2e3d477a3f Merge "Add ring indicator for battery level" into main 2024-07-09 08:44:48 +00:00
Yiling Chuang
419a6a9079 FRP bypass defense in App battery usage page
Before the setup flow completion, don't allow the app info page in App battery usage to be launched.

Bug: 327748846
Test: atest SettingsRoboTests + manual test
- factory reset + launch app battery usage app info via ADB during Setup -> verify app closes
Flag : EXEMPT bugfix

Change-Id: I486820ca2afecc02729a56a3c531fb931c1907d0
2024-07-09 08:13:49 +00:00
Matías Hernández
bb41777f87 Merge "Add mode: Choose name and icon for new custom modes" into main 2024-07-09 02:20:07 +00:00
Alina Zaidi
b456e84570 [Dev option] Use DesktopModeStatus and ToggleOverride from wm/shell in Settings DesktopModePreferenceController
Test: Added tests
Bug: 348193756
Flag: com.android.window.flags.show_desktop_windowing_dev_option
Change-Id: I0dc3c62df992a2454bd7c1fc239302489107ae59
2024-07-08 16:07:43 +00:00
Shaowei Shen
76129cbe23 Merge "[Touchpad Setting] Hide Touchpad page when there's no connected one" into main 2024-07-08 03:55:14 +00:00
Matías Hernández
574fcaf1b2 Add mode: Choose name and icon for new custom modes
This also unifies the "icon picker" screen with the new "add mode" screen since in both cases we want to edit name and icon together (and not save updates until the user confirms).

Bug: 326442408
Bug: 346278854
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: I8a9d07ba0b6c55f3abc1b9884f278d51d178dc83
2024-07-06 22:12:58 +00:00
Matías Hernández
606f9b1727 Merge "Use a temporary summary in the "Apps that can interrupt" preference" into main 2024-07-06 10:42:23 +00:00
Matías Hernández
ec376bcfce Use a temporary summary in the "Apps that can interrupt" preference
We load the list of apps in a background thread, so getting that string later was causing the preference to increase in height, with an annoyingly noticeable animation. Having a placeholder test ensures this doesn't happen (and actually loading is pretty fast, so this text lkely won't even be visible).

Fixes: 347744856
Test: atest ZenModeAppsLinkPreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I4f9f60104fb8b0abbc7c4279b87daafac481e98a
2024-07-05 17:36:47 +02:00
Ioana Alexandru
5c642663de Merge "Consolidate statusbar/notification and notification/" into main 2024-07-05 08:35:54 +00:00
shaoweishen
60eae5e01c [Touchpad Setting] Hide Touchpad page when there's no connected one
The option for entering page already has complete check condition.
Update the same check logic to isSeachable in setting page to hide
page when there's no touchpad connected.
Also apply check on trackpadTouchGesture.

Test: verify on device
Bug: 346497646
Flag: EXEMPT bugfix
Change-Id: I1730c7bd1fd2615dc1725ec0cc32293254e5b54a
2024-07-05 08:18:48 +00:00
Sunny Shao
79c69fccd1 Fix display problem in the freeform mode
Fixes: 347373574
Flag: EXEMPT bugfix
Test: manual test
Change-Id: Ia1333474059988a524fc0ca49e7062b51da2cc37
2024-07-05 15:41:57 +08:00
Treehugger Robot
9b192cf15b Merge "Settings: fix unexpected routing selection" into main am: a02b1c3aa2 am: 226c0d5487
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3160065

Change-Id: I1fa2395682dfb3b94b2cc1b8fa269fa8e17b305d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-05 07:36:20 +00:00
Treehugger Robot
226c0d5487 Merge "Settings: fix unexpected routing selection" into main am: a02b1c3aa2
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3160065

Change-Id: I6ccacc71a9848cc2f030fb2612f3762172e893ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-05 07:17:38 +00:00
Treehugger Robot
476323f0b0 Merge "Disable "Add network" if DISALLOW_ADD_WIFI_CONFIG" into main 2024-07-05 06:58:17 +00:00
Wilson Wu
5146bc8ce2 Merge "Simplify default keyboard vibration settings value" into main 2024-07-05 02:28:03 +00:00
Treehugger Robot
78beeb1d30 Merge "Gray out admin-disabled screenlock option properly" into main 2024-07-05 01:31:34 +00:00
Weng Su
a7b13c11cd Disable "Add network" if DISALLOW_ADD_WIFI_CONFIG
- When DISALLOW_ADD_WIFI_CONFIG is not restricted by Admin
  - Disable the preference directly

Bug: 335387874
Flag: EXEMPT bugfix
Test: Manual testing
atest -c AddWifiNetworkPreferenceTest

Change-Id: I0bb08656971107c73d7632a395a820d03723620b
2024-07-05 06:52:36 +08:00
hoffc
99e33291d3 Settings: fix unexpected routing selection
setRouterGroupId in WifiDisplayPreferenceController will result in unexpected routing selection in MediaRouter, which will lead to WFD scanning not be triggered when entering WFD settings page if there is one remembered WFD device exists before reboot.

Remove the set group id call.

Bug: 351110755

Change-Id: I0d434543338d9896116541963f31e4669d877ea8
2024-07-04 09:02:23 +00:00
YK Hung
8d5d69d62f Merge "Avoid dump BatteryReattributeDatabaseHist if the feature is disabled" into main 2024-07-04 06:12:53 +00:00
Haijie Hong
5d96249d6e Add ring indicator for battery level
Bug: 343317785
Test: atest AdvancedBluetoothDetailsHeaderControllerTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: Ib657db60be8d377ea990674c4d2438ea8a6854d0
2024-07-04 13:26:48 +08:00
YK Hung
e15e2397af Avoid dump BatteryReattributeDatabaseHist if the feature is disabled
Fix: 346706894
Fix: 350798552
Test: atest SettingsRoboTests:com.android.settings.fuelgauge.batteryusage
Flag: EXEMPT bug fix
Change-Id: I1670e2769bc71fe91a752efeea18074d53c5a017
2024-07-04 04:59:34 +00:00
Wilson Wu
2ae9ed0297 Merge "Clean up the keyboard vibration config" into main 2024-07-04 02:45:29 +00:00
Julia Reynolds
4fd34aa386 Create a new link preference for priority modes entry
Test: ZenModesSummaryHelperTest
Test: manual. Successfully search for both 'event' and 'priority'
Flag: android.app.modes_ui
Bug: 341726633
Change-Id: Ib7bd1a5c2f7b06b1728a66f7a9cef53cd45acc0b
2024-07-03 16:22:20 -04:00
Julia Reynolds
6632826881 Merge "Fix IndexOutOfBoundsException" into main 2024-07-03 18:01:46 +00:00
Alina Zaidi
903976cd34 Merge "Update OWNERS for DesktopModePreferenceController" into main am: ed9bccb0b3 am: 7b4fcc6006
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3159736

Change-Id: Ibb60677d29ad574c106f95391f4572b0e142864b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-03 17:52:03 +00:00
Alina Zaidi
7b4fcc6006 Merge "Update OWNERS for DesktopModePreferenceController" into main am: ed9bccb0b3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3159736

Change-Id: I79c2dd015ce63fa0fe658daf486971f48917f0ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-03 17:37:22 +00:00
Alina Zaidi
a059eabdb3 Update OWNERS for DesktopModePreferenceController
Change-Id: I446525a06480a27f80e530c65181fd31f43a9ef8
Test: N/A
Flag: EXEMPT Ownership cannot be flagged
2024-07-03 16:22:23 +00:00
Pawan Wagh
e1a69960f9 Merge "Fix flaky test for persistent notifications" into main am: b6fc7a6f58 am: fdd68f473b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3156445

Change-Id: I0635a73774b0db08c401ef2523b2da13b0b359f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-03 15:47:26 +00:00
Pawan Wagh
fdd68f473b Merge "Fix flaky test for persistent notifications" into main am: b6fc7a6f58
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3156445

Change-Id: I0c2f3c0445e06e63a26cc69efa326c8ccabf0e66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-03 15:36:52 +00:00
Julia Reynolds
bb10c9f4df Fix IndexOutOfBoundsException
Test: none, MonkeyComboTest_StabilityMonkey
Fixes: 341614935
Flag: EXEMPT bugfix
Change-Id: Id52bcbc40145d7dca477425322e317abc2268a59
2024-07-03 09:32:59 -04:00
Rubin Xu
935cea2ca7 Gray out admin-disabled screenlock option properly
Fix an issue where some sceenlock options are disabled
by admins but not showing up as grayed out.

Bug: 288081292
Flag: EXEMPT bug fix
Test: manually with `am start  -a android.app.action.SET_NEW_PASSWORD
  --ez isSetupFlow true --ei android.app.extra.PASSWORD_COMPLEXITY 327680`
Change-Id: I4aab61a052bc2c5146f44d0bfcd8153e3f2cee92
2024-07-03 10:55:47 +00:00
Fan Wu
6f6d3e7263 Merge "Remove Use on-screen keyboard preference from Physical Keyboard page" into main 2024-07-03 09:27:44 +00:00
SongFerng Wang
6213cb9aa9 Merge "Fix UI flashing after changing network mode" into main 2024-07-03 08:10:12 +00:00
Fan Wu
ec5df5cd1e Remove Use on-screen keyboard preference from Physical Keyboard page
Bug: 304460009
Flag: EXEMPT removing preference from xml
Test: on device
Change-Id: Ibb0517c5ffa4addb52f1b0469f30c5126bd5828a
2024-07-03 06:29:54 +00:00
Jayant Chowdhary
8569d2ade0 Merge "Exclude webcam and MIDI USB preferences from requiring auth challenge" into main 2024-07-03 04:55:58 +00:00
Treehugger Robot
a56866ddaa Merge "Add mandatory biometric prompt to platform surfaces (2/N)" into main 2024-07-03 02:39:11 +00:00
Julia Reynolds
ce4f2e9db6 Merge "Show bundles separately from other channels" into main 2024-07-03 00:02:33 +00:00
Pawan Wagh
999b8a9f33 Fix flaky test for persistent notifications
Persistent notifications test sometimes fails due
to setup activity doesn't exit due to failed intent.
Adding setup exit command when on device tests are starting and
adding timeout for transition.

Test: m Settings && adb install -r $ANDROID_PRODUCT_OUT/system_ext/priv-app/Settings/Settings.apk
Flag: EXEMPT bugfix
Bug: 349820489
Change-Id: Iaf1c1f481612367bbce919b27e89f88a24abb582
2024-07-02 23:57:57 +00:00
Diya Bera
606bfb3057 Add mandatory biometric prompt to platform surfaces (2/N)
1. Factory reset

Flag: android.hardware.biometrics.Flags.MANDATORY_BIOMETRICS
Bug: 339910718
Test: atest MainClearTest

Change-Id: I7216f991a2550197c520af860da67f8452cff323
2024-07-02 20:57:43 +00:00
Yuri Lin
8a766c1b9b Merge "Check that modes can be deleted before adding delete menu option." into main 2024-07-02 19:23:02 +00:00
Jayant Chowdhary
cf9eee0bb5 Exclude webcam and MIDI USB preferences from requiring auth challenge
Webcam / MIDI don't transfer any persistent data to the host device,
so it is okay to not guard it by an auth challenge. Auth challenge for
webcam use increases friction and reduces usability.

Bug: 349370229

Flag: com.android.settings.flags.exclude_webcam_auth_challenge

Test: Check when the flag is enabled, webcam / MIDI doesn't require auth
Test: Settings robolectric tests

Change-Id: Id4c97a635a4c0a9ed14f88fbdda2743e2371dd10
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2024-07-02 18:36:51 +00:00
Yuri Lin
2a19cc1874 Check that modes can be deleted before adding delete menu option.
Migrates to using MenuProvider instead of onCreateOptionsMenu, since the previous approach is apparently now deprecated.

Also wraps usages of requireActivity() so that we're sure the activity isn't null instead of potentially throwing an exception.

Flag: android.app.modes_ui
Bug: 346575126
Test: manually confirmed that manual DND is no longer deletable
Change-Id: I872f6054061c019db9a72028cc90cbb123a1cdce
2024-07-02 14:10:19 -04:00
Yalan Yiue
c291f22722 Merge "Launch oobe from Settings" into main 2024-07-02 17:22:14 +00:00
Ioana Alexandru
b2dfa6a123 Consolidate statusbar/notification and notification/
Move everything to notification/ in SettingsLib. Also have all
corresponding tests as deviceless tests in the correct directory.

Bug: NA
Flag: EXEMPT trivial refactor
Test: existing tests pass
Change-Id: I1b5650424e7ee2eff5d42995ec0ce85555d19c04
2024-07-02 16:49:18 +02:00
Matías Hernández
0037dfe9a9 Merge changes from topics "add-mode-dialog", "nicer-icon-header" into main
* changes:
  Icon picker: Styling improvements
  Add mode: Support for app-provided modes
2024-07-02 12:26:42 +00:00