Commit Graph

26539 Commits

Author SHA1 Message Date
TreeHugger Robot
8b285f2355 Merge "Show mobile data slice in Search even no SIM card" into qt-dev 2019-04-30 11:05:37 +00:00
Raff Tsai
f34d143d0c Fix Battery Fix slice can not displayed
Fixes: 123174237
Test: manual
Change-Id: I3b349a27be5ecffbc64aaccb709c443f6ada875b
2019-04-30 15:13:12 +08:00
TreeHugger Robot
5bfa4b24e2 Merge "Update location app stats" into qt-dev 2019-04-30 02:50:58 +00:00
TreeHugger Robot
9efd0c9685 Merge "Make UI smoothly when switch device in MediaOuput slice" into qt-dev 2019-04-30 01:52:37 +00:00
cosmohsieh
636ad9d947 Fix modification of WifiDialog doesn't take effect on details page
When clicking modify menu option in detiails page, modification on
metered or privacy preferences in the WifiDialog does not effect
back to details page but only changing internal data of WifiDialog.
Adding callback to update those two preferences.

Bug: 130775713
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi.details.WifiDetailPreferenceControllerTest
Change-Id: I74bfa5a9581dfae73894c3e9f73d1069a36fd16b
2019-04-30 09:32:27 +08:00
Yohei Yukawa
8cb387adae Let Settings app use InputMethodInfo#loadIcon()
This is a follow up CL to my previous CL [1], which attempted to show
the most appropriate IME icon even when multiple IMEs are implemented
in a single APK.

This CL simplifies the way how IME icon is obtained in the Settings
app, by simply using InputMethodInfo#loadIcon(), which already does
what we want.

Notable user-visible behavior changes are:
 - Like before my previous CL was submitted, android:logo will not be
   used in the IME settings (again).
 - Icons shown in IME settings start having (user) badges like other
   settings pages.
 - If no icon is available in IME,
   PackageManager#getDefaultActivityIcon() will be used. This is
   actually consistent with other settings pages.

 [1]: I406ccc0d53e6ec69793c2fc8be8c6c1c90b34811
      2cae5b8952

Bug: 28204635
Fix: 131432102
Test: Manually verified as follows.
  1. Build aosp_taimen-userdebug and flash it
  2. Install TestDPC.
  3. Set up a work profile
  4. Open Settings App -> System -> Languages & input
     -> Advanced -> Virtual keyboard for work
  5. Make sure the icon of "Android Keyboard (AOSP)" has a small badge.
  6. Tap "Manage keyboards"
  7. Make sure the icon of "Android Keyboard (AOSP)" has the same icon
     as the step 5.
  8. Open Settings App -> System -> Languages & input
     -> Virtual keyboard
  9. Make sure the icon of "Android Keyboard (AOSP)" does not have a
     small badge on it.
 10. Tap "Manage keyboards"
 11. Make sure the icon of "Android Keyboard (AOSP)" has the same icon
     as the step 9.
Change-Id: Ie9be1eb3071abcc2df7723ceb10d76fe458c4808
2019-04-29 18:11:33 -07:00
TreeHugger Robot
15524dbaee Merge "Only shows two suggestion cards at once." into qt-dev 2019-04-30 00:58:18 +00:00
TreeHugger Robot
116d4f14dc Merge "Fix a crash in battery settings page" into qt-dev 2019-04-30 00:19:39 +00:00
Antony Sargent
562f7b2f91 Add 'Erase SIM' to mobile network details page
This adds a preference to the mobile network details page that lets a
user delete an eSIM profile.

Bug: 124254555
Test: make RunSettingsRoboTests
Change-Id: I1e266566afc36ff39bf1b1c6d1db674c7c6e8648
2019-04-29 16:57:35 -07:00
Lei Yu
aa625bd06e Fix a crash in battery settings page
Regression from ag/7161923, in this case we should use onResume/onPause
pair. Also sort the method to fit android lifecycle.

Bug: 131615524
Test: RunSettingsRoboTests
Change-Id: I299032bfeb119dac293039917c6673dd4c0ef4e0
2019-04-29 15:43:57 -07:00
TreeHugger Robot
a02cbbf23f Merge "Add null check to avoid settings crash" into qt-dev 2019-04-29 20:26:26 +00:00
Malcolm Chen
7dd82f966c Create enable MMS notification.
Adding a notification in SimSelectNotification that will be triggered
when receiving a enable MMS request. Tapping on the notificaiton will
lead to the subscription setting page.

Bug: 130222866
Test: manual -- have a test app that sends the intent when mobile
data is turned off. And verify that the heads-up notificaiton is shown
and that it will lead to subscription setting page.

Change-Id: Ia80e8e5ab20adf78a31647a23cb2ba8dac690e41
2019-04-29 18:49:27 +00:00
Fan Zhang
eb2e8dd22c Add an interface that returns time spent text for app.
Bug: 129266977
Test: robotest
Change-Id: Iaa5b4c5504eccbe0290b1014bd8e25aa3d4c3dd8
2019-04-29 11:09:58 -07:00
TreeHugger Robot
64693e31d9 Merge changes from topic "fingerprint-settings-after-enrollment" into qt-dev
* changes:
  Show fingerprint preferences after enrolling from settings
  Run postEnroll() after enrolling from SUW
2019-04-29 18:03:45 +00:00
TreeHugger Robot
7c802e553f Merge "Fix visibility and editability of importance fields" into qt-dev 2019-04-29 17:04:02 +00:00
Beverly
23c07c8727 Add null check to avoid settings crash
Test: manual
Fixes: 131580180
Change-Id: I128d1b23ca33c06f049d8fe4ca3e56c5abefae5f
2019-04-29 15:40:14 +00:00
Yi-Ling Chuang
ec01bff5c4 Only shows two suggestion cards at once.
Displaying too many cards may overwhelm users, so limit
the number of suggestion cards that should be displayed to two.

Fixes: 126213965
Test: robotests
Change-Id: I17c43746f475b31121c5809e0e8c6cf932efb99d
2019-04-29 18:30:28 +08:00
Kevin Chang
70e9b59a51 Change the string of Captions and reorder the feature in audio category
Bug: 128887817
Test: Visual
Change-Id: I4bcde9c52b4ed3484727e79758ef37f4b05a209d
Merged-In: I4bcde9c52b4ed3484727e79758ef37f4b05a209d
2019-04-29 02:10:25 +00:00
Julia Reynolds
a540fa56d4 Fix visibility and editability of importance fields
- Block field should always be visible
- Locked by OEM: cannot block or change importance
- Locked by default app: cannot block, can change importance
- Locked by system app: cannot block, can change importance
- system app but blockable: can block, can change importance

Test: robotests
Fixes: 131248127
Change-Id: Ifa718c84573dd5125aefa4f672a79dc4f267d515
2019-04-28 22:01:36 -04:00
Pasty Chang
54cddc70e5 Merge "Set QR scan activity to light theme in setup flow" into qt-dev 2019-04-29 01:52:11 +00:00
Ilya Matyukhin
8979f84865 Show fingerprint preferences after enrolling from settings
Bug: 131231334
Test: tested on blueline
Change-Id: Ifd43f28001fcb42ec61a62ad6656d2da2a0629eb
2019-04-28 16:31:54 -07:00
Ilya Matyukhin
cee87535e2 Run postEnroll() after enrolling from SUW
Bug: 131231334
Test: tested on blueline
Change-Id: I225725edb1c3379f2f3f5bc8b5cbe9adddb49f59
2019-04-28 16:24:29 -07:00
Clown SHEN
fbcf3708a6 Merge "Show "Disconnected" instead of "Saved" in detail page summary" into qt-dev 2019-04-27 06:42:45 +00:00
TreeHugger Robot
06da2980a0 Merge "Remove empty MNC filtering when retrieving available subscriptions" into qt-dev 2019-04-26 22:34:27 +00:00
Lifu Tang
d3a6d5e860 Update location app stats
- Count apps in both primary and work profiles
- Show the number of any location permitted app instead of background
  allowed apps on Location settings page
- Update the text at the top-level settings page

Bug: 129296799
Bug: 129358133
Bug: 129358508
Bug: 131432116
Test: build, flash, and test manually
Change-Id: I1a4284257a8a284140b81685efc98a2cc4a74619
2019-04-26 15:05:06 -07:00
Antony Sargent
972bf437f6 Remove empty MNC filtering when retrieving available subscriptions
During the early phase of work on DSDS, we found that a hacky solution
to seeing duplicate subscriptions that are part of a logical group (eg
Google Fi) was to filter out the entries with empty MNC strings. It
turns out this breaks things for some legitimate eSIM subsctiptions, and
isn't needed anymore because of the fixes that landed for b/127833821.

Fixes: 130706446
Test: make RunSettingsRoboTests
Change-Id: Ic4472c1de3c3e2449139b3e2ffb20d11a0058e8a
2019-04-26 13:45:53 -07:00
Andrew Sapperstein
655e2e55e9 Merge "Remove "data usage" from search." into qt-dev 2019-04-26 20:28:06 +00:00
Andrew Sapperstein
067332ca9e Merge "Move SIM_SUB_INFO_SETTINGS to NetworkDashboardActivity." into qt-dev 2019-04-26 20:27:01 +00:00
TreeHugger Robot
f9fd3b9e17 Merge "Fix toggle button is enabled state but can't click" into qt-dev 2019-04-26 20:00:48 +00:00
Fan Zhang
4fe327858f Merge "Fix incorrect mapping to get subscriptioninfo" into qt-dev 2019-04-26 19:57:09 +00:00
Andrew Sapperstein
c65ccd23b4 Move SIM_SUB_INFO_SETTINGS to NetworkDashboardActivity.
Remove the entry point for SimSettings and redirect any intents to the new UI.

Filed b/131324863 to track deleting the code.

Fixes: 128859223
Bug: 131324863
Test: adb shell am start -a com.android.settings.sim.SIM_SUB_INFO_SETTINGS
shows main connectivity screens

Change-Id: I4a4ed5c34d231eaab929a923c7fcbbfc1e0ed6f3
2019-04-26 12:01:42 -07:00
Andrew Sapperstein
62a68d6edb Remove "data usage" from search.
Fixes: 131324402
Test: verified manually
Change-Id: Ib72902c3eaa1f2427e9c1c835ba2939f28cf7a0d
2019-04-26 10:23:02 -07:00
Fan Zhang
f61db6e9d7 Fix incorrect mapping to get subscriptioninfo
getActiveSubscriptionInfoList() returns a list of active subscription.
It doesn't 1:1 mapping with slotId. So it is not correct to use slotId
as index to get subscriptioninfo from list.
Use framework interface getActiveSubscriptionInfoForSimSlotIndex() to
get subscriptioninfo per slotid instead.

Fixes: 129038597
Test: robotest
Change-Id: If4277c425e6145e0e3ba716551d0dce46cdb61ab
2019-04-26 10:07:07 -07:00
Lei Yu
1a66d9b22f Merge "Hide number label if info is opportunistic" into qt-dev 2019-04-26 16:54:02 +00:00
Andy Chou
8c16ef2906 Merge "Avoid IMEI overrided by getSummary() for dual SIM condition" into qt-dev 2019-04-26 15:04:25 +00:00
Chandan Nath
2f2a3c4055 Merge "Always show backup settings (even if backup is deactivated)." into qt-dev 2019-04-26 08:14:53 +00:00
Sunny Shao
238928dea2 Show mobile data slice in Search even no SIM card
- return slice like in airplan mode when mobile data disabled in the getSlice
  of the MobileDataSlice
- replace CONDITIONALLY_UNAVAILABLE by DISABLED_DEPENDENT_SETTING in the
  getAvailabilityStatus of the MobileDataPreferenceController
- remove the duplicated mobile data item by update data_usage_cellular.xml

Fixes: 130650621
Test: robotest
Change-Id: I42c0983c27d4edb17fcdce7ca386023911254d2d
2019-04-26 14:44:55 +08:00
andychou
7c89a929c4 Avoid IMEI overrided by getSummary() for dual SIM condition
IMEI information will be overrided by getSummary() and cause second slot IMEI is
oerrided by first slot.
Avoid IMEI is override by first slot information.

Bug: 131124169
Test: Test with dual SIM device and atest
ImeiInfoPreferenceControllerTest, ImeiInfoDialogControllerTest pass

Change-Id: Ia0a028aa0103867f42fff610129cf7ce2d3910b7
2019-04-26 09:31:43 +08:00
TreeHugger Robot
668edcfb95 Merge "Fix media output slice is empty even BT device is paired" into qt-dev 2019-04-26 00:46:48 +00:00
TreeHugger Robot
80be930357 Merge "Add timestamp to recent used apps" into qt-dev 2019-04-25 22:54:20 +00:00
Kevin Chyn
8888d346d1 Merge changes I74d677dc,I17f4db85 into qt-dev
* changes:
  Only gray out remove button after positive button is pressed
  Check PackageManager before getting system service
2019-04-25 22:48:02 +00:00
Lei Yu
7e9ef34112 Hide number label if info is opportunistic
Fixes: 125855323
Test: RunSettingsRoboTests
Change-Id: I6f77d65691319097c9bf56232710ba12fa7360f3
2019-04-25 14:56:59 -07:00
Lei Yu
30991963e4 Merge "Update color filter for battery saver mode" into qt-dev 2019-04-25 21:42:56 +00:00
TreeHugger Robot
d414c64dc3 Merge "Include always ask button in SIM picker dialog" into qt-dev 2019-04-25 21:02:13 +00:00
Lifu Tang
c359536d0b Add timestamp to recent used apps
Bug: 129354132
Test: build, flash, and test manually
Change-Id: If8e657460da45db019633e95e77dffb1493997c0
2019-04-25 12:47:42 -07:00
TreeHugger Robot
1eb92917c9 Merge "Fix broken dark ui test" into qt-dev 2019-04-25 19:25:30 +00:00
Kevin Chyn
f19fb6fa46 Only gray out remove button after positive button is pressed
Fixes: 131252811

Test: manual
Change-Id: I74d677dc5608b21045b148020a13d5ea5c1bde20
2019-04-25 12:21:29 -07:00
Kevin Chyn
acc340d615 Check PackageManager before getting system service
Fixes: 131285189

Test: manual
Change-Id: I17f4db85afc5969c58a0a08667ef05786302712b
2019-04-25 12:17:26 -07:00
TreeHugger Robot
c7564be562 Merge "Improve the latency of NotificationChannelSlice" into qt-dev 2019-04-25 17:31:16 +00:00
Salvador Martinez
b0737ee174 Fix broken dark ui test
It was checking something in shared preferences which seems
to have stopped working (a bunch of the stuff used in the
test is deprecated). This CL just has it verify that
updateDarkTheme() is called when appropriate since that
is all we really care about.

Test: is a test
Bug: 130897882
Change-Id: If3286dd91b5a95cb0f41cac619a11a9089e0aecf
2019-04-25 10:25:15 -07:00