PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
123,775 Commits 1 Branch 0 Tags
f733b7b0ffb97b618608d9916c6642fa52de5e17
Commit Graph

9 Commits

Author SHA1 Message Date
menghanli
bea25c7513 Fix certain Accessibility Settings subpages use wrong resources 
Root cause: Portrait mode does not always respect the sw600dp qualifier and instead uses the phone (default) resources.
Solution: Using the product to customize the tablet and phone cases is better way than using the configuration qualifier.

Bug: 269130587
Test: Manual testing
Change-Id: I90cc44f1e9bccf8950a4d89f70119ba5e3c0bfdc
 2023-02-14 17:13:36 +08:00
jasonwshsu
2119458e6d Save user's option when clicking 'Change setting' in triple-tap warning dialog 
Root Cause: Did not save user's option when clicking 'Change setting'.

Solution: user did click on "save" before that dialog showed up, so it is their intention to save.

Fix: 228405345
Test: manual test
Change-Id: I28e3cb372419ec3b4f27ee84051f58d37e7c5c46
 2022-05-01 00:05:21 +08:00
jasonwshsu
4bfe215e4c Add link functionality in message of magnification triple-tap dialog 
Bug: 210593079
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ShortcutPreferenceTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=MagnificationModePreferenceControllerTest
Change-Id: Id69b0b717410b5c5c44a818c36688bb7331c73ae
 2022-03-23 19:44:33 +08:00
jasonwshsu
3b96a2c57e Apply new flow to hint user about triple-tap will delay when user select triple-tap shortcut on window-mode. 
Root Cause: Original content in magnification switch shortcut dialog needs to have different versions for different accessibility software shortcuts. Use the generic content and new flow to replace it.

Solution: Apply new flow from UX suggestion.

Bug: 210593079
Test: make RunSettingsRoboTests ROBOTEST_FILTER=MagnificationModePreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilityDialogUtilsTest
Change-Id: Id09b8847cca4fce1f3fb77770a03bff53ae05855
 2022-03-23 19:43:03 +08:00
menghanli
78c093b0b3 Move DialogEumn into AccessibilityDialogUtils 
Bug: 190022774
Test: Manual testing
Change-Id: I391089b675b415c26bbacd028caf1d1ab617e707
 2021-06-07 13:38:50 +08:00
ryanlwlin
6269a92e16 Move Magnification Mode Settings to the main page 
We move the mode settings because currently there is
only one item in the settings page. To fully test all logic,
we don't use fragament anymore in the controllerTest, and
test the interaction between the controller and the fragment
in the test of these two fragments.

Bug: 182992338
Test: atest ToggleScreenMagnificationPreferenceFragmentTest
      atest MagnificationModePreferenceControllerTest
      atest MagnificationSettingsFragmentTest
      manually test
Change-Id: Ia6b0ea4f116f3215407637d7aeaddb8d8196d8fb
 2021-04-29 20:12:35 +08:00
ryanlwlin
8e5e4dec12 Extract the logic of MagnificationMode to the controller 
To move the preference to the upper layer, we extract all logics
to its controller.

We move all tests to the test files and add server tests to
verify the behaviour of edit shortcut dialog.

Bug: 182992338
Test: atest  MagnificationModePreferenceControllerTest

Change-Id: I34c4361e2e116a22c3e34bd35c8ac8cac752ab96
 2021-04-15 18:41:44 +08:00
jasonwshsu
f30eded170 Extract magnification capabilities from MagnificationSettingsFragment into a new class. 
* To increase single responsibility of MagnificationSettingsFragment

Bug: 168567356
Test: atest MagnificationCapabilitiesTest
Change-Id: Ic5e8a556858ac2b6ab9929b1bbdc373ce320c270
 2020-12-30 19:40:43 +08:00
menghanli
756104417a Create settings for window magnification (2/n) 
Provide a setting for new Magnify area feature and joystick controller

Bug: 146019459
Bug: 146473544
Test: make RunSettingsRoboTests ROBOTEST_FILTER=MagnificationModePreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=MagnificationWindowControlPreferenceControllerTest
Test: make RunSettingsRoboTests2
Change-Id: Ia32fa073c59ad304e9ef9eb530ba37dd24c2f2f6
 2019-12-19 18:08:10 +08:00