Commit Graph

50380 Commits

Author SHA1 Message Date
Pavel Grafov
19cf0b4580 Don't hide "Add user" when disallowed by admin
Bug: 125226170
Test: atest tests/robotests/src/com/android/settings/users/UserSettingsTest.java
Test: manual, with TestDPC
Change-Id: I347fae04030e04325a5ee5c634f782e554ece263
2019-02-21 13:38:53 +00:00
TreeHugger Robot
7e1bd433e6 Merge changes from topic "homepage_latency"
* changes:
  Make slices precheck executes in parallel.
  Use a better way to bind slice for slice precheck.
2019-02-21 10:10:39 +00:00
Raff Tsai
2d91873dcb Fix Talkback issue
It is a button without text. Talkback will focus on this item.
We hide this item from layout so that Talkback will not find it.

Fixes: 125065965
Test: Test it with Talkback
Change-Id: I143c02b13b9f888fa5837dd2c472cf69bd00edcf
2019-02-21 09:46:39 +00:00
Sunny Shao
c8786408e5 Enlarge the touch area of the avatar
Use the padding to enlarge touch area.

Fixes: 124797089
Test: manual
Change-Id: Ief2296f015f021ca4d7e4cba0ca14ac0eada972b
2019-02-21 16:45:39 +08:00
tmfang
7de5314676 Add app entities widget for recently opened apps
If there is no recently opened app should be shown,
just show up an "All apps" preference.

If there are some recently opened apps, we show up
result with app entites controller.

- Clean up some useless ui. (category)
- User BasePreferenceController
- Modify test cases.

Test: robotest, visual
Change-Id: I411f61ed32eaaed97921941fd5026f1d65308d00
Fixes: 123538183
2019-02-21 16:23:18 +08:00
Yi-Ling Chuang
45ee7c2aac Dynamically return the uri of WifiSlice.
WifiSlice is used by both ContextualWifiSlice and WifiSlice itself.
In contextual homepage, we provide contextual_wifi slice for the
homepage. So in our slice pre-check, contextual_wifi slice will gets
pinned and bound. But when it comes to the state where wifi is on but
not connected, it actually returns wifi slice instead of contextual_wifi
slice, which will hit slice not pinned exception as wifi slice never
gets pinned.

Thus, we have to dynamically return the corresponding uri to  avoid this.

Fixes: 124627340
Test: robotests
Change-Id: I54ba255871628bb8eb814442f990a5d1149461e0
2019-02-21 16:14:29 +08:00
Yanting Yang
6934475d69 Merge "Fix preferences ordering issue in AccountSyncSettings" 2019-02-21 07:36:53 +00:00
Yi-Ling Chuang
dde76e6d5c Make slices precheck executes in parallel.
Slice binding takes up sometime which may cause latency.
Thus, making it run in parallel instead of sequentially to improve the
performance and avoid hitting the timeout problem.

Bug: 124366297
Fixes: 123668403
Test: robotests, unit tests
Change-Id: I5d9fa4605f59e2acef65aadf6fce85df36d8fff1
2019-02-21 15:24:28 +08:00
tmfang
f9cdc3e963 Fix test cases for Privacy package
Test: robotest
Fixes: 124970652
Change-Id: I165a1658a4a40499e0b9ec6dd03ada86b9631b06
2019-02-21 15:19:59 +08:00
Yi-Ling Chuang
daa8ff36cc Use a better way to bind slice for slice precheck.
Calling Slice.bindSlice() directly will cause the exception stating that
slices are not pinned, which sometimes leads to crash. Hence, change the
way we bind slices which handles pinSlice() for us before onBindSlice().

Bug: 120552892
Test: robotests, unit tests
Change-Id: I3e65c6b79876dbee5db6f19387bc6b675f734161
2019-02-21 14:18:01 +08:00
TreeHugger Robot
cd1718c9e4 Merge "String change for Permissions Dashboard" 2019-02-21 05:35:44 +00:00
TreeHugger Robot
5f321d7921 Merge "Replace deprecated KeyguardManager API with new BiometricPrompt one" 2019-02-21 03:05:02 +00:00
tmfang
0b51ad3139 String change for Permissions Dashboard
Test: visual
Bug: 125018087
Change-Id: I02bd34347eb78531e754295262a1a08b47c6402e
2019-02-21 10:23:05 +08:00
Kiyoung Kim
e011c2a308 [automerger skipped] Merge "Schematize Crypto system properties" am: b837a44716 am: a078a02c42
am: 9602f7eb0b -s ours
am skip reason: change_id I65a6ce1a682687702f4c8b5c2e054eaaf91c389b with SHA1 3737da3ae6 is in history

Change-Id: I1bfc2de7781bb2036c68daae22d45b3738c4b30e
2019-02-20 17:29:45 -08:00
Kiyoung Kim
9602f7eb0b Merge "Schematize Crypto system properties" am: b837a44716
am: a078a02c42

Change-Id: Ie498a453d85651904d98b0501d895e15cabfb317
2019-02-20 17:07:08 -08:00
Kiyoung Kim
a078a02c42 Merge "Schematize Crypto system properties"
am: b837a44716

Change-Id: I55c43d3d1273e2c79ab29c60a714a97d2ca0f264
2019-02-20 16:34:01 -08:00
Kiyoung Kim
b837a44716 Merge "Schematize Crypto system properties" 2019-02-21 00:16:45 +00:00
Fan Zhang
1479bc2b12 Merge "Update char limit" 2019-02-20 23:10:17 +00:00
Fan Zhang
b8c3127c49 Update char limit
Fixes: 124535061
Test: manual
Change-Id: I17a3c7b93b09f6f6d02ab36df3dd9a16bebd7294
2019-02-20 15:07:28 -08:00
TreeHugger Robot
40617d20ac Merge "Add event logging for changing SmsDefaultDialog window attr" 2019-02-20 22:56:29 +00:00
Android Build Merger (Role)
ba87cf7444 [automerger] Do not allow draw on top for default sms picker. am: 95d0fb7f49 am: b810aee20f am: 7a58589114 am: 7926131837 am: d6bde3f5b8
Change-Id: I029a177108cbe0c6646b9c717e910266c9a5a410
2019-02-20 21:54:41 +00:00
Android Build Merger (Role)
d6bde3f5b8 [automerger] Do not allow draw on top for default sms picker. am: 95d0fb7f49 am: b810aee20f am: 7a58589114 am: 7926131837
Change-Id: I16c54cab9346d161d668dc4183ae4a9eb7117996
2019-02-20 21:54:39 +00:00
Android Build Merger (Role)
7926131837 [automerger] Do not allow draw on top for default sms picker. am: 95d0fb7f49 am: b810aee20f am: 7a58589114
Change-Id: I9212ffd96f974268c0069e80e68347102967e7e5
2019-02-20 21:54:37 +00:00
Android Build Merger (Role)
7a58589114 [automerger] Do not allow draw on top for default sms picker. am: 95d0fb7f49 am: b810aee20f
Change-Id: Ic6e4308ee65a83e7d00801452323569301e65d66
2019-02-20 21:54:34 +00:00
Android Build Merger (Role)
b810aee20f [automerger] Do not allow draw on top for default sms picker. am: 95d0fb7f49
Change-Id: I9466105a6de960efb4513d4e856450459aec2560
2019-02-20 21:54:31 +00:00
Fan Zhang
95d0fb7f49 Do not allow draw on top for default sms picker.
Fixes: 120484087
Test: manual
Change-Id: I4be265565678302fad207839216d5cd65dcb6e94
Merged-In: I4be265565678302fad207839216d5cd65dcb6e94
(cherry picked from commit 9d46e1fdfe)
2019-02-20 13:53:51 -08:00
TreeHugger Robot
1de49122d3 Merge "Use MATCH_ALL to query available browsers." 2019-02-20 21:31:21 +00:00
Fan Zhang
f6dc3af6df Add event logging for changing SmsDefaultDialog window attr
Bug: 120484087
Test: manual
Change-Id: Ia5b00f79f2e54cb40377abb18c1ac07891020ae2
2019-02-20 13:13:41 -08:00
Xin Li
569aa2594e [automerger skipped] Merge "DO NOT MERGE - Merge PPRL.190205.001 into master" am: d4716c1a62 -s ours am: 92fc138524 -s ours
am: b637de1cb8 -s ours
am skip reason: subject contains skip directive

Change-Id: I23b85158470a5d10ddb6a559c8f2d2fcd0154de6
2019-02-20 12:16:32 -08:00
Xin Li
b637de1cb8 [automerger skipped] Merge "DO NOT MERGE - Merge PPRL.190205.001 into master" am: d4716c1a62 -s ours
am: 92fc138524 -s ours
am skip reason: subject contains skip directive

Change-Id: I1e1a98a476c0fcda84f8d5c1d245e296b0354708
2019-02-20 11:47:29 -08:00
Hongming Jin
6c728dc924 Migrate emegency default app to role manager.
Bug: 123293861
Test: atest DefaultEmergencyPickerTest
Change-Id: I7bd9e2655b22a35fc3268091d38c6770911d4046
2019-02-20 11:46:02 -08:00
Hai Zhang
7bd98d2519 Use MATCH_ALL to query available browsers.
Browser intent resolution has been special for a long time, and we
need to pass MATCH_ALL to get all the candidates, then do manual
filtering later.

Bug: 116216651
Test: manual
Change-Id: I5e9b7b907005f73b7c54c3253c872d85ef7c4863
2019-02-20 11:28:01 -08:00
TreeHugger Robot
8febd82f34 Merge "Add pref for notification swipe direction" 2019-02-20 19:06:42 +00:00
Xin Li
92fc138524 [automerger skipped] Merge "DO NOT MERGE - Merge PPRL.190205.001 into master"
am: d4716c1a62 -s ours
am skip reason: subject contains skip directive

Change-Id: If29e30a1516d869c647bb9634eb8c1d3b4b9b3f9
2019-02-20 11:06:41 -08:00
Xin Li
ec45103b4d [automerger skipped] DO NOT MERGE - Merge PPRL.190205.001 into master am: 9d8c2cc2c6 -s ours am: a99376f647 -s ours
am: 3003b4b39c -s ours
am skip reason: subject contains skip directive

Change-Id: I3d5eeea407f925dbc342ff8c059555c76c05fa86
2019-02-20 10:16:18 -08:00
Xin Li
3003b4b39c [automerger skipped] DO NOT MERGE - Merge PPRL.190205.001 into master am: 9d8c2cc2c6 -s ours
am: a99376f647 -s ours
am skip reason: subject contains skip directive

Change-Id: I70f7a0afed0ff3124670ac7da3a5a4d643b07970
2019-02-20 09:29:00 -08:00
Xin Li
a99376f647 [automerger skipped] DO NOT MERGE - Merge PPRL.190205.001 into master
am: 9d8c2cc2c6 -s ours
am skip reason: subject contains skip directive

Change-Id: Ic2e84fd1810cf9eb661c2c4b4b32755821cf17e3
2019-02-20 08:52:26 -08:00
Xin Li
d4716c1a62 Merge "DO NOT MERGE - Merge PPRL.190205.001 into master" 2019-02-20 16:25:59 +00:00
Julia Reynolds
14289bd356 Add pref for notification swipe direction
And move that and other settings under an 'advanced' category

Test: robotests
Fixes: 124099692
Change-Id: I89df276a8bc1cd56ce8530239ca02b2c4b43fa65
2019-02-20 10:36:50 -05:00
Yanting Yang
11a157a8e7 Fix preferences ordering issue in AccountSyncSettings
In Pie, it's alphabetical ordering in Accounts > Account sync detail page.
But Q doesn't follow it, intend to keep the same behavior.

Fixes:124382857
Test: visual, robotests
Change-Id: I593a4cc919daa0018d3874d84978e876198aae23
2019-02-20 21:18:28 +08:00
TreeHugger Robot
763f7450f2 Merge changes from topic "Wi-Fi DPP error code handling"
* changes:
  Fix camera stop forever after error occurs while sharing or adding network
  Handle different error codes in DPP
2019-02-20 12:45:26 +00:00
TreeHugger Robot
812855c83e Merge "Update char limit for DND conditional" 2019-02-20 10:48:35 +00:00
Mill Chen
594767634f Update char limit for DND conditional
Increasing the character limit for the "Phone muted" to 38 in the DND
condition.

Bug: 124784648
Test: rebuild
Change-Id: I46496ee60f6757f477b0d0bbd021c43234f83222
2019-02-20 16:16:35 +08:00
Arc Wang
ffae615d25 Fix camera stop forever after error occurs while sharing or adding network
Restart QrCamera decoding task after Wi-Fi DPP handshake fail or
Wi-Fi connection fail.

Bug: 124128539
Test: manual test
Change-Id: I6d916ed1378f50038089e2c1e2870915ca083d68
2019-02-20 14:29:08 +08:00
Arc Wang
7bdcadbe72 Handle different error codes in DPP
Show error message for corresponding Wi-Fi DPP error code. And

1. To update error message only from each fragment,
   remove some callbacks which calls from fragment to activity.
2. After clicking 'Share Wi-Fi' button, hide it before Wi-Fi DPP handshake completes.
3. Show 'Done' button for some error codes.
4. Use ViewModel to call startEasyConnectAsConfiguratorInitiator and
   startEasyConnectAsEnrolleeInitiator because a lifecycle object
   does not receive an Executor callback after configurator change.
5. In WifiDppQrCodeScannerFragment, show an error message for 10s instead of 2s
   since new added error messages may carry more information.
6. Show a different error message for enrollee handshake success but Wi-Fi
   connection fail case.
7. stop camera when scanned a Wi-Fi DPP QR code for enrollee.
8. In QR code scanner fragment, support to show error message after
    configuration change.

Bug: 124247872
Bug: 124491247
Test: manual test
      atest WifiQrCodeTest
      atest WifiDppConfiguratorActivityTest
      atest WifiDppEnrolleeActivityTest
      atest WifiDppQrCodeGeneratorFragmentTest
      atest WifiDppQrCodeScannerFragmentTest
      atest WifiNetworkListFragmentTest
      atest WifiDppChooseSavedWifiNetworkFragmentTest

Change-Id: Id130215e9ddafac8bc4c68238deda48ce99b4255
2019-02-20 14:28:52 +08:00
Arc Wang
79a3ae860e Replace deprecated KeyguardManager API with new BiometricPrompt one
Use BiometricPrompt to replace KeyguardManager#createConfirmDeviceCredentialIntent

Bug: 124249685
Test: manual test
Change-Id: I7a05b8f1b08471cf9f09b3d4ce1bedc7cd529e72
2019-02-20 14:17:45 +08:00
TreeHugger Robot
0acd013f03 Merge "Add developer menu to enable/disable ART verifier." 2019-02-20 03:55:40 +00:00
Xiangyu/Malcolm Chen
e67344a5c5 Merge "Correct behavior of "Mobile data" button on opportunistic subscriptions." 2019-02-19 21:04:01 +00:00
Malcolm Chen
5506e0c732 Correct behavior of "Mobile data" button on opportunistic subscriptions.
A check was added earlier to make sure in DSDS mode only one sub
shows data on, which is not true for opportunistic subscriptions. For
them, it should always be on (enforced by Telephony) and be disabled
as it shouldn't be turned off.

Bug: 124331860
Bug: 124683219
Test: manual, robolectric
Change-Id: I53c8d881ff71ad25c418085d3eee63e55c786b8f
2019-02-19 21:03:42 +00:00
Ryan Mitchell
03fc6bbedd Fix invalid style reference in xml
AAPT2 does not recognize @android:style/@Widget.Material.Button.Colored.
This change removes the unnecessary '@' symbol.

Bug: 123251200
Test: build success
Change-Id: Ie5ae2a8898602d5776f5b6bf32058b1bf7c668ca
2019-02-19 18:32:43 +00:00