Commit Graph

7739 Commits

Author SHA1 Message Date
Raff Tsai
fd7e2b43f7 Merge "Do not log Contextual card display when card is dismissed" 2019-02-27 23:20:28 +00:00
Fan Zhang
4050fd2fcb Merge "Fix homepage display test." 2019-02-27 23:09:43 +00:00
Fan Zhang
625ffbd0e9 Fix homepage display test.
We updated the IA but it's still checking old keywords.

Fixes: n/a
Test: atest
Change-Id: I495201d0a2580e7d600982139907d216aa1f558d
2019-02-27 22:37:07 +00:00
Sunil Ravi
c430c09421 Merge "WiFi: Replace -1 with LINK_SPEED_UNKNOWN constant" 2019-02-27 21:16:25 +00:00
TreeHugger Robot
b67abe180c Merge "Use Device Policy dialog in switchbar" 2019-02-27 19:51:35 +00:00
Zhi An Ng
c6b4170460 Merge "Disable system alert window permissions on low ram devices" 2019-02-27 17:06:50 +00:00
Issei Suzuki
1ac14708e8 Merge "Move AmbientDisplayConfiguration class out of internal package." 2019-02-27 14:28:36 +00:00
Issei Suzuki
fd85a9fae6 Move AmbientDisplayConfiguration class out of internal package.
Test: m droid (run full build)
Bug: 126327497
Change-Id: Idc07c811864edb4f88151051e25d6e05e4caf3b2
2019-02-27 13:25:15 +01:00
Jason Chiu
6391c9b6e4 Merge "Leverage the behavior of showing the searching message in wifi slice" 2019-02-27 10:03:28 +00:00
TreeHugger Robot
5d0d664ae2 Merge "Bar chart preserves data before rotating device" 2019-02-27 06:39:07 +00:00
TreeHugger Robot
3776476764 Merge "Use ThemedBatteryDrawable in settings" 2019-02-27 06:02:49 +00:00
Jason Chiu
6bbe6e2362 Leverage the behavior of showing the searching message in wifi slice
Fixes: 124823973
Test: robotest
Change-Id: Id89ec5ef09f05f83e019a6f4488cacf2ab4e635b
2019-02-27 12:20:11 +08:00
tmfang
44e5aeca65 Bar chart preserves data before rotating device
We saw chart view is gone while rotating device.

Fow now, we save the old permission data before
fragment was recreated.
Then, we can initialize the view quickly with
old data.

Test: robotest, visual
Fixes: 123539793
Change-Id: I230fecc6001a17a0c0205f2a1dcb5dd79f32e744
2019-02-27 11:25:35 +08:00
Rich Cannings
03908ded19 Merge "Refactor passwords/pins/patterns to byte[]" 2019-02-27 03:21:57 +00:00
Kevin Chang
40d496471a Merge "Duplicate dark mode settings to accessibility display settings" 2019-02-27 03:15:39 +00:00
TreeHugger Robot
b80a409a21 Merge "Create a preference controller for "App info"" 2019-02-27 03:02:46 +00:00
Raff Tsai
3881e2986c Do not log Contextual card display when card is dismissed
If the db change comes from dismiss card uri. We don't
need to log card display again.

Fixes: 121196921
Test: Robolectric
Change-Id: I4e222187fafa8325e803fa6ee17ebb0b51fb8cb2
2019-02-27 10:36:03 +08:00
Arc Wang
c1036df9b8 Change Easy Connect intent naming
1. From ACTION_PROCESS_WIFI_EASY_CONNECT_QR_CODE to ACTION_PROCESS_WIFI_EASY_CONNECT_URI
2. Remove EXTRA_QR_CODE and use data Uri to specify Easy Connect bootstrapping information string

Bug: 125874365
Test: atest AvailableIntentsTest
      WifiDppChooseSavedWifiNetworkFragmentTest
      WifiDppConfiguratorActivityTest
      WifiNetworkListFragmentTest

Change-Id: I706513520daa10197a27f596fa08ca58980205d8
2019-02-27 10:06:04 +08:00
Ng Zhi An
b97bdc38da Disable system alert window permissions on low ram devices
Bug: 63697002
Bug: 117832554
Test: adb am start-activity -a
android.settings.action.MANAGE_OVERLAY_PERMISSION
Change-Id: I44c64001cd07fd4934cdc55f455384cebd5c9cfb
2019-02-26 17:58:43 -08:00
TreeHugger Robot
db6e6629b4 Merge "Guard NPE in RingtonePrefController" 2019-02-27 01:51:18 +00:00
Raff Tsai
3fd80809cc Use Device Policy dialog in switchbar
We need to pop dialog when switchbar is disabled by Device Policy

Test: visual, robolectric
Fixes: 124855614
Change-Id: Ief65baa2c4912cb7c85d5eccc2c0f363d2fc898b
2019-02-27 09:38:52 +08:00
Jackal Guo
2936551f70 Provide a way to ToggleA11yServicePreferenceFragment via Intent
Intent can only open the list of a11y services in Settings currently.
PermissionController needs a way to open the screen with the a11y
service toggle.

Bug: 123693167
Test: manual
Test: atest AccessibilityDetailsSettingsFragmentTest
Change-Id: I32ed39330cf9e4c18a1747521fb65eb911d1c6e4
2019-02-27 09:38:14 +08:00
Kevin Chang
a78b9222b0 Duplicate dark mode settings to accessibility display settings
Bug: 123227114
Test: Manual
      make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilitySettings
Change-Id: Icb60bc18e31377a2e73780004bd1bdea7bc96eea
2019-02-27 09:18:40 +08:00
Fan Zhang
f1b5989706 Guard NPE in RingtonePrefController
Fixes: 126416474
Test: robotests
Change-Id: I02d0279ae107e7c03668849beaea8aa0463b4da6
2019-02-26 15:45:17 -08:00
Rich Cannings
b27c4308a2 Refactor passwords/pins/patterns to byte[]
Relating to packages/apps/Settings

Bug: 120484642
Test: manual - test setting and unlocking passwords/pins/patterns.
      automated - 20 of about 500 tests fail due to fragile synthetic
      password test code.

Change-Id: Idec8338d141c185bef67ade12035fdb2fa9d17ea
2019-02-26 14:46:12 -08:00
Fan Zhang
98f58f9102 Merge "Make Serial number preference a copyable slice." 2019-02-26 22:36:18 +00:00
TreeHugger Robot
1d3dbbce85 Merge "Include uid in device admin pref id." 2019-02-26 22:14:56 +00:00
Sunil Ravi
7d0d684339 WiFi: Replace -1 with LINK_SPEED_UNKNOWN constant
Defined constant LINK_SPEED_UNKNOWN = -1 in WiFiInfo for unknown link
speeds. So replacing -1 with this new macro.

Bug: 124302657
Test: Connect STA to AP and verify the link speeds in network details.
Change-Id: Ie21069984adb02420ca55b08a8cb161aaad2b7b3
2019-02-26 13:32:40 -08:00
Fan Zhang
7c261409d2 Make Serial number preference a copyable slice.
Fixes: 73769621
Test: robotests
Change-Id: Ic20d8865bc26c1acc7db74e665f92fe388d62f74
2019-02-26 13:14:03 -08:00
TreeHugger Robot
3329ead489 Merge "Remove NFC Slice jank" 2019-02-26 19:28:58 +00:00
TreeHugger Robot
683bbb5ce9 Merge "Update settings notification ui tests" 2019-02-26 19:15:17 +00:00
TreeHugger Robot
8e32fa1972 Merge "Make PreventRingingSwitch preference clickable" 2019-02-26 19:15:13 +00:00
Evan Laird
35e35622d9 Use ThemedBatteryDrawable in settings
Changed out BatteryMeterDrawable to inherit from ThemedBatteryDrawable
instead of BatteryMeterDrawableBase. Also removed warning text paint
because it seemed unused and simplified the interface.

Bug: 123705805
Test: visual
Change-Id: I30496e3d8881803d9d3d8a316c10387482a8f610
2019-02-26 14:11:58 -05:00
Fan Zhang
71d5e90a6e Include uid in device admin pref id.
Fixes: 124979213
Test: robotests
Change-Id: I50114db79e9b5278bc916fbbba6353c5f19df24f
2019-02-26 10:49:53 -08:00
Matthew Fritze
9e50419c75 Remove NFC Slice jank
The NFC Slice would jank on enable and disable, because of the
intent filter it registered with SysUI. The intent filter would
broadcast an update for four states:
1) On
2) Off
3) Turning On
4) Turning off

The first two caused no problems. The third and fourth caused jank,
since when clicked, the switch in the NFC slice would turn on / off
asynchronously - that is, it turned on or off based on the previous
state of the switch, rather than on the actual value of NFC. It does
this to feel fluid in the app in which it is rendered.

From the off state, the order of events is:
1.  Switch clicked
2.  Switch animates on
2.  Background intent is fired to settings to turn on Nfc (happens at
       the same time as animation)
3.  Settings calls the NFC enable API
4.  A broadcast for Turning On is sent
5.  The receiver in SysUI gets the broadcast and forwards it to settings
6.  Settings tells the Slice to make sure it is up to date
7.  The Slice checks for the current value - IMPORTANTLY - which is
        currently off, it is only in the process of being enabled.
8.  The Slice flips back off
9.  Nfc finishes getting enabled in the background
10. The framework pushes the NFC ON broadcast
11. SysUI gets the broadcast, and forwards it to settings
12. Settings tells the slice to update
13. The slice checks again and finds that NFC is on, flipping on.

This CL creates a new background slice worker for NFC and registers
the intent filter there, rather than in SysUI. When the background
worker gets the broadcast, it checks if it is in state 3/4, and if so,
it drops the update silently.

Fixes: 115737701
Test: robotests
Change-Id: I17043828ad3a67a2a5acdf5c75d9cc51ff7e91d0
2019-02-26 08:20:38 -08:00
Beverly
5588921190 Update settings notification ui tests
Test: atest AppNotificationSettingsTest
Test: atest ZenModeSettingsIntegrationTest
Test: atest ChannelNotificationSettingsTest
Fixes: 126253682
Change-Id: Ie7fc5f177eb418162ecf24b0c4818ee52a8088db
2019-02-26 10:38:53 -05:00
Fabian Kozynski
c2d7bb7965 Merge "Add summary to Notification Assistant picker" 2019-02-26 14:11:56 +00:00
tmfang
826879ed63 Create a preference controller for "App info"
We try to avoid managing too many preferences in a controller.
So, we create another controller to manage all apps info preference.

RecentAppsPreferenceController and AllAppsInfoPreferenceController
share same state of recent apps in order to improve the performance.

Test: visual, robo test
Fixes: 126134996
Change-Id: I1d8a175b213831415797437c64fd9d432864f9d3
2019-02-26 19:34:46 +08:00
TreeHugger Robot
cabe72cf7b Merge "Improve launch time for Apps & notifications page" 2019-02-26 08:50:20 +00:00
tmfang
ac74050a7c Improve launch time for Apps & notifications page
In original design, we reload usage data at least thrice
for showing recent apps.

For now, we only reload usage data once in constuctor.
And we reload data again when we are calling updateState.

Test: Open App & notifications page, and then I compare the lauch time
with P platform device.
Fixes: 126013076

Change-Id: Ida769f28a4419125e1948e36658686ee55bf51a5
2019-02-26 15:08:22 +08:00
TreeHugger Robot
3189d7b332 Merge "Clean up instrumentation tests" 2019-02-26 04:54:18 +00:00
TreeHugger Robot
2b0611cec4 Merge changes I9f1edb0a,Iaba7077c
* changes:
  Make model & hardware UI full screen.
  Merge Copyable into Sliceable.
2019-02-26 04:00:13 +00:00
Kiyoung Kim
cf6757a72f Merge "Schematize Crypto state system property" 2019-02-26 01:44:28 +00:00
Lei Yu
2c1672c482 Merge "Add Bluetooth metadata listenr" 2019-02-26 01:30:13 +00:00
Fan Zhang
8ae1514299 Make model & hardware UI full screen.
Bug: 112427717
Test: robotests
Change-Id: I9f1edb0ab377aff142b57d86f4fa218b755356b1
2019-02-25 16:36:04 -08:00
Fan Zhang
e0a722e130 Merge Copyable into Sliceable.
It's only a slice concept. Regular preference copyability is handled in
xml.

Bug: 112427717
Test: rebuild
Change-Id: Iaba7077c320cd03a5963797916a60e0dc80fdbbe
2019-02-25 16:36:04 -08:00
Fan Zhang
0047944c2e Clean up instrumentation tests
- Fixed some important tests
- Deleted some useless tests
- Some tests are still broken, filed bugs for these

Fixes: 124572765
Test: atest
Change-Id: Iac4e6a1fb1dbf9383d91945525df69a651ae77fd
2019-02-25 16:24:35 -08:00
jackqdyulei
344d761e60 Add Bluetooth metadata listenr
If it is updated, we need to refresh UI to display latest information

Fixes: 124455912
Test: RunSettingsRoboTests
Change-Id: I73b03f4931e3c2b0d367bbd2d3b2057b26c84b59
2019-02-25 15:02:10 -08:00
Beverly
986f2ecc55 Make PreventRingingSwitch preference clickable
- Talk back says the preference is clickable

Test: make ROBOTEST_FILTER=PreventRingingSwitchPreferenceControllerTest RunSettingsRoboTests -j40
Bug: 124827588
Change-Id: Ia409bbc6516f6aa11975726691131f1fad1518fd
2019-02-25 16:36:45 -05:00
Fabian Kozynski
d565d7a505 Add summary to Notification Assistant picker
Test: manual
Test: atest
Fixes: 126200103
Change-Id: I9569ca7dd58184242fe740e3db63bd7958042cfb
2019-02-25 15:52:40 -05:00