PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
49,964 Commits 1 Branch 0 Tags
f66882f1e1434252f95ae984ff487d922af2e2be
Commit Graph

13 Commits

Author SHA1 Message Date
TreeHugger Robot
f66882f1e1 Merge "developer-options: avoid oem-unlock preference controller crash" 2019-02-21 18:00:23 +00:00
bohu
9bc365febd developer-options: avoid oem-unlock preference controller crash 
If there is no FEATURE_TELEPHONY_CARRIERLOCK.

BUG: 123583878

Test: lunch sdk_phone_x86-eng
make -j
emulator
the Settings->System->Developer options should not crash

Test:
make RunSettingsRoboTests ROBOTEST_FILTER=OemUnlockPreferenceControllerTest
should all pass (12 tests: 11 existing and 1 new)

Change-Id: I18c08c1ff1a7860616b0081ede4eb19dcfa8814b
 2019-02-21 08:08:12 -08:00
Fan Zhang
7db118e367 Mass clean up: don't cast class when not needed. 
Bug: none
Test: rebuild
Change-Id: Ie3f58a3d5ae99ade28a33dcac80c18de90d4d5b2
 2019-02-14 12:26:09 -08:00
Fan Zhang
31b210017b Migrate all MetricsProto enums to SettingsEnums 
Bug: 122855168
Test: rebuild
Change-Id: I962d9a71179f86b7cae9dc5e9a00e0aa1557dc76
 2019-01-17 14:55:42 -08:00
Fan Zhang
23f8d59d02 Sort imports 
Having consistent import order will reduce chance of merge
conflict between internal and external master

Test: rebuild
Change-Id: I0b1a170967ddcce7f388603fd521f6ed1eeba30b
 2018-08-28 22:13:15 +00:00
Fan Zhang
c7162cd24d Reorder and clean up imports. 
Test: rebuild
Change-Id: I178485c84ae7146f991fd77b6d7504b029942a68
 2018-06-18 15:45:09 -07:00
Aurimas Liutikas
e0069d332d Migrate Settings to androidx. 
Test: make Settings
Bug: 76692459
Change-Id: I941dea40562170649bf056e675cc32e5163c0e39
 2018-04-20 12:52:29 -07:00
Doris Ling
4fbf04cd10 Remove unnecessary onDeveloperOptionsSwitchEnabled/Disabled override. 
- default implementation has been added in the super class to handle
enabling/disabling the preference when the master developer options
switch it turned on/off. Removing all subclass that originally
implemented the methods that only contains the default behavior.

Bug: 73955632
Test: make RunSettingsRoboTests
Change-Id: I13c372c2ab498a5786b40cdc1ad3b5f3424abb5a
 2018-03-01 13:58:29 -08:00
jeffreyhuang
0545d6e7d7 Move OemUnlockPreferenceControllerTest to sdk 26 
Test: make RunSettingsRoboTests -j40
Change-Id: I25d96c82bd99c5c7adba6b6269f1a5735b22ca5b
 2017-11-28 12:01:12 -08:00
Fan Zhang
47a50edf31 Add a dialog when turning off oem unlock dialog. 
Change-Id: I93a93c0a110c2770d3701b5449c7939f941c7593
Fixes: 28199132
Test: robotests
 2017-10-30 17:53:11 -07:00
jeffreyhuang
37df3d6d1f Move DevOptionsPrefCtrl to SettingsLib 
- Move DeveloperOptionsPreferenceController

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ie434d479d8d3f7527ffce54f241ac2e090e0fc44
 2017-10-09 10:17:44 -07:00
jeffreyhuang
f5539a1969 Add isAvailable check to devOptionsController 
- This avoids the null check for PreferenceControllers where isAvailable()
 is not always true

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ibed8bc6a2a812355c521620d77fb571c1fd8a649
 2017-09-20 13:44:16 -07:00
jeffreyhuang
223484ea3c Introduce OemUnlockPreferenceController 
- Create new OemUnlockPreferenceController
 - Add new onActivityResult method in DeveloperOptionsController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I0b1387b9547e7c9f2a1a0963421d0ebea55d9ff4
 2017-09-19 13:21:25 -07:00