Commit Graph

2642 Commits

Author SHA1 Message Date
Kyle Zhang
3d84ccf8a2 Fix force L3 preference unit test
Bug: 385101776
Change-Id: I898b7855d3922636c09c99414cdaefee236fc71f
2024-12-19 16:02:45 -08:00
Xin Li
cfa19e11a6 Merge 24Q4 (ab/12406339) into aosp-main-future
Bug: 370570306
Merged-In: Ie90e7495dd4a134538bae6e3e08eea0d02134b14
Change-Id: I20517e9ee410e95f2cbeb1247c0c0288ed9f006f
2024-11-11 21:38:40 -08:00
Treehugger Robot
aa8b66f3ad Merge "Avoid flakiness SLO" into main 2024-10-23 08:13:58 +00:00
YK Hung
cb2e1bdabb Fix BatterySaverScheduleRadioButtonsControllerTest
Test was failing because it was not setting the EXTRA_LOW_POWER_WARNING_ACKNOWLEDGED setting.

Change-Id: Id9e95c0240908dafbaa791e7f4f4b9ded9d39d9b
Test: atest BatterySaverScheduleRadioButtonsControllerTest
Bug: 370883745
Fix: 370883745
Flag: EXEMPT for simple bug fix
2024-10-20 02:11:54 +00:00
tomhsu
3f4cf24ad3 Avoid flakiness SLO
Flag: EXEMPT bugfix
Fix: b/365673174
Test: atest pass
Change-Id: If27c4ca7f8dfd1a0670962b5dba1c42303caccce
2024-10-18 07:16:36 +00:00
Tom Hsu
9832fe9281 Avoid test flaky
flag: EXEMPT bugfix
fix: 365673174
Test: atest passed
Change-Id: Id7c3747eafff3410ab899716d0c6e35eb405c76e
Merged-In: Id1290e6979fdafa93ded6f50e49d6b3464a80b50
2024-10-11 05:15:14 +00:00
Diya Bera
baa6254207 Merge "(2/N) Biometric error dialog" into main 2024-09-17 23:58:50 +00:00
Diya Bera
1c604f29ef (2/N) Biometric error dialog
Add an error dialog to help user recover from biometric error for
for identity check while trying to factory reset

Flag: android.hardware.biometrics.flag.mandatory_biometrics
Bug: 358641110
Bug: 358179610
Test: atest MainClearTest
Change-Id: Ia20389a3146aa45ad42bdc4d31f1bd9488f2dc42
2024-09-17 20:21:48 +00:00
Chaohui Wang
a6db1aabb6 Create SimRepository
Which unifies whether we should sim settings on some related pages.

Before this change, we check SubscriptionUtil.isSimHardwareVisible()
and / or Utils.isWifiOnly().

After this change, we unified logic to,
canChangeSimSettings() =
  packageManager.hasSystemFeature(PackageManager.FEATURE_TELEPHONY) &&
    userManager.isAdminUser

Fix: 365924140
Flag: EXEMPT bug fix
Test: manual - check Network & internet
Test: unit tests
Change-Id: Ibf83237e3d0088f78c96a1b39ee8f1e3a9c756ea
2024-09-12 08:59:26 +00:00
Chaohui Wang
fc8e8991c9 Clean up InternetPreferenceController
And also the flag.

Bug: 339884322
Flag: com.android.settings.flags.internet_preference_controller_v2
Test: manual - Network & internet
Change-Id: Icb3427f6624db0442c05f5e149dbe522d1497e83
2024-08-29 15:55:44 +08:00
Chaohui Wang
f218f76221 Create VideoCallingRepository
Also support settings search for video calling.

Fix: 233327342
Flag: EXEMPT bug fix
Test: manual - on mobile settings
Test: manual - search video calling
Test: unit test
Change-Id: Ic4a25849f77f1759fa157931d428daa9e6854ff2
2024-08-29 03:37:50 +00:00
Pat Manning
f81aec1662 Replace Large mouse pointer setting with Pointer Scale
Bug: 269100659
Test: LargePointerIconPreferenceControllerTest
Flag: android.view.flags.enable_vector_cursor_a11y_settings
Change-Id: Ic643eb1eb862388eddf5d6f3de2d25739d4d23ad
2024-08-28 11:16:09 +00:00
Chaohui Wang
29f56b0b54 Clean up EuiccPreferenceController
Bug: 356684993
Flag: EXEMPT clean up
Test: manual - on mobile settings
Change-Id: I44856cf82f97c69d74dd2c8ba6e0c815498a7520
2024-08-22 12:09:32 +08:00
Chaohui Wang
b3ee1d70c4 Settings search for Carrier settings version
Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search carrier
Test: unit test
Change-Id: I4c13d22a6b689273684ff44df8071789a7a78d6e
2024-08-20 13:22:04 +08:00
Chaohui Wang
2c751d1671 Merge "Create UiccSlotRepository" into main 2024-08-19 05:17:04 +00:00
Joshua Mccloskey
bb23b97519 Merge "Split up FingerprintManagerInteractor" into main 2024-08-16 15:55:56 +00:00
Weng Su
1a975d6f72 Refine WifiHotspotRepository variable names
- Since the speed of hotspot design was changed to refer to allowed channels rather than usable channels, remove the "Usable" naming to avoid confusion

Fix: 360312024
Flag: EXEMPT refactor
Test: Manual testing
atest -c WifiHotspotRepositoryTest

Change-Id: Ie54a351e0f788e1b6aeec079ccf6671f7f78fb1c
2024-08-16 18:55:36 +08:00
Chaohui Wang
1951412dbe Create UiccSlotRepository
Also fix crash when TelephonyManager.uiccSlotsInfo returns array
contains null.

Fix: 358215954
Flag: EXEMPT bug fix
Test: manual - on Mobile Settings
Test: atest UiccSlotUtilTest
Change-Id: I4f92c9a43a430e295b6e048aee059416c46a256b
2024-08-15 08:27:34 +00:00
Xin Li
0b886fe303 Merge 24Q3 (ab/AP3A.240905.015) to aosp-main-future
Bug: 347831320
Merged-In: I54a12b03ed9be6dc49fb957df0f1f7b31647810d
Change-Id: I473577d5983daafb368afa5523bad948499cb9a2
2024-08-14 23:26:30 -07:00
Treehugger Robot
b3d4b76c69 Merge "Add mandatory biometric prompt to platform surfaces (5/N)" into main 2024-08-15 01:11:42 +00:00
Weng Su
6c2158edef Get available channels allowed by Hotspot
- Use getAllowedChannels API instead of getUsableChannels API to avoid corner cases

Bug: 352267181
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiHotspotRepositoryTest

Change-Id: I5ae4a4d429924ac2b8676bbbb27016a93ccd9a1b
2024-08-14 17:10:05 +08:00
Joshua McCloskey
882e1c3621 Split up FingerprintManagerInteractor
Test: atest, screenshot tests passed
Flag: com.android.settings.flags.fingerprint_v2_enrollment
Change-Id: I70833d5d9888f730233a9757589ce7faa45eccc9
2024-08-13 18:36:44 +00:00
Diya Bera
92ea474b86 Add mandatory biometric prompt to platform surfaces (5/N)
1. For biometric settings, request biometric prompt only after
   successful credential verification and no auth request after
   enrollment

2. Differentiate between mandatory biometrics ineffective error and
   other biometric errors

Flag: android.hardware.biometrics.flags.mandatory_biometrics
Bug: 358176202
Bug: 358179610
Test: atest UtilsTest DevelopmentSettingsDashboardFragmentTest MainClearTest BuildNumberPreferenceControllerTest CombinedBiometricProfileSettingsTest
Change-Id: I778dd5403dd5ab64d8cc39bd88b22c4d39182e94
2024-08-13 04:21:37 +00:00
Kai Zhou
c64611f30f Merge "Add unit test in WifiDppConfiguratorActivity" into main 2024-08-12 02:59:28 +00:00
Chaohui Wang
25d5816f5f Dual SIM search for Preferred network type
Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search preferred
Test: atest EnabledNetworkModePreferenceControllerHelperTest
Change-Id: Icb86d88eec3bcaaaf1db67f7008173a90957cbbc
2024-08-08 14:16:29 +08:00
Kai Zhou
184bca9c16 Add unit test in WifiDppConfiguratorActivity
* Bug: b/349252886
* Settings Intake: b/329012096

Test: atest tests/unit/src/com/android/settings/wifi/dpp/WifiDppConfiguratorActivityTest.java
Flag: com.android.settings.flags.enable_wifi_sharing_runtime_fragment

Change-Id: I951ed57acd40505c1ccecdb8420d197f7edd42f7
2024-08-07 07:10:20 +00:00
Allen Su
bf0b93b104 [ToA] Fix unit test failure
Flag: TEST_ONLY
Bug: 328697623
Test: atest TermsOfAddressCategoryControllerTest
Change-Id: Iddbf5b1ca16e455dfa12b9a9a6543d366b62d55e
2024-08-04 17:01:26 +00:00
Diya Bera
bc915e7bdc Merge "Add mandatory biometric prompt to platform surfaces (4/N)" into main 2024-07-31 17:06:14 +00:00
Diya Bera
8f0c77bb19 Add mandatory biometric prompt to platform surfaces (4/N)
1. Enable developer options via build info
2. Enable developer options via toggle under system -> developer options

Flag: android.hardware.biometrics.flags.mandatory_biometrics
Fixes: 355500452
Test: atest BuildNumberPreferenceControllerTest
DevelopmentSettingsDashboardFragmentTest

Change-Id: Iecbe34024d287e71e235becec3ce5a2bd5c1697f
2024-07-30 20:36:31 +00:00
Joshua McCloskey
ed59922ca8 Remove face/fignerprint search if not present
Test: Verified manually with a device that if face/fingerprint are not
present they do not show up.
Fixes: 350599580
Flag: EXEMPT bugfix

Change-Id: I6a691d2985e4839336e9c08dfa6c97abe23f43f2
2024-07-30 18:14:41 +00:00
Les Lee
ae2195c549 wifi: fix ADB URI doesn't work
Using old WifiQrCode parsing for ADB Uri.

Flag: EXEMPT bugfix
Bug: 355088188
Test: Manual test & TH
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:da21128568e29a6c2992b1b38cbb2db9ec36892f)
Merged-In: I54a12b03ed9be6dc49fb957df0f1f7b31647810d
Change-Id: I54a12b03ed9be6dc49fb957df0f1f7b31647810d
2024-07-29 23:56:20 +00:00
Treehugger Robot
dc8b74e343 Merge "Make adb team OWNERS of all Adb settings" into main am: 998787ffa8 am: ee6f5cf1ed
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3195878

Change-Id: Ifa37256b70cc3c1d7c6b22637cba040bce62ca3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-26 18:39:33 +00:00
Treehugger Robot
ee6f5cf1ed Merge "Make adb team OWNERS of all Adb settings" into main am: 998787ffa8
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3195878

Change-Id: Idcd085b62b69bace7ddfda325b1645b6b89440ca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-26 18:25:24 +00:00
Fabien Sanglard
c7adef9634 Make adb team OWNERS of all Adb settings
Test: NA
Bug: 355088188
Flags: NA
Change-Id: I59c037765940a26509f1d312b4c8c2e0105a3580
2024-07-26 10:57:43 -07:00
Rambo Wang
a07738266b Fix Settings restart during Reset mobile nework settings flow
This CL avoids restarting Settings in the reset mobile flow when phone
process is restarted, by switching the usage of the stable content
provider connection to the unstable client.

The CL also arranges restarting phone process as the last reset
operation in the flow (later than RILD reset) to avoid any reset
operation get impacted by phone process restarting.

Since the permission to protect the TelephonyContentProvider has been
renamed, the CL also renames the requsted permision.

Bug: 347047105
Test: atest ResetNetworkOperationBuilderTest
Test: Reset mobile network feature test
Flag: EXEMPT resource update with minor refactoring
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5ac9d9c8fa0005f787b75052010dcc9935efcb4f)
Merged-In: I7bfa79bc9d7451a4a03269704b0009a3730e287f
Change-Id: I7bfa79bc9d7451a4a03269704b0009a3730e287f
2024-07-26 02:03:55 +00:00
Les Lee
da21128568 wifi: fix ADB URI doesn't work
Using old WifiQrCode parsing for ADB Uri.

Flag: EXEMPT bugfix
Bug: 355088188
Test: Manual test & TH
Change-Id: I54a12b03ed9be6dc49fb957df0f1f7b31647810d
2024-07-25 21:38:15 +00:00
Oleg Blinnikov
efc891fca7 Merge "External display mode limit flag in settings" into main 2024-07-24 20:50:46 +00:00
Oleg Blinnikov
1821d25d39 External display mode limit flag in settings
Use external display mode limit flag and override
for the flag in the settings to allow selection
of any resolutions with the refresh rate around 60

Change-Id: I180ba97eb9dfa14a386a7517f29504d369268563
Bug: 351831642
Flag: com.android.settings.flags.resolution_and_enable_connected_display_setting
Test: atest ResolutionPreferenceFragmentTest
2024-07-23 16:47:46 +00:00
Treehugger Robot
6aac1cba28 Merge "Clean up BT stack log level preference controller and tests" into main 2024-07-23 02:45:25 +00:00
Treehugger Robot
2db5d1618f Merge "Show less secure warning in Network details settings" into main 2024-07-15 08:00:42 +00:00
Weng Su
05b28d24c3 Show less secure warning in Network details settings
- Show warning when device connected to WEP protocol

Bug: 331973632
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WepLessSecureWarningControllerTest

Change-Id: I54a9bafb2c672db44d47259d6acc49c02046cb81
2024-07-15 14:51:25 +08:00
Vincent Wang
8d235a2fc8 Merge "Remove package biometric2 from AOSP settings" into main 2024-07-15 05:00:06 +00:00
Sal Savage
da2e2c3e4a Clean up BT stack log level preference controller and tests
Problem: These tests were failing because the resource ID used in the
test and its version of the R class resolved to a different integer
(and subsequently a different string array) than the R class used on
device. This was causing different string arrays with different lengths
and values to sometimes appear, especially when the source and tests
were builts separately.

Solution: Manually lookup the resource ID to use by name instead of
using the pre-baked R class and assuming its ID is correct. This allows
us to get the proper ID every time and trust the values in the array.
This trust allows for some clean up on the code and tests, such that now
our tests can iterate on values instead of relying on private constants
being made visible or even hardcoded values.

Flag: EXEMPT, test fix and minor refactor with no behavior change
Bug: 339148064
Test: atest com.android.settings.development.bluetooth.BluetoothStackLogPreferenceControllerTest
Change-Id: I8149bd06ed70589afb3797a9f453eb2a11c3c410
2024-07-11 15:11:06 -07:00
Chaohui Wang
cd4cf67422 Clean up SubscriptionInfoEntity unused fields
It's safe since MobileNetworkDatabase is in memory only.

Bug: 348118234
Flag: EXEMPT clean up
Test: manual - check Mobile Settings
Change-Id: If170c65f4d0dfdc42c1cec9a56e25c516db4f75e
2024-07-11 04:15:37 +00:00
Vincent Wang
e9c4adfaf1 Remove package biometric2 from AOSP settings
Flag: EXEMPT Remove legacy code from AOSP
Bug: 351977012
Test: Build pass
Change-Id: I2285ab8cc2776071c329d7432849aeffc28ed8ee
2024-07-11 00:06:41 +00:00
mxyyiyi
a954e914dd Add a flag to protect overwrite app optimization mode to restricted mode.
- Skip set app optimization mode to restricted if the flag disabled.

Bug: 348192536
Fix: 348192536
Test: atest
Flag: EXEMPT bug fix
Change-Id: I92d320ce1edfe9b7044afdcd058651b0d54bd6bd
2024-07-01 17:38:50 +08:00
Kyle Zhang
febb0822a0 Merge "Keep FakeFeatureFlagsImpl" into main 2024-06-28 05:25:10 +00:00
Chaohui Wang
b8ad25f8bd Clean up MobileNetworkInfoEntity unused fields
It's safe since MobileNetworkDatabase is in memory only.

Bug: 348118234
Flag: EXEMPT clean up
Test: manual - check Mobile Settings
Change-Id: I25141a87b9afb42b85d73cbcd7307b899b3f0a3b
2024-06-27 17:30:19 +08:00
Kyle Zhang
7dbe6517ec Keep FakeFeatureFlagsImpl
* Keep FakeFeatureFlagsImpl.
* Use EnableFlags and DisableFlags annotation
* Switch back from `assumeTrue` to `assert` when flag is enabled or disabled.
* Remove flag rollback test.

Bug: 342830919
Change-Id: Ic9b3438f3f0e31e64d5405ed81903b352195714a
2024-06-27 08:46:17 +00:00
Chaohui Wang
b70c805717 Fix unable to erase eSIM
Before this change,
- eSIM will be erased twice, one with result callback and one without
  result callback.
- During reset, ResetNetworkConfirm could interrupted by subscription
  invalid event, which happens during reset.

After this change,
- eSIM will be erased only once, result callback is registered
  separately.
- Explicit exit the page when reset finish, and ignore the subscription
  invalid event after reset started.

Bug: 328293508
Flag: EXEMPT bug fix
Test: manual - dry run the reset
Test: ResetNetworkConfirmTest
Change-Id: I51395a556b1c8775192d5897a87f13046c042578
2024-06-26 11:02:56 +08:00