Commit Graph

35057 Commits

Author SHA1 Message Date
Ben Chung
f27d3c33c4 Merge "Accessibility settings interaction controls category restructure, add tap assistance fragment for related accessibility services." 2021-01-12 04:53:55 +00:00
TreeHugger Robot
0f81257a5f Merge "Disable toolbar title of screen lock pages" 2021-01-12 02:14:38 +00:00
TreeHugger Robot
b63f537238 Merge changes from topic "settings_collapsing_toolbar"
* changes:
  Disable the title of mobile network
  Add CollapsingToolbarLayout for sub settings
2021-01-12 02:14:38 +00:00
TreeHugger Robot
cbfeb8bf01 Merge "Set a title for personal dictionary" 2021-01-12 02:14:38 +00:00
Diego Vela
12797dc986 Merge "Revert "Expose role API for Settings on RoleManager."" 2021-01-11 19:30:04 +00:00
Diego Vela
e822aea2e1 Revert "Expose role API for Settings on RoleManager."
Revert submission 13261069-role-settings-api

Reason for revert: Might be breaking RcsProvisioningMonitorTest
Bug: 177227549
Test: RcsProvisioningMonitor
Reverted Changes:
Idbd0db119:Expose role API for Settings on RoleManager.
Iafe1d2460:Expose role API for Settings on RoleManager.
I6a3e5a26c:Expose role API for Settings on RoleManager.

Change-Id: Ic48c562e8249ca43e7c594f55d94ba190540be22
2021-01-11 19:11:25 +00:00
Ashwini Oruganti
eb9e2e74cc Merge "Bulk apply PendingIntent.FLAG_MUTABLE_UNAUDITED." 2021-01-11 18:25:05 +00:00
Fan Zhang
1447ed1fa5 Merge "Add android:order to all emergency setting items" 2021-01-11 16:52:11 +00:00
Mill Chen
82777ba0c0 Disable toolbar title of screen lock pages
After applying collapsing toolbar in the Settings app, the toolbar title
will be shown in every subsetting pages. However some pages in the
security category don't need the title, like set screen lock page and
lock screen page. This CL is to disable these titles through overriding
isToolbarEnabled method.

Bug: 176883575
Test: manual test and visual verified
1) Navigate to Settings -> Security -> Screen lock ->
Pattern/PIN/Password
2) Observe and check if there is a duplicated title.

Change-Id: I6dfa4fbe1b5e2ac3582804ba1e125196f3bdba6c
2021-01-11 18:31:54 +08:00
Mill Chen
82df7e60a1 Disable the title of mobile network
After the collapsing toolbar layout is applied to subsetting pages, the
mobile network page has two title shown currently. One is the activity
title while the other is the collapsing toolbar title To make sure
there will be only one title shown on this page, the activity title will
be removed and we will keep the collapsing toolbar title.

Bug: 176899590
Test: manual test and visual verified
1) Navigate to Settings -> Network & internet -> Mobile network
2) Check if there's only one title in this page

Change-Id: I50e57468c640f1d176fd99dcaafc06ed3fc601dc
2021-01-11 18:31:26 +08:00
Mill Chen
14cfd2f2ca Add CollapsingToolbarLayout for sub settings
Settings app is planning to make toolbar collapsible for next
Android release. This CL is to add a new layout for
CollapsingToolbarLayout in the Settings app and to update the theme
correspondly. This feature will be controlled by feature flag, which
makes Settings app compacitible with the existing layout.

Bug: 174451673
Test: manul test and visual verification
1) Enable the feature and open Settings app
2) Navigate to each sub page and check if toolbar is collapsible

Change-Id: Ibef524bbaa7ae3f0a43db7e40e599f42e009437f
2021-01-11 18:30:20 +08:00
Mill Chen
124f01999c Set a title for personal dictionary
After the collapsing toolbar layout is applied to subsetting pages, the
title of the personal dictionary page won't be shown. This CL is to set
a title for the personal dictionary page.

Bug: 176897229
Test: manual test and visual verified
1) Navigate to Settings -> System -> Languages & input -> Personal
dictionary
2) Enable collapsing toolbar feature
3) Observe and check if the title is shown as normal

Change-Id: I0b6488bc2c8040b275ba0d5348d09aa4bad905d1
2021-01-11 17:59:47 +08:00
Ben Chung
dfe1977044 Accessibility settings interaction controls category restructure, add tap assistance fragment for related accessibility services.
Bug: 174829936
Test: atest TapAssistanceFragmentTest, atest AccessibilitySettingsTest
Change-Id: I39c4eba8ec807248eb11371fab2466cf7d7553ef
2021-01-11 17:21:14 +08:00
Weng Su
062a80f221 Merge "Add Hotspot WPA3 Settings" 2021-01-11 08:46:15 +00:00
PETER LIANG
90c976b8c0 Merge "Add test cases for ToggleAutoclickCustomSeekbarController." 2021-01-11 07:34:21 +00:00
tim peng
ce66cbb502 Merge "Rename MediaOutputSliceConstants to MediaOutputConstants" 2021-01-11 05:08:26 +00:00
Weng Su
b9c865b704 Add Hotspot WPA3 Settings
- Add WPA3 SAE security types
  - "WPA3-Personal"
  - "WPA2/WPA3-Personal"

- Verify valid WPA3 password

- Enable QR code scanner for Hotspot WPA3

- Avoid null point exception when settings keyword searching

- Screenshot
  https://screenshot.googleplex.com/B6u54wh8w35Xnyf
  https://screenshot.googleplex.com/8hWHHUTb6UaS9vB

Bug: 167968488
Test: manual test
- atest WifiTetherSecurityPreferenceControllerTest
- atest WifiUtilsTest

Change-Id: I2992040498f8add107a4cce70a92c1c6ee6ab805
2021-01-10 08:38:39 +00:00
Fan Zhang
78cbca8cbd Add android:order to all emergency setting items
Each item has a gap of 100 to allow external setting injection choose
where to display.

Bug: 175158310
Test: manual
Change-Id: Icf150ad8fc956c3db391251382b08b5155034a8b
2021-01-08 23:56:33 +00:00
Ashwini Oruganti
2f349da025 Bulk apply PendingIntent.FLAG_MUTABLE_UNAUDITED.
We've been working hard to require PendingIntents explicitly declare
if they allow their contents to be mutated or not, and to finish
landing that work this change applies the new FLAG_MUTABLE_UNAUDITED
flag to all remaining code locations until they can be manually
inspected.

Bug: 160794467
Test: manual
Change-Id: I7b9ef5dcd35187facef1ec424589b81f834f23c0
2021-01-08 13:14:05 -08:00
Joshua Mccloskey
83102ab0a2 Merge "Updated Fingerprint enrollment logging" 2021-01-08 19:11:51 +00:00
TreeHugger Robot
4419633fb1 Merge "Expose role API for Settings on RoleManager." 2021-01-08 18:48:37 +00:00
Jason Hsu
606e8b1f88 Merge "Fix crash when rotating the device on magnification mode dialog" 2021-01-08 13:13:28 +00:00
TreeHugger Robot
1d4857d8dd Merge "Animate the search bar expansion" 2021-01-08 12:51:38 +00:00
Treehugger Robot
4fa8813f8b Merge "Fix too many receivers Exception" am: 2e6cde6b94 am: 8c2b2cc806 am: f83f554a75
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1498417

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I994084cd157a33e74a07525e6dd61229069fbdd7
2021-01-08 10:40:56 +00:00
Treehugger Robot
f83f554a75 Merge "Fix too many receivers Exception" am: 2e6cde6b94 am: 8c2b2cc806
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1498417

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Iac11b0261e6c2323558d974e7e81788c54661029
2021-01-08 10:14:26 +00:00
Tsung-Mao Fang
902a3469f0 Animate the search bar expansion
Enable the transition between Settings app and Settings Search

Test: Record the transition video and confirm it.
Fix: 175764903
Change-Id: I95125fba17bbf517feee9a10fd828ff8017f7106
2021-01-08 07:48:54 +00:00
Fan Zhang
80c7251526 Switch to use EmergencyNumberUtils to update e-number.
The backend storage choice is delegated to EmergencyNumberUtils. Using
the utils class abstrats underlying details away from Settings app.

Bug: 177006940
Test: manual
Change-Id: I78c5ef79e141e3609ab9d10e558803457b617911
2021-01-07 22:45:39 -08:00
Treehugger Robot
2e6cde6b94 Merge "Fix too many receivers Exception" 2021-01-08 05:35:46 +00:00
TreeHugger Robot
66363d707f Merge "[Provider Model] Replace WiFi panel to Internet panel" 2021-01-08 03:57:19 +00:00
Julia Reynolds
60633f6253 Merge "Allow notification filtering per listener." 2021-01-08 03:14:52 +00:00
TreeHugger Robot
76c649968f Merge "Add a empty page to host Safety/emergency settings" 2021-01-07 22:39:06 +00:00
joshmccloskey
75587638ff Updated Fingerprint enrollment logging
Test: Verified regular fingerprint enrollment correctly logged
enrollment.
Test: Verified that the find fingerprint sensor activity no longer
falsely reports a failed enrollment.
Bug: 175316123

Fingerprint enrollment shows a find sensor screen which makes a call to
FingerprintManager.enroll(), the purpose is to get the user to locate
the sensor. The consequence was that logging built into the framework
was incorrectly logging a failed enrollment after cancellation.

Change-Id: I4777613fe521f04cc97c471e0a1e85e5809d7f06
2021-01-07 13:53:27 -08:00
Fan Zhang
9b1fb77b54 Add a empty page to host Safety/emergency settings
The page will eventually be displayed on settings root. It's currently
disabled to avoid QA/dogfood confusion, as the page is pretty empty at
this point.

Bug: 175158310
Test: manual only. Skipped robolectric because the page is pretty empty.
      Will add more test as we build business logic.
Change-Id: I80f193f6e90b89ab0c37d0f23f7174e4ba86c091
2021-01-07 10:56:32 -08:00
jasonwshsu
bab448a610 Fix crash when rotating the device on magnification mode dialog
Root Cause:
1. onActivityCreated() has been deprecated
2. mCapabilities will be 0 when updateAlertDialogEnableState(),
   because onCreateDialog() will get mCapabilities
   but it will be called after onCreate() and before onCreateView();
   onActivityCreated() will set mCapabilities but it will be called after onCreateView()

Solution:
Move deprecated flow onActivityCreated() into onCreate() to set mCapabilities first

Bug: 172171402
Bug: 168567356
Test: atest MagnificationSettingsFragmentTest
Change-Id: Id9f861d59fa23f5cb77aac55b87152e921246135
2021-01-08 02:04:47 +08:00
Julia Reynolds
eb2b36a5e2 Allow notification filtering per listener.
Test: atest
Bug: 173052211
Change-Id: I54c740e9755f18339c59aad4f1f5aecd8c734892
2021-01-07 10:01:08 -05:00
Weng Su
c33f69673a [Provider Model] Replace WiFi panel to Internet panel
- Replace the android.settings.panel.action.WIFI panel
  - Provider Model Disable: Wifi panel
  - Provider Model Enabled: Internet panel

Bug: 172707942
Test: manual test
- adb shell am start -a android.settings.panel.action.WIFI
- atest PanelFeatureProviderImplTest

Change-Id: I9f111e96385452b586971d4c28988b564d4e25f4
2021-01-07 11:55:28 +00:00
TreeHugger Robot
12a5868126 Merge "Only show the schedule text for the night display and dark theme" 2021-01-07 10:30:46 +00:00
Tsung-Mao Fang
acab1a0364 Only show the schedule text for the night display and dark theme
In Android S design, night display and dark theme only show
schedule text for summary.

- Rmove redundant string resource.
- Remove redundant method in night display formatter.
- Refactor the code in dark mode preference and night display
controller.

Test: See the correct behavior in screen.
Fix: 174964139
Change-Id: I658b3073a0a6ed83f589103999c711e5430eaeb7
2021-01-07 16:17:20 +08:00
Yi-Ling Chuang
843616eb69 Add the mutability flag for SettingsSliceProvider
Starting Android S, all PendingIntent should have the mutability flag
assigned to prevent from vulnerability.

Fixes: 172811605
Fixes: 172206649
Test: 1. Play on the slices in Settings search.
2. Make a permission request intent of Settings wifi slice in the
slice-viewer app, clicking on it and make sure it gets redirect to
Settings without crashes.

Change-Id: I86f915bc062a6e632b5ca9c74e232db1036f08de
2021-01-07 16:00:08 +08:00
Hugh Chen
18c06480b0 DO NOT MERGE: resolve merge conflicts of c17ec818af to rvc-qpr-dev
Bug: 167403112
Test: send intent to test right prompts message is pop up. make -j42 RunSettingsRoboTests
Change-Id: Iec4d1963e626829b696c2047c5979a684119acf7
Merged-In: Idc6ef558b692115bb82ea58cf223f5919b618633
2021-01-07 11:54:30 +08:00
Peter_Liang
34829bdcbc Add test cases for ToggleAutoclickCustomSeekbarController.
Bug: 168567356
Test: atest ToggleAutoclickCustomSeekbarControllerTest

Change-Id: Ie69b8788482ecaddadb31b0339d3175a26881ed8
2021-01-07 11:50:58 +08:00
Ben Chung
cfedc19ab9 Merge "Accessibility settings display category restructure, add text and display fragment for related accessibility services." 2021-01-07 01:28:17 +00:00
Steven Liu
7f05bd4dfc Merge "Introduce a WifiTrackerLibProvider." 2021-01-07 00:58:49 +00:00
Peter Kalauskas
f22eb5971d Merge "Update icons and text for guest user" 2021-01-06 17:41:26 +00:00
Steven Liu
c1477650c9 Introduce a WifiTrackerLibProvider.
This make the WifiTrackerLib can be customized.

Bug: 149540986
Test: manual test wifi picker, and atest com.android.settings
Change-Id: I1418ae39c895ce2ff87f18005a226a4835f9e083
2021-01-06 08:44:34 -08:00
Edgar Wang
e49ae19b1e Merge "Replace some customized RadioButtonPreferences" 2021-01-06 16:31:02 +00:00
Julia Reynolds
c68b4be047 Merge "Migrate NLS access to preferencecontrollers" 2021-01-06 15:42:49 +00:00
TreeHugger Robot
b7076d5d5e Merge "[Provider Model] Implement the carrner network selection settings" 2021-01-06 14:25:46 +00:00
Julia Reynolds
d41f2db9ec Migrate NLS access to preferencecontrollers
In preparation for some new settings

Test: RoboTests
Bug: 173052211
Change-Id: I57c692d7ff0a1a8e36fb9e3f6c159263997fdc71
2021-01-06 14:23:59 +00:00
Rubin Xu
4fe99f19c1 Merge "Call KeyChain credential management app APIs Settings" 2021-01-06 11:30:30 +00:00