Kevin Chyn
f1a45e1257
Merge "BiometricFragment should commitAllowingStateLoss" into rvc-dev am: 5c4334276f am: 6d5a778090
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11838911
Change-Id: I39e23f9eb82e59e35bf8124c463d0c3a333caf82
2020-06-12 20:19:48 +00:00
Kevin Chyn
6d5a778090
Merge "BiometricFragment should commitAllowingStateLoss" into rvc-dev am: 5c4334276f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11838911
Change-Id: I6ebcf9c066ee56092f1b165e806622c1eadc87d4
2020-06-12 20:08:21 +00:00
Kevin Chyn
5c4334276f
Merge "BiometricFragment should commitAllowingStateLoss" into rvc-dev
2020-06-12 19:56:01 +00:00
Jason Chiu
981d30f49e
Merge "Fix Slice not pinned error" into rvc-dev am: 8cbee49d28 am: 6eca50ddf0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11833849
Change-Id: Iafe23935be9d14dc6f9ea05a638e50630b1630ec
2020-06-12 12:05:36 +00:00
Jason Chiu
7b40a59fd1
Merge "Fix Slice not pinned error" into rvc-dev am: 8cbee49d28
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11833849
Change-Id: I1e4d0fd72093d6674f8960e9af500adaa9d8f36a
2020-06-12 11:44:12 +00:00
Jason Chiu
6eca50ddf0
Merge "Fix Slice not pinned error" into rvc-dev am: 8cbee49d28
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11833849
Change-Id: Iba28857a715609cb332f9f50884a4de9ba81e5cb
2020-06-12 11:43:24 +00:00
Jason Chiu
8cbee49d28
Merge "Fix Slice not pinned error" into rvc-dev
2020-06-12 11:31:23 +00:00
tim peng
1d4e2258a2
Merge "Output switcher panel requires large title icon for Slice slider style" into rvc-dev am: c21406a0a2 am: de8b0ada5f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11818502
Change-Id: I7103136caa2b9139e2c598826d6ae7494678c6c0
2020-06-12 05:25:08 +00:00
tim peng
de8b0ada5f
Merge "Output switcher panel requires large title icon for Slice slider style" into rvc-dev am: c21406a0a2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11818502
Change-Id: I62a7dfd8d9693d15eb6cf6012418c3ba5cc1efd1
2020-06-12 05:10:37 +00:00
tim peng
b2ab3dfff2
Merge "Output switcher panel requires large title icon for Slice slider style" into rvc-dev am: c21406a0a2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11818502
Change-Id: Id609ee38c9b5230def2c8d1cffb7aac8e209e4e6
2020-06-12 05:10:33 +00:00
tim peng
c21406a0a2
Merge "Output switcher panel requires large title icon for Slice slider style" into rvc-dev
2020-06-12 04:58:04 +00:00
Tim Peng
27b0ef6eb3
Output switcher panel requires large title icon for Slice slider style
...
-Add "VIEW_TYPE_SLIDER_LARGE_ICON" to be a new panel type which would enlarge its title icon
-Set "VIEW_TYPE_SLIDER_LARGE_ICON" to MediaOutputPanel and MediaOutputGroupPanel
-Extend slider style and add customized icon size
-Add test cases
Bug: 157208551
Test: make -j42 RunSettingsRoboTests
Change-Id: I9b4de4aa552e8b26e766411f7eff93ea1a2d1910
2020-06-12 11:22:17 +08:00
TreeHugger Robot
50ab6f1fc7
Merge "Unicode-wrap app names for default apps summary." into rvc-dev am: 6791e1c09b am: 9ece2c0ae7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11844071
Change-Id: I9b366d0a1900be5e9a5d541260c4b06c91f41447
2020-06-12 02:56:14 +00:00
TreeHugger Robot
72041754a5
Merge "Unicode-wrap app names for default apps summary." into rvc-dev am: 6791e1c09b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11844071
Change-Id: I578b119b97da6a5351d5ebd4b898de1a88ea500d
2020-06-12 02:40:50 +00:00
TreeHugger Robot
9ece2c0ae7
Merge "Unicode-wrap app names for default apps summary." into rvc-dev am: 6791e1c09b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11844071
Change-Id: I2fdb01e00f706fc50d1fe37b9a462aeb08e2c6f1
2020-06-12 02:40:44 +00:00
TreeHugger Robot
6791e1c09b
Merge "Unicode-wrap app names for default apps summary." into rvc-dev
2020-06-12 02:28:48 +00:00
Hai Zhang
3f511d8ca9
Unicode-wrap app names for default apps summary.
...
This was done for permissions summary inside PermissionController, so
also do it in Settings.
Bug: 153804329
Test: manually confirm that the summary matches what linguist
suggested after fix
Change-Id: I650fbed4488abfd871adafba5afb1ae9a2995c62
2020-06-11 16:54:25 -07:00
Jason Chiu
f7afded1d1
Fix Slice not pinned error
...
Slices should be pinned before being bound. The original design calls
registerSliceCallback() to pin a slice, and then calls bindSlice() and
passes the result to the callback directly. When the callback is
called, it executes unregisterSliceCallback() and unpins the slice.
However, registerSliceCallback() starts to observe the slice change and
then rebind it in an AsyncTask. If the slice is updating via its
background worker and the timing of the binding overlaps the callback
execution, it's possible to bind the slice right after unpinning it and
causes the error.
The solution is to remove the callback mechanism, and just to pin, bind
and unpin the slice directly.
Fixes: 157387583
Test: robotest
Change-Id: I8748dd3038a3662599935f07420d07cf254a4073
2020-06-12 04:14:46 +08:00
Kevin Chyn
895ddf239a
BiometricFragment should commitAllowingStateLoss
...
This is a terminal case for both authentication as well as the
activity itself, so this should be safe.
Fixes: 158635014
Test: Builds
Change-Id: Ieef1ab305e6518dbc0ae34ad59d52da82895972a
2020-06-11 12:59:05 -07:00
TreeHugger Robot
f836c42063
Merge "Don't pass channel info for the bubble app page" into rvc-dev am: d6081039c6 am: 4327cd65cc
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11636410
Change-Id: Idafdf6a714a9c35f92a21684de3aeb941f772e12
2020-06-11 17:56:12 +00:00
Joshua Duong
ac85fec739
Merge "[adbwifi] Handle tls port changes." into rvc-dev am: 63facb88bd am: b84cafa24c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11828521
Change-Id: Idb0fee5e98d8618634eace2b5adabc65997c7cf9
2020-06-11 17:55:24 +00:00
TreeHugger Robot
4327cd65cc
Merge "Don't pass channel info for the bubble app page" into rvc-dev am: d6081039c6
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11636410
Change-Id: Icc6c824db2ad89a8a18fdcdcd595afc4f406aa6d
2020-06-11 17:37:14 +00:00
Joshua Duong
b84cafa24c
Merge "[adbwifi] Handle tls port changes." into rvc-dev am: 63facb88bd
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11828521
Change-Id: Ib5e569614e15f5c39590fc40a18b2673e45f9767
2020-06-11 17:36:49 +00:00
TreeHugger Robot
b299d90b7f
Merge "Don't pass channel info for the bubble app page" into rvc-dev am: d6081039c6
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11636410
Change-Id: I88d711322b1b3ea5f4e50f534bab68e7a5b17b96
2020-06-11 17:36:29 +00:00
Joshua Duong
928e81ae49
Merge "[adbwifi] Handle tls port changes." into rvc-dev am: 63facb88bd
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11828521
Change-Id: If2438ebe5f39ba9543d3a74d27e71902f6f93c4e
2020-06-11 17:36:19 +00:00
TreeHugger Robot
d6081039c6
Merge "Don't pass channel info for the bubble app page" into rvc-dev
2020-06-11 17:23:56 +00:00
Joshua Duong
63facb88bd
Merge "[adbwifi] Handle tls port changes." into rvc-dev
2020-06-11 17:23:00 +00:00
Mady Mellor
87e16f416f
Don't pass channel info for the bubble app page
...
Fixes: 157485149
Test: make SettingsUnitTests; adb shell am instrument etc
Change-Id: If8d9b446ed056996cda91fcc5e92c7077ff3ea5d
2020-06-11 08:33:45 -07:00
András Klöczl
4e2a9a04e3
Merge "Change user setup prompt dialog showing logic" into rvc-dev am: f8754b4deb am: 974efbd7f2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11686951
Change-Id: Idf895f299526d9eacdd139d8dbe77e98c22d1e1d
2020-06-11 09:35:24 +00:00
András Klöczl
cfe3027432
Merge "Change user setup prompt dialog showing logic" into rvc-dev am: f8754b4deb
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11686951
Change-Id: I56ac089933167479e20ccdb731e5b506dfbbbf48
2020-06-11 09:01:25 +00:00
András Klöczl
974efbd7f2
Merge "Change user setup prompt dialog showing logic" into rvc-dev am: f8754b4deb
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11686951
Change-Id: Ie3c8012398740f0629ef89fce1574cb21f91667d
2020-06-11 09:01:15 +00:00
András Klöczl
f8754b4deb
Merge "Change user setup prompt dialog showing logic" into rvc-dev
2020-06-11 08:47:07 +00:00
tim peng
c7005e8f1c
Merge "Apply RangeBuilder amination for media transferring" into rvc-dev am: 359d3ac829 am: 8aa018d1b1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/10987459
Change-Id: Ia0b24f6991b290a35261611245b1dd592a621acb
2020-06-11 06:24:26 +00:00
tim peng
0022d19d92
Merge "Apply RangeBuilder amination for media transferring" into rvc-dev am: 359d3ac829
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/10987459
Change-Id: Ic25cbabe73970d7e53d09dd1ca3b426998c2e8aa
2020-06-11 06:09:41 +00:00
tim peng
8aa018d1b1
Merge "Apply RangeBuilder amination for media transferring" into rvc-dev am: 359d3ac829
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/10987459
Change-Id: Ic22de77b2dae64bf64b7f0be29abad135e85c70b
2020-06-11 06:09:38 +00:00
tim peng
359d3ac829
Merge "Apply RangeBuilder amination for media transferring" into rvc-dev
2020-06-11 05:55:21 +00:00
Joshua Duong
76d2afb832
[adbwifi] Handle tls port changes.
...
Events such as adbd restarts can change the connection port. We need
to update the UI accordingly.
Bug: 158219145
Test: Manual.
1) Enable wireless debugging in Settings and validate port in UI via
> adb shell su 0 netstat -plnt | grep LISTEN
2) Restart adbd: > adb root
3) validate port again (may have changed)
Change-Id: I93339a6a258fbf69fa3f45186863a01126d279ce
2020-06-10 16:56:29 -07:00
Goven Liu
19a357bd33
Merge "[Wi-Fi] Request focus on input field when config a WiFi network" into rvc-dev am: 75d8ada079 am: 194780965f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11818501
Change-Id: I01c6ead928b15b21cfb1e0b1bea6be83cd675820
2020-06-10 09:43:11 +00:00
Goven Liu
39b77cfc2f
Merge "[Wi-Fi] Request focus on input field when config a WiFi network" into rvc-dev am: 75d8ada079
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11818501
Change-Id: I2598e69139714bc466563cace94ba33e91f3fe89
2020-06-10 09:31:17 +00:00
Goven Liu
194780965f
Merge "[Wi-Fi] Request focus on input field when config a WiFi network" into rvc-dev am: 75d8ada079
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11818501
Change-Id: If45a7ff167a2df5c9b490cced15dce18d8a737b5
2020-06-10 09:31:09 +00:00
Goven Liu
75d8ada079
Merge "[Wi-Fi] Request focus on input field when config a WiFi network" into rvc-dev
2020-06-10 09:13:38 +00:00
TreeHugger Robot
19323ada32
Merge "Add app icons to leasee view in shared data dev options." into rvc-dev am: 6647ac93d4 am: 4af89f865c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11817586
Change-Id: Ie48811783028a45cf841f6244a6be53f47dbded4
2020-06-10 08:05:35 +00:00
TreeHugger Robot
c3d70d2942
Merge "Add app icons to leasee view in shared data dev options." into rvc-dev am: 6647ac93d4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11817586
Change-Id: I4a2da8d9003dc7ced1bfa830b3424bb74fe0c4b6
2020-06-10 07:53:18 +00:00
TreeHugger Robot
4af89f865c
Merge "Add app icons to leasee view in shared data dev options." into rvc-dev am: 6647ac93d4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11817586
Change-Id: I62a98c1cd351bc6ea74e69a5a79b833c06ee5402
2020-06-10 07:53:11 +00:00
TreeHugger Robot
6647ac93d4
Merge "Add app icons to leasee view in shared data dev options." into rvc-dev
2020-06-10 07:35:36 +00:00
govenliu
dfdcdf1330
[Wi-Fi] Request focus on input field when config a WiFi network
...
For better user experience, recover the dialog focus command to get password field focused.
Bug: 158393164
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigController2Test
Change-Id: I343a7b43bd1ad2478991051b0bd8ef6082f75dc1
2020-06-10 07:20:40 +00:00
TreeHugger Robot
84ee394cf1
Merge "Fix blocked notifications screen" into rvc-dev am: 1528d932ed am: 367aeee6b8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11808483
Change-Id: I9ba51ea22f1551b79709c0de38230981920159df
2020-06-10 06:31:54 +00:00
TreeHugger Robot
42ddde2d73
Merge "Fix blocked notifications screen" into rvc-dev am: 1528d932ed
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11808483
Change-Id: If2fd41dbb50a4908962fdcbcd40ec08e9a9b8860
2020-06-10 06:15:26 +00:00
TreeHugger Robot
367aeee6b8
Merge "Fix blocked notifications screen" into rvc-dev am: 1528d932ed
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11808483
Change-Id: Iafdae12f789f21d26c59d74382b5a147feeb0454
2020-06-10 06:15:23 +00:00
TreeHugger Robot
1528d932ed
Merge "Fix blocked notifications screen" into rvc-dev
2020-06-10 05:59:31 +00:00