Commit Graph

7 Commits

Author SHA1 Message Date
Daniel Norman
1b98e50809 Uses placeholder and percentage formatter for seek bar state strings.
Placeholders and percentage formatter are best practice to help prevent
accidental translation errors, especially when mixing formatted strings
with literal percent signs.

Fix: 366201919
Flag: EXEMPT minor string format fix with no functionality change
Test: Use TalkBack to observe the state description of the seekbar;
      observe description is unchanged (e.g. "60% left, 40% right")
Test: atest BalanceSeekBarTest
Change-Id: Ie9dcc9219d253795be31b39279ed9d01d8794f66
2024-09-12 20:50:30 +00:00
Daniel Norman
0771fd8a9e Uses a custom state description for the Audio Balance seek bar.
This makes the seek bar more informative for a user of a screen reader
or other accessibility service. See context in b/319575109#comment7.

Bug: 319575109
Flag: com.android.settings.accessibility.audio_balance_state_description
Test: Use TalkBack to observe the state description while moving the
      seek bar.
Test: atest BalanceSeekBarTest
Change-Id: I7be15b26116f83854efe69d6b0560edde946daf5
2024-07-08 23:30:41 +00:00
Peter_Liang
ba297dc396 Correct the position of the marker for audio adjustment.
Root cause: Miss one the layout padding condition for computing the position of the marker.
Solution: add the layout padding condition into.

Bug: 196980036
Test: make RunSettingsRoboTests ROBOTEST_FILTER=BalanceSeekBarTest ROBOTEST_FILTER=BalanceSeekBarPreferenceTest
Change-Id: Id0c6ebbc981d9ef41e7956ffff1fc5b9d4c0e787
2021-08-30 07:16:35 +00:00
John Li
ad0e3d3f71 Add haptic effect for the seekbar in Settings 2/n.
- for Audio balance, perform haptic feedback as the seekbar's progress value is the center/min/max value.
- screenshot, https://screenshot.googleplex.com/3xJUJkvJuXTUCqe

Bug: 174109628
Test: make -j42 RunSettingsRoboTests ROBOTEST_FILTER=BalanceSeekBarTest
Change-Id: I8b4ab37a2e635fb3b1ca2a9277a06b1e83f81bbb
2020-12-01 01:18:57 +00:00
Peter_Liang
34a873884d Fix the dark theme obscures the center marker of audio balance slider.
Root Cause:
The color of center marker is wrong.

Next:
The color of center marker is white when dark theme is enabled; Otherwise, it's black.

Bug: 159028208
Test: manual test & make RunSettingsRoboTests ROBOTEST_FILTER=BalanceSeekBarPreferenceTest & make RunSettingsRoboTests ROBOTEST_FILTER=BalanceSeekBarTest
Change-Id: Id2d548778d1275709448f4c009a8469216950d8c
2020-06-17 08:30:55 +00:00
Kevin Chang
a22bd67d5c Add test cases for BalanceSeekBar
Bug: 123722274
Test: Manual
      make RunSettingsRoboTests ROBOTEST_FILTER=BalanceSeekBar

Change-Id: Ie6b560b2f92d78a0d3bd7ddb0e0d0a85c7803827
2019-03-11 10:46:13 +08:00
Edward Savage-Jones
5042c9b41b Add master audio balance setting
This adds an audio balance slider to accessibility allowing the end
user to adjust the audio balance between left and right channels.

Test: Change Balance through Settings, play audio
Bug: 28390736
Change-Id: I70f22d222ea310fd33ebe4f3fb054f44f69d2548
2019-02-05 14:26:28 -08:00