Commit Graph

1626 Commits

Author SHA1 Message Date
Daniel Norman
9ef696d0e8 Migrate Remove Animations preference to Catalyst backend.
This preference (and its test) has no flagging, but its parent
page 'Color and motion' is flagged for Catalyst migration.

This preference looks identical before and after migration.

Fix: 373451690
Flag: com.android.settings.flags.catalyst_accessibility_color_and_motion
Test: atest RemoveAnimationsPreferenceTest
Test: Enable our flag, and top-level Catalyst flag;
      Toggle the setting in Settings > Accessibility;
      Observe expected changes to animation behavior;
Change-Id: I07dbe45a120780439393d7cfd46a749025b7ab0c
2024-11-19 23:10:37 +00:00
Menghan Li
2dbb5f0c66 Merge "fix(ColorCorrection): Palette preview text contrast Issue" into main 2024-11-15 01:16:35 +00:00
Menghan Li
80f8b87e28 fix(ColorCorrection): Palette preview text contrast Issue
Root Cause: The palette preview's text color inherits dynamic colors from the BC pattern, leading to insufficient contrast against some backgrounds. This wasn't a problem in the original design, as the BC pattern was introduced later.

Solution: Set the palette preview text color to textColorPrimary to ensure the text remains legible against a wider range of background colors.

Bug: 378775277
Flag: EXEMPT bugfix
Test: atest PaletteListPreferenceTest

Change-Id: I8efb9f9d916d618b450df169292202e499d8ac0d
2024-11-14 13:03:17 +00:00
Roy Chou
04715ae017 Merge "feat(brightness suw): adjust brightness toggles UI and remove autobrightness standalone page" into main 2024-11-13 08:22:07 +00:00
Candice
f959debbe5 Enable HearingAids#AudioRouting page search if the device supports hearing aid
Enable searching in the AccessibilityAudioRoutingFragment only if the
page is available and the device supports hearing aid.

Bug: 353853318
Test: atest AccessibiilityAudioRoutingFragmentTest
Test: Manually. Add screen recording of search results to the bug
Test: Manually set the support to hearing aids to false and verify that searches to the page contents are not available
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: I6786c51438d49ff9bb1d458d312ec09bd16098a4
2024-11-11 13:37:34 +00:00
Riley Jones
5a06b74ef1 Merge "Caption settings cleanup" into main 2024-11-08 21:06:11 +00:00
Riley Jones
b3eea625ec Caption settings cleanup
Bug: 353757664
Test: atest com.android.settings.accessibility
Test: Manually verify conditions described in bug
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: Iff25702843e5dd3e7ebcca1a13f190d48cf83e7a
2024-11-08 19:09:06 +00:00
Roy Chou
c2d0b25753 feat(brightness suw): adjust brightness toggles UI and remove autobrightness standalone page
Based on the UX alignment in doc and figma, we remove the autobrightness
detailed page to make the consistency with other Vision settings, and
update the brightness preference icons and summaries.

Bug: 377289685
Flag: com.android.settings.accessibility.add_brightness_settings_in_suw
Test: manually
Change-Id: If4038de07dec7eeb38d3c057affba737849e23c9
2024-11-04 16:22:46 +00:00
Candice
db622c1aea Allow connected Hearing Aid devices to be searched by names
Bug: 353847080
Test: atest AvailableHearingDevicePreferenceControllerTest
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: I634c5ce7b31ae5d7f78a006b9cedc0725794482a
2024-11-04 09:14:00 +00:00
Candice
898d1e07ad Allow saved Hearing Aid devices to be searched by names
Bug: 353847080
Test: atest SavedHearingDevicePreferenceControllerTest
Test: Manually. Add video to the bug
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: Ic20a74bf6ffa28a82eeb44a0651861d2ff22e246
2024-11-04 09:10:53 +00:00
Candice
48d984511a Enable HearingAid page search if the device supports hearing aid
Bug: 353847080
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Test: atest AccessibilityHearingAidsFragmentTest
Test: let the HearingAidHelper return false in supporting availability and check if the items exist during search
Change-Id: I6b6ffddb5ccd44795db292d1ddc3b60f69166b2a
2024-10-28 14:39:39 +00:00
Treehugger Robot
384c432857 Merge "Removes overrides for shortcut-required service toggling." into main 2024-10-23 16:49:20 +00:00
Jacky Wang
b05a1aa543 Remove backing fields for ColorAndMotionScreen
Bug: 373451690
Flag: EXEMPT refactor
Test: atest
Change-Id: I371bd221b6079c9816725e5253e110eef423fc5e
2024-10-22 17:42:38 +08:00
Daniel Norman
41440ff248 Removes overrides for shortcut-required service toggling.
These are unnecessary now that shortcut enabling is done via
A11yManager#enableShortcutsForTargets which handles enabling
a shortcut-required service if necessary, controlled by the
rolled out a11yQsShortcut flag.

These also cause a race condition conflict when attempting to toggle a
service that does not require a warning, causing it to disable the
service immediately after enabling.

Bug: 324653372
Flag: android.view.accessibility.a11y_qs_shortcut
Test: Toggle a shortcut-required service that does not require
      a warning; service is started correctly.
Test: Repeat for a service that does require a warning
Change-Id: Iff44d87faf8a5d2eb9b6643dd582c2b697ad0b5d
2024-10-18 20:26:31 +00:00
Chun-Ku Lin
abdb92453f Merge "Create an empty color and motion screen with Catalyst Infra" into main 2024-10-18 20:26:09 +00:00
Chun-Ku Lin
688cc94413 Create an empty color and motion screen with Catalyst Infra
Bug: 373451690
Test: atest ColorAndMotionScreenTest
Flag: com.android.settings.flags.catalyst_accessibility_color_and_motion
Change-Id: I4bfa5ec4d15bd745d691f586e49318b1b0a9bf6c
2024-10-18 18:36:13 +00:00
Daniel Norman
29641287d8 Merge "Hides the Edit Shortcut top preference when empty." into main 2024-10-18 17:29:37 +00:00
Daniel Norman
4c3473134c Hides the Edit Shortcut top preference when empty.
This fixes an issue where this page was presenting an inaccurate
preference list count to TalkBack because it was including this empty
preference.

(Uses the same flag as other fixes for this same bug, even though the
flag name doesn't make sense here.)

Test: atest EditShortcutsPreferenceFragmentTest
Test: Confirm preference invisible when editing a single feature,
      opened from the Settings app
Test: Confirm preference invisible when editing a single feature,
      opened from the FAB Drag-to-Edit
Test: Confirm preference still visible when editing multiple features,
      opened from the FAB Drag-to-Edit
Test: Confirm TalkBack announces correct item counts in both cases,
      including when editing Magnification which has an "advanced"
      preference that gets replaced with the triple-tap shortcut.
Bug: 318607873
Flag: com.android.settings.accessibility.toggle_feature_fragment_collection_info
Change-Id: I2e1eb7f66022c1a47d1f96a914294fd8da25549c
2024-10-18 00:18:54 +00:00
Piotr Wilczyński
ddef40edd0 Merge "Set the same density to all displays" into main 2024-10-17 15:17:59 +00:00
Treehugger Robot
421bd753c4 Merge "Migrate Text Reading" into main 2024-10-17 00:49:14 +00:00
Sunny Shao
3d2f06fd7b Migrate Text Reading
Add the skeleton of the Text Reading

Test: atest TextReadingScreenTest
Bug: 372776688
Flag: com.android.settings.flags.catalyst_text_reading_screen
Change-Id: Ic5afa8da5ee7ea02d9ce9479c14d2c71e751dee4
2024-10-16 21:16:39 +08:00
Piotr Wilczyński
2f9f582310 Set the same density to all displays
Bug: 324439718
Test: manual
Test: atest DisplaySizeDataTest
Test: atest ScreenResolutionFragmentTest
Flag: EXEMPT bugfix
Change-Id: Ibe8b15be8968545c701a872103c1c20fa698228f
2024-10-16 12:50:57 +00:00
Mill Chen
b923194def [Catalyst] Vibration and haptics screen migration
- Add a flag for vibration and haptics migration
- Add skeleton of vibration and haptics

Bug: 368360218
Test: atest VibrationIntensityScreenTest
Flag: com.android.settings.flags.catalyst_vibration_intensity_screen
Change-Id: I0117f570fe9bf92e61974984d00c0bd5be684fff
2024-10-15 04:44:09 +00:00
Candice
2e914a311f Make Extra Dim main toggle and shortcut searchable
Since the Extra Dim main toggle and shortcut preferences are created in
codes, we override `getRawDataToIndex` to return the corresponding index raw data.

Bug: 354778552
Test: atest ToggleReduceBrightColorsPreferenceTest
Test: Manually check the preferences are searchable in Settings search
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: I1642e96273cd16f35b23350af0ede3b1247ef067
2024-10-11 16:54:53 +00:00
Riley Jones
a75ba56192 Merge "Provides an ordered array of shortcut types so Settings presents shortcuts in the desired order" into main 2024-10-10 23:00:13 +00:00
Treehugger Robot
4bcad87e0d Merge "Pass the actual quantity/count to the MessageFormat and let it decide" into main 2024-10-10 22:43:31 +00:00
Riley Jones
ea06748ee2 Provides an ordered array of shortcut types so Settings presents shortcuts in the desired order
NO_IFTTT=corrects ui order
Flag: android.provider.a11y_standalone_gesture_enabled
Test: atest AccessibilityUtilTest
Bug: 371463731

Change-Id: Ia1864076faa281cf57c469a2d0d34f859858d859
2024-10-10 20:12:04 +00:00
Chun-Ku Lin
0a6d37b871 Pass the actual quantity/count to the MessageFormat and let it decide
Bug: 185400417
Test: manual (the autoclick location has changed to Settings > System >
Trackpad & mouse > Pointer & touch accessibility > Autoclick)
Flag: EXEMPT low risk localization fix

Change-Id: Iee63b87513550a6758db9dce376e88a12a51d9f8
2024-10-10 01:03:44 +00:00
chenjean
0ac1ba5920 Makes Use Color correction and Color correction shortcut searchable.
Fix: 354079305
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Test: atest ToggleDaltonizerPreferenceFragmentTest
Test: adb shell pm clear com.google.android.settings.intelligence;
      search Settings for 'use color correction' & 'color correction shortcut', observe 'use color correction' & 'color correction shortcut' present;
Change-Id: I0fd1885c1e82ac14290dfe40636e652a624e003a
2024-10-09 14:17:06 +08:00
Jean Chen
685f66695f Merge changes Iad13fbe1,I6eed7598 into main
* changes:
  Makes Use Color inversion searchable.
  Create a method to allow child classes to define it's main switch toggle's pref key
2024-10-09 03:25:55 +00:00
chenjean
806b91414d Makes Use Color inversion searchable.
Fix: 354773587
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Test: atest ToggleColorInversionPreferenceFragmentTest
Test: adb shell pm clear com.google.android.settings.intelligence;
      search Settings for 'use color inversion', observe 'use color inversion' present;
Change-Id: Iad13fbe163002af6e84a79fdeafb8517d53e2b09
2024-10-09 07:45:11 +08:00
Daniel Norman
3079b2d108 Makes Settings > Accessibility > Magnification prefs searchable.
All preferences are searchable except for "Keep on while switching apps"
which is only searchable if the user already has a magnification
shortcut enabled, to minimize user confusion from that generically-named
preference.

NO_IFTTT=adding IFTTT

Fix: 353772926
Test: atest ToggleScreenMagnificationPreferenceFragmentTest
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Test: adb shell pm clear com.google.android.settings.intelligence;
      search Settings for the items in the bug
Change-Id: I01c7e5586ec0ea432cb2df80f156141683b97522
2024-10-08 23:42:18 +00:00
chenjean
012ba80c50 Create a method to allow child classes to define it's main switch toggle's pref key
We'd like to make the main switch toggle's preference searchable. Since we construct the preference programmatically, this would allow the preference to be automatically scrolled to when the user is brought to this page from a search result.

Bug: 372171003
Flag: EXEMPT refactor
Test: manual
Test: atest ToggleColorInversionPreferenceFragmentTest
      atest ToggleDaltonizerPreferenceFragmentTest
      atest ToggleFeaturePreferenceFragmentTest
Change-Id: I6eed7598ad296a758573318cf4bde5de30c7005c
2024-10-08 18:08:17 +08:00
Chun-Ku Lin
b3ebc1968d Merge "[Physical Keyboard][Setting] New pk a11y entry under a11y page" into main 2024-10-04 17:40:21 +00:00
shaoweishen
f0b6123acc [Physical Keyboard][Setting] New pk a11y entry under a11y page
Add entry for physical keyboard a11y page under a11y setting

Bug: 345399212
Test: atest SettingsRoboTests
Flag: com.android.settings.keyboard.keyboard_and_touchpad_a11y_new_page_enabled
Change-Id: I0c59c3a9df1b5df5e22349ab3907f767682d6fb9
2024-10-04 09:06:10 +00:00
Riley Jones
3d4b0c5440 Refactoring A11y shortcut functions in Settings to use GESTURE
Properly integrating GESTURE into Settings, so that text pertaining to the gesture shortcut are displayed when appropriate.
Heavy refactoring has been done to allow for easier cleanup and expansion

Demo video: https://x20web.corp.google.com/users/jo/jonesriley/splitShortcut/a11ySettingsGestureCompat.mp4

NO_IFTTT=changes do not alter the order of the shortcuts.

Bug: 365570709
Test: atest com.android.settings.accessibility
Flag: android.provider.a11y_standalone_gesture_enabled
Change-Id: If90719763a48e3b8bc35988a1de9a352a766953b
2024-09-28 02:50:09 +00:00
Menghan Li
e0f734526d refactor(brightness suw): decouple auto brightness initialization logic for setup flow
The AccessibilitySettingsForSetupWizard class should not be responsible for managing the initial
logic of controllers, such as determining which controllers need to be dynamically added or updated
using setInSetupWizard APIs. This logic should be handled directly by the controllers themselves.

Bug: 311093618
Flag: EXEMPT bugfix
Test: atest AccessibilitySettingsForSetupWizardTest
            AutoBrightnessPreferenceControllerForSetupWizardTest
            AutoBrightnessPreferenceControllerTest
            BrightnessLevelPreferenceControllerForSetupWizardTest
            BrightnessLevelPreferenceControllerTest

Change-Id: I6065a10e72d002981c0f514543e6933d79c2aa1b
2024-09-24 05:41:23 +00:00
Treehugger Robot
428829bfc5 Merge "Provide installed a11y services/activities from dynamicRawData for search" into main 2024-09-13 20:19:40 +00:00
Treehugger Robot
b041a687ca Merge "Uses placeholder and percentage formatter for seek bar state strings." into main 2024-09-12 22:41:52 +00:00
Daniel Norman
1b98e50809 Uses placeholder and percentage formatter for seek bar state strings.
Placeholders and percentage formatter are best practice to help prevent
accidental translation errors, especially when mixing formatted strings
with literal percent signs.

Fix: 366201919
Flag: EXEMPT minor string format fix with no functionality change
Test: Use TalkBack to observe the state description of the seekbar;
      observe description is unchanged (e.g. "60% left, 40% right")
Test: atest BalanceSeekBarTest
Change-Id: Ie9dcc9219d253795be31b39279ed9d01d8794f66
2024-09-12 20:50:30 +00:00
Chun-Ku Lin
3f19805209 Provide installed a11y services/activities from dynamicRawData for search
Bug: 354076686
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Test: Search Project Relate and verify the item shows up in the search
result
Test: Search Talkback with keywords, verify the Talkback shows up in the
search result
Test: atest AccessibilitySettingsTest

Change-Id: I258ecb0928308b7cde30c12104408e11cc25ecd5
2024-09-12 17:20:04 +00:00
Riley Jones
23fd32c6d1 Quick fix for FAB fade setting summary
Fixes the fade setting to properly set its summary when not disabled.

Flag: EXEMPT internal change
Bug: 349178637
Test: Check the settings page with navigation button mode and FAB button mode. Verify the summary of the fade setting is correct in both cases.
Change-Id: Ia87a634fd69e6098f1a0a658f788e69d10f2dbec
2024-09-12 00:01:27 +00:00
Riley Jones
8d7cd93e46 Merge "Remove mentions of "gesture" on the Accessibility Button settings page" into main 2024-09-10 23:31:54 +00:00
Riley Jones
28e10455a1 Remove mentions of "gesture" on the Accessibility Button settings page
Configures page to hide/replace elements that would mention gesture.
Also, provides context when necessary if a setting is disabled by the current button mode.

Demonstration video:
https://x20web.corp.google.com/users/jo/jonesriley/splitShortcut/a11yShortcutSettingsCleanup.mp4

Test: manual, navigate to the Accessibility Button "more options" page in gesture navigation mode. Verify there are no references to gesture.
Bug: 349178639
Flag: android.provider.a11y_standalone_gesture_enabled
Change-Id: I067738d23e74c00bab4010d187820d09013809ad
2024-09-10 17:49:45 +00:00
Daniel Norman
216353a770 Makes Caption Language searchable only if captions are enabled.
Fix: 354785578
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Test: atest CaptioningMoreOptionsFragmentTest
Test: adb shell pm clear com.google.android.settings.intelligence;
      disable captioning;
      search Settings for 'language', observe caption language missing
      enable captioning;
      search Settings for 'language', observe caption language present
Change-Id: I015d2c77fbd3f7b8fe713bafb3a49a86160ca958
2024-09-07 00:56:13 +00:00
Treehugger Robot
dcc2530964 Merge "Populates collection info count for A11y toggle feature pages." into main 2024-09-05 21:27:35 +00:00
Chun-Ku Lin
3ed0afc982 Merge "Pass null looper if the looper is not prepared in the calling thread" into main 2024-09-03 17:09:29 +00:00
Angela Wang
ed519640fa Add hearing device related logs in Settings
1. The HAC toggle on/off event
2. The "See more devices" button click in hearing device pairing page
3. The preset changed event in Bluetooth device details page

Flag: EXEMPT, simple log
Bug: 361206470
Test: manually check on go/atomviewer
Test: atest BluetoothDetailsHearingAidsPresetsControllerTest
Change-Id: I743ea136ec4cb3370c0463df865db830e73e7997
2024-09-03 08:06:43 +00:00
Chun-Ku Lin
d077ca6dd9 Pass null looper if the looper is not prepared in the calling thread
**Root cause**
The PreferenceController can be constructed by the
SettingsSearchIndexablesProvider where the looper of the thread is not
prepared. This result in not able to construct the PreferenceController
that will be used as part of the SettingsSearch.

Currently, if the SettingsSearchIndexablesProvider is not able to
construct the PreferenceController defined in xml, it would just
silently failed.

Test: atest SettingsUnitTests
Test: atest SettingsRoboTests

Flag: EXEMPT low risk bugfix
Bug: 352622249
Change-Id: I72a4ce24ec6842b9efe067e3cb7d1c73cd98a566
2024-08-29 23:02:34 +00:00
Pat Manning
f81aec1662 Replace Large mouse pointer setting with Pointer Scale
Bug: 269100659
Test: LargePointerIconPreferenceControllerTest
Flag: android.view.flags.enable_vector_cursor_a11y_settings
Change-Id: Ic643eb1eb862388eddf5d6f3de2d25739d4d23ad
2024-08-28 11:16:09 +00:00