Commit Graph

58043 Commits

Author SHA1 Message Date
Arc Wang
d1dae54f27 Merge "[Wi-Fi] Implement getDialogMetricsCategory in WifiSettings2" 2020-01-03 01:45:42 +00:00
Quang Luong
41ece633c7 Merge "[Wi-Fi] Split WifiEntryCallback into separate callbacks for each action" 2020-01-03 00:54:19 +00:00
Bonian Chen
3446cfebfa [Settings] Replacing accessing of PhoneConstants$DataState
Replaced by PhoneStateListner#onPreciseDataConnectionStateChanged().

Bug: 147080692
Test: manual
Change-Id: I0a00bac335a62079913a95bf5ab6cdb9fbcd069d
2020-01-03 08:14:42 +08:00
Curtis Belmonte
4ac1d25c2a Finish biometric enroll screens when backgrounded
Currently, there are some biometric security setting and enrollment
screens which remain open after the user has backgrounded them. This
means that they can later be resumed without requiring the user to
confirm their device credential as normal.

This commit fixes the issue in AOSP by adding logic to the affected
biometric enrollment/setting activities in to finish() with
RESULT_TIMEOUT in onStop(). We don't want to finish() these activities
prematurely if the user is currently in a wizard setup flow, however. In
that case, this commit ensures that the newly added logic will not run.

Test: Pixel 3 - Background at each step of fingerprint enroll => finish
Test: Pixel 3 - Rotate at each step of fingerprint enroll => no finish
Test: Pixel 3 - Proceed though fingerprint setup wizard => no change

Bug: 142544519
Change-Id: I8ec0fa1e30bafe097d9dc82991ff786ebf24844b
2020-01-02 11:06:29 -08:00
Bonian Chen
e520ec60aa [Settings] Remove PhoneStateIntentReceiver
1. Replace PhoneStateIntentReceiver by adopting PhoneStateListener
2. Replace TelephonyProperties.in_ecm_mode() by
TelephonyManager.getEmergencyCallbackMode()

Bug: 144331663
Change-Id: Ib127cb165c65f50851c4390b05a16dfb8024fab1
Bug: 145830780
Test: Manual
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=AirplaneModeEnabler
Merged-In: Ib39ab1881484f65bc5a3834b2828c6ba98198cca
2020-01-02 18:26:21 +08:00
Bonian Chen
6b7b92ced5 Merge "[Settings] Refactor AirplaneModeEnabler with test" 2020-01-02 10:19:59 +00:00
Arc Wang
08b4204643 [Wi-Fi] Replace some WifiEntryShell methods with WifiEntry version
These WifiEntryShell methods are removed:

getNetworkId
hiddenSSID
isPasspoint

Bug: 143326832
Test: build
Change-Id: I6642992a90ea18328817cb58931cc370045b1e56
2020-01-02 18:11:32 +08:00
Jason Chiu
2d609759cd Add preference click metric logs for some special cases
Bug: 137559984
Test: visual, robotest
Change-Id: If8624b49abcd0000487065160ce4a7ba861f234c
2020-01-02 17:45:23 +08:00
danielwbhuang
bf11e47a1b Add 5G icon in manual network selection.
Manual network selection need to have 5G icon when 5G signal is
available.

Bug: 143995814
Test: 1. Build pass.
2. check UI:
3-1. Open APN settings page: Settings > Network & Internet > Mobile Network > Advanced > Access Point Names
3-2. Turn off Automatically select network

Change-Id: I3664105d3bf52e3694a2274c6aa76a755de4e1dd
2020-01-02 15:59:46 +08:00
TreeHugger Robot
5df80504c3 Merge "Change DEFAULT_CARD_COUNT for settings homepage." 2020-01-02 07:39:24 +00:00
Jason Hsu
bda73ed270 Merge "Accessibility shortcut secondary action - auto hide divider in shortcutPreference" 2020-01-02 07:15:55 +00:00
Menghan Li
d889dec474 Merge "Support accessibility shortcut secondary action (6/n)" 2020-01-02 05:55:12 +00:00
Bonian Chen
717e0765a5 [Settings] Refactor AirplaneModeEnabler with test
Support auto testing

Bug: 147029746
Test: manual
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=AirplaneModeEnablerTest
Change-Id: Ib39ab1881484f65bc5a3834b2828c6ba98198cca
2020-01-02 12:06:00 +08:00
Bonian Chen
3e9fd2490e Merge "[Settings] Refactor AirplaneModeEnabler" 2020-01-02 03:15:51 +00:00
Tsung-Mao Fang
3fe3a1a47b Merge "Remove the @ignore flag in test file." 2020-01-02 03:04:56 +00:00
Arc Wang
0a13ae9aea Merge "[Wi-Fi] Support intent extra "wifi_start_connect_ssid" in WifiSettings2" 2020-01-01 01:17:59 +00:00
Arc Wang
5814737a49 [Wi-Fi] Implement getDialogMetricsCategory in WifiSettings2
It's necessary to implement getDialogMetricsCategory to show
dialog in WifiSettings2.

Bug: 143328194
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.wifi
Change-Id: I65ac4168ef922be981624e7916316f189ab590c2
2020-01-01 01:16:04 +00:00
Stanley Wang
74e42c7d6f Merge "The index implementation for face unlock settings." 2019-12-31 15:11:21 +00:00
TreeHugger Robot
82c437128d Merge "[Wi-Fi] Support intent extra "wifi_enable_next_on_connect" in WifiSettings2" 2019-12-31 11:33:45 +00:00
TreeHugger Robot
7ab84a073a Merge "[Wi-Fi] Show link speed for WifiDialog2 MODE_VIEW" 2019-12-31 11:16:18 +00:00
Stanley Wang
e81d6b7b31 The index implementation for face unlock settings.
- Index the delete face unlock preference and set up face unlock preference.

Fixes: 147031175
Test: manual
Change-Id: Ia984a116947d0c2e6a909f53914d081e25496f87
2019-12-31 18:59:46 +08:00
Stanley Wang
c3abeb3c99 Remove the @ignore flag in test file.
- Remove the @ignore flag in WifiTetherApBandPreferenceControllerTest.
  All test cases should pass.

Fixes: 147031384
Test: robotest
Change-Id: Icf7d5063b001699c644d6666c79b6e81709d704d
2019-12-31 18:15:23 +08:00
menghanli
a5d8e12766 Support accessibility shortcut secondary action (6/n)
Implements new edit shortcut dialog selection and save what user
prefered key back for color inversion, color correction, magnifiction,
downlaoded service - LEGACY, INVISIBLE, INTUITIVE case.

Bug: 142530063
Bug: 142531156
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilityUtilTest
Test: make RunSettingsRoboTests2
Change-Id: I94607db918047ae4082457dd33f17c8675934e2c
2019-12-31 17:42:06 +08:00
Arc Wang
3971d4e0c4 [Wi-Fi] Support disconnect button for connected Wi-Fi AP
Connect button becomes Disconnect button if the Wi-Fi AP
is connected.

Bug: 135891885
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=WifiDetailPreferenceController2Test
Change-Id: I0e0d485385294658170da3d37bc1cc1f8748468f
2019-12-31 17:06:44 +08:00
Bonian Chen
a72a038bb6 [Settings] Refactor AirplaneModeEnabler
1. Multiple instance of PhoneStateListener is not required.
2. It will be better to monitor radio power state changed instead of service state.

Bug: 147029746
Test: Manual
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=AirplaneModePreferenceControllerTest
Change-Id: I51465904ce2409b6c07c3ba80ea362d208989fbd
2019-12-31 17:02:35 +08:00
Ahmed ElArabawy
8a9ad06570 Merge "Wifi: Fix rototests for wifi tethering" 2019-12-31 08:41:11 +00:00
Arc Wang
d5ec80afc5 [Wi-Fi] Split WifiEntryCallback into separate callbacks for each action
This change uses splitted WifiEntry callbacks.

Bug: 70983952
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.wifi
Change-Id: I3b8e55b11d4f71e5548b4da82104dac1f5089b1b
2019-12-31 15:00:24 +08:00
Ahmed ElArabawy
2632c25f37 Wifi: Fix rototests for wifi tethering
This commit makes fixes to the wifi tethering rototests.
These fixes are done by using the proper encoding for the AP bands.

Bug: 146767071
Test: Run robotest
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.wifi
Change-Id: I4ddf6ea9328dabed09bc23d355efa188975316b6
2019-12-30 22:55:17 -08:00
Arc Wang
808070ccbb [Wi-Fi] Show link speed for WifiDialog2 MODE_VIEW
Now there is no WifiDialog2 MODE_VIEW use case since
they are replaced by WifiNetworkDetailsFragment2.

Should think about removing MODE_VIEW in the future,
however, we should let it work before phase out it.

Bug: 146407136
Test: build
Change-Id: I7cd470c74cea846046975b8c65fd2604702cc136
2019-12-31 14:54:31 +08:00
jasonwshsu
a2cf6a1313 Accessibility shortcut secondary action - auto hide divider in shortcutPreference
- Hide divider when settings view is gone.

Bug: 142530063
Test: manual
Change-Id: I07c9aa628c4e300d1fd21fe5b87c18ff1c294e17
2019-12-31 12:12:49 +08:00
Stanley Wang
ae89ecf8d0 Merge "Remove the unused slices." 2019-12-31 02:04:59 +00:00
Stanley Wang
9fd20149c9 Merge "Index wi-fi preferences." 2019-12-31 02:04:24 +00:00
TreeHugger Robot
d515ed7ba2 Merge "Update BrandedAccountPreferenceController" 2019-12-30 14:10:25 +00:00
Stanley Wang
0577751718 Index wi-fi preferences.
- Add xml file to index "Saved network" and "Wifi data usage"
preferences.
- Disable the "Saved network" if the access points is empty.
- Disable the "Wifi data usage" if there is no wifi radio.

Fixes: 146823365
Test: manual
Change-Id: I049d0463fd58f186dae1d5f54dcc914f52031da7
2019-12-30 19:50:18 +08:00
Stanley Wang
5ce5349167 Remove the unused slices.
Remove the DataUsageSlice, DeviceInfoSlice and EmergencyInfoSlice.

Fixes: 146994847
Test: robotest
Change-Id: Ic840e9cc93e99b3c0a34eb6536401db34c98eca8
2019-12-30 19:04:49 +08:00
Arc Wang
e8e0e5d81b Merge "[Wi-Fi] Hide the Advanced Option after expanding the advanced option fields." 2019-12-30 10:44:32 +00:00
Sunny Shao
12cef91760 Update BrandedAccountPreferenceController
Use the updateState to decide the preference display due to the displayPreference
could not be called while user press BACK key then the upper page gone and bottom
page reshow.

Fixes: 146989749
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.deviceinfo
Change-Id: I00b08b59c533ed0832ed07e6231138dd88084517
2019-12-30 18:13:37 +08:00
Bonian Chen
739ae785ff Merge "[Settings] Code refactor" 2019-12-30 08:20:39 +00:00
Automerger Merge Worker
6d56b7373a Merge "[Settings] Correct spelling in source code" am: 22c5c7d4a4 am: 42a1f866e4 am: 08b42adf46
Change-Id: I83915ffc8745cf102573e9dc7a762236ed57d696
2019-12-30 07:54:57 +00:00
Automerger Merge Worker
08b42adf46 Merge "[Settings] Correct spelling in source code" am: 22c5c7d4a4 am: 42a1f866e4
Change-Id: Iac65c4fb8ded870857207c316946535f4ec87a5f
2019-12-30 07:35:49 +00:00
Bonian Chen
42a1f866e4 Merge "[Settings] Correct spelling in source code"
am: 22c5c7d4a4

Change-Id: Ia9322a82c58385c4aed2f4b3ffa0d85aed7b123f
2019-12-29 23:21:24 -08:00
Bonian Chen
22c5c7d4a4 Merge "[Settings] Correct spelling in source code" 2019-12-30 07:18:59 +00:00
Stanley Wang
849853c468 Merge "The dynamic index implementation for time zone preferences." 2019-12-30 06:47:38 +00:00
Quang Luong
942af81d73 Merge "[Wi-Fi] Sync Connect button UI with WifiEntry connected state" 2019-12-30 06:02:23 +00:00
Automerger Merge Worker
066d3f693d Merge "Changed reference of telecom.Log to util.Log" am: f9d06dc434 am: 2bffc2754a am: c30575610c
Change-Id: I50d8ae9c889ae4764ffc8dcc7b8e714563b41bcd
2019-12-30 05:11:37 +00:00
Automerger Merge Worker
c30575610c Merge "Changed reference of telecom.Log to util.Log" am: f9d06dc434 am: 2bffc2754a
Change-Id: Ic36bfe8db4edba2a80353a9d4fa66027e5d92364
2019-12-30 04:59:08 +00:00
govenliu
91d6dfc455 [Wi-Fi] Hide the Advanced Option after expanding the advanced option fields.
To align with other advanced option behaviors in other Settings items, hide the Advanced Option button after the hidden advanced options are show, which also solve the a11y issue.

Bug: 146908469
Test: Add test case getVisibility_whenAdvancedOptionClicked_shouldBeGone
to verify View is Gone.
Change-Id: I11b2f9b250a7d50d32b8c05207498f4cf14feb41
2019-12-30 12:48:29 +08:00
Stanley Wang
f0cd9742b5 The dynamic index implementation for time zone preferences.
Disable the region settings page if auto time zone is enabled.

Fixes: 146849126
Test: manual
Change-Id: Icce1e5aca14539d6c9149e05a3321429bd337f17
2019-12-30 12:46:32 +08:00
Lee Chou
2bffc2754a Merge "Changed reference of telecom.Log to util.Log"
am: f9d06dc434

Change-Id: I5fcbf96ab581c71e714de6659b97a1bf9a3a02d9
2019-12-29 20:39:02 -08:00
Lee Chou
f9d06dc434 Merge "Changed reference of telecom.Log to util.Log" 2019-12-30 04:36:18 +00:00