Commit Graph

25691 Commits

Author SHA1 Message Date
TreeHugger Robot
c37171f1eb Merge "Dynamically return the uri of WifiSlice." 2019-02-21 18:55:40 +00:00
Doris Ling
c5a1b4f666 Remove all reference to settings_side_margin.
- since the overlay of the value for bigger screen has been removed,
the side margin is now always 0dp. Remove this dimen value and all
reference to it.

Fixes: 124526984
Test: rebuild and visual
Change-Id: I68ff42513a379111042cab9b34594822544e246e
2019-02-21 10:18:00 -08:00
TreeHugger Robot
f66882f1e1 Merge "developer-options: avoid oem-unlock preference controller crash" 2019-02-21 18:00:23 +00:00
TreeHugger Robot
85fc06d03f Merge "Fix Talkback issue" 2019-02-21 17:23:35 +00:00
Beverly
77f05fe793 Add onPreferenceClickListener to dnd schedule
- Talkback says the preference is clickable

Test: manual
Bug: 124827588
Change-Id: I1cf5ae564eb0a7ddfa60e1c307f00194f9338a13
2019-02-21 11:15:08 -05:00
bohu
9bc365febd developer-options: avoid oem-unlock preference controller crash
If there is no FEATURE_TELEPHONY_CARRIERLOCK.

BUG: 123583878

Test: lunch sdk_phone_x86-eng
make -j
emulator
the Settings->System->Developer options should not crash

Test:
make RunSettingsRoboTests ROBOTEST_FILTER=OemUnlockPreferenceControllerTest
should all pass (12 tests: 11 existing and 1 new)

Change-Id: I18c08c1ff1a7860616b0081ede4eb19dcfa8814b
2019-02-21 08:08:12 -08:00
Yanting Yang
e7f2ec1360 Update subTitle of NotificationChannelSlice
If there are <=3 channels, should not have the "Tap to manage all".

Fixes: 124461104
Test: visual, robotests
Change-Id: Iebb957c65b8ca53f4c5d482041837338b7b3bbf2
2019-02-21 23:57:55 +08:00
Pavel Grafov
19cf0b4580 Don't hide "Add user" when disallowed by admin
Bug: 125226170
Test: atest tests/robotests/src/com/android/settings/users/UserSettingsTest.java
Test: manual, with TestDPC
Change-Id: I347fae04030e04325a5ee5c634f782e554ece263
2019-02-21 13:38:53 +00:00
TreeHugger Robot
7e1bd433e6 Merge changes from topic "homepage_latency"
* changes:
  Make slices precheck executes in parallel.
  Use a better way to bind slice for slice precheck.
2019-02-21 10:10:39 +00:00
Raff Tsai
2d91873dcb Fix Talkback issue
It is a button without text. Talkback will focus on this item.
We hide this item from layout so that Talkback will not find it.

Fixes: 125065965
Test: Test it with Talkback
Change-Id: I143c02b13b9f888fa5837dd2c472cf69bd00edcf
2019-02-21 09:46:39 +00:00
tmfang
7de5314676 Add app entities widget for recently opened apps
If there is no recently opened app should be shown,
just show up an "All apps" preference.

If there are some recently opened apps, we show up
result with app entites controller.

- Clean up some useless ui. (category)
- User BasePreferenceController
- Modify test cases.

Test: robotest, visual
Change-Id: I411f61ed32eaaed97921941fd5026f1d65308d00
Fixes: 123538183
2019-02-21 16:23:18 +08:00
Yi-Ling Chuang
45ee7c2aac Dynamically return the uri of WifiSlice.
WifiSlice is used by both ContextualWifiSlice and WifiSlice itself.
In contextual homepage, we provide contextual_wifi slice for the
homepage. So in our slice pre-check, contextual_wifi slice will gets
pinned and bound. But when it comes to the state where wifi is on but
not connected, it actually returns wifi slice instead of contextual_wifi
slice, which will hit slice not pinned exception as wifi slice never
gets pinned.

Thus, we have to dynamically return the corresponding uri to  avoid this.

Fixes: 124627340
Test: robotests
Change-Id: I54ba255871628bb8eb814442f990a5d1149461e0
2019-02-21 16:14:29 +08:00
Yanting Yang
6934475d69 Merge "Fix preferences ordering issue in AccountSyncSettings" 2019-02-21 07:36:53 +00:00
Yi-Ling Chuang
dde76e6d5c Make slices precheck executes in parallel.
Slice binding takes up sometime which may cause latency.
Thus, making it run in parallel instead of sequentially to improve the
performance and avoid hitting the timeout problem.

Bug: 124366297
Fixes: 123668403
Test: robotests, unit tests
Change-Id: I5d9fa4605f59e2acef65aadf6fce85df36d8fff1
2019-02-21 15:24:28 +08:00
Yi-Ling Chuang
daa8ff36cc Use a better way to bind slice for slice precheck.
Calling Slice.bindSlice() directly will cause the exception stating that
slices are not pinned, which sometimes leads to crash. Hence, change the
way we bind slices which handles pinSlice() for us before onBindSlice().

Bug: 120552892
Test: robotests, unit tests
Change-Id: I3e65c6b79876dbee5db6f19387bc6b675f734161
2019-02-21 14:18:01 +08:00
TreeHugger Robot
5f321d7921 Merge "Replace deprecated KeyguardManager API with new BiometricPrompt one" 2019-02-21 03:05:02 +00:00
Kiyoung Kim
b837a44716 Merge "Schematize Crypto system properties" 2019-02-21 00:16:45 +00:00
TreeHugger Robot
40617d20ac Merge "Add event logging for changing SmsDefaultDialog window attr" 2019-02-20 22:56:29 +00:00
Android Build Merger (Role)
ba87cf7444 [automerger] Do not allow draw on top for default sms picker. am: 95d0fb7f49 am: b810aee20f am: 7a58589114 am: 7926131837 am: d6bde3f5b8
Change-Id: I029a177108cbe0c6646b9c717e910266c9a5a410
2019-02-20 21:54:41 +00:00
Android Build Merger (Role)
d6bde3f5b8 [automerger] Do not allow draw on top for default sms picker. am: 95d0fb7f49 am: b810aee20f am: 7a58589114 am: 7926131837
Change-Id: I16c54cab9346d161d668dc4183ae4a9eb7117996
2019-02-20 21:54:39 +00:00
Android Build Merger (Role)
7926131837 [automerger] Do not allow draw on top for default sms picker. am: 95d0fb7f49 am: b810aee20f am: 7a58589114
Change-Id: I9212ffd96f974268c0069e80e68347102967e7e5
2019-02-20 21:54:37 +00:00
Android Build Merger (Role)
7a58589114 [automerger] Do not allow draw on top for default sms picker. am: 95d0fb7f49 am: b810aee20f
Change-Id: Ic6e4308ee65a83e7d00801452323569301e65d66
2019-02-20 21:54:34 +00:00
Android Build Merger (Role)
b810aee20f [automerger] Do not allow draw on top for default sms picker. am: 95d0fb7f49
Change-Id: I9466105a6de960efb4513d4e856450459aec2560
2019-02-20 21:54:31 +00:00
Fan Zhang
95d0fb7f49 Do not allow draw on top for default sms picker.
Fixes: 120484087
Test: manual
Change-Id: I4be265565678302fad207839216d5cd65dcb6e94
Merged-In: I4be265565678302fad207839216d5cd65dcb6e94
(cherry picked from commit 9d46e1fdfe)
2019-02-20 13:53:51 -08:00
TreeHugger Robot
1de49122d3 Merge "Use MATCH_ALL to query available browsers." 2019-02-20 21:31:21 +00:00
Fan Zhang
f6dc3af6df Add event logging for changing SmsDefaultDialog window attr
Bug: 120484087
Test: manual
Change-Id: Ia5b00f79f2e54cb40377abb18c1ac07891020ae2
2019-02-20 13:13:41 -08:00
Hongming Jin
6c728dc924 Migrate emegency default app to role manager.
Bug: 123293861
Test: atest DefaultEmergencyPickerTest
Change-Id: I7bd9e2655b22a35fc3268091d38c6770911d4046
2019-02-20 11:46:02 -08:00
Hai Zhang
7bd98d2519 Use MATCH_ALL to query available browsers.
Browser intent resolution has been special for a long time, and we
need to pass MATCH_ALL to get all the candidates, then do manual
filtering later.

Bug: 116216651
Test: manual
Change-Id: I5e9b7b907005f73b7c54c3253c872d85ef7c4863
2019-02-20 11:28:01 -08:00
TreeHugger Robot
8febd82f34 Merge "Add pref for notification swipe direction" 2019-02-20 19:06:42 +00:00
Julia Reynolds
14289bd356 Add pref for notification swipe direction
And move that and other settings under an 'advanced' category

Test: robotests
Fixes: 124099692
Change-Id: I89df276a8bc1cd56ce8530239ca02b2c4b43fa65
2019-02-20 10:36:50 -05:00
Yanting Yang
11a157a8e7 Fix preferences ordering issue in AccountSyncSettings
In Pie, it's alphabetical ordering in Accounts > Account sync detail page.
But Q doesn't follow it, intend to keep the same behavior.

Fixes:124382857
Test: visual, robotests
Change-Id: I593a4cc919daa0018d3874d84978e876198aae23
2019-02-20 21:18:28 +08:00
Arc Wang
ffae615d25 Fix camera stop forever after error occurs while sharing or adding network
Restart QrCamera decoding task after Wi-Fi DPP handshake fail or
Wi-Fi connection fail.

Bug: 124128539
Test: manual test
Change-Id: I6d916ed1378f50038089e2c1e2870915ca083d68
2019-02-20 14:29:08 +08:00
Arc Wang
7bdcadbe72 Handle different error codes in DPP
Show error message for corresponding Wi-Fi DPP error code. And

1. To update error message only from each fragment,
   remove some callbacks which calls from fragment to activity.
2. After clicking 'Share Wi-Fi' button, hide it before Wi-Fi DPP handshake completes.
3. Show 'Done' button for some error codes.
4. Use ViewModel to call startEasyConnectAsConfiguratorInitiator and
   startEasyConnectAsEnrolleeInitiator because a lifecycle object
   does not receive an Executor callback after configurator change.
5. In WifiDppQrCodeScannerFragment, show an error message for 10s instead of 2s
   since new added error messages may carry more information.
6. Show a different error message for enrollee handshake success but Wi-Fi
   connection fail case.
7. stop camera when scanned a Wi-Fi DPP QR code for enrollee.
8. In QR code scanner fragment, support to show error message after
    configuration change.

Bug: 124247872
Bug: 124491247
Test: manual test
      atest WifiQrCodeTest
      atest WifiDppConfiguratorActivityTest
      atest WifiDppEnrolleeActivityTest
      atest WifiDppQrCodeGeneratorFragmentTest
      atest WifiDppQrCodeScannerFragmentTest
      atest WifiNetworkListFragmentTest
      atest WifiDppChooseSavedWifiNetworkFragmentTest

Change-Id: Id130215e9ddafac8bc4c68238deda48ce99b4255
2019-02-20 14:28:52 +08:00
Arc Wang
79a3ae860e Replace deprecated KeyguardManager API with new BiometricPrompt one
Use BiometricPrompt to replace KeyguardManager#createConfirmDeviceCredentialIntent

Bug: 124249685
Test: manual test
Change-Id: I7a05b8f1b08471cf9f09b3d4ce1bedc7cd529e72
2019-02-20 14:17:45 +08:00
TreeHugger Robot
0acd013f03 Merge "Add developer menu to enable/disable ART verifier." 2019-02-20 03:55:40 +00:00
Xiangyu/Malcolm Chen
e67344a5c5 Merge "Correct behavior of "Mobile data" button on opportunistic subscriptions." 2019-02-19 21:04:01 +00:00
Malcolm Chen
5506e0c732 Correct behavior of "Mobile data" button on opportunistic subscriptions.
A check was added earlier to make sure in DSDS mode only one sub
shows data on, which is not true for opportunistic subscriptions. For
them, it should always be on (enforced by Telephony) and be disabled
as it shouldn't be turned off.

Bug: 124331860
Bug: 124683219
Test: manual, robolectric
Change-Id: I53c8d881ff71ad25c418085d3eee63e55c786b8f
2019-02-19 21:03:42 +00:00
TreeHugger Robot
7646786cd3 Merge "Add a util method of creating Icon with Drawable" 2019-02-19 12:25:17 +00:00
Jason Chiu
c78c54a9c6 Add a util method of creating Icon with Drawable
- Add a util method to help create Icon with Drawable so that
users don't need to handle bitmaps
- Add support for creating with ColorDrawable

Test: robotest
Fixes: 124407373
Change-Id: I1897256821cc804a5e599d967feb84a3bcd689a9
2019-02-19 15:51:38 +08:00
TreeHugger Robot
de08e6e901 Merge "Fix janky in App info screen" 2019-02-19 03:48:53 +00:00
Alex Buynytskyy
787a92c983 Add developer menu to enable/disable ART verifier.
The new developer option modifies the global setting "art_verifier_verify_debuggable"; it allows to check if the bytecode of the Debuggable Apps is correct, e.g. if it's using the correct APIs.

Test: make RunSettingsRoboTests ROBOTEST_FILTER=development
Bug: 124403695
Change-Id: I8e721d62c5ca6fb5f26d9b989a8242eece8f55ab
2019-02-18 12:01:25 -08:00
tmfang
7fb266f30b Fix janky in App info screen
If a Recycle view inside in a NestedScrollView,
The times of calling recyclerView#onCreateViewHolder()
is requal to its data set.

When there are large set of apps need to be shown,
RecyclerView will need to take many time to call
onCreateViewHolder for each item.

So, it causes the screen is janky or freeze UI when page
is loading large data set.

For now, we get rid of NestedScrollView, just use RecycleView
and AppBarLayout to have same bahavior for spinner.

Fixes: 124384314
Fixes: 123036231
Fixes: 122964660
Fixes: 123088178

Test: 1. Select show system in App info screen. Observe whether there
is any janky.
2. Select show system in App info screen, and then change device
orientation. Observer whether there is any janky.
3. Go to Settings > Apps & notifications> Advanced > Special app access >
Select "battery optimization", and then Tap drop down and select "all
apps". Observe whether ther is any janky.

Change-Id: Icd65e91eec3b32476d80cc12e9c4baa71151306a
2019-02-18 17:52:03 +08:00
George Chang
8adb77fd3d Replace Banner with App Title Text
Bug: 123719839
Test: switch different payment
Change-Id: Ica90394bf5d5d0062403f2a0888c56072fdce7ee
2019-02-18 16:38:07 +08:00
TreeHugger Robot
c53f53c9ed Merge "[Network Connection] Implement "show all" button for NetworkRequestDialog" 2019-02-18 06:19:41 +00:00
TreeHugger Robot
70e97d29ef Merge "[Mac Randomization] Fix MAC randomization option does not work when ephemeral newtork" 2019-02-18 04:29:26 +00:00
TreeHugger Robot
56d2dd2515 Merge "Fix [RTL] Wifi QR Scanner option overlaps wifi Password text" 2019-02-18 04:13:39 +00:00
cosmohsieh
1e687606dd [Network Connection] Implement "show all" button for
NetworkRequestDialog

Add "show all" button to NetworkRequest dialog to let user be able to
show all AccessPoints of onMatch() callback.

Bug: 117985692
Test: atest NetworkRequestDialogFragmentTest
Change-Id: I604083fd0f3ea98208d860a327733699cd4664d7
2019-02-18 11:42:59 +08:00
TreeHugger Robot
9e9dc49cb8 Merge "Add progress bar for Privacy screen" 2019-02-18 03:04:05 +00:00
cosmohsieh
5cbd97f4ea [Mac Randomization] Fix MAC randomization option does not work when
ephemeral newtork

WifiConfiguration is only available when saved network. So ephemeral
newtork could not have wifi config to config wifi setting. In this
situation, making option be not selectable.

Bug: 122919564
Test: atest WifiPrivacyPreferenceControllerTest
Change-Id: I8a2a1c36ec6d41a6f912da29a8b17bc2e43d9a27
2019-02-18 10:55:42 +08:00
Yanting Yang
29934110dd Merge "Hide "Pair new device" from connected device slice" 2019-02-18 02:46:04 +00:00