Commit Graph

44074 Commits

Author SHA1 Message Date
TreeHugger Robot
7a5e97e10f Merge "apostrophe should be curly" into pi-dev 2018-04-06 16:32:35 +00:00
Nicolas Geoffray
932679b141 Exempt tests from hidden API checks.
Bug: 64382372
Bug: 74963051

Test: m
Change-Id: I4e51a8a7d86ac79668f66057daf550a8f04711dd
2018-04-06 14:55:46 +01:00
arangelov
cf1e59a960 Change "More details" to "Learn more" in policy transparency dialog.
Screenshot: https://screenshot.googleplex.com/5xrwW3g29qa.png

Bug: 77618738
Test: none
Change-Id: I464f492cd6b1468b85b5a691c29ae7a982ecebff
2018-04-06 14:31:32 +01:00
Bill Yi
52329a9cd3 Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I065e2a1271c2f8e4dba989736069982ed6be7f9d
2018-04-05 16:59:06 -07:00
TreeHugger Robot
c91339b3ce Merge ""Data Warn & Limits" pref. summary should be empty." into pi-dev 2018-04-05 23:41:47 +00:00
TreeHugger Robot
ac119ae807 Merge "Add new string for sound settings" into pi-dev 2018-04-05 23:33:40 +00:00
TreeHugger Robot
3da184f074 Merge "Import translations. DO NOT MERGE" into pi-dev 2018-04-05 23:12:21 +00:00
Lei Yu
85bab3d4d9 Add name and icon for AOD
Keep it in both app list and full usage list for now,
so we don't need to update smearing code.

Bug: 77156569
Test: Screenshot | RunSettingsRoboTests
Change-Id: I5247da90ea591b226cafef8f2d1ffcbff387b62f
2018-04-05 16:01:03 -07:00
TreeHugger Robot
22bf690fdd Merge "Change "X over" text color to ColorError" into pi-dev 2018-04-05 22:47:23 +00:00
Andreas Terzis
903a92535a "Data Warn & Limits" pref. summary should be empty.
The "Data Warning & Limits" preference in the Data Usage screen
should not have a summary.

Bug: 77300376

Test: manual
Test: make RunSettingsRoboTests
Change-Id: Ic567e7451ac3ea102577ab96ccef3ce7de05d4ad
2018-04-05 15:22:31 -07:00
Fan Zhang
76dbb21cb5 Protect against invalid authority in account sync pref.
Some apps might contain account synclets with empty authority. Settings
UI should protect against this type of synclets. Otherwise clicking on
these synclets will crash.

(Also removed some strings that are no longer needed)

Change-Id: I364b45fc67679aa287ff1e04e6f5ac749116543a
Fixes: 74240862
Test: robotests
2018-04-05 15:19:51 -07:00
Lei Yu
f82d22afbb Hide app if it shares uid with whitelisted app
Statsd blame app based on uid, which may mapping to multiple packages.
If there is one app in whitelist, then we shouldn't blame other apps
in anomaly detection.

Change-Id: Ib546e207eb113cef9ef5fecb1138e61558e9cf55
Fixes: 77560853
Test: RunSettingsRoboTests
2018-04-05 15:13:07 -07:00
TreeHugger Robot
148af6ba16 Merge "Update WifiScanningRequiredFragment dialog to show help page" into pi-dev 2018-04-05 22:07:30 +00:00
TreeHugger Robot
3f59ce67b6 Merge "Do not use warning or limit to display "X B left" above usage bar" into pi-dev 2018-04-05 21:36:59 +00:00
Bill Yi
494e7989ad Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I08041a5d5d29533296012921a6d53956948ad527
2018-04-05 14:34:11 -07:00
TreeHugger Robot
2c8a78a97c Merge "Update the anomaly type constants" into pi-dev 2018-04-05 21:23:24 +00:00
TreeHugger Robot
31d1b214ce Merge "Import translations. DO NOT MERGE" into pi-dev 2018-04-05 21:02:51 +00:00
Fan Zhang
79cd7986e5 Update SliceContollerInXmlTest to match latest slice spec.
- Convert the test to use CodeInspector
- Skip abstract classes when validating contract
- Also check SliderPreferenceController when validating contract

Change-Id: I671c1a622df6d1d7248a12932f144711fbf5a026
Fixes: 77634230
Test: make RunSettingsRoboTests -j40 ROBOTEST_FILTER=CodeIns
2018-04-05 13:56:07 -07:00
TreeHugger Robot
40d411abf5 Merge "Update launch intent flags for settings shortcut widgets." into pi-dev 2018-04-05 20:50:06 +00:00
Salvador Martinez
0768f15470 Update WifiScanningRequiredFragment dialog to show help page
This CL updates the WifiScanningRequiredFragment dialog so that the
learn more button is only shown when a help page is available.
Additionally, we add the metrics constant for the dialog.

Test: robotests
Bug: 67070896
Change-Id: I7697c88b5969edaf5c06eb33251f215b776c64ee
2018-04-05 13:34:03 -07:00
Jan Nordqvist
bdd559a181 Do not use warning or limit to display "X B left" above usage bar
Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I46f4f5f1cf6092038e49beaafe5aa6a19ffb0aa1
2018-04-05 13:22:06 -07:00
TreeHugger Robot
220a6a002e Merge "Fall back to Wi-Fi data display in data usage screen with no SIM." into pi-dev 2018-04-05 19:59:00 +00:00
Bill Yi
41106de196 Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I2be2f8d5061e7b01fd97170d861d68980db9e665
2018-04-05 12:33:14 -07:00
TreeHugger Robot
963a4fb59e Merge "Couple more Scoped Directory Access changes." into pi-dev 2018-04-05 19:02:11 +00:00
Julia Reynolds
560637970f Make volume sliders sliceable
Test: make -j RunSettingsRoboTests
Change-Id: I8495770792dfdada54174ca61937f336e4fc219c
Fixes: 67997207
2018-04-05 14:47:44 -04:00
Lei Yu
695290b129 Update the anomaly type constants
Bug: 77323601
Test: Build
Change-Id: I0b6733edbfe12f494104f78be7087fa621191431
2018-04-05 11:13:50 -07:00
Lei Yu
197be04330 Merge "Show Battery saver tip when battery saver is on" into pi-dev 2018-04-05 17:48:55 +00:00
TreeHugger Robot
d95668db99 Merge "Fix crash in Monkey test." into pi-dev 2018-04-05 17:46:21 +00:00
Lei Yu
0a358ba47c Add battery illustration
Also update the VideoPreference to handle the full screen
illustration by adding attr isFullWidth and aspectRadio.

Change-Id: If2ccba4ce792801c6fd79b7c60af4e3826c091cc
Fixes: 74409022
Test: Screenshot | RunSettingsRoboTests
2018-04-05 10:26:41 -07:00
Doris Ling
f2d7680d2c Update launch intent flags for settings shortcut widgets.
- earlier changes were made to the intent flags when creating new
settings shortcut to ensure that it is launching a new task. However,
ShortcutManager is actually caching existing shortcut info, and it will
continue to use the existing shortcut info unless we explicitly update
the info.
- when rebooting from build upgrade, we will go through all existing
shortcut to update the launch intent flags to ensure that the shortcut
info is update to date.

Change-Id: Iee2365d9aec64a47b193e3c9be443c252504815b
Fixes: 76395879
Test: make RunSettingsRoboTests
2018-04-05 10:20:26 -07:00
TreeHugger Robot
1b899f2a0a Merge "Fix issue in ring volume sample not always being played." into pi-dev 2018-04-05 17:12:43 +00:00
Lei Yu
2e96ec2f99 Merge "Hide uninstalled app in restrict app dialog" into pi-dev 2018-04-05 16:57:13 +00:00
Jan Nordqvist
a2731e24a6 Change "X over" text color to ColorError
Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I2a59d6b4b4549a780ae168e9e1b3f356c677262c
2018-04-05 09:30:43 -07:00
TreeHugger Robot
8d905b2f9e Merge "Update settings to reference correct versionCode" into pi-dev 2018-04-05 16:20:25 +00:00
Bill Yi
4c2704847b Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I3feadbd392d82249b0318377310b4d1155057773
2018-04-05 07:28:37 -07:00
TreeHugger Robot
086dbda475 Merge "Fix a bug where homepage is using staled locale for tiles" into pi-dev 2018-04-05 04:57:46 +00:00
TreeHugger Robot
295b1dba78 Merge "Import translations. DO NOT MERGE" into pi-dev 2018-04-05 03:55:05 +00:00
Lei Yu
559f65a28a Show Battery saver tip when battery saver is on
Before this CL, we only show "Battery Saver is on" when users turn it
on in battery tips.

In this CL, we change to constantly show this tip when battery
saver is on.

Change-Id: I9ddefdbd5818725202ddf4469b4a685ba008060a
Fixes: 75251000
Test: RunSettingsRoboTests
2018-04-04 18:28:57 -07:00
Bill Yi
9905176917 Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: Ibf6633b42d66e2c1418c2c3b719533a36c696f6a
2018-04-04 18:18:03 -07:00
Doris Ling
de08eaf437 Fix issue in ring volume sample not always being played.
- when we adjust the sound volme in Sound settings, we only re-post the
stop sample message when we receive the onSampleStarting callback.
However, if we change the volume while a sample is still playing,
onSampleStarting will not be called as it's already started. This
results in shortened sample duration, which in extreme case, the new
sample will not be played at all if the new volume change is made almost
towards the end of the previous sample period. So, everytime user change
the volume, we should re-post the stop sample message, so that the
sample playing duration would be extended properly.

- also removed the original calls to the onStreamValueChanged() during
init, as the original implementation is empty, and during init, we do
not need any handling to start/stop the sample.

Change-Id: I9f35ddfb6d809eeb83b1a732a09362286ff6ed77
Fixes: 77514234
Test: make RunSettingsRoboTests
2018-04-04 17:35:41 -07:00
Fan Zhang
f1030e8cdf Fix a bug where homepage is using staled locale for tiles
When setting a new locale, SettingsActivity restarts to load
everything in the new locale.

Data (containing locale specific title/summary etc) is reloaded
correctly and triggers a callback to UI to redraw.

However we skip the first callback as an optimization for app startup
time. When we restart fragment, we failed to save the state whether we
have already seen the first callback. So when data with new locale text
triggers the callback, it's being skipped and this make UI still render
in old locale.

The fix is to just save the state before fragment gets destroyed before
locale change so the callback can trigger later.

A better fix is: make data (Tile object) not cache text. Then we don't
need to worry about locale cache at all. We should do this fix in the
long term.

Test: localeswitcher
Test: adb shell am broadcast -a com.google.android.testing.i18n.localeswitcher.CHANGE_LOCALE -e LANGUAGE_TAG "zh"
Test: adb shell am broadcast -a com.google.android.testing.i18n.localeswitcher.CHANGE_LOCALE -e LANGUAGE_TAG "ja"

Fixes: 77470788
Bug: 77600770

Change-Id: Ic4223ddbb679db64d0fc3c29d16a5f61a66cc99c
2018-04-04 17:29:45 -07:00
TreeHugger Robot
66e6e637a4 Merge "Fix crash in non-indexable keys collection" into pi-dev 2018-04-04 23:59:49 +00:00
Daniel Solomon
a1687df27b Disable user control of color mode depending on Accessibility
The Accessibility settings for color inversion and color correction are
incompatible with some color modes. When either of these settings is
enabled, disable GUI color mode controls.

Bug: 68856024
Change-Id: I12fad22190283bac38592b94e88d865d3af978ad
2018-04-04 16:04:14 -07:00
Jan Nordqvist
cd3f9e2a5e Fall back to Wi-Fi data display in data usage screen with no SIM.
Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I06bf78e54119819be87e15baca7e5b6a241958cb
Merged-In: I06bf78e54119819be87e15baca7e5b6a241958cb
2018-04-04 15:58:53 -07:00
TreeHugger Robot
b299122e08 Merge "Updates to match prebuilts drop" into pi-dev 2018-04-04 22:40:27 +00:00
TreeHugger Robot
fe7cc296c1 Merge "Expressly forbid IP string literals as Private DNS hostnames" into pi-dev 2018-04-04 21:30:32 +00:00
Makoto Onuki
e0c97aa65d Once auto-battery saver is ever set, don't show suggestion
Bug: 77228046
Test: manual test after adb shell settings delete secure suppress_auto_battery_saver_suggestion
Test: m -j ROBOTEST_FILTER=BatterySaverButtonPreferenceControllerTest RunSettingsRoboTests
Change-Id: If0d26f05399a33269d9540e6e09292ce46765637
2018-04-04 13:58:24 -07:00
TreeHugger Robot
1400734315 Merge "Log when settings slice is requested/updated." into pi-dev 2018-04-04 20:37:15 +00:00
Matthew Fritze
3cd543fb85 Fix crash in non-indexable keys collection
Some of the AmbientDisplay preference controllers were
crashing when their isAvailable methods were being called
by their fragment's search index providers, which meant that
the entire collection of non-indexable keys failed. Thus,
all search results were showing up. In the case of a secondary
user, they were able to see developer options which crashed
settings when clicked.

There are two issues addressed in this cl.
1. Fix the crashes so the non-indexable keys collection works
2. Contain each fragment's collection, so that if a fragment does
crash, the damage is minimized.

Part 1 is checking that the config in isAvailable is not null,
and creating one if so.

Part 2 is fixed by surrounding the collection of non-indexable
keys in a try-catch, with an option in the catch to re-throw the
error if a system property is set. Thus, in a new pre-submit
instrumentation test, we can and docheck if any of the fragments crash
when collecting non-indexable keys.

Change-Id: I820bd9cb2649aa6faff7f82fcf575a62e41dc4fc
Fixes: 77486668
Test: atest NonIndexableCrashTest, robotests
2018-04-04 13:36:33 -07:00
Patrick Baumann
ea4874db83 Update settings to reference correct versionCode
This settings change is required for a framework change that ensures
that apps built for pre-P that rely on reflection to access
ApplicationInfo#versionCode don't crash. The move to long version
code introduces a new field and all modifications of the field are
wrapped in a method that ensures both the new and old fields are set
appropriately.

Bug: 74393568
Test: manual - builds and broken app runs
Change-Id: Idfa5f85d3f91583098ebee88f0e8caecaacff9b4
2018-04-04 13:17:05 -07:00