Commit Graph

142371 Commits

Author SHA1 Message Date
Matías Hernández
fa494a6d46 Merge "Tweak Modes layouts and use updated strings to match mocks" into main 2024-07-31 07:34:43 +00:00
Yiling Chuang
0e903bfe7f RESTRICT AUTOMERGE FRP bypass defense in App battery usage page
Before the setup flow completion, don't allow the app info page in App battery usage to be launched.

Bug: 327748846
Test: atest SettingsRoboTests + manual test
- factory reset + launch app battery usage app info via ADB during Setup -> verify app closes
Flag : EXEMPT bugfix

Change-Id: I486820ca2afecc02729a56a3c531fb931c1907d0
Merged-In: I486820ca2afecc02729a56a3c531fb931c1907d0
(cherry picked from commit 419a6a9079)
2024-07-31 07:21:54 +00:00
Yiling Chuang
23b88e0724 RESTRICT AUTOMERGE FRP bypass defense in App battery usage page
Before the setup flow completion, don't allow the app info page in App battery usage to be launched.

Bug: 327748846
Test: atest SettingsRoboTests + manual test
- factory reset + launch app battery usage app info via ADB during Setup -> verify app closes
Flag : EXEMPT bugfix

Change-Id: I486820ca2afecc02729a56a3c531fb931c1907d0
Merged-In: I486820ca2afecc02729a56a3c531fb931c1907d0
(cherry picked from commit 419a6a9079)
2024-07-31 07:18:16 +00:00
Yiling Chuang
c9d2588c69 RESTRICT AUTOMERGE FRP bypass defense in App battery usage page
Before the setup flow completion, don't allow the app info page in App battery usage to be launched.

Bug: 327748846
Test: atest SettingsRoboTests + manual test
- factory reset + launch app battery usage app info via ADB during Setup -> verify app closes
Flag : EXEMPT bugfix

Change-Id: I486820ca2afecc02729a56a3c531fb931c1907d0
Merged-In: I486820ca2afecc02729a56a3c531fb931c1907d0
(cherry picked from commit 419a6a9079)
2024-07-31 07:06:38 +00:00
Yiling Chuang
3c2a216bbb RESTRICT AUTOMERGE FRP bypass defense in App battery usage page
Before the setup flow completion, don't allow the app info page in App battery usage to be launched.

Bug: 327748846
Test: atest SettingsRoboTests + manual test
- factory reset + launch app battery usage app info via ADB during Setup -> verify app closes
Flag : EXEMPT bugfix

Change-Id: I486820ca2afecc02729a56a3c531fb931c1907d0
Merged-In: I486820ca2afecc02729a56a3c531fb931c1907d0
(cherry picked from commit 419a6a9079)
2024-07-31 07:04:20 +00:00
Chaohui Wang
a6d7b8c9d9 Improve the robustness of updateNonIndexableKeys
- Isolate preference controller crash in the same page
  Current if one search item throw exception, entire page's search will
  broken, can isolate issue by controller to improve.

- Expose preference controller crash in debuggable build
  Current the search index exception is silently ignored, expose the
  exception in debuggable builds to expose issue earlier.

- Change default to hide items instead of shown when crash

Fix: 352455031
Fix: 352455432
Fix: 352455540
Flag: EXEMPT bug fix
Test: manual - Settings Search
Change-Id: I2cdbd58543be8fe6617e42d9c02789791186f53b
2024-07-31 14:58:35 +08:00
Yiyi Shen
ec282ed60b Merge "[Audiosharing] Clean up dup codes" into main 2024-07-31 05:20:39 +00:00
Yiling Chuang
0c097d5c0d RESTRICT AUTOMERGE FRP bypass defense in App battery usage page
Before the setup flow completion, don't allow the app info page in App battery usage to be launched.

Bug: 327748846
Test: atest SettingsRoboTests + manual test
- factory reset + launch app battery usage app info via ADB during Setup -> verify app closes
Flag : EXEMPT bugfix

Change-Id: I486820ca2afecc02729a56a3c531fb931c1907d0
Merged-In: I486820ca2afecc02729a56a3c531fb931c1907d0
(cherry picked from commit 419a6a9079)
2024-07-31 04:04:47 +00:00
Chaohui Wang
86e5406c46 Merge "Reduce flaky of InstantAppDomainsPreferenceTest" into main 2024-07-31 03:45:02 +00:00
Edgar Wang
83e43b6e98 Use SwitchPreferenceCompat instead of SwitchPreference
Bug: 356105969
Change-Id: I0770313b9ee560298ea1d2b8938f511c4b36d7d1
Test: manual
Flag: EXEMPT bug fix
2024-07-31 03:03:17 +00:00
Joshua Mccloskey
a2b127bbe8 Merge "Remove face/fignerprint search if not present" into main 2024-07-30 23:02:58 +00:00
Daniel Norman
0e44239daf Never restricts Accessibility Activities based on ECM/admin.
Keeps accessibility activity preference as inheriting from
RestrictedPreference since it shares lots of behavior with the
accessibility service perference (same base class), but always
calls setEnabled(true) for activities.

Fix: 331990900
Flag: com.android.settings.accessibility.never_restrict_accessibility_activity
Test: atest RestrictedPreferenceHelperTest
Change-Id: I39971bc3f65aa630fa62a0e31132f177fd21b635
2024-07-30 21:34:23 +00:00
Bill Yi
ceeb62c413 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-07-30 20:51:59 +00:00
Bill Yi
796d9b65b1 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-07-30 20:51:59 +00:00
Diya Bera
8f0c77bb19 Add mandatory biometric prompt to platform surfaces (4/N)
1. Enable developer options via build info
2. Enable developer options via toggle under system -> developer options

Flag: android.hardware.biometrics.flags.mandatory_biometrics
Fixes: 355500452
Test: atest BuildNumberPreferenceControllerTest
DevelopmentSettingsDashboardFragmentTest

Change-Id: Iecbe34024d287e71e235becec3ce5a2bd5c1697f
2024-07-30 20:36:31 +00:00
Treehugger Robot
95fded9b3e [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: d0e1e57003 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/28537384

Change-Id: Ifd1634b8bb09cd503ac0e990a393d888cf3582fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-30 19:41:52 +00:00
Bill Yi
d1991e6b07 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 53c28ece72 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/28537384

Change-Id: I03a126bdc7fa65b00ae1cd75033e04547e30ccbb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-30 19:41:43 +00:00
Bill Yi
989a1debc9 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 92d90e7f13 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/28535560

Change-Id: Ib81d810924f0ae188f0f7368fbb400f4ab5a197c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-30 19:41:31 +00:00
Treehugger Robot
d0e1e57003 Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev 2024-07-30 19:24:04 +00:00
Bill Yi
23f6c8fe06 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: b7cf038679 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/28535559

Change-Id: I3a22d09a14f76d8383185d7e1fb04dcab32fa35d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-30 18:22:00 +00:00
Joshua McCloskey
ed59922ca8 Remove face/fignerprint search if not present
Test: Verified manually with a device that if face/fingerprint are not
present they do not show up.
Fixes: 350599580
Flag: EXEMPT bugfix

Change-Id: I6a691d2985e4839336e9c08dfa6c97abe23f43f2
2024-07-30 18:14:41 +00:00
Priyanka Advani (xWF)
9bf8ce78b2 Merge "Revert "Change API requestIsEnabled to requestIsSessionStarted"" into main 2024-07-30 18:12:18 +00:00
Matías Hernández
0359aaeb47 Tweak Modes layouts and use updated strings to match mocks
Bug: 333682392
Test: mostly manual, also ZenModeTriggerUpdatePreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I5bae828a55128f3cb0b07ea0ff21ca196e7564dc
2024-07-30 17:45:38 +00:00
Matías Hernández
f4d44c5500 Fix Zen tests that were failing with modes_ui enabled
Actual fixes are in ZenModesListFragmentTest (was creating somewhat unrelated preferences with the actual ZenModesBackend, and isAvailable now returns true for them) and ZenModePreferenceControllerTest (no longer available with modes_ui). But also added EnableFlags(FLAG_MODES_UI) to all tests in notification/modes that lacked it, so we don't regress before we flip the flag.

Bug: 356334282
Test: atest com.android.settings.notification
Flag: android.app.modes_ui
Change-Id: I791b52cfb3fd9adea61079b4b41e456c8b3fe7bd
2024-07-30 14:33:03 +02:00
Oli Thompson
2a8b7039b0 Fix UnsupportedOperationException from immutable set
change immutable set to HashSet

Flag: android.app.admin.flags.backup_connected_apps_settings
Bug: 355817689
Test: manually tested
Change-Id: I983d9b3f979e5659669a4a318f03e720623a47b4
2024-07-30 10:49:36 +00:00
Chaitanya Cheemala (xWF)
413e85fa7a Revert "Change API requestIsEnabled to requestIsSessionStarted"
Revert submission 28533501-NTN_check_modem_state

Reason for revert: Likely culprit for b/356320274  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:28533501-NTN_check_modem_state

Change-Id: I4cdb936eb6a27eeee0aba6a5adfcf9cbdfacd5eb
2024-07-30 09:31:35 +00:00
Haijie Hong
2e12b95c45 Merge "Add multi-toggle preference UI for device details page" into main 2024-07-30 09:25:12 +00:00
Chaohui Wang
e15fcaa1cf Reduce flaky of InstantAppDomainsPreferenceTest
Also DeveloperOptionsControllerTest.

Fix: 355270127
Flag: EXEMPT test only
Test: atest InstantAppDomainsPreferenceTest
Test: atest DeveloperOptionsControllerTest
Change-Id: I80517988b8674ec4d717292da71454419762e65a
2024-07-30 16:29:09 +08:00
Yiyi Shen
7b2435a01c [Audiosharing] Clean up dup codes
Bug: 305620450
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Test: atest
Change-Id: Ife2bf26d78e522dc51891be633d6635883923de3
2024-07-30 15:34:09 +08:00
Chaohui Wang
3a8ce3f970 Merge "Call wifiStatusTracker.fetchInitialState first" into main 2024-07-30 07:09:34 +00:00
Tom Hsu
d5225c236d Merge "Change API requestIsEnabled to requestIsSessionStarted" into main 2024-07-30 06:51:17 +00:00
Chaohui Wang
0be6705da6 Call wifiStatusTracker.fetchInitialState first
Before set listening to true, otherwise could cause race condition.

Fix: 354500692
Flag: EXEMPT bug fix
Test: manual - check wifi summary
Change-Id: I4160f89fae666ac02b816b7d9a69bac581bbd29e
2024-07-30 13:51:52 +08:00
Chaohui Wang
30b9c3c1ae Merge "Create SubscriptionRepository.phoneNumberFlow" into main 2024-07-30 04:41:02 +00:00
Hakjun Choi
ad6c9cf31a Merge "[Internal cleanup] remove warning message for resource ID" into main 2024-07-30 04:38:09 +00:00
Chaohui Wang
7009c008f9 Fix search for MMS Message
Also display multiple results when there are multiple MMS Message on
different SIMs.

When doing indexing, we not also log sub id as part of the key.
When user clicks the result, using SpaSearchLandingActivity to do the
redirection, set arguments to the fragment.

Fix: 352245817
Flag: EXEMPT bug fix
Test: manual - search mms
Test: unit test
Change-Id: Id47a1151cb418c18f68f97e3be33dcd21c5f5102
2024-07-30 11:34:24 +08:00
Haijie Hong
cc2114a797 Add multi-toggle preference UI for device details page
BUG: 343317785
Test: atest DeviceSettingRepositoryTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I67e7647fee39e789cc1342943f69e7ddc170d0eb
2024-07-30 10:59:27 +08:00
Pajace Chen
ab697ce33f Merge "[Bugfix] Fix the failed test case" into main 2024-07-30 02:43:19 +00:00
pajacechen
a9eb7c90dd [Bugfix] Fix the failed test case
Fix the failed test case that missed from ag/28495857

Test: Unit Test
Fix: 348563863
Fix: 356152111
Flag: EXEMPT bug fix
Change-Id: I852da018c6967c6ca13e3aea72290a2d6be8bfdd
2024-07-30 10:10:35 +08:00
Chaohui Wang
7477f4ea9a Show category when search "Mobile data"
The displayed category is "SIMs".

Bug: 346776183
Flag: EXEMPT bug fix
Test: manual - search "Mobile data"
Test: unit test
Change-Id: If3c395281e96603193e7476a9e76d1f9e9213531
2024-07-30 09:48:28 +08:00
tomhsu
b091995671 Change API requestIsEnabled to requestIsSessionStarted
- Avoid using APM/WIFI/BT in settings app from any transitioning from TN to NTN.

Flag: EXEMPT bugfix
fix: 354806125
Test: Manual test
Change-Id: Id65567971b3d1ea3e177a0cc1e1304446d8fa0e8
2024-07-30 01:27:58 +00:00
Matías Hernández
50a18d9e85 Merge "Fix a11y issues in the schedule editor" into main 2024-07-29 23:29:26 +00:00
Bill Yi
92d90e7f13 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I3e773ef09338ed8525dcfaa4a2b58f2bbdf828d5
2024-07-29 15:24:03 -07:00
Bill Yi
37a3e16ae5 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ida6326582c7ec91706155298c198da670848373d
2024-07-29 15:23:10 -07:00
Bill Yi
53c28ece72 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Idc757e3710cb3aae594b35c1c26b75fc56f6e2c4
2024-07-29 15:20:44 -07:00
Bill Yi
0db37a4d5b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I879f0ef0f2c7cb82d851352cf7a75fcbecc5bdc4
2024-07-29 15:18:54 -07:00
Bill Yi
b7cf038679 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I6ae0fec262e838110a867b3555a61f1d577482af
2024-07-29 15:14:51 -07:00
Matías Hernández
149bd0a5a4 Merge "Improve lifecycle of ZenModeFragment & friends" into main 2024-07-29 20:28:55 +00:00
Matías Hernández
a463b0af7b Fix a11y issues in the schedule editor
* Don't read start / end time as separate labels.
* Fix content description of day buttons (ToggleButton's stateDescription is textOn/textOff -- which are the same for this particular button, thus it wasn't possible to know whether a day was selected or not).

Fixes: 346396147
Test: manual, with Talkback
Flag: android.app.modes_ui
Change-Id: If73a791cf9bd62cf17e058c81a8051b3e7fd82ea
2024-07-29 18:11:34 +00:00
Matías Hernández
691c0c3f6a Fix unwanted animation when opening Modes list
Fixes: 356151158
Test: manual
Flag: android.app.modes_ui
Change-Id: Ibbc54c68c4bcbf75e908d4a36ef2d8f609b5b797
2024-07-29 18:11:17 +00:00
Matías Hernández
b8b897e552 Improve lifecycle of ZenModeFragment & friends
* Don't keep Settings observers longer than start-stop.
* Only call updateState() once on controllers during create->start->resume.
* Remove some duplicate controller update methods from ZenModesFragmentBase (we can directly call DashboardFragment's).
* Don't update controllers if unrelated modes were changed.
* Extract ZenSettingsObserver for use in the link tile later.
* Add tests.

Fixes: 353946788
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: I64b51714d699b5c3a592a76fcb615d2999998829
2024-07-29 20:10:03 +02:00