Commit Graph

50617 Commits

Author SHA1 Message Date
TreeHugger Robot
00b0abd68e Merge "Force LSKF in ConfirmCredential UI when pending escrow token exists" 2019-03-18 19:44:47 +00:00
Fan Zhang
9f5e7b77ff Merge "Fix crash on AppInfo screen" 2019-03-18 18:36:49 +00:00
Hunter Knepshield
711b78d5ed Merge "[Strings + layout] Minor changes for eSIM erase." 2019-03-18 18:17:20 +00:00
TreeHugger Robot
eaf00ae476 Merge "Handle the SQLiteDatabase already-closed problem" 2019-03-18 18:13:27 +00:00
TreeHugger Robot
15bd7f24e9 Merge "Add null check for worker" 2019-03-18 18:01:08 +00:00
Brad Ebinger
be10b45fe6 Merge "Do not show Provisioning items for IMS if it is not enabled." 2019-03-18 17:35:27 +00:00
Jack Yu
c2299333ae Merge "Renamed NetworkRegistrationState to NetworkRegistrationInfo" 2019-03-18 17:28:08 +00:00
Rubin Xu
e0efe27f03 Force LSKF in ConfirmCredential UI when pending escrow token exists
Escrow tokens can only be activated by user confirming their LSKF,
while ConfirmCredential allows both LSKF and biometrics by default.
By requiring LSKF, it simplifies the DPC's flow of requesting the user
to activate a pending escrow token.

This change tweaks the ConfirmCredential UI to skip biometrics if pending
token exists.

Bug: 127377026
Bug: 76084679
Bug: 79547502
Test: manual
Change-Id: Iee9b2d57d7f4de98e225b3aeff7cc35cc8e3d36a
2019-03-18 17:20:26 +00:00
TreeHugger Robot
50bdbe92ab Merge "Move WakeGestureScreenGestureSettings" 2019-03-18 17:20:01 +00:00
Annie Meng
66ac958993 Update OWNERS for backup settings
Test: build/make/tools/checkowners.py -c -v OWNERS
Change-Id: Ib98d9c9ef2b538b7d620e1361d0e48d263635449
2019-03-18 17:18:39 +00:00
Yanting Yang
0f3049d4b7 Fix voice access issue on home page
Bug: 128825246
Test: manual
Change-Id: Icd9b31c195f44b11b97a30292de586483ea2e651
2019-03-18 22:12:49 +08:00
TreeHugger Robot
e7668660d5 Merge "Move a few classes around for easier ownership control" 2019-03-18 12:06:30 +00:00
Sunny Shao
c7e094001d Handle the SQLiteDatabase already-closed problem
Remove the database.close in code for handling the re-open an already-closed object:SQLiteDatabase
problem.

Bug: 124451874
Test: robotest
Change-Id: Iff8c0bc5ea092d42cff0a40dfa4324a4de7c90bc
2019-03-18 19:42:09 +08:00
hughchen
8f76b44410 Add null check for worker
Add null check to avoid crash when worker cannot get through uri.

Bug: 128492874
Test: make -j42 RunSettingsRoboTests
Change-Id: I789ce0bfa98c0b0b145a8605c58c88a77eeb76a9
2019-03-18 19:12:32 +08:00
Jason Chiu
d4ab14969f Merge "Fix the bug of "Connecting" is rarely appearing on Wi-Fi slice" 2019-03-18 10:13:56 +00:00
Hyundo Moon
eecf8a55fd Merge "Remove ControllerLink" 2019-03-18 10:03:07 +00:00
Jason Chiu
4e42f53896 Fix the bug of "Connecting" is rarely appearing on Wi-Fi slice
- AccessPoint treats connected and connecting as equal so slice doesn't
refresh in this case
- Add a new method to determine if two lists are the same in SliceBackgroundWorker
- WifiScanWorker overrides this method to check the access point states

Fixes: 123941320
Test: robotest
Change-Id: I78d610da4b6b1d40f5785ba6701fb71b987fe31c
2019-03-18 16:01:48 +08:00
TreeHugger Robot
d1089d5c11 Merge "Update the expand more icon in the condition" 2019-03-18 06:24:26 +00:00
tmfang
062d4acf45 Fix crash on AppInfo screen
We start a search page with a request code which is same as
"uninstall" request code. The root cause is we handle same
reuqest code for different event.

We redefine an unique request code for "search" feature.

Fixes: 124775813
Test: Click search and back to App info screen.
Change-Id: I8ab21c30b605bcb65b6d4bd9fceb749a65a49f80
2019-03-18 14:09:52 +08:00
Sunny Shao
3ef480e895 Update the expand more icon in the condition
- Rollback the color from accent to gray.
- Use the "ic_expand_more_inverse.xml" to replace the "expand more" icon.

Fixes: 126926489
Test: manual
Change-Id: I438a03f42987001de7dce5040dd01347c2c6a9b0
2019-03-18 06:08:16 +00:00
TreeHugger Robot
313bddb80e Merge "Log contextual card event to CURRENT user" 2019-03-18 05:56:25 +00:00
TreeHugger Robot
b07c5371b7 Merge "Use short format to avoid truncated problem" 2019-03-18 04:49:14 +00:00
Raff Tsai
a4fa5bc212 Log contextual card event to CURRENT user
Fixes: 128804262
Test: Robolectric. Manual
Change-Id: I6e7cffe0773572025beb3ab7964cc18da49681c2
2019-03-18 04:33:14 +00:00
tmfang
0b73c29993 Fix color lint check error
Test: We can upload CL.
Change-Id: Iabe1d918a98167048b86dae1b61d450fb2e8bd97
2019-03-18 11:43:28 +08:00
TreeHugger Robot
47e8fbbcee Merge "Choose a pref key less likely to conflict" 2019-03-16 02:54:25 +00:00
Hall Liu
bf04e65d39 [automerger skipped] Merge "Base implementation of WFC disclaimer UI" am: 7e2c23aa0d am: 257e6f71ee
am: 770e610a77 -s ours
am skip reason: change_id I789f530d3e16baa6e56feaa4269f6696976f747e with SHA1 9fae73915c is in history

Change-Id: I19290040bf66d86354f83aa7854ee549cf54d50a
2019-03-15 17:41:47 -07:00
Hall Liu
770e610a77 Merge "Base implementation of WFC disclaimer UI" am: 7e2c23aa0d
am: 257e6f71ee

Change-Id: Iceb8fffc425756e19b1a2bf16469b0cb69a444da
2019-03-15 17:37:37 -07:00
Hall Liu
257e6f71ee Merge "Base implementation of WFC disclaimer UI"
am: 7e2c23aa0d

Change-Id: Ib89de5bf801b6669795e7c49010136a0e966324a
2019-03-15 17:33:26 -07:00
Hall Liu
7e2c23aa0d Merge "Base implementation of WFC disclaimer UI" 2019-03-16 00:23:23 +00:00
hughchen
6feb55546d Sound + Output Switcher on Volume Slice
- Show "play media to" item when Previously Connected device is available
- Click "Play media to" to launch output slice
- Update test case

Bug: 127729340
Test: make -j50 RunSettingsRoboTests
Change-Id: Ic00b309f87bc16f540b22b5a43fecb86f76caeb2
2019-03-16 07:04:43 +08:00
manabu, shimoda
8498436a96 Base implementation of WFC disclaimer UI
Test: manual - Check that no error occurred when changing the wifi
calling settings to turn on.
Test: auto - Passed WifiCallingSettingsForSubTest,
WifiCallingDisclaimerFragmentTest and DisclaimerItemListAdapterTest.
Bug: 67872298

Change-Id: I789f530d3e16baa6e56feaa4269f6696976f747e
Merged-In: I789f530d3e16baa6e56feaa4269f6696976f747e
2019-03-15 22:57:36 +00:00
Hall Liu
c776acee06 Merge "Base implementation of WFC disclaimer UI" 2019-03-15 22:57:06 +00:00
Fan Zhang
d3b848713d Remove reference to R.id.summary_container.
It's deleted in another CL.

Fixes: 123317946
Test: visual/robo
Change-Id: I7b461ba68e8b56946e4effc26850776881236ec7
2019-03-15 15:41:47 -07:00
Fan Zhang
5db43105e8 Move a few classes around for easier ownership control
Bug: 128547723
Test: rebuild
Change-Id: I8f0dcf30fee44eaae60e10510620fb518cded68f
2019-03-15 15:32:33 -07:00
Jack Yu
8533937220 Renamed NetworkRegistrationState to NetworkRegistrationInfo
API review changes. The class covers more information other than
registration state.

Test: Build
Bug: 127657991
Change-Id: I362bcd3e4bec91817081ddea2f822062b12c4207
2019-03-15 15:03:27 -07:00
TreeHugger Robot
8c3fb57ea3 Merge "Fix channel configurability check" 2019-03-15 21:57:23 +00:00
TreeHugger Robot
4c42163093 Merge "Update design of channel pages." 2019-03-15 21:47:51 +00:00
TreeHugger Robot
6f822c1049 Merge "Fix for affordances to add a mobile subscription" 2019-03-15 21:47:32 +00:00
TreeHugger Robot
a63fd33c0b Merge "Tie ContextualWifiSlice to UI instead of garbage collector" 2019-03-15 21:41:29 +00:00
TreeHugger Robot
08ee7b5aa4 Merge "Only show zen rule gear if intent is valid" 2019-03-15 21:39:42 +00:00
TreeHugger Robot
20886072af Merge changes I85ca2b69,Ibd7a47cb,I79522aab
* changes:
  Update strings for scanning settings
  Display empty message if no recent location access
  Add comment to help translator with plural forms
2019-03-15 21:36:41 +00:00
Jack Yu
8bdef807ac Merge "Moved transport to IntDef" 2019-03-15 21:16:41 +00:00
Fan Zhang
2635ae4ccb Merge "Update switchbar color for accessibilty" 2019-03-15 19:47:19 +00:00
jackqdyulei
8308274058 Add circle background outline to unthethered icon
Fixes: 124247230
Test: manual
Change-Id: I70f8158685134e2115f2a7baded983ebac6c8f1b
2019-03-15 12:40:58 -07:00
Fan Zhang
f47cb9a008 Update switchbar color for accessibilty
Fixes: 127878068
Test: visual
Change-Id: Ice36a11c4fe126a80db6e5a504e8867e81344173
2019-03-15 12:40:18 -07:00
Lifu Tang
754ce92037 Update strings for scanning settings
Bug: 128323721
Test: build, flash, and test manually
Change-Id: I85ca2b69e61bdc839b9df1010c74d945990d5549
2019-03-15 12:32:32 -07:00
Lifu Tang
ecea9e96d9 Display empty message if no recent location access
Bug: 120873123
Test: build, flash, and test manually
Change-Id: Ibd7a47cb814fe16ecb1c017865ab28862e17ddcc
2019-03-15 11:43:00 -07:00
Julia Reynolds
99644e2098 Choose a pref key less likely to conflict
Test: manual
Fixes: 127498706
Change-Id: I254cef727df137abac5810f19e63449a7f582876
2019-03-15 18:17:35 +00:00
Antony Sargent
10353cd8b6 Fix for affordances to add a mobile subscription
This changes the behavior for when we show an affordance to add a mobile
subscription via the eSIM manager (if eSIM is supported).  On the
Network & internet page, the behavior we now want for the "Mobile
network" pref has several possibilities as detailed below.

No existing subscriptions:
- Summary is "Add a network"
- Tapping on pref leads to the add subscription flow

One existing subscription:
- Summary is the name of the subscription (usually the carrier name)
- Tapping left-hand side of the pref leads to mobile network details
- A "+" button is shown on right of pref, and tapping "+" leads to the
  add subscription flow

2 or more existing subscriptions:
- Summary is "<count> SIMs"
- Tapping left-hand side of the pref leads to a new page with the list
  of subscriptions
- A "+" button is shown on right of pref, and tapping "+" leads to the
  add subscription flow

The existing code controlling the "Mobile network" pref (in
MobileNetworkSummaryController.java) already had behavior similar to
this, but needed to be updated to no longer rely on whether we're in
DSDS mode.

Also, the page with the list of subscriptions that you can go to in the
"2 or more existing subscriptions" case mentioned above has an "Add
more" link at the bottom which leads to the same eSIM manager flow, but
it was always showing this link even if the device doesn't support
eSIM. This CL also fixes that problem.

Bug: 127870567
Test: make RunSettingsRoboTests
Change-Id: Ie8cca47ac81f8992fa6ecf1940bdfed411fd333b
2019-03-15 10:27:21 -07:00
Julia Reynolds
9c6f1aa74b Fix channel configurability check
Test: atest
Fixes: 128669244
Change-Id: Ib4bc666262426ea1fb8fc034a361c93bdd5afb36
2019-03-15 17:19:02 +00:00