Commit Graph

1095 Commits

Author SHA1 Message Date
Treehugger Robot
22e2cd594e Merge "Fixed accessibility issues in Wi-Fi SSID view" into main 2025-02-18 22:38:53 -08:00
Weng Su
d44941bd00 Fixed accessibility issues in Wi-Fi SSID view
- Keep the Save button enabled at all times

- Show "Enter the SSID" to remind the user

Bug: 386897596
Flag: EXEMPT bugfix
Test: Manual testing
  atest SettingsUnitTests:AddNetworkFragmentTest
  atest WifiConfigController2Test
Change-Id: I6cc6b197864511ee2c1c92affc67698b1761f11d
2025-02-19 13:22:26 +08:00
Hakjun Choi
1a53ea7a05 Clean up aconfig flag carrier_enabled_satellite_flag
Bug: 393951373
FLAG: EXEMPT flag clean up
Test: atest NetworkSelectSettingsTest WifiCallingSettingsForSubTest SatelliteSettingsPreferenceControllerTest
Test: manual test in live network
Change-Id: I154e9be8a8c771fafb37af078be7b495f18b6100
2025-02-18 08:41:14 +00:00
Kevin Liu
8384d162d0 Merge "Temp disable test that contains custom shadow within it" into main am: d1b8b3a7e1 am: 0db2f6c60f
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3479734

Change-Id: Ibb99bff0e14112bab302f89de9da40d4910c78a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-06 11:55:15 -08:00
Kevin Liu
a9e22be8a5 Temp disable test that contains custom shadow within it
We need proper support or Exception throw for this scenario

Test: atest SettingsRoboTests
Bug: 394813533
Change-Id: I8b552f7b2bff166643bdaa492dceff23679116ff
2025-02-06 14:48:43 +00:00
Jacky Wang
7a24cd61ac [Catalyst] Migrate WifiCallingScreen to parameterized screen
Bug: 388420844
Bug: 372732219
Flag: com.android.settings.flags.catalyst_wifi_calling
Test: devtool
Change-Id: I322001acc453eae0d69761f7a585c6f33087ef6a
2025-01-23 17:16:41 +08:00
Weng Su
955c862de1 Add talkback hint to Wi-Fi hotspot preferences
- Set the title as the edit box hint.

Bug: 385857484
Flag: EXEMPT bugfix
Test: Manual testing
atest -c com.android.settings.wifi.tether.WifiTetherPasswordPreferenceControllerTest \
         WifiTetherSSIDPreferenceControllerTest

Change-Id: Ie7fe1c29d5f45ce47c7f393bf433ed3b2bcacb59
2024-12-25 22:10:31 +08:00
Fan Wu
40b8917b57 Fix WifiCallingSettingsForSubTest
Bug: 378832412
Test: atest
Flag: EXEMPT fix test
Change-Id: Id45f472e87371eb00ba3412a39ccda5af5723e4b
2024-11-14 08:55:20 +00:00
Treehugger Robot
75e2dc4b21 Merge "Avoid disabling the Wi-Fi hotspot switch causing Talkback confusion" into main 2024-10-28 05:38:51 +00:00
Weng Su
259d3a47c8 Avoid disabling the Wi-Fi hotspot switch causing Talkback confusion
- Use local variables to filter inappropriate callbacks when the switch is busy

Bug: 374234537
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiTetherSwitchBarControllerTest

Change-Id: If5237230c73cae5a6230a6d3fdaa65a8511bdcd8
2024-10-28 03:31:32 +08:00
Fan Wu
60521ee2f9 Add WifiCallingScreen and corresponding TS flag
Bug: 372732219
Test: atest
Flag: com.android.settings.flags.catalyst_wifi_calling_settings

Change-Id: I3d78b6745e1127a0a7e73ec20ae95e9c9db2c139
2024-10-24 10:44:24 +08:00
Fan Wu
059593f1b1 Update WifiCallingSettingsForSub to inherit DashboardFragment. Controller logic will be refactored later
Bug: 372732219
Test: atest
Flag: EXEMPT refactor
Change-Id: I8fc419acd0311cc5b11d78662fb6a13b2c61b169
2024-10-23 09:07:59 +00:00
Weng Su
efe8d52f77 Connect to OWE Wi-Fi network when QR code has no password
- Since there is no password for Wi-Fi security in OPEN and OWE, try to connect to one of them

Bug: 360377330
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiDppQrCodeScannerFragmentTest

Change-Id: Ia0a59e099b724170ad993df8b4246b94e0da392c
2024-10-14 07:02:18 +08:00
Weng Su
0256fe816d Avoid launching captive portal pages when uri is empty
- If uri is empty it will cause ActivityNotFoundException when calling startActivity

Bug: 363782926
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiDetailPreferenceController2Test

Change-Id: I48b9a53afe08a7c5e8e512c1961d6aea22a12a21
2024-09-16 17:05:10 +08:00
Treehugger Robot
06ab83eb50 Merge "Fix errorprone issues" into main am: eb2e9e4776 am: bdd44e5242
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3258078

Change-Id: I1249c4cdae2cee729ac60d9e41507c7dc684621e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-11 18:22:01 +00:00
Treehugger Robot
eb2e9e4776 Merge "Fix errorprone issues" into main 2024-09-11 18:08:19 +00:00
Cole Faust
9b89e3d643 Fix errorprone issues
IgnoredPureGetter, LenientFormatStringValidation, ProtocolBufferOrdinal, and ReturnValueIgnored.
https://errorprone.info/bugpatterns

Bug: 253827323
Test: RUN_ERROR_PRONE=true m javac-check
Change-Id: Ib0a0335aa04b36924adcbfecc830b7392c0e5bec
2024-09-06 13:34:50 -07:00
Weng Su
c749ba028a Fix Wi-Fi details crash in secondary users
- When Wi-Fi details are restricted for secondary users, UI components will be removed to prevent user interaction
  - The UI update function may not obtain the expected resources, causing NPE issues

Bug: 362151753
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiNetworkDetailsFragmentTest

Change-Id: Ia97b4e202faff85ced0b6eaf2e4b4f0dc04b5cef
2024-09-05 03:58:40 +08:00
Chaohui Wang
fc8e8991c9 Clean up InternetPreferenceController
And also the flag.

Bug: 339884322
Flag: com.android.settings.flags.internet_preference_controller_v2
Test: manual - Network & internet
Change-Id: Icb3427f6624db0442c05f5e149dbe522d1497e83
2024-08-29 15:55:44 +08:00
Weng Su
675b817c49 Hide new Hotspot preferences if feature is disabled
- Hide new "Security" preference

- Hide new "Speed and compatibility" preference

Bug: 356898105
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiTetherSettingsTest

Change-Id: I734959ed511929bfcc9a314770a4acdf9a7e0b99
2024-08-12 05:49:02 +08:00
Quang Luong
2f257a1982 Merge "Fix mac randomization value mismatch" into main 2024-07-25 10:45:54 +00:00
Quang Anh Luong
47a83c7ed7 Fix mac randomization value mismatch
WifiConfigController2 passes in
WifiConfiguration.MacRandomizationSetting to methods that expect
WifiEntry.Privacy enums, resulting in the wrong values being saved and
displayed for the edit dialog. Fix this by making sure the correct
WifiEntry values are used.

Note that the Network Details Page uses
WifiPrivacyPreferenceController2, which uses the correct values.

Flag: EXEMPT bugfix
Bug: 284230986
Test: atest WifiPrivacyPreferenceController2Test, atest
WifiConfigController2Test, manually verify adding a new network saves
the config with RANDOMIZATION_AUTO by default and changing the value
works correctly.

Change-Id: I84dc7cc50d04360aca611ca80ee400a97b693722
2024-07-18 05:31:11 +00:00
Chaohui Wang
371e7b09e1 Clean up WifiPrimarySwitchPreferenceController
This one is not used any more.

Bug: 167474581
Flag: EXEMPT clean up
Test: m Settings
Change-Id: Ia2439af2b3a6b643f41f6e3fce9e4bf1126c282e
2024-07-17 16:02:40 +08:00
Kai Zhou
9775bd31f9 Wifi Sharing page uses a new enum for telemetry.
* Previous ID was shared by several pages.
* New ID is only used by this page.

Bug: b/349226088
Settings Intake: b/329012096

Test: atest WifiDppQrCodeGeneratorFragmentTest
Flag: com.android.settings.flags.enable_wifi_sharing_runtime_fragment

Change-Id: I22c8f3a216cf348460a645561be48b23a4bf0e7e
2024-07-11 02:30:12 +00:00
Weng Su
a7b13c11cd Disable "Add network" if DISALLOW_ADD_WIFI_CONFIG
- When DISALLOW_ADD_WIFI_CONFIG is not restricted by Admin
  - Disable the preference directly

Bug: 335387874
Flag: EXEMPT bugfix
Test: Manual testing
atest -c AddWifiNetworkPreferenceTest

Change-Id: I0bb08656971107c73d7632a395a820d03723620b
2024-07-05 06:52:36 +08:00
Chaohui Wang
562f56bb7a Use wifiCallingReadyFlow in WifiCallingSettingsForSub
Simply and unify the logic, and fixed a crash.

Fix: 348372605
Flag: EXEMPT bug fix
Test: manual on Wi-Fi calling
Change-Id: Idc7dff934323fbebb09137bbd0585575e65a7867
2024-06-21 16:53:38 +08:00
Weng Su
ec4db174a8 Merge "Remove Instant Hotspot from Settings search" into main 2024-05-13 06:54:59 +00:00
Weng Su
3dc7837617 Remove Instant Hotspot from Settings search
- If Instant Hotspot is not enabled then remove it from Settings search

Bug: 339159245
Flag: None
Test: Manual testing
atest -c WifiTetherSettingsTest

Change-Id: I0b1d34c1130b17bfc0f3f0451a10c8aba265733c
2024-05-11 20:00:02 +08:00
Treehugger Robot
8e4223c769 Merge "Revert "Checks WEP password lengths of Wi-Fi network"" into main 2024-05-09 08:00:14 +00:00
Weng Su
2e25a60436 Revert "Checks WEP password lengths of Wi-Fi network"
This reverts commit 1cd3b6f21f.

Reason for revert:
http://b/338298452 Can't connect to WEP network because incorrect passphrase length check  

Change-Id: I4e152a0c89e9ee11b4faa957061b6e9844b1a0c4
2024-05-09 06:49:41 +00:00
Tom Hsu
c495d92a25 Merge "Show dialog on Wifi, and APM' entries in Settings" into main 2024-05-08 04:37:28 +00:00
tomhsu
29b2f16edf Show dialog on Wifi, and APM' entries in Settings
- When satellite mode is switched on Wifi, and APM entry shall show the warning dialog and avoid user uses these functions.

Bug: 337154438
Test: Manual test.
Test: atest pass
Change-Id: I45cd92a8688e7a619613361ea4a8d58a0984d99f
2024-05-08 03:53:32 +00:00
Mill Chen
4c061771b7 Deprecated Wifi panel and relevant objects
Bug: 328529085
Test: robotest
Change-Id: I960718acbdf1d2be6c3b6b396cf2ac69d4aa3046
2024-05-06 22:22:52 +00:00
Fan Wu
14c9806612 Remove all remaining usages of LooperMode.LEGACY
Also temporarily ignore UwbPreferenceControllerTest due to unfinished tasks on main thread, see b/337171922 for more detail

Bug: 330824314

Test: atest
Change-Id: I45219fee8094b38790faf8d778e8a1ddeb7c7aaa
2024-04-26 07:11:26 +00:00
Weng Su
1cd3b6f21f Checks WEP password lengths of Wi-Fi network
- Checks for WEP40 and WEP104 password lengths (5 and 13 bytes)

Bug: 333289235
Flag: None
Test: unit test
atest -c WifiConfigController2Test

Change-Id: I5f96ad67ed0c67a2724960e72464dc0a56c0c1ab
2024-04-11 08:20:17 +00:00
Charlotte Lu
08f8f0ce9e Add dhcp in advanced settings toggle.
Test: Unit Test
Fix: 329002870
Change-Id: I5c57deb1e8ed0dd59a7699b56f5eb99ca29876b8
2024-03-11 06:47:38 +00:00
Aishwarya Mallampati
abf2a6ae52 Merge "Disable Wi-Fi calling roaming preferrence while using NTN." into main 2024-02-02 22:40:50 +00:00
Aishwarya Mallampati
aab23344cb Disable Wi-Fi calling roaming preferrence while using NTN.
When phone is connected to non-terrestrial network, carrier can specify
whether to override Wi-Fi calling roaming mode or not using
KEY_OVERRIDE_WFC_ROAMING_MODE_WHILE_USING_NTN_BOOL.

If KEY_USE_WFC_HOME_NETWORK_MODE_IN_ROAMING_NETWORK_BOOL is false,
and if KEY_NTN_EDITABLE_WFC_ROAMING_MODE_BOOL is true and
if KEY_OVERRIDE_WFC_ROAMING_MODE_WHILE_USING_NTN_BOOL is true, then
Wi-Fi calling roaming preferrence is disabled.

Bug: 318871716
Test: atest CarrierConfigManagerTest, atest ImsManagerTest,
atest WifiCallingSettingsForSubTest

Change-Id: I95bf5e6a0f11796e67bd7e6a2c12a331481f8187
2024-02-02 06:34:18 +00:00
Weng Su
5510f605ce Fix WifiDialogActivityTest legacy issue
- Add @LooperMode(LooperMode.Mode.LEGACY) to fix loop issue.

Bug: 314867581
Flag: None
Test: unit test
atest -c SettingsRoboTests

Change-Id: Ib1676a8502005870e9944fc654801916fe1bb945
2024-01-27 00:09:54 +08:00
Treehugger Robot
5fe4714851 Merge "Restrict WifiDialogActivity" into main 2024-01-26 10:56:00 +00:00
Weng Su
51fa3d798a Restrict WifiDialogActivity
- Don't show WifiDialogActivity if user has DISALLOW_ADD_WIFI_CONFIG

Fix: 299931761
Bug: 314867581
Flag: None
Test: manual test with TestDPC
atest -c SettingsRoboTests:WifiDialogActivityTest

Change-Id: Icbb8f45922ded163208976be9c2816060dcf09f1
2024-01-26 18:01:28 +08:00
Weng Su
dd1947c078 Fix Wi-Fi anonymous ID UI issue
- Do not reset the anonymous default ID after retrieving the previous value from WifiConfiguration.

Fix: 267517525
Flag: None
Test: manual test
make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigController2Test

Change-Id: Ic10d6953f6657836e18eab6884df2af0f35a20c4
2024-01-23 06:44:46 +08:00
Sunny Shao
076ed573eb Revert^2 "Nullability Annotations replacement"
This reverts commit 19d1d3d15d.

Reason for revert: revert it because this is not the root cause.

bug: 316867690
Change-Id: I0f168dbb64044aa720202af7b1040afd4f028c9c
2024-01-10 07:34:01 +00:00
Sunny Shao
19d1d3d15d Revert "Nullability Annotations replacement"
This reverts commit cf0501e4d7.

Reason for revert: b/317462033, it seems a flaky but revert it first.

Change-Id: Ie1d5e279cca6477fc17d8c27c1ecda8d7a6b2553
2023-12-29 02:28:24 +00:00
sunnyshao
cf0501e4d7 Nullability Annotations replacement
-- Replace the android.annotation.Nullable / android.annotation.NonNull
   with androidx.annotation.Nullable / androidx.annotation.NonNull

Bug: 316867690
Test: build pass
Change-Id: I0c1da55dfb09ece855151c47e0492d6f46538621
2023-12-20 08:50:09 +08:00
Yanting Yang
09e32b466b Ignore failing tests of WifiDialogActivityTest
Bug: 314867581
Test: post-submit
Change-Id: Ie0027de0a81e209a6db10a6075a92e680b1c1206
2023-12-06 15:14:02 +00:00
FanWu
1bb01ff055 Ignore failing tests under com.android.settings.wifi
Bug: 314867581

Test: not needed
Change-Id: Id721c8a91baa54c746aba007dd40a086276953e8
2023-12-05 12:01:30 +08:00
Chaohui Wang
0664d3cc45 Clean up AllInOneTetherSettings
This project is not on-going.

Clean up to help improve latency.

Bug: 311604902
Test: manual - on Network & internet page
Test: robo test
Change-Id: I6addb92e5587206661d1b64bdc56473a85ba9c9f
2023-11-30 12:27:33 +08:00
FanWu
c9eb27c62c Ignore failing tests under com.android.settings.wifi.details
Bug: 313536962

Test: atest
Change-Id: I8f2152e29fe8db0463ea1cbf5ab1e388e17366dd
2023-11-28 10:42:05 +08:00
Chaohui Wang
34c4deb6c9 Clean up Contextual Wifi card
Bug: 245854887
Test: m RunSettingsRoboTests
Change-Id: I3b4ccc076a68eadc11e9fb3d2967a34fe0396cf9
2023-11-27 13:59:33 +08:00