Commit Graph

313 Commits

Author SHA1 Message Date
Aurimas Liutikas
b1af85d155 Migrate Settings to androidx.
Test: make Settings
Bug: 76692459
Change-Id: I941dea40562170649bf056e675cc32e5163c0e39
Merged-In: I941dea40562170649bf056e675cc32e5163c0e39
(cherry picked from commit a290b873d0)
2018-08-28 11:48:56 -07:00
Matthew Fritze
bd376296cd Establish permanently unavailable settings
Distinguish between settings which are permanently unavailable on
the device, and temporarily unavailable. This enables us to restrict
which setting slices are exposed in onSliceGetDescendants.

The primary changes in this CL are renaming:
"DISABLED_UNSUPPORTED" -> "UNSUPPORTED_ON_DEVICE"
to be more clear the the setting will cannot be accessed on the device, and,
adding a new enum to encapsulate settings which are currently unavailable, but
could be enabled in the future.

Also remove UNAVAILABLE_UNKNOWN. Devs should never need this enum.

Bug: 78910582
Fixes: 79245656
Test: robotests
Change-Id: I42c2cedab66be2d76999795f46470a079cc1ec71
Merged-In: I58821a6cfd6134b3b351657b6edf5f74ead00643
2018-05-09 10:03:40 -07:00
Jan Nordqvist
be73af0369 Hiding data remaining text when available space is too small.
Bug: 77799887

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I53390a36e74f9832bdc7757cd67d51064e8a77f3
Merged-In: I53390a36e74f9832bdc7757cd67d51064e8a77f3
2018-04-25 12:30:06 -07:00
Doris Ling
1cf0dfd3b2 Fix Data warning title not translated.
- change to use the title resource id instead of getting the title from
the preference, so that it can react to language change properly.

Change-Id: I7f4b3c49ef1622b3d90bf035597742cac6f7af3c
Fixes: 78318536
Test: run i18nscreenshots
2018-04-24 13:42:19 -07:00
TreeHugger Robot
21a34488ba Merge "Fix limit data usage dialog body not being translated." into pi-dev 2018-04-20 00:43:58 +00:00
Doris Ling
689bb2c27c Fix limit data usage dialog body not being translated.
- need to pass the resource id instead of the text when building the
dialog in order for it to react to language change.
- also remove the unnecessary set/get the body message in the dialog
creation since the msg id can be used directly.

Change-Id: I399dcda54961fac457fc5f0fad9082f2c1e1a2b2
Fixes: 77897157
Test: run i18nscreenshots
2018-04-19 16:35:28 -07:00
Doris Ling
6784296248 Fix App data usage title not being translated.
- we need to pass the title resource id instead of the actual text in
the launch intent in order for it react to language change properly.

Change-Id: I72ccbe67411c9f4da328dd24671f4e71ab927851
Fixes: 77898325
Test: run i18nscreenshots
2018-04-19 16:09:58 -07:00
Jan Nordqvist
d4c7973615 Fixing incorrect method to launch mobile data plan app.
Bug: 77529772

Test: manual
Change-Id: Id102cb11bcbcc94b139caff47195364e281850e3
2018-04-17 18:21:25 -07:00
Fan Zhang
be30190362 Switch from SI to IEC unit when formatting data usage bytes
- Created a new helper method DataUsageUtils.formatDataUsage() to
  format data usage bytes using IEC formatting.
- Switch from Formatter.formatFileSize() to DataUsageUtils.formatDataUsage()
  everywhere in datausage package.

Change-Id: I9323beed8bf5126b153fc9a3cdd9591c97ca6fd2
Merged-In: I9323beed8bf5126b153fc9a3cdd9591c97ca6fd2
Fixes: 76159924
Test: robotests
2018-04-11 18:22:55 -07:00
TreeHugger Robot
c91339b3ce Merge ""Data Warn & Limits" pref. summary should be empty." into pi-dev 2018-04-05 23:41:47 +00:00
TreeHugger Robot
22bf690fdd Merge "Change "X over" text color to ColorError" into pi-dev 2018-04-05 22:47:23 +00:00
Andreas Terzis
903a92535a "Data Warn & Limits" pref. summary should be empty.
The "Data Warning & Limits" preference in the Data Usage screen
should not have a summary.

Bug: 77300376

Test: manual
Test: make RunSettingsRoboTests
Change-Id: Ic567e7451ac3ea102577ab96ccef3ce7de05d4ad
2018-04-05 15:22:31 -07:00
Jan Nordqvist
bdd559a181 Do not use warning or limit to display "X B left" above usage bar
Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I46f4f5f1cf6092038e49beaafe5aa6a19ffb0aa1
2018-04-05 13:22:06 -07:00
Jan Nordqvist
a2731e24a6 Change "X over" text color to ColorError
Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I2a59d6b4b4549a780ae168e9e1b3f356c677262c
2018-04-05 09:30:43 -07:00
Jan Nordqvist
cd3f9e2a5e Fall back to Wi-Fi data display in data usage screen with no SIM.
Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I06bf78e54119819be87e15baca7e5b6a241958cb
Merged-In: I06bf78e54119819be87e15baca7e5b6a241958cb
2018-04-04 15:58:53 -07:00
TreeHugger Robot
a673f714c4 Merge "Report unavailable data usage." into pi-dev 2018-03-29 19:57:44 +00:00
Doris Ling
02b4cf2aca Report unavailable data usage.
- when showing the data usage graph, if the first data point is equal to
the first available data, insert a 0 usage point on the first day of
available data, so that it will show a flat line for the days that do
not have available data instead of showing a non-zero slope.

Change-Id: Ibf305e292a65ab3310ea12efbb575e3a7e1b6012
Fixes: 76155147
Test: make RunSettingsRoboTests
2018-03-29 10:54:54 -07:00
Andrew Chiang
f3ea58a7df Merge "Update toggle text for Data Saver" into pi-dev 2018-03-29 02:44:04 +00:00
TreeHugger Robot
00a2dcb8f9 Merge "Entity header: When screen scrolls, there should be shadow under the header." into pi-dev 2018-03-28 20:12:46 +00:00
Jan Nordqvist
4092b2193c Entity header: When screen scrolls, there should be shadow under the header.
Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests

Change-Id: I5c1d9f463a57d48e258d67602fc4d1fbbdfaad60
2018-03-28 11:17:23 -07:00
TreeHugger Robot
bbb3d3e72c Merge "Fix data usage under Wi-Fi has title "Mobile data usage"" into pi-dev 2018-03-28 16:36:16 +00:00
Shawn Ding
a4d78e43c2 Fix data usage under Wi-Fi has title "Mobile data usage"
Fix "Wi-Fi data usage" in Wi-Fi section. (Settings -> Network & internet -> Data usage)

Change-Id: I6c4117db321af252a2c3061f554ffbe2f87a714e
Fixes: 76165354
Test: Manual test
2018-03-28 07:32:23 +08:00
Fan Zhang
0c8f8a8b46 Use custom drawable for Battery saver condition icon.
- Updated condition interface to use Drawable instead of Icon for icons.
- Converted all conditions to return drawable instead of Icon.
- Created a BatterySaverDrawable to draw a static battery saver icon.

Change-Id: Ie964f3439009c7658603a8ff352a05e964a0a795
Fixes: 76168403
Test: robotests
2018-03-26 17:50:27 -07:00
Andrew Chiang
f6c8a42d93 Update toggle text for Data Saver
Update Data Saver toggle to say "Use Data Saver" instead of "On"/"Off"

Bug: 75983536
Test: Robotest, manual test and atest DataSaverSummaryUITest
Change-Id: Icf690638570278fb869515931943ac486adbfc7c
2018-03-26 15:16:19 +08:00
TreeHugger Robot
f88dcfadbb Merge "Fix crash when launching mobile data usage page via intent." into pi-dev 2018-03-22 07:24:23 +00:00
TreeHugger Robot
ce447d9191 Merge "Add back the data saver preference." into pi-dev 2018-03-22 04:56:35 +00:00
TreeHugger Robot
58a8b09e7b Merge "Fix entity header to "Hide" shadow of app bar unless scrolled." into pi-dev 2018-03-22 03:17:29 +00:00
TreeHugger Robot
119d95bae1 Merge "Modify "Updated ..." text." into pi-dev 2018-03-22 02:58:41 +00:00
Andreas Terzis
446cd9db73 Add back the data saver preference.
Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: Ia39cb62ec021ae568a76fed04776b5e531e63b36
2018-03-21 19:23:05 -07:00
Fan Zhang
681c073fdb Fix crash when launching mobile data usage page via intent.
Need to parse parameters from Intent if argument is empty or has no
parameter.

Change-Id: I23af434e1be794036dc711b72e0d9afa8bd65aa6
Fixes: 74235734
Test: robotests
2018-03-21 16:58:23 -07:00
Sundeep Ghuman
9bfbc3f1fd Modify "Updated ..." text.
Use d/h/m "narrow" time formatting with no period.

Change font style when update is "old."

Bug: 70950124
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=DataUsageSummaryPreferenceTest

Change-Id: I25902c98eb0fdf4dd2f64c3f5d668b5efdcdff0c
2018-03-21 15:24:43 -07:00
Jan Nordqvist
ba1c53455a Fix entity header to "Hide" shadow of app bar unless scrolled.
Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I3d23ac49365873361f23b0c7ab105f208d6a7ed7
2018-03-21 15:15:10 -07:00
TreeHugger Robot
d17e849775 Merge "Only show mobile data usage information when mobile data is enabled." into pi-dev 2018-03-21 18:29:21 +00:00
Jan Nordqvist
19375adb5a Only show mobile data usage information when mobile data is enabled.
Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I4eb774120cbcf50f40d22c7c8c3caeb0eacbbed3
2018-03-21 09:13:02 -07:00
TreeHugger Robot
09d1588a07 Merge "Remove the overflow menu from the usage Appbar." into pi-dev 2018-03-21 00:44:09 +00:00
Jan Nordqvist
e22f79139a Remove the overflow menu from the usage Appbar.
In Data Usage screen, Above the data bar, Remove the overflow
menu (3 dots on top right of the screen) from the Appbar.

Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I4e8a5e54b1e5c573496ff2a76a5a80da38650f2b
2018-03-20 14:49:15 -07:00
Andreas Terzis
91ea3c5e56 Merge "In Data Usage screen, hide data bar if plan is unlimited" into pi-dev 2018-03-20 05:49:51 +00:00
Jan Nordqvist
641288f7c1 In Data Usage screen, hide data bar if plan is unlimited
Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I1314bdf9748c55a2391ccb39ff66c3dcb133be7e
2018-03-19 14:13:47 -07:00
Jan Nordqvist
44e5941757 Merge "In Network & internet screen, hide summary under Data usage when there is No SIM" into pi-dev 2018-03-19 16:04:23 +00:00
Andreas Terzis
895f785470 Merge "Add the string "No time remaining" when remaining time <= 0." into pi-dev 2018-03-19 14:22:51 +00:00
Jan Nordqvist
c7faabf408 Add the string "No time remaining" when remaining time <= 0.
Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: Id8ff1dde78f3389b5ab15120a2460ab19e895c6f
2018-03-16 16:32:00 -07:00
Jan Nordqvist
637dc29fe9 In Network & internet screen, hide summary under Data usage when there is No SIM
Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I4abd401aa9420b2b0090fac76991fe5067acc2e9
2018-03-16 14:29:33 -07:00
Jan Nordqvist
b65b3ce173 In Data Usage screen, Above the data bar, Change font size of number.
Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I671a605fe341f36adeb6ae239333295ddfb550c7
2018-03-16 09:16:26 -07:00
Sundeep Ghuman
b673aaadc9 Merge "Change text for data warning and data limit." into pi-dev 2018-03-15 17:08:34 +00:00
Jan Nordqvist
7b352d271e Change text for data warning and data limit.
This change modifies the "data warning" text to show either nothing, only
warning, only limit, or warning and limit, based on which of the values are
set. It also remove the capitalization of the first letter of the texts.

Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: Ifebb411b906719c6e2f343f48d825f7b6f17af53
2018-03-15 09:49:32 -07:00
Jan Nordqvist
9a65e5fec7 Set color of update line to red if update is older than six hours.
In Data Usage screen, out-of-date state

Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: Icf6fafe9ab61a2c1ac3fba2bebf3bd4407c0ecfe
2018-03-15 00:20:39 -07:00
Jan Nordqvist
a6f6e9c41c In Data Usage screen, Below the data bar, Add “X days left” field.
Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I35eb3f0c09c84d609ad54e87400913ec77e19ea0
2018-03-15 00:17:53 -07:00
Sundeep Ghuman
21ef6cb644 In Data Usage screen, add over-limit state.
Bug: 70950124
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=DataUsageSummaryPreferenceTest

Change-Id: Ieec0c486c6a5451cd5983f02e202ddac3413a602
2018-03-14 23:22:30 -07:00
Jan Nordqvist
8a241f642e Change text layout of data usage string.
In Data Usage screen, Above the data bar, Change font size of number
In Data Usage screen, Above the data bar, Update text style of “GB used”
In Data Usage screen, Above the data bar, Add “GB left” aligned right of bar (not always shown)

Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I8accb16425283cf148ddb6b6646f92ff51a74b7c
2018-03-14 22:48:46 -07:00
Sundeep Ghuman
d610e51613 Merge "Fix the ProgressBar in DataUsageSummaryV2 page." into pi-dev 2018-03-15 05:00:41 +00:00