Commit Graph

25576 Commits

Author SHA1 Message Date
Matthew Fritze
e435b062a0 Fix NPE in constructor
Move getActivity() call and fetching of metrics feature provider into
onCreateView rathre than the Constructor of the fragment (where Activity
is not yet created).

Test: manual
Test: existing robotests
Fixes: 128808444
Change-Id: I88586b0ca3ebda60f8933041322541cc5911de68
2019-03-20 08:29:23 -07:00
TreeHugger Robot
23924cf3f4 Merge "Enable nav bar overlay when gestural nav is enabled and tune edge swipe width." 2019-03-19 00:17:38 +00:00
Hai Shalom
94c888fb30 Merge "[Wi-Fi] Do not delete certs when forgetting network" 2019-03-18 22:38:47 +00:00
Tracy Zhou
ecb94f5466 Enable nav bar overlay when gestural nav is enabled and tune edge swipe
width.

Fixes: 128680874, 128711028
Test: Manual
Change-Id: I371819c6f6206f2bbc8599c0b14b4da9b67a2e14
2019-03-18 15:14:57 -07:00
Fan Zhang
93c690979f Merge "Disable draw overlay for most of Settings." 2019-03-18 21:55:24 +00:00
Fan Zhang
9d98344122 Disable draw overlay for most of Settings.
Fixes: 120484087
Test: robotests
Change-Id: I1f7c8e83bd5054525bde5ca35fac55b7c9586c7c
2019-03-18 14:54:39 -07:00
TreeHugger Robot
00b0abd68e Merge "Force LSKF in ConfirmCredential UI when pending escrow token exists" 2019-03-18 19:44:47 +00:00
Fan Zhang
9f5e7b77ff Merge "Fix crash on AppInfo screen" 2019-03-18 18:36:49 +00:00
Hunter Knepshield
711b78d5ed Merge "[Strings + layout] Minor changes for eSIM erase." 2019-03-18 18:17:20 +00:00
TreeHugger Robot
eaf00ae476 Merge "Handle the SQLiteDatabase already-closed problem" 2019-03-18 18:13:27 +00:00
TreeHugger Robot
15bd7f24e9 Merge "Add null check for worker" 2019-03-18 18:01:08 +00:00
Jack Yu
c2299333ae Merge "Renamed NetworkRegistrationState to NetworkRegistrationInfo" 2019-03-18 17:28:08 +00:00
Rubin Xu
e0efe27f03 Force LSKF in ConfirmCredential UI when pending escrow token exists
Escrow tokens can only be activated by user confirming their LSKF,
while ConfirmCredential allows both LSKF and biometrics by default.
By requiring LSKF, it simplifies the DPC's flow of requesting the user
to activate a pending escrow token.

This change tweaks the ConfirmCredential UI to skip biometrics if pending
token exists.

Bug: 127377026
Bug: 76084679
Bug: 79547502
Test: manual
Change-Id: Iee9b2d57d7f4de98e225b3aeff7cc35cc8e3d36a
2019-03-18 17:20:26 +00:00
TreeHugger Robot
50bdbe92ab Merge "Move WakeGestureScreenGestureSettings" 2019-03-18 17:20:01 +00:00
TreeHugger Robot
e7668660d5 Merge "Move a few classes around for easier ownership control" 2019-03-18 12:06:30 +00:00
Sunny Shao
c7e094001d Handle the SQLiteDatabase already-closed problem
Remove the database.close in code for handling the re-open an already-closed object:SQLiteDatabase
problem.

Bug: 124451874
Test: robotest
Change-Id: Iff8c0bc5ea092d42cff0a40dfa4324a4de7c90bc
2019-03-18 19:42:09 +08:00
hughchen
8f76b44410 Add null check for worker
Add null check to avoid crash when worker cannot get through uri.

Bug: 128492874
Test: make -j42 RunSettingsRoboTests
Change-Id: I789ce0bfa98c0b0b145a8605c58c88a77eeb76a9
2019-03-18 19:12:32 +08:00
Jason Chiu
d4ab14969f Merge "Fix the bug of "Connecting" is rarely appearing on Wi-Fi slice" 2019-03-18 10:13:56 +00:00
Jason Chiu
4e42f53896 Fix the bug of "Connecting" is rarely appearing on Wi-Fi slice
- AccessPoint treats connected and connecting as equal so slice doesn't
refresh in this case
- Add a new method to determine if two lists are the same in SliceBackgroundWorker
- WifiScanWorker overrides this method to check the access point states

Fixes: 123941320
Test: robotest
Change-Id: I78d610da4b6b1d40f5785ba6701fb71b987fe31c
2019-03-18 16:01:48 +08:00
tmfang
062d4acf45 Fix crash on AppInfo screen
We start a search page with a request code which is same as
"uninstall" request code. The root cause is we handle same
reuqest code for different event.

We redefine an unique request code for "search" feature.

Fixes: 124775813
Test: Click search and back to App info screen.
Change-Id: I8ab21c30b605bcb65b6d4bd9fceb749a65a49f80
2019-03-18 14:09:52 +08:00
TreeHugger Robot
313bddb80e Merge "Log contextual card event to CURRENT user" 2019-03-18 05:56:25 +00:00
TreeHugger Robot
b07c5371b7 Merge "Use short format to avoid truncated problem" 2019-03-18 04:49:14 +00:00
Raff Tsai
a4fa5bc212 Log contextual card event to CURRENT user
Fixes: 128804262
Test: Robolectric. Manual
Change-Id: I6e7cffe0773572025beb3ab7964cc18da49681c2
2019-03-18 04:33:14 +00:00
TreeHugger Robot
47e8fbbcee Merge "Choose a pref key less likely to conflict" 2019-03-16 02:54:25 +00:00
Hall Liu
c776acee06 Merge "Base implementation of WFC disclaimer UI" 2019-03-15 22:57:06 +00:00
Fan Zhang
5db43105e8 Move a few classes around for easier ownership control
Bug: 128547723
Test: rebuild
Change-Id: I8f0dcf30fee44eaae60e10510620fb518cded68f
2019-03-15 15:32:33 -07:00
Jack Yu
8533937220 Renamed NetworkRegistrationState to NetworkRegistrationInfo
API review changes. The class covers more information other than
registration state.

Test: Build
Bug: 127657991
Change-Id: I362bcd3e4bec91817081ddea2f822062b12c4207
2019-03-15 15:03:27 -07:00
TreeHugger Robot
8c3fb57ea3 Merge "Fix channel configurability check" 2019-03-15 21:57:23 +00:00
TreeHugger Robot
4c42163093 Merge "Update design of channel pages." 2019-03-15 21:47:51 +00:00
TreeHugger Robot
6f822c1049 Merge "Fix for affordances to add a mobile subscription" 2019-03-15 21:47:32 +00:00
TreeHugger Robot
a63fd33c0b Merge "Tie ContextualWifiSlice to UI instead of garbage collector" 2019-03-15 21:41:29 +00:00
TreeHugger Robot
08ee7b5aa4 Merge "Only show zen rule gear if intent is valid" 2019-03-15 21:39:42 +00:00
TreeHugger Robot
20886072af Merge changes I85ca2b69,Ibd7a47cb,I79522aab
* changes:
  Update strings for scanning settings
  Display empty message if no recent location access
  Add comment to help translator with plural forms
2019-03-15 21:36:41 +00:00
Jack Yu
8bdef807ac Merge "Moved transport to IntDef" 2019-03-15 21:16:41 +00:00
Lifu Tang
ecea9e96d9 Display empty message if no recent location access
Bug: 120873123
Test: build, flash, and test manually
Change-Id: Ibd7a47cb814fe16ecb1c017865ab28862e17ddcc
2019-03-15 11:43:00 -07:00
Julia Reynolds
99644e2098 Choose a pref key less likely to conflict
Test: manual
Fixes: 127498706
Change-Id: I254cef727df137abac5810f19e63449a7f582876
2019-03-15 18:17:35 +00:00
Antony Sargent
10353cd8b6 Fix for affordances to add a mobile subscription
This changes the behavior for when we show an affordance to add a mobile
subscription via the eSIM manager (if eSIM is supported).  On the
Network & internet page, the behavior we now want for the "Mobile
network" pref has several possibilities as detailed below.

No existing subscriptions:
- Summary is "Add a network"
- Tapping on pref leads to the add subscription flow

One existing subscription:
- Summary is the name of the subscription (usually the carrier name)
- Tapping left-hand side of the pref leads to mobile network details
- A "+" button is shown on right of pref, and tapping "+" leads to the
  add subscription flow

2 or more existing subscriptions:
- Summary is "<count> SIMs"
- Tapping left-hand side of the pref leads to a new page with the list
  of subscriptions
- A "+" button is shown on right of pref, and tapping "+" leads to the
  add subscription flow

The existing code controlling the "Mobile network" pref (in
MobileNetworkSummaryController.java) already had behavior similar to
this, but needed to be updated to no longer rely on whether we're in
DSDS mode.

Also, the page with the list of subscriptions that you can go to in the
"2 or more existing subscriptions" case mentioned above has an "Add
more" link at the bottom which leads to the same eSIM manager flow, but
it was always showing this link even if the device doesn't support
eSIM. This CL also fixes that problem.

Bug: 127870567
Test: make RunSettingsRoboTests
Change-Id: Ie8cca47ac81f8992fa6ecf1940bdfed411fd333b
2019-03-15 10:27:21 -07:00
Julia Reynolds
9c6f1aa74b Fix channel configurability check
Test: atest
Fixes: 128669244
Change-Id: Ib4bc666262426ea1fb8fc034a361c93bdd5afb36
2019-03-15 17:19:02 +00:00
Lei Yu
7960cf6023 Merge "Turn on remote volume slider" 2019-03-15 17:06:33 +00:00
TreeHugger Robot
3b7571ab75 Merge "Remove parameter from uri when get slice" 2019-03-15 16:19:14 +00:00
Julia Reynolds
4253be9191 Update design of channel pages.
Test: atest
Bug: 127796543
Change-Id: I4fabeafe2602c341554959303e67bc69c8817a8f
2019-03-15 10:21:24 -04:00
Beverly
575a856709 Move WakeGestureScreenGestureSettings
Test: robosettings tests
Bug: 127955764
Change-Id: I058a960d6e51afd6e92b9a035993f6bfd91025b8
2019-03-15 09:34:05 -04:00
hughchen
9e78737483 Remove parameter from uri when get slice
Slice may added parameter in their uri.
When get slice through uri, removed parameter from uri to get correct slice.

Bug: 128651940
Test: make -j42 RunSettingsRoboTests
Change-Id: Id3cb7b91026384ce4e22c157a2908a5e18bc7993
2019-03-15 15:14:16 +08:00
Kevin Chyn
b697847430 Merge "Update toggle logic" 2019-03-15 04:22:58 +00:00
TreeHugger Robot
63820288ae Merge "Add links to app location permission page" 2019-03-15 03:52:46 +00:00
Jack Yu
763f7710fe Moved transport to IntDef
Moved out from the sub class per API review feedback.

Test: Build
Bug: 128607082

Change-Id: I4c476b61b472a9ce706ffe9e52da47e26b0b6dcf
2019-03-14 20:18:42 -07:00
Amit Mahajan
defd0155a1 Merge "Move SMS raw db deletion to phone process." am: 479ec92c27 am: f784db5cae
am: 1285b12980

Change-Id: I349002ff9a72b08056a8af47361de4914afb2b3d
2019-03-14 18:55:13 -07:00
Amit Mahajan
1285b12980 Merge "Move SMS raw db deletion to phone process." am: 479ec92c27
am: f784db5cae

Change-Id: Ib90080a6fad7ad8914390df8e4aa92749669f1a9
2019-03-14 18:49:59 -07:00
Amit Mahajan
f784db5cae Merge "Move SMS raw db deletion to phone process."
am: 479ec92c27

Change-Id: I38689f5f833825eae230706b536c4ad1ded847bd
2019-03-14 18:45:50 -07:00
Kevin Chyn
11679da53d Update toggle logic
Bug: 111548033

Test: Builds
Change-Id: I591297940b48cffe61ca0279ff835ccacd2a625f
2019-03-14 18:25:40 -07:00