Commit Graph

50289 Commits

Author SHA1 Message Date
Xin Li
d4716c1a62 Merge "DO NOT MERGE - Merge PPRL.190205.001 into master" 2019-02-20 16:25:59 +00:00
Julia Reynolds
14289bd356 Add pref for notification swipe direction
And move that and other settings under an 'advanced' category

Test: robotests
Fixes: 124099692
Change-Id: I89df276a8bc1cd56ce8530239ca02b2c4b43fa65
2019-02-20 10:36:50 -05:00
Yanting Yang
11a157a8e7 Fix preferences ordering issue in AccountSyncSettings
In Pie, it's alphabetical ordering in Accounts > Account sync detail page.
But Q doesn't follow it, intend to keep the same behavior.

Fixes:124382857
Test: visual, robotests
Change-Id: I593a4cc919daa0018d3874d84978e876198aae23
2019-02-20 21:18:28 +08:00
TreeHugger Robot
763f7450f2 Merge changes from topic "Wi-Fi DPP error code handling"
* changes:
  Fix camera stop forever after error occurs while sharing or adding network
  Handle different error codes in DPP
2019-02-20 12:45:26 +00:00
TreeHugger Robot
812855c83e Merge "Update char limit for DND conditional" 2019-02-20 10:48:35 +00:00
Mill Chen
594767634f Update char limit for DND conditional
Increasing the character limit for the "Phone muted" to 38 in the DND
condition.

Bug: 124784648
Test: rebuild
Change-Id: I46496ee60f6757f477b0d0bbd021c43234f83222
2019-02-20 16:16:35 +08:00
Arc Wang
ffae615d25 Fix camera stop forever after error occurs while sharing or adding network
Restart QrCamera decoding task after Wi-Fi DPP handshake fail or
Wi-Fi connection fail.

Bug: 124128539
Test: manual test
Change-Id: I6d916ed1378f50038089e2c1e2870915ca083d68
2019-02-20 14:29:08 +08:00
Arc Wang
7bdcadbe72 Handle different error codes in DPP
Show error message for corresponding Wi-Fi DPP error code. And

1. To update error message only from each fragment,
   remove some callbacks which calls from fragment to activity.
2. After clicking 'Share Wi-Fi' button, hide it before Wi-Fi DPP handshake completes.
3. Show 'Done' button for some error codes.
4. Use ViewModel to call startEasyConnectAsConfiguratorInitiator and
   startEasyConnectAsEnrolleeInitiator because a lifecycle object
   does not receive an Executor callback after configurator change.
5. In WifiDppQrCodeScannerFragment, show an error message for 10s instead of 2s
   since new added error messages may carry more information.
6. Show a different error message for enrollee handshake success but Wi-Fi
   connection fail case.
7. stop camera when scanned a Wi-Fi DPP QR code for enrollee.
8. In QR code scanner fragment, support to show error message after
    configuration change.

Bug: 124247872
Bug: 124491247
Test: manual test
      atest WifiQrCodeTest
      atest WifiDppConfiguratorActivityTest
      atest WifiDppEnrolleeActivityTest
      atest WifiDppQrCodeGeneratorFragmentTest
      atest WifiDppQrCodeScannerFragmentTest
      atest WifiNetworkListFragmentTest
      atest WifiDppChooseSavedWifiNetworkFragmentTest

Change-Id: Id130215e9ddafac8bc4c68238deda48ce99b4255
2019-02-20 14:28:52 +08:00
Arc Wang
79a3ae860e Replace deprecated KeyguardManager API with new BiometricPrompt one
Use BiometricPrompt to replace KeyguardManager#createConfirmDeviceCredentialIntent

Bug: 124249685
Test: manual test
Change-Id: I7a05b8f1b08471cf9f09b3d4ce1bedc7cd529e72
2019-02-20 14:17:45 +08:00
TreeHugger Robot
0acd013f03 Merge "Add developer menu to enable/disable ART verifier." 2019-02-20 03:55:40 +00:00
Xiangyu/Malcolm Chen
e67344a5c5 Merge "Correct behavior of "Mobile data" button on opportunistic subscriptions." 2019-02-19 21:04:01 +00:00
Malcolm Chen
5506e0c732 Correct behavior of "Mobile data" button on opportunistic subscriptions.
A check was added earlier to make sure in DSDS mode only one sub
shows data on, which is not true for opportunistic subscriptions. For
them, it should always be on (enforced by Telephony) and be disabled
as it shouldn't be turned off.

Bug: 124331860
Bug: 124683219
Test: manual, robolectric
Change-Id: I53c8d881ff71ad25c418085d3eee63e55c786b8f
2019-02-19 21:03:42 +00:00
Ryan Mitchell
03fc6bbedd Fix invalid style reference in xml
AAPT2 does not recognize @android:style/@Widget.Material.Button.Colored.
This change removes the unnecessary '@' symbol.

Bug: 123251200
Test: build success
Change-Id: Ie5ae2a8898602d5776f5b6bf32058b1bf7c668ca
2019-02-19 18:32:43 +00:00
TreeHugger Robot
7646786cd3 Merge "Add a util method of creating Icon with Drawable" 2019-02-19 12:25:17 +00:00
Jason Chiu
c78c54a9c6 Add a util method of creating Icon with Drawable
- Add a util method to help create Icon with Drawable so that
users don't need to handle bitmaps
- Add support for creating with ColorDrawable

Test: robotest
Fixes: 124407373
Change-Id: I1897256821cc804a5e599d967feb84a3bcd689a9
2019-02-19 15:51:38 +08:00
TreeHugger Robot
72c33375ff Merge "Visual update: update the icons for suggestions" 2019-02-19 05:53:44 +00:00
TreeHugger Robot
de08e6e901 Merge "Fix janky in App info screen" 2019-02-19 03:48:53 +00:00
Xin Li
9d8c2cc2c6 DO NOT MERGE - Merge PPRL.190205.001 into master
Bug: 124234733
Change-Id: I3db6a7deadc7a88e071105be9ddb911da7e9bacd
2019-02-18 15:58:44 -08:00
Alex Buynytskyy
787a92c983 Add developer menu to enable/disable ART verifier.
The new developer option modifies the global setting "art_verifier_verify_debuggable"; it allows to check if the bytecode of the Debuggable Apps is correct, e.g. if it's using the correct APIs.

Test: make RunSettingsRoboTests ROBOTEST_FILTER=development
Bug: 124403695
Change-Id: I8e721d62c5ca6fb5f26d9b989a8242eece8f55ab
2019-02-18 12:01:25 -08:00
Mill Chen
7195800371 Visual update: update the icons for suggestions
- remove blue tint
- add the icons of suggestions for contextual homepage

Bug: 122310542
Test: visual, rebuild
Change-Id: I2bac139669a4218455195aebeba83d1649184895
2019-02-18 18:03:09 +08:00
tmfang
7fb266f30b Fix janky in App info screen
If a Recycle view inside in a NestedScrollView,
The times of calling recyclerView#onCreateViewHolder()
is requal to its data set.

When there are large set of apps need to be shown,
RecyclerView will need to take many time to call
onCreateViewHolder for each item.

So, it causes the screen is janky or freeze UI when page
is loading large data set.

For now, we get rid of NestedScrollView, just use RecycleView
and AppBarLayout to have same bahavior for spinner.

Fixes: 124384314
Fixes: 123036231
Fixes: 122964660
Fixes: 123088178

Test: 1. Select show system in App info screen. Observe whether there
is any janky.
2. Select show system in App info screen, and then change device
orientation. Observer whether there is any janky.
3. Go to Settings > Apps & notifications> Advanced > Special app access >
Select "battery optimization", and then Tap drop down and select "all
apps". Observe whether ther is any janky.

Change-Id: Icd65e91eec3b32476d80cc12e9c4baa71151306a
2019-02-18 17:52:03 +08:00
George Chang
8adb77fd3d Replace Banner with App Title Text
Bug: 123719839
Test: switch different payment
Change-Id: Ica90394bf5d5d0062403f2a0888c56072fdce7ee
2019-02-18 16:38:07 +08:00
Yanting Yang
4bd94b9053 Remove deprecated EXCLUSIVE field from proto
Fixes: 123560880
Test: robotests
Change-Id: I6ff184dc5998d1e8eadfbfa16c8c7a85ebd75d98
2019-02-18 16:25:23 +08:00
TreeHugger Robot
c53f53c9ed Merge "[Network Connection] Implement "show all" button for NetworkRequestDialog" 2019-02-18 06:19:41 +00:00
TreeHugger Robot
70e97d29ef Merge "[Mac Randomization] Fix MAC randomization option does not work when ephemeral newtork" 2019-02-18 04:29:26 +00:00
TreeHugger Robot
56d2dd2515 Merge "Fix [RTL] Wifi QR Scanner option overlaps wifi Password text" 2019-02-18 04:13:39 +00:00
cosmohsieh
1e687606dd [Network Connection] Implement "show all" button for
NetworkRequestDialog

Add "show all" button to NetworkRequest dialog to let user be able to
show all AccessPoints of onMatch() callback.

Bug: 117985692
Test: atest NetworkRequestDialogFragmentTest
Change-Id: I604083fd0f3ea98208d860a327733699cd4664d7
2019-02-18 11:42:59 +08:00
TreeHugger Robot
9e9dc49cb8 Merge "Add progress bar for Privacy screen" 2019-02-18 03:04:05 +00:00
cosmohsieh
5cbd97f4ea [Mac Randomization] Fix MAC randomization option does not work when
ephemeral newtork

WifiConfiguration is only available when saved network. So ephemeral
newtork could not have wifi config to config wifi setting. In this
situation, making option be not selectable.

Bug: 122919564
Test: atest WifiPrivacyPreferenceControllerTest
Change-Id: I8a2a1c36ec6d41a6f912da29a8b17bc2e43d9a27
2019-02-18 10:55:42 +08:00
Yanting Yang
29934110dd Merge "Hide "Pair new device" from connected device slice" 2019-02-18 02:46:04 +00:00
TreeHugger Robot
4e706fc7c3 Merge "Remove feature flags of WiFi Sharing feature" 2019-02-18 02:42:33 +00:00
Michele
4919064d21 Add checks on multisim capabilities.
Rename method isMultisimCarrierRestricted to isMultisimSupported to
indicate extended scope that includes checks on the capabilities of the
hardware to support multi-SIM configuration.

Bug: 123537730
Test: Compilation, test application
Change-Id: I39954476a9a8fad791892a65d2c47aa23be75053
2019-02-16 10:02:14 -08:00
TreeHugger Robot
334f0a1e2e Merge "Fix failing robotest" 2019-02-16 02:30:16 +00:00
TreeHugger Robot
0b5ae6791c Merge "Move some slice related api out of BasePreferenceController" 2019-02-16 00:38:28 +00:00
Fan Zhang
9859b8b0b0 Fix failing robotest
Fixes: 124531152
Test: robotests
Change-Id: I4442ae543b062ef17b4bfd828134ede879d2b22d
2019-02-15 16:15:39 -08:00
TreeHugger Robot
bad926c890 Merge "Remove side padding for settings items in bigger screen." 2019-02-15 23:28:32 +00:00
TreeHugger Robot
6dca5ef8e9 Merge "Fix doubling of channel listing" 2019-02-15 22:46:15 +00:00
TreeHugger Robot
2195fd721a Merge "Fix legacy app notification pages" 2019-02-15 22:36:12 +00:00
Fan Zhang
45f961b624 Move some slice related api out of BasePreferenceController
And share with CustomSliceable.

Bug: 121150258
Test: rebuild
Change-Id: Ia5aed9c156fb168c1f001da6e37f7f12f191b385
2019-02-15 14:21:10 -08:00
Fan Zhang
1aa75aa71a Merge "Move registered slice set from settings to settingslib." 2019-02-15 22:14:22 +00:00
TreeHugger Robot
ee0c55bd23 Merge "Update some string char limits" 2019-02-15 21:49:23 +00:00
Doris Ling
e5df0b1934 Remove side padding for settings items in bigger screen.
Fixes: 110804029
Test: visual in emulator with tablet skin
Change-Id: Ib569731d8cff088c6d110c4ae9d43a7609416238
2019-02-15 13:33:00 -08:00
Julia Reynolds
0b6d652d20 Fix doubling of channel listing
Test: toggle a notification group on/off
Change-Id: Ia93cf8084aee0c886a591301cba764975e5e0147
Fixes: 124384280
2019-02-15 20:42:24 +00:00
Antony Sargent
a72540089e Update some string char limits
We got a bug requesting slightly longer character limits for of the some
new strings used when displaying information in multi-SIM mode.

Bug: 124474015
Test: n/a
Change-Id: I706586b2fc97ae8e6f0e809d2b3b168c7a9353c1
2019-02-15 11:37:05 -08:00
TreeHugger Robot
3f95dfefd5 Merge "Check flag to see whether to show accessibility usage dialog." 2019-02-15 19:09:08 +00:00
Maurice Lam
082e7967dc Merge "Revert "Revert "Remove TemplateLayout that is not for external use""" 2019-02-15 18:55:34 +00:00
Lei Yu
755a7d5b65 Merge "Update battery summary" 2019-02-15 18:26:56 +00:00
Julia Reynolds
7d914f509a Fix legacy app notification pages
Test: view legacy app notification page
Change-Id: Id0d7ac53bc0d9e4d7084bea7ff44d4d8a082cb74
Fixes: 124453411
2019-02-15 13:15:50 -05:00
Joel Galenson
858fa64d4a Check flag to see whether to show accessibility usage dialog.
Test: Manually set/unset flag, see/don't see dialog.
Test: atest AccessibilityUsagePreferenceControllerTest
Change-Id: I214cf0bf4c67889f48e43fdf774a943dd11e6c34
2019-02-15 08:16:33 -08:00
TreeHugger Robot
9232a4a147 Merge "Update the summary for DND conditional" 2019-02-15 15:42:35 +00:00