Commit Graph

32040 Commits

Author SHA1 Message Date
TreeHugger Robot
f349972f5a Merge "Some text polish" into rvc-dev am: 56c820fb65
Original change: undetermined

Change-Id: Ia8ca1f7e5977299de3515fa057e1cd22bf1dc359
2020-06-01 23:03:05 +00:00
TreeHugger Robot
56c820fb65 Merge "Some text polish" into rvc-dev 2020-06-01 22:58:03 +00:00
Fabian Kozynski
5a91550b9d Merge "Use PackageManager.FEATURE_CONTROLS to decide availability" into rvc-dev am: 43527ef8f4
Change-Id: If7d9bc00bffb5faaaa8541ea37c145d8d0f7a1fe
2020-06-01 20:38:19 +00:00
Fabian Kozynski
43527ef8f4 Merge "Use PackageManager.FEATURE_CONTROLS to decide availability" into rvc-dev 2020-06-01 20:21:36 +00:00
Julia Reynolds
e32e6cc981 Some text polish
- Update styles and alignment

Test: manual
Fixes: 157769522
Change-Id: I92113b5e7a918e1ec31acb64aa10457f4c762760
2020-06-01 14:57:30 -04:00
TreeHugger Robot
101209195e Merge "Hide header if no items present" into rvc-dev am: 729c6c64a9
Change-Id: I8d4d7931e5c33c31126cd734ab496e6365a4dd29
2020-06-01 16:27:43 +00:00
TreeHugger Robot
729c6c64a9 Merge "Hide header if no items present" into rvc-dev 2020-06-01 16:16:53 +00:00
TreeHugger Robot
48e8670c1f Merge "Improve multi user functionality for restricted users" into rvc-dev am: f1fbba45d3
Change-Id: Ic63b42684105818f922240262d2b1dc684a167e6
2020-06-01 15:41:31 +00:00
TreeHugger Robot
f1fbba45d3 Merge "Improve multi user functionality for restricted users" into rvc-dev 2020-06-01 15:29:34 +00:00
Mathew Inwood
43f9adea62 Improved UX when no debuggable apps are available.
In AppPicker, add an extra to exclude the "Nothing" sentinel. This is
used when selecting a debug app, and makes sense in that context.
However it does not makes sense when choosing an app to modify
compatibilty options for, so exclude it.

Also update the AppPicker to return a new result code in the case that
there are no apps available which match the criteria given. This result
code can only be used when the new extra is defined which keep this
change low risk.

In PlatformCompatDashboard, use the new extra and handle the new result
code, showing a dialog to explain that only debuggable apps are shown in
user builds. This also results in the "Nothing" item being shown at the
top of the app list.

Bug: 157633308
Test: Manual
Change-Id: Ifb055dd7c030cda42556bca8a9d7e87606f0ff72
2020-06-01 14:46:46 +01:00
Julia Reynolds
2545b4aa3d Hide header if no items present
Test: atest
Fixes: 157093918
Change-Id: If4f86ff71fc5e961e36e5485186d247546355174
2020-06-01 09:24:18 -04:00
Yi-Ling Chuang
3e9fb7c765 Remove High usage battery tip from Settings homepage.
Remove this card since it is not actionable.

Fixes: 157131344
Test: robotests
Change-Id: I562e4bec84429f885911bd99461edbe10bad537a
2020-06-01 19:06:16 +08:00
Hugh Chen
bf1de21131 Fix output switch will show empty slice
Use MediaDevice in the list to add row instead of use connectedDevice.
Becauae connectedDevice that got from getCurrentConnectedMediaDevice()
could be null.

Bug: 157611605
Test: make -j42 RunSettingsRoboTests
Change-Id: Ib51e3e436e65a9aaa5a35488191b8b2ad9cb6a4b
2020-06-01 16:31:52 +08:00
SongFerng Wang
893107fc60 Revert "EnabledNetworkModePreferenceController Remove AllowedNetworkType"
This reverts commit 259e6288c9.

Reason for revert: Sooraj will implement another API for power manager.
Bug: 156709797
Change-Id: I15ee2799574cdf0318e593500f0dbfbf135d71f8
2020-06-01 06:25:13 +00:00
Julia Reynolds
9be31ce9ef Merge "Only show Bubbles link for messaging apps" into rvc-dev am: 73b6bfc1e8
Change-Id: Ied54b377c639d4beeff1d0f576f426f55b110fdc
2020-05-31 19:08:20 +00:00
Julia Reynolds
73b6bfc1e8 Merge "Only show Bubbles link for messaging apps" into rvc-dev 2020-05-31 18:57:41 +00:00
Julia Reynolds
ff85c188d8 Add a bubbles content description am: 4029f92f12
Change-Id: I2bb8406aca20a1052379b6c4cf06608785363ee9
2020-05-29 22:25:38 +00:00
Julia Reynolds
4029f92f12 Add a bubbles content description
Test: manual with a11y service
Fixes: 155262236
Change-Id: Ib4c9650e1d90c4681ca721df3fde58ffc9430078
2020-05-29 20:47:40 +00:00
Julia Reynolds
3d613bb6c9 Only show Bubbles link for messaging apps
Apps that have sent at least one valid conversation

Test: manual, atest
Fixes: 156033178
Change-Id: If4fff6810f2e390ba0ad0f7587b8d8c2d5819c93
2020-05-29 14:51:06 -04:00
Fabian Kozynski
d0d07ddceb Use PackageManager.FEATURE_CONTROLS to decide availability
Using this features, some of the Preference in Power Menu Settings can
change their availability and their summary.

Test: Robotest Settings
Fixes: 157244528
Change-Id: I704438dda181aa6347c3f168ac5ef6bd16148993
2020-05-29 13:12:08 -04:00
Andras Kloczl
106431e525 Improve multi user functionality for restricted users
- Restricted users can change their name
- Improved App&Content access screen
- Remove "Turn on phone calls" from restricted user detail page

Doc: http://shortn/_Prb3SJ3xJ3
Bug: 142798722
Test: Run robo tests with this command:
  make -j64 RunSettingsRoboTests
Change-Id: I2aadf32aef52ba5ad0db7aa0cd83bac9d9941589
(cherry picked from commit f4759e00d5)
2020-05-29 12:55:18 +00:00
TreeHugger Robot
3d735f0aa1 Merge "Fix the janky transition of contextual cards." into rvc-dev am: ff35a3e641
Change-Id: Ifc9b6dbdf16b9d8f92ffdbfacf62fff3351a52a8
2020-05-29 12:01:23 +00:00
TreeHugger Robot
ff35a3e641 Merge "Fix the janky transition of contextual cards." into rvc-dev 2020-05-29 11:51:51 +00:00
TreeHugger Robot
609a4aa949 Merge "Cleanup notification channel slice" into rvc-dev am: 1e0bb9f528
Change-Id: I6e99a73c8c0eb5745b39f592cae2d4f3d9e71bd1
2020-05-29 11:10:34 +00:00
Rubin Xu
085509cb17 Merge "Allow setting password during provisioning if FRP is not supported" into rvc-dev am: c3b12c3b00
Change-Id: I1539235ffb0b4776a4b521c96e69d637ae9603e1
2020-05-29 11:09:46 +00:00
TreeHugger Robot
1e0bb9f528 Merge "Cleanup notification channel slice" into rvc-dev 2020-05-29 10:55:53 +00:00
Rubin Xu
c3b12c3b00 Merge "Allow setting password during provisioning if FRP is not supported" into rvc-dev 2020-05-29 10:44:18 +00:00
Yi-Ling Chuang
bed0f23940 Fix the janky transition of contextual cards.
When contextual cards are being laid out, there are two separate layout
transitions, which brings users the feeling of slowness.

In the current design, we bind slices in the adapter's
onBindViewHolder(), where slice's binding is acutally done in the
background thread and it's time consuming. So before getting the
callback from the slice framework to have actual contents, the view is
empty but the viewholder is already created. So the RecyclerView would
treat it as completed and starts to lay them out. This introduces the
first time transition. Once we get the actual slice content, the view
will be refreshed and laid out, which is the second time transition.

To tackle this, this CL caches slices that are created at pre-check
time, and use them to render before getting updated slices to fill up
the gap.

Fixes: 156372414
Test: robotest and launch settings to see the transition being smooth.
Change-Id: Ic0a27ff36f1824de499b75ec73b2635de9cbe6b5
2020-05-29 18:28:45 +08:00
Jason Chiu
d06333167d Cleanup notification channel slice
Fixes: 144897605
Test: robotest

Change-Id: I1b654f31c6b001ef6f1eed95a87ca0b2dd1afc2e
2020-05-29 17:35:22 +08:00
Bonian Chen
fb4a0c25e0 [Settings] Avoid crash when switch SIM during PIN lock
PIN lock status are stored without subscription ID mapping on it.
Which makes SIM status change can't be processed correctly.

Through storing the subscription ID for PIN lock screen, dialog can be
reset when SIM status changed and crash can be avoided.

Bug: 155852345
Test: manual
Change-Id: Ic520bc34c5a460b4fcd199cd524b180d307e9ab4
2020-05-29 17:09:04 +08:00
TreeHugger Robot
ef95b4781b Merge "Disable anomaly app detection for battery" into rvc-dev am: 90331c0f20
Change-Id: Ie3409d93df4c63857cfdbd8bf5d5b263f4bd390c
2020-05-29 06:50:02 +00:00
TreeHugger Robot
29e0d389bf Merge "[ANR] Settings froze" into rvc-dev am: dd356c5653
Change-Id: I337c660b32dcb94482919cf934b28d29ebbaa771
2020-05-29 06:49:54 +00:00
TreeHugger Robot
90331c0f20 Merge "Disable anomaly app detection for battery" into rvc-dev 2020-05-29 06:47:00 +00:00
TreeHugger Robot
dd356c5653 Merge "[ANR] Settings froze" into rvc-dev 2020-05-29 06:37:53 +00:00
tim peng
1b1e05fb1d Merge "Improve feedback when failing transferring a disconnected device" into rvc-dev am: 6febf2c629
Change-Id: I8bb341fb70c18e314ae8ac2bdfbf5ce1140845b5
2020-05-29 05:22:02 +00:00
tim peng
6febf2c629 Merge "Improve feedback when failing transferring a disconnected device" into rvc-dev 2020-05-29 05:09:07 +00:00
Tim Peng
0989586ce2 [ANR] Settings froze
-To handle getActiveLocalMediaController() in a background thread
-To update test cases for waiting LocalMediaManager initial in
 background thread

Bug: 157522889
Test: make -j42 RunSettingsRoboTests
Change-Id: I27cd282a89ac9cfb6a098843f7282d5b94d98402
2020-05-29 02:30:56 +00:00
Jay Aliomer
e931c35f4d Merge "Incorrect localization of dark theme custom time" into rvc-dev am: fb6711ae92
Change-Id: Ibf41defa2849b26c934dd3b72d30117993d696f2
2020-05-28 23:37:48 +00:00
Jay Aliomer
fb6711ae92 Merge "Incorrect localization of dark theme custom time" into rvc-dev 2020-05-28 22:21:21 +00:00
Jay Aliomer
57cc7d01ae Incorrect localization of dark theme custom time
Fixes: 154361883
Test: manually select dark theme custom time and make sure it matches
locale

Change-Id: I2a918b4b2f5aad6b04d3b0318bbca25e82dfae78
2020-05-28 12:00:17 -04:00
TreeHugger Robot
1438ab4d59 Merge "Revert "Do not prebind sticky slices."" into rvc-dev am: 591d761d43
Change-Id: I6fca5b77f9301f2ddf0336beb8f12dd8bfd9bcb6
2020-05-28 15:48:00 +00:00
TreeHugger Robot
1d1e16a09b Merge "Increase the timeout for contextual card loading." into rvc-dev am: c3b262ed52
Change-Id: I50b31cbe7f309b988d30d5cab191dc6be9095eef
2020-05-28 15:47:30 +00:00
TreeHugger Robot
591d761d43 Merge "Revert "Do not prebind sticky slices."" into rvc-dev 2020-05-28 15:42:28 +00:00
Yi-Ling Chuang
740db33c5c Revert "Do not prebind sticky slices."
This reverts commit ac59ea8e23.

Reason for revert: Fix it using another approach in ag/11629780. The prebind part will be helpful to cache slice data.

Bug: 152365480
Change-Id: Iebed42027552a923907647b61480f135ac4f4097
2020-05-28 15:42:15 +00:00
TreeHugger Robot
c3b262ed52 Merge "Increase the timeout for contextual card loading." into rvc-dev 2020-05-28 15:37:37 +00:00
Bonian Chen
cb1353756d Merge "[Settings] Avoid crash for VoIP account displayed as default voice" into rvc-dev am: e2da25108a
Change-Id: I98bea7d8fa90e267a3039012bf19babd2eec7223
2020-05-28 15:07:52 +00:00
Bonian Chen
e2da25108a Merge "[Settings] Avoid crash for VoIP account displayed as default voice" into rvc-dev 2020-05-28 14:59:47 +00:00
SongFerngWang
b6b8bc01e8 EnabledNetworkModePreferenceController Remove AllowedNetworkType am: 259e6288c9
Change-Id: I4064e14c9ed83f5712141ebff4edc8217efd879b
2020-05-28 14:32:40 +00:00
SongFerngWang
259e6288c9 EnabledNetworkModePreferenceController Remove AllowedNetworkType
Power manager decision do enable/disable NR by AllowedNetworkType,
and it will effect the PreferredNetworkMode UI. The
PreferredNetworkMode list no 5G item when AllowedNetworkType
disabled.

Bug: 156709797
Test: make RunSettingsRoboTests ROBOTEST_FILTER=\
EnabledNetworkModePreferenceControllerTest  (pass)

Change-Id: I3ab9eca0956c4cce1b79e518942063b681eb96cd
2020-05-28 20:37:51 +08:00
Tsung-Mao Fang
850bafbf58 Disable anomaly app detection for battery
This feature is introducing some false positive cases,
so we're going to disable this feature now.
Battery team will make it more precise in the next release.

Test: Run robotest. See there's no related card in battery page.
Fix: 156369998
Change-Id: I2dfe2f772e561b768af6af45ac92fdc65c1fafee
2020-05-28 20:14:32 +08:00