Commit Graph

84826 Commits

Author SHA1 Message Date
Mill Chen
fb2bfac434 Fix a flicker problem on top app bar
The height of top app bar area is dependent on the line count of
multiline title. This mechanism is always triggered when entering either
subsetting page or rotating the screen, regardless the state of
collapsing toolbar. That is saying this mechanism caused a flicker
problem or a title in wrong color. The mechanism will be updated to
check the state of collapsing toolbar to make sure that it is only
triggered if the collapsing toolbar is in expanded state.

Fix: 186419089
Fix: 187709056
Test: visual verified
1) Navigate to a subsetting page with multiline title
2) Rotate the screen to landscape mode and collapse the title
3) Rotate the screen to portrait mode and see if the title is in
collapsed state

Change-Id: I3da2403fa43913469e64bd37e761b41a083efd38
2021-06-24 16:04:36 +08:00
tim peng
dc8199b6cf Merge "Sound panel doesn't match material next design for Android S" into sc-dev am: 416a24d821 am: 2b03503015
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15076794

Change-Id: I6c49890968d317b3284011b94fec09d190211af5
2021-06-24 07:36:30 +00:00
tim peng
02a51f3d46 Merge "Sound panel doesn't match material next design for Android S" into sc-dev am: 416a24d821 am: 13e9349f1d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15076794

Change-Id: I6c2adc883f9b0be2e77776dd9a491afa5cfffe06
2021-06-24 07:36:12 +00:00
tim peng
13e9349f1d Merge "Sound panel doesn't match material next design for Android S" into sc-dev am: 416a24d821
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15076794

Change-Id: I39a9145ef21d85b366f80897170838cf73dfd919
2021-06-24 07:19:30 +00:00
tim peng
2b03503015 Merge "Sound panel doesn't match material next design for Android S" into sc-dev am: 416a24d821
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15076794

Change-Id: I98ce4b1f09e0a91c2ab726a5c2fec426326d5f63
2021-06-24 07:18:20 +00:00
tim peng
416a24d821 Merge "Sound panel doesn't match material next design for Android S" into sc-dev 2021-06-24 07:04:37 +00:00
Arc Wang
c6b97a939e Merge "Tweak UI of profile tab layout" into sc-dev am: 73f539ed3f am: ccee1e82ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15080730

Change-Id: I807e703cc24228ab6076accbbf5c125cca9e17ad
2021-06-24 06:32:07 +00:00
Arc Wang
2531c74c88 Merge "Tweak UI of profile tab layout" into sc-dev am: 73f539ed3f am: 8dad166f0c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15080730

Change-Id: Idb385550694649937f3c432f24c1585aff00160b
2021-06-24 06:31:52 +00:00
Arc Wang
8dad166f0c Merge "Tweak UI of profile tab layout" into sc-dev am: 73f539ed3f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15080730

Change-Id: I39d3f4520d98d75a643edaacb53b56f8706e352c
2021-06-24 06:14:00 +00:00
Arc Wang
ccee1e82ee Merge "Tweak UI of profile tab layout" into sc-dev am: 73f539ed3f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15080730

Change-Id: I5ba63ade5a81d6c490da14f1b95d9deacf5b4e4c
2021-06-24 06:13:14 +00:00
Arc Wang
73f539ed3f Merge "Tweak UI of profile tab layout" into sc-dev 2021-06-24 05:58:10 +00:00
Arc Wang
e366490c4e Merge "Fix crashes when clearing storage for a protected package" into sc-dev am: 79ee0ea944 am: 732b2b0bc6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15081391

Change-Id: Iaf7debb52265e584b5474586563911122901e6e6
2021-06-24 04:00:56 +00:00
Arc Wang
7e94a559c1 Merge "Fix crashes when clearing storage for a protected package" into sc-dev am: 79ee0ea944 am: 0a873a62cf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15081391

Change-Id: I2d474eb085d941f04cd7024479c25b48f4d75b19
2021-06-24 04:00:40 +00:00
Arc Wang
0a873a62cf Merge "Fix crashes when clearing storage for a protected package" into sc-dev am: 79ee0ea944
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15081391

Change-Id: Ib6dafcc9486ccf794d6c527e223d49f309711192
2021-06-24 03:35:48 +00:00
Arc Wang
732b2b0bc6 Merge "Fix crashes when clearing storage for a protected package" into sc-dev am: 79ee0ea944
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15081391

Change-Id: If61ab834c034bbb50d846f3de550140fb2a98dd5
2021-06-24 03:34:56 +00:00
Arc Wang
79ee0ea944 Merge "Fix crashes when clearing storage for a protected package" into sc-dev 2021-06-24 03:21:49 +00:00
Arc Wang
4f1d2ebfdf Tweak UI of profile tab layout
- Change color & shape of indicator.
- Add margin around tab layout.
- Remove divider below the tab layout.

Bug: 188589806
Bug: 188589053
Test: manual visual
Change-Id: I644a4aeb951daa6eb601229fa5f1096dcbdc86ca
2021-06-24 11:15:48 +08:00
Curtis Belmonte
640fc9a07b Merge "Fix face education UX for both grid and traffic light" into sc-dev am: 147fa2f159 am: a8d6dba649
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15084564

Change-Id: I2ac9044a19b92545b483a82c2eb9193e7daf1b10
2021-06-24 01:32:28 +00:00
Arc Wang
e461e673ac Fix crashes when clearing storage for a protected package
When clearing storage for a protected package,
ActivityManager throws a SecurityException.

This change catches the exception then shows a dialog
with the message "Couldn't clear storage for app".

Bug: 191806850
Test: manual visual
      1. Lock the device.
      2. Clear storage for a protected package.
Change-Id: Ic3e2c2237c6ee6dc945b03dac35b3b96a26129a9
2021-06-24 01:31:19 +00:00
Curtis Belmonte
7b3919c358 Merge "Fix face education UX for both grid and traffic light" into sc-dev am: 147fa2f159 am: d50fe51f27
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15084564

Change-Id: Id1d109091260935031924dde6d4bc099536f2ce7
2021-06-24 01:27:42 +00:00
Curtis Belmonte
a8d6dba649 Merge "Fix face education UX for both grid and traffic light" into sc-dev am: 147fa2f159
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15084564

Change-Id: I5f7ef4965a008e4d70fac9338b3a6b65e445fca9
2021-06-24 01:13:30 +00:00
Curtis Belmonte
d50fe51f27 Merge "Fix face education UX for both grid and traffic light" into sc-dev am: 147fa2f159
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15084564

Change-Id: Ib8e4dab08664d29ff6c09c6d848e6e92955855cc
2021-06-24 01:12:30 +00:00
Jeremy Goldman
1f286057d6 Merge "Close AirplaneModeEnabler once lifecycle classes are destroyed." into sc-dev am: 7a6ff6942c am: 4d2861be0b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15007770

Change-Id: I135050c6be49662769936081711c085db5f8c090
2021-06-24 01:09:10 +00:00
Curtis Belmonte
147fa2f159 Merge "Fix face education UX for both grid and traffic light" into sc-dev 2021-06-24 00:57:31 +00:00
Jeremy Goldman
b866e020d9 Merge "Close AirplaneModeEnabler once lifecycle classes are destroyed." into sc-dev am: 7a6ff6942c am: 1d2831122a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15007770

Change-Id: I20bb0ddcd89b746c6678928221a0d8b738154139
2021-06-24 00:55:28 +00:00
TreeHugger Robot
8095f5f4a0 Merge "Change your to the for lock prompts." into sc-dev am: c8059dc338 am: 4801c804ba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15081922

Change-Id: Id69b4583ad2c5ad946bc0b25a514f8df467a98bb
2021-06-24 00:55:22 +00:00
Jeremy Goldman
4d2861be0b Merge "Close AirplaneModeEnabler once lifecycle classes are destroyed." into sc-dev am: 7a6ff6942c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15007770

Change-Id: I6472545a7af7840d6e9562675bff1189d3781cf9
2021-06-24 00:55:06 +00:00
TreeHugger Robot
ead5339436 Merge "Change your to the for lock prompts." into sc-dev am: c8059dc338 am: d4a3d14b52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15081922

Change-Id: I59a0597db892f2efdcfef69b455a8b77c327c854
2021-06-24 00:51:03 +00:00
Jeremy Goldman
1d2831122a Merge "Close AirplaneModeEnabler once lifecycle classes are destroyed." into sc-dev am: 7a6ff6942c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15007770

Change-Id: I985d3a55d15a0fb53f6d62b06644f2e30f7c754e
2021-06-24 00:42:41 +00:00
Jeremy Goldman
7a6ff6942c Merge "Close AirplaneModeEnabler once lifecycle classes are destroyed." into sc-dev 2021-06-24 00:40:46 +00:00
TreeHugger Robot
4801c804ba Merge "Change your to the for lock prompts." into sc-dev am: c8059dc338
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15081922

Change-Id: Ib99a9d3e55f527e3fc4adcc95d426112d8477507
2021-06-24 00:38:15 +00:00
TreeHugger Robot
d4a3d14b52 Merge "Change your to the for lock prompts." into sc-dev am: c8059dc338
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15081922

Change-Id: I3d02075249299c653e5a017b9c1ff73d839be2b6
2021-06-24 00:37:45 +00:00
Curtis Belmonte
39c9ad88f6 Use correct string for Face Unlock preference category
Updates the title of the preferences subcategory on the Face Unlock
Settings screen to use the correct string reference.

Test: Manually inspected string on Face Unlock Settings page

Bug: 191923052
Change-Id: Ia8a4a5b8f64bff8e2b764d0ecabe16099d2eba21
2021-06-23 17:37:15 -07:00
TreeHugger Robot
c8059dc338 Merge "Change your to the for lock prompts." into sc-dev 2021-06-24 00:24:26 +00:00
Menghan Li
bfb5f7e274 Merge "Show one line of footer content change in Accessibility button page when the user is in gesture nav." into sc-dev am: b2d7b6e5de am: 4fc3f100ae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15056863

Change-Id: I973d809f9b06c0e8efa50914ebe64a9fc7144093
2021-06-24 00:17:53 +00:00
Menghan Li
1d77747bf0 Merge "Show one line of footer content change in Accessibility button page when the user is in gesture nav." into sc-dev am: b2d7b6e5de am: c4f8d2e5bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15056863

Change-Id: Icd77f7ff6ed85b91a4ecdd56fcbc25271eefa1e0
2021-06-24 00:17:31 +00:00
Joshua Mccloskey
9a13bb445c Updated fingerprint bad calibration string
Test: Verified that the string appears during fp enrollment.
Bug: 189133688
Change-Id: I3e62788d88a29b88b7102764161be1c0f96e0e5f
2021-06-23 17:11:05 -07:00
Menghan Li
c4f8d2e5bf Merge "Show one line of footer content change in Accessibility button page when the user is in gesture nav." into sc-dev am: b2d7b6e5de
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15056863

Change-Id: Ie8b6955ce1ea129b6940ff40b971ffe989aff6b0
2021-06-23 23:59:55 +00:00
Menghan Li
4fc3f100ae Merge "Show one line of footer content change in Accessibility button page when the user is in gesture nav." into sc-dev am: b2d7b6e5de
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15056863

Change-Id: I8f709c24b3ef6799ee770286f64850957ddc48e3
2021-06-23 23:59:03 +00:00
Menghan Li
b2d7b6e5de Merge "Show one line of footer content change in Accessibility button page when the user is in gesture nav." into sc-dev 2021-06-23 23:49:40 +00:00
Joe Bolinger
f144de8909 Change your to the for lock prompts.
Bug: 188847063
Test: N/A
Change-Id: I2c3432cc1ef12d4dc265f71a465a7ebb6df4c666
2021-06-23 16:19:00 -07:00
Curtis Belmonte
d3a07c29bf Fix face education UX for both grid and traffic light
Makes the following adjustments to the UI of the Face Unlock education
screen for both the grid and traffic light enrollment flows:
- Fixes issues with text being overlapped by illustrations
- Prevents views from moving vertically due to state changes
- Ensures no scroll is required for default locale and scaling
- Adjusts the color and content of the a11y setup toggle

Test: Manual:
1. Start grid-based face enrollment (e.g. from Settings > Security)
2. Proceed to "How to set up Face Unlock" screen
3. Tap "Setup for limited vision or head motion"
4. Toggle "Setup for limited vision or head motion" switch off and on
5. Repeat steps 1-4 for traffic light face enrollment

Fixes: 191105436
Fixes: 191317385
Change-Id: Ie80f5b3130b5b0aeceb889f53cc2dec8c7423e47
2021-06-23 16:14:40 -07:00
Quang Luong
e619d227c9 isCarrierNetworkActive() should check if the carrier network is default
WifiPickerTrackerHelper should use MergedCarrierEntry.isDefaultNetwork()
for isCarrierNetworkActive().

Bug: 191090765
Test: atest WifiPickerTrackerHelperTest
Change-Id: I44d8eed3af019a8d6a30a4b743cad468d1f0469b
2021-06-23 16:08:47 -07:00
menghanli
880e1898fc Show one line of footer content change in Accessibility button page when the user is in gesture nav.
Bug: 190563948
Bug: 191733125
Test: make RunSettingsRoboTests -j52 ROBOTEST_FILTER=AccessibilityButtonFooterPreferenceControllerTest
Change-Id: I13ce0b3331835469d6eb9a6263a3a01f821814a8
2021-06-24 05:24:14 +08:00
TreeHugger Robot
0d64ba7eb8 Merge "[Provider Model] Remove Wi-Fi switch menu in internet panel" into sc-dev am: 22f6857a6a am: 2924989c46
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15076801

Change-Id: Iff3b80c6bd5d03b47af9cfbb99359492b0e64d30
2021-06-23 16:04:30 +00:00
TreeHugger Robot
ff2a0ffad2 Merge "[Provider Model] Remove Wi-Fi switch menu in internet panel" into sc-dev am: 22f6857a6a am: 35e410b52b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15076801

Change-Id: I4b6ccc70cb734ba01b1014d7c4f5489aa6487a68
2021-06-23 16:04:11 +00:00
TreeHugger Robot
35e410b52b Merge "[Provider Model] Remove Wi-Fi switch menu in internet panel" into sc-dev am: 22f6857a6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15076801

Change-Id: I295986d82ed772e9c86c7eb1df2080874f6fa360
2021-06-23 15:44:59 +00:00
TreeHugger Robot
2924989c46 Merge "[Provider Model] Remove Wi-Fi switch menu in internet panel" into sc-dev am: 22f6857a6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15076801

Change-Id: I7896e2c43083c812376a6ce45d096ea73c23fec2
2021-06-23 15:43:54 +00:00
TreeHugger Robot
22f6857a6a Merge "[Provider Model] Remove Wi-Fi switch menu in internet panel" into sc-dev 2021-06-23 15:12:19 +00:00
PETER LIANG
db8d2773f5 Merge "Fixing the SettingsRoboTest failure of the AnimatedImagePreference." into sc-dev am: a458f9cdea am: d0ac40c376
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15064551

Change-Id: I19c9a4cb72f97fb713a1fa85e4f3c8f8ee8bf2cc
2021-06-23 14:55:50 +00:00